GitLab

BUG=356742
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/213153004

git-svn-id: svn://svn.chromium.org/blink/trunk@170070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: Provide and handle a synthetic keyCode for synthetic KeyboardEvents.
This is required for handling of shortcuts forwarded from extension panels.

R=caseq

Review URL: https://codereview.chromium.org/212573006

git-svn-id: svn://svn.chromium.org/blink/trunk@170069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=LayoutTests/inspector/utilities.html
R=alph, pfeldman

Review URL: https://codereview.chromium.org/212863005

git-svn-id: svn://svn.chromium.org/blink/trunk@170068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change introduces HTMLImport::SyncMode for readability.

TEST=none
BUG=356257
R=dominicc@chromium.org

Review URL: https://codereview.chromium.org/211363004

git-svn-id: svn://svn.chromium.org/blink/trunk@170067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r168968 made us avoid full invalidations in repaintAfterLayoutIfNeeded
for shifted renderers. This is wrong as inserted / removed renderers
can shift content without marking them for layout.

The old logic would rely on the outline box to detect the previous
case and force a full invalidation but r168968 disabled the outline
box checks unless you have an outline.

This change brings back the full-invalidation-on-shifted-renderer,
which brings back some missing invalidations. The new baselines are
matching pre-r168968 baselines but we haven't completely reverted
the changes from r168968 so it's still an overall win.

BUG=353933

Review URL: https://codereview.chromium.org/210203005

git-svn-id: svn://svn.chromium.org/blink/trunk@170066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn the global Window into a garbage collected object.

R=haraken@chromium.org,ager@chromium.org,wibling@chromium.org,zerny@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/211373002

git-svn-id: svn://svn.chromium.org/blink/trunk@170065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/212703003

git-svn-id: svn://svn.chromium.org/blink/trunk@170064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, the media stream track will create one source provider and let WebAudio use it. But this does not work when there are more than 1 WebAudio AudioContexts connecting to the same media stream.
This Cl fixes the problem by creating one source provider for each CreateMediaStreamSource() call.

NOTRY=true

BUG=354468

Review URL: https://codereview.chromium.org/202923007

git-svn-id: svn://svn.chromium.org/blink/trunk@170063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove old functions. Now there are no 'SysEx' and 'sysEx' strings
in Web MIDI implementation after this change.

Here are a series of changes on this renaming. 
1. https://codereview.chromium.org/208243014/
2. https://codereview.chromium.org/210003002/
3. this change

BUG=349538
TEST=LayoutTests/webmidi

Review URL: https://codereview.chromium.org/208423016

git-svn-id: svn://svn.chromium.org/blink/trunk@170062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/205403004

git-svn-id: svn://svn.chromium.org/blink/trunk@170061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Steal a bit from RenderBlock to avoid descending through the same
stack of nested boxes multiple times while preparing to lay them out.


This CL creates a 4% improvement in the 
Performance/Layout/floats_*_nested.html tests.

Review URL: https://codereview.chromium.org/195363007

git-svn-id: svn://svn.chromium.org/blink/trunk@170060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey,eustas
BUG=178635
NOTRY=true

Review URL: https://codereview.chromium.org/212653002

git-svn-id: svn://svn.chromium.org/blink/trunk@170059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

clientBridgePtr->run() can allocate and is therefore not part of the
safe point.

TBR=haraken@chromium.org, vegorov@chromium.org
NOTRY=true
BUG=356307

Review URL: https://codereview.chromium.org/212573005

git-svn-id: svn://svn.chromium.org/blink/trunk@170058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of pointing to actual console.log() call done from a framework wrapper function,
we should point to the user code.

BUG=231007
R=pfeldman

Review URL: https://codereview.chromium.org/211493002

git-svn-id: svn://svn.chromium.org/blink/trunk@170057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes pretty-print functionality for VM scripts.

BUG=356269

Review URL: https://codereview.chromium.org/211243006

git-svn-id: svn://svn.chromium.org/blink/trunk@170056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a setting which when enabled will append a time stamp to each
message in the console.

BUG=131714

Review URL: https://codereview.chromium.org/185713007

git-svn-id: svn://svn.chromium.org/blink/trunk@170055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes InspectorHistory::Action class to be refcounted. This
helps to get results of completed operations in InspectorHistory without
possibility of use-after-free (this patch fixes two of this cases).

BUG=

Review URL: https://codereview.chromium.org/208893007

git-svn-id: svn://svn.chromium.org/blink/trunk@170054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add runtime feature and property names for unprefixed CSS Transforms (https://codereview.chromium.org/211033002/)

Reason for revert:
Breaks telemetry_unittests: 
http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13762

Here is how you can run the tests after you build debug chrome: 
tools/telemetry/run_tests --browser=debug web_components.web_components_unittest

Original issue's description:
> Add runtime feature and property names for unprefixed CSS Transforms
> 
> Adds a runtime flag (enabled only for testing) and defines property names
> for each property defined in CSS Transforms[1]. Future patches will make
> these properties functional.
> 
> [1] http://www.w3.org/TR/css3-transforms/
> 
> NOTRY=true
> BUG=154772
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170005

TBR=eseidel@chromium.org,esprehn@chromium.org,dstockwell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=154772

Review URL: https://codereview.chromium.org/212563007

git-svn-id: svn://svn.chromium.org/blink/trunk@170053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

{,un}setPendingActivity is deprecated. This CL replaces it with |hasPendingActivity()| override.

This also makes FileSystemCallbacks reference to the DOMFileSystem strong, as |addPendingCallbacks()| would no longer ref() DOMFileSystem.

TEST=fast/filesystem
BUG=354845

Review URL: https://codereview.chromium.org/212263002

git-svn-id: svn://svn.chromium.org/blink/trunk@170052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/212763002/)

Reason for revert:
I don't think this was a reason of failures

Original issue's description:
> Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/210573002/)
> 
> Reason for revert:
> This might have caused android tests failure: 
> http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18266
> Speculatively reverting it.
> 
> Original issue's description:
> > Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits
> > 
> > Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits
> > method from FontPlatformDataHarfBuzz.
> > 
> > BUG=355806
> > R=pdr@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169955
> 
> TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=355806
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170048

TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355806

Review URL: https://codereview.chromium.org/212563005

git-svn-id: svn://svn.chromium.org/blink/trunk@170051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Preserve autosizing multiplier on style recalc. (https://codereview.chromium.org/208393008/)

Reason for revert:
This might have caused android tests failure: 
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg...
Speculatively reverting it.

Original issue's description:
> Preserve autosizing multiplier on style recalc.
> 
> BUG=353309
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169961

TBR=pdr@chromium.org,esprehn@chromium.org,skobes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353309

Review URL: https://codereview.chromium.org/212163006

git-svn-id: svn://svn.chromium.org/blink/trunk@170050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None
TBR=michaeln

Review URL: https://codereview.chromium.org/198913003

git-svn-id: svn://svn.chromium.org/blink/trunk@170049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/210573002/)

Reason for revert:
This might have caused android tests failure: 
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18266
Speculatively reverting it.

Original issue's description:
> Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits
> 
> Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits
> method from FontPlatformDataHarfBuzz.
> 
> BUG=355806
> R=pdr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169955

TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355806

Review URL: https://codereview.chromium.org/212763002

git-svn-id: svn://svn.chromium.org/blink/trunk@170048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org, tkent@chromium.org, vegorov@chromium.org
BUG=356307

Review URL: https://codereview.chromium.org/212553002

git-svn-id: svn://svn.chromium.org/blink/trunk@170047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=347020
TEST=https://codereview.chromium.org/208243016/

Review URL: https://codereview.chromium.org/208333018

git-svn-id: svn://svn.chromium.org/blink/trunk@170046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This has broken android_aosp compilation.

http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/58228

Original issue's description:
> Fix dependencies for EventInterfaces.in
> 
> EventInterfaces.in should depend on event IDL files.
> It currently doesn't, which means it fails to rebuild correctly.
> This fixes it.
> 
> TBR=haraken
> BUG=341748
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169998

TBR=haraken@chromium.org,acolwell@chromium.org,nbarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341748

Review URL: https://codereview.chromium.org/212713002

git-svn-id: svn://svn.chromium.org/blink/trunk@170044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only needed by Apple's setPagination API, which doesn't exist in Blink anymore.

Link to "intent to remove" post:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7n-oLhmTkuM

Review URL: https://codereview.chromium.org/201573009

git-svn-id: svn://svn.chromium.org/blink/trunk@170043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This complicates things significantly and also leads to repeated computations of the data object for each cell.

BUG=None

Review URL: https://codereview.chromium.org/211273005

git-svn-id: svn://svn.chromium.org/blink/trunk@170042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

@jochen or tkent: Could you take a look at the wtf change. I needed to change the trait's Pass[In|Out]Type and Peek[In|Out]Type to make it compile on both gcc and clang for both oilpan and non-oilpan.

Also change the StyleResolver's ViewportStyleResolver to an OwnPtrWillBeMember and removed the call to the clearDocument method.
Added DISALLOW_ALLOCATION to TreeBoundaryCrossingRules since it is only allocated as a part object and traced it from StyleResolver.
Had to change CanvasRenderingContext2D's vector of State to a Vector of pointers to State since we don't yet support vectors of objects with vtables.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/211073002

git-svn-id: svn://svn.chromium.org/blink/trunk@170040 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@170039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since StyleColor stores the color value (32-bit RGBA) plus a single flag,
it is a bit inefficient.  In particular when multiple StyleColor objects
are members of another object, there will be a lot of unnecessary padding.

This padding can be avoided by storing the color value and the flag as
separate members of the containing structure, which allows the flags to
be packed into a bitfield.

The actual saving from this change, measured in a 64-bit Linux build, is
20 bytes per StyleRareInheritedData object.

BUG=356124

Review URL: https://codereview.chromium.org/196103013

git-svn-id: svn://svn.chromium.org/blink/trunk@170038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce an ExceptionMessage helper for emitting the desired error
message when calling a constructor as a function & have the IDL compiler
generate calls to it.

At the same time, make 'detail' a required argument to all 'failedToXX'
methods on ExceptionMessage -- better if the caller is required to
supply meaningful info.

R=nbarth@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/211333004

git-svn-id: svn://svn.chromium.org/blink/trunk@170037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Breaks many browser tests: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35489

Original issue's description:
> Remove prefixed Shadow DOM APIs in Element.
> 
> It's time to remove. We've shipped unprefixed APIs for these APIs.
> 
> BUG=336121
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170008

TBR=dglazkov@chromium.org,esprehn@chromium.org,hayato@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336121

Review URL: https://codereview.chromium.org/212303005

git-svn-id: svn://svn.chromium.org/blink/trunk@170036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org, vsevik

Review URL: https://codereview.chromium.org/212223003

git-svn-id: svn://svn.chromium.org/blink/trunk@170035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman
BUG=337138
NOTRY=true

Review URL: https://codereview.chromium.org/212503002

git-svn-id: svn://svn.chromium.org/blink/trunk@170034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/208893005

git-svn-id: svn://svn.chromium.org/blink/trunk@170033 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=331301

Review URL: https://codereview.chromium.org/212333002

git-svn-id: svn://svn.chromium.org/blink/trunk@170032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/212143002

git-svn-id: svn://svn.chromium.org/blink/trunk@170031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354373

Review URL: https://codereview.chromium.org/210763005

git-svn-id: svn://svn.chromium.org/blink/trunk@170030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Misuse of this method could easily cause
memory leaks and UAFs. It wasn't actually doing anything
in the one place it was called, so I removed it.

I also fixed another FIXME about how unsigned/signed
constructors are confusing.  At least now we'll ASSERT
if you got the wrong one.

Review URL: https://codereview.chromium.org/209353004

git-svn-id: svn://svn.chromium.org/blink/trunk@170029 bbb929c8-8fbe-4397-9dbb-9b2b20218538