- 09 Nov, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium f038ea34. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/overflow-wrap NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I89a829c659b10bbbdfb07c86d8e997b9e9edbc08 Reviewed-on: https://chromium-review.googlesource.com/c/1328711 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606799}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c465c5ea..6130e69e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic5c1b7a01e1e1fb5cdc8f73ba76ff53f7d97c3bf Reviewed-on: https://chromium-review.googlesource.com/c/1328712Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606798}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/365e59b9d0c3..486203eeaffd git log 365e59b9d0c3..486203eeaffd --date=short --no-merges --format='%ad %ae %s' 2018-11-09 hjd@google.com Merge "perfetto_cmd: Teach perfetto_cmd to parse pbtxt configs" Created with: gclient setdep -r src/third_party/perfetto@486203eeaffd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If1aa1235b1bf32d44d939c356c4b9b8d8bb590ae Reviewed-on: https://chromium-review.googlesource.com/c/1328728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606797}
-
Findit authored
This reverts commit c4e9ae1b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 606788 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZTlhZTFiOWFiYzE2N2MxNzdkNjU5ZGJjYzNkMWY3OTRlOTMwNjQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-rel/5951 Sample Failed Step: compile Original change's description: > media/gpu/VEA unittest: Test DMABuf-backed input buffers > > This adds the command line option, --natvie_input, that VEA unittest passes > DMABuf-backed video frame to VEA. > DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on > Chrome OS, it needs to set up Ozone environment properly. Therefore, this change > also makes VEA unittest dependent on Ozone. > > BUG=chromium:895230 > TEST=VEA unittest on eve w/wo --native_input > > Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc > Reviewed-on: https://chromium-review.googlesource.com/c/1295636 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606788} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:895230 Change-Id: I75c80e914ec2493c26b34ddb4644e53099ba6bf5 Reviewed-on: https://chromium-review.googlesource.com/c/1328713 Cr-Commit-Position: refs/heads/master@{#606796}
-
Sheng-Hao Tsao authored
This CL changes the consolidated camera app icon logic so that it launches GCA/GCA migration app only if ARC is P or above. This is to address 2 problems: 1. Android N and below do not support external cameras. We would like users to use CCA so that they can still utilize external cameras. 2. Managed users in Android N still have the problem where GCA could be stripped out. Bug: b:118860552,chromium:896140 Test: Used N devices (caroline) with google.com account and verified that CCA is opened. Change-Id: I7836d2b4256856028901e5e542f460e7107fc8db Reviewed-on: https://chromium-review.googlesource.com/c/1316982 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#606795}
-
Mathias Carlen authored
This patch introduces a checkbox in the Autofill Assistant payment request UI. The state of which is communicated in the processed action results to the backend. This logic only exists on the Java side and is opaquely passed through the c++ layer. Issue: b/117920169 Screenshot: https://screenshot.googleplex.com/iiHvY18nLqn.png Bug: 806868 Change-Id: Ica17176c4cac695c126d1d5695a8b7e5a31020e1 Reviewed-on: https://chromium-review.googlesource.com/c/1316770 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606794}
-
Yi Su authored
The feature of Custom Search Engine is nearly finished and ready to be tested. Chnage the feature flag to be enabled by default. Bug: 433824 Change-Id: Ied1d61b1df73bd8ceee89a2088e3e53418cbf856 Reviewed-on: https://chromium-review.googlesource.com/c/1326002Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606793}
-
Arthur Sonzogni authored
Please see the explanation here: https://bugs.chromium.org/p/chromium/issues/detail?id=882661#c72 Generating a fake internal redirect causes conflicts with what the current URLLoader is doing. The latter doesn't know anything about the redirect. To work properly, the current URLLoader must be destroyed first. The current code automatically handles creating a new URLLoader after FollowRedirect(). Bug: 882661 Change-Id: Ib17dc2f29a2c63da735794b4792ef7805e7dbc58 Reviewed-on: https://chromium-review.googlesource.com/c/1326481 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#606792}
-
Rune Lillesveen authored
Tree-abiding pseudo elements are allowed after ::slotted() according to css-scoping-1. According to css-pseudo-4 they are ::before, ::after, ::marker, and ::placeholder. We already allowed ::before and ::after. We do not support ::marker. This CL allows ::placeholder. TEST=external/wpt/css/css-scoping/slotted-parsing.html TEST=external/wpt/css/css-scoping/slotted-placeholder.html Bug: 902518 Change-Id: I963fa93e68c8fbd33fc8090e930be9a00f3c9bd4 Reviewed-on: https://chromium-review.googlesource.com/c/1323049 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#606791}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22b0ec4f83aa..88e15bdaf539 git log 22b0ec4f83aa..88e15bdaf539 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d856ca48f425..5d2dfa46c05c (2 commits) Created with: gclient setdep -r src/third_party/skia@88e15bdaf539 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I669e2dcceb60198f833772e058db4e4ffd2de923 Reviewed-on: https://chromium-review.googlesource.com/c/1328723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606790}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53aa50a0dced..0ee41cbd4bf0 Created with: gclient setdep -r src-internal@0ee41cbd4bf0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I97a39edb26a9fcecef541f317a1788d833f9fa14 Reviewed-on: https://chromium-review.googlesource.com/c/1328727Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606789}
-
Hirokazu Honda authored
This adds the command line option, --natvie_input, that VEA unittest passes DMABuf-backed video frame to VEA. DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on Chrome OS, it needs to set up Ozone environment properly. Therefore, this change also makes VEA unittest dependent on Ozone. BUG=chromium:895230 TEST=VEA unittest on eve w/wo --native_input Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc Reviewed-on: https://chromium-review.googlesource.com/c/1295636 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#606788}
-
Mario Sanchez Prada authored
IdentityManager::OnRefreshTokenRemovedForAccount() expects as a first parameter a "const std::string&" instead of a "const AccountInfo&", so this patch fixes it to prevent build failures when using this API because of OnRefreshTokenRemovedForAccount(const AccountInfo&) not being a valid override for the virtual method declared. Bug: 903391 Change-Id: I46cd6778240a40af6863ca7fd3b8d9a88e735fde Reviewed-on: https://chromium-review.googlesource.com/c/1327161Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#606787}
-
Koji Ishii authored
This is a reland of b43c6fca The original CL had moved a call to ToString() to within DCHECK, because the result is used only by DCHECK. But the ToString() has a side effect that must be performed. Because of the change, this CL breaks if DCHECK is not enabled. Unfortunately, no build configs in trybots and CQs have DCHECK disabled. Reverted the change, and added TODO to clean it up. Original change's description: > Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow > > This patch allows computing NGOffsetMapping for legacy inline > formatting context. > > For an experimental project "Invisible DOM"[1][2] to support > the find-in-page feature, it is needed to compute the text > content with whitespace collapsing applied, along with the > mapping to the DOM offset. This patch adds an API to compute > NGOffsetMapping even when the LayoutBlockFlow is not laid out > by LayoutNG for that purpose. > > Note that the project is still in the early phase. We may > revisit the design as it moves forward. > > [1] https://github.com/rakina/searchable-invisible-dom > [2] https://www.chromestatus.com/feature/5105291213406208 > > Bug: 636993, 873057 > Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882 > Reviewed-on: https://chromium-review.googlesource.com/c/1322184 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606292} TBR=yoshin@chromium.org, eae@chromium.org, xiaochengh@chromium.org, rakina@chromium.org Bug: 636993, 873057 Change-Id: I8a29073fb18a1349d758d37033e6b046a54d5beb Reviewed-on: https://chromium-review.googlesource.com/c/1327582Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606786}
-
Balazs Engedy authored
Add the missing histogram suffix `media-engagement` to histograms.xml. This is the content setting type with by far the largest number of exceptions, yet missing from the dashboards. Bug: 890129 Change-Id: Iaca89cf7b28db59a9d3c9baf3f810e765a8308a7 Reviewed-on: https://chromium-review.googlesource.com/c/1326147Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606785}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98c0fdb927c4..6edb632ff8cd git log 98c0fdb927c4..6edb632ff8cd --date=short --no-merges --format='%ad %ae %s' 2018-11-09 vadimsh@chromium.org [cipd] Bump CIPD client and vpython versions. Created with: gclient setdep -r src/third_party/depot_tools@6edb632ff8cd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic57f994925c49696f5f1f3da863df1b317081f7e Reviewed-on: https://chromium-review.googlesource.com/c/1328523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606784}
-
Colin Blundell authored
//components/signin/core/browser contains three different types of code: 1. Code that forms the guts of IdentityManager and will form the guts of the Identity Service implementation (e.g., SigninManager). 2. Code that will be clients of IdentityManager (e.g., SigninTracker). 3. Code that will be used on both sides (e.g., AccountInfo). 1 and 2 have already been split via a preceding CL. This CL creates 3. To start off with, 3 contains two pieces of code that were already in their own standalone targets for similar motivations as the above: account_info.* and signin_metrics.*. In the future more code will likely move in. Bug: 901859 Change-Id: Ibcae3c9f1ecff2dc7ccd013046b74c97b3dd2b7a Reviewed-on: https://chromium-review.googlesource.com/c/1323114Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606783}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: Ic280acd363864f15e43d89b7ee466b554fc2e614 Reviewed-on: https://chromium-review.googlesource.com/c/1328841Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606782}
-
Balazs Engedy authored
The profile and its KeyedServices are normally destroyed before the TaskScheduler shuts down background threads, so the background task to record site engagement metrics needs to avoid using any members of SiteEngagementService Bug: 900022 Change-Id: Ibdebbd5a64d59fad29b7715be3557eeed411d741 Reviewed-on: https://chromium-review.googlesource.com/c/1326441Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606781}
-
Rune Lillesveen authored
It belongs with the other anonymous LayoutObject propagation code. There are still two loops for pseudo elements where we propagate style to anonymous table boxes like before but propagate style from the pseudo element to the generated content directly, skipping other anonymous boxes, in a separate loop. This is just keeping the same functionality for generated content without trying to propagate style through others anonymous boxes. Left a TODO for that. Change-Id: I3c38bc9d831b8a767fd601d47e4db0f81923ba47 Reviewed-on: https://chromium-review.googlesource.com/c/1328041Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#606780}
-
Patrik Höglund authored
This reverts commit db889e10. Reason for revert: Speculative revert: A bunch of SSL related tests failing on Mac: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36146 Original change's description: > Route SSLPrivateKey provider names into NetLog. > > Improve debugging in the future so we don't have to keep asking "are you > using a smartcard? which?". > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ifbaf6f5aa0aa73dcd19be0ccc0046c2c2c069319 > Reviewed-on: https://chromium-review.googlesource.com/c/1292509 > Commit-Queue: David Benjamin <davidben@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606700} TBR=rsleevi@chromium.org,kinuko@chromium.org,davidben@chromium.org,emaxx@chromium.org Change-Id: Icb8db36c96ba199e0857296cd21fa9d3e8826c90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1328882Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606779}
-
Patrik Höglund authored
This reverts commit 79ffe683. Reason for revert: Speculative revert: lots of garbage-collection related failures on WebKit Linux Trusty ASAN (see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/17912) Original change's description: > Enable unified garbage collections part two > > This flag overrides the default Blink value for content layer. > > Sheriffs: This is a dry-run of the feature and will be reverted after > cycling through the waterfall and performance bots. > > Tbr: jochen@chromium.org, lfg@chromium.org > Bug: 843903 > Change-Id: Ie362301e4874198eb775346d051bf8267837aaf8 > Reviewed-on: https://chromium-review.googlesource.com/c/1320970 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606446} TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org,lfg@chromium.org Change-Id: I189aca41c8f8ba11c358a4c15bc7f56591e38196 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843903 Reviewed-on: https://chromium-review.googlesource.com/c/1328902Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606778}
-
Peng Huang authored
This CL adds a new GLContextVirtualDelegate interface to contain all context state related methods from DecoderContext. After this one, I am going to implement GLContextVirtualDelegate in RasterDecoderContextState and only create one GLContextVirtual for all raster decoder and display compositor. Bug: 900941, 902904 Change-Id: I10d80bea8531885c449a2e676ce0552e9363b34c Reviewed-on: https://chromium-review.googlesource.com/c/1312338Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#606777}
-
Yi Su authored
This CL changes how search engines are displayed in Search Engine Settings. Previous(1 list): 1. search engines that are prepopulated or created by policy. Current(2 lists): 1. Search engines that are prepopulated or created by policy, and possibly one custom search engine at the end if it's selected as default search engine; 2. All remaining search engines. Unittests are also updated. Bug: 433824 Change-Id: Ib70a18f0544101760c331bb349ee9818956ed231 Reviewed-on: https://chromium-review.googlesource.com/c/1323509Reviewed-by:Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606776}
-
Yutaka Hirano authored
Replace use of ReadableStreamOperations in BodyStreamBuffer with ReadableStream. This CL doesn't change the behavior. Bug: 894357, 888165, 902633 Change-Id: Icd478dcc59ca86e020d540229d69f0c61fb689c0 Reviewed-on: https://chromium-review.googlesource.com/c/1319408 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#606775}
-
Mario Sanchez Prada authored
Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually creating the browser's state by providing specific factories, and then use the APIs from IdentityTestEnvironment, instead of SigninManagerBase. Bug: 890826 Change-Id: Id9d422e002d8fd2edc0ef1ad158f29e95c6dce64 Reviewed-on: https://chromium-review.googlesource.com/c/1318974 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606774}
-
David Jean authored
Added base class that should be used in passwords later. Bug: 845472 Change-Id: I1c1d2204d920ae141448239cfeb1c1c5a0e93a20 Reviewed-on: https://chromium-review.googlesource.com/c/1319714 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27fe62b3b2f9..53aa50a0dced Created with: gclient setdep -r src-internal@53aa50a0dced The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0ceb97585997b51d4374733c0324a20c8d817333 Reviewed-on: https://chromium-review.googlesource.com/c/1328724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606772}
-
Stephane Zermatten authored
This change allows a focus action to provide a list of elements that can be accessed. On a touch event, the position of the touch is compared against the position of the elements before forwarding the event to the webpage (or not). The position of the element is updated periodically or after a scroll event. Currently, touches are just swallowed. A follow-up change will make it clear what's going on and offer alternatives. By default, the new behavior is disabled. Bug: 806868 Change-Id: I5bce26d3a4a81a7167253b564ca416364d18b61e Reviewed-on: https://chromium-review.googlesource.com/c/1323489 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#606771}
-
Jia authored
Bug: 881215 Change-Id: I504764bd39f586d07e67eef1443565d4235a6a2c Reviewed-on: https://chromium-review.googlesource.com/c/1322256Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606770}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7963defb. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I19c1f1a503fec2ad9086489fb20d598cb03b8a1b Reviewed-on: https://chromium-review.googlesource.com/c/1328706 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606769}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I203aa13a2da986403ddb642a29a20ed3069e1e09 Reviewed-on: https://chromium-review.googlesource.com/c/1328725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606768}
-
Nick Harper authored
Bug: 875053 Change-Id: I4687640650ac9120acbacbc82dcfe9b0ccb87451 Reviewed-on: https://chromium-review.googlesource.com/c/1325567 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606767}
-
Mohamed Amir Yosef authored
This CL adds the skeleton of the PasswordSyncBridge and plumps it into PasswordStore. In addition it also include the feature toggle for Passwords USS migration. Bug: 902349 Change-Id: I343f2bb83ecf2c993bacab9e299e7d0deea868b2 Reviewed-on: https://chromium-review.googlesource.com/c/1323653 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606766}
-
Jia authored
This cl removes white space when we read ALS path and spec from command line. Bug: 881215 Change-Id: I8a7373439793d0d3cd697c41ae882bbb10e7b455 Reviewed-on: https://chromium-review.googlesource.com/c/1328543 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#606765}
-
Rakina Zata Amni authored
Currently when traversing to the next/prev sibling of a slot's assigned child, we find the current node's position by looping through a list of the slot's assigned child, taking O(N) time where N is the number of assigned children in that slot. This means traversing through a slot's children will take a total of O(N^2) time. This CL adds a node->index map for slot's children so that we will instead take O(1) time to find a node's position in the list. The downside of this is in cases where there are only a small number of children assigned to a slot, the performance will be slightly worse because of the hashmap lookup. Benchmarked with https://jsbin.com/ravolid/edit?html,output, comparing shadow dom v0 vs v1, where v0 already uses maps. For N = 500 (release build), v0 takes ~20ms, v1 without map takes ~200ms, so v0 is 10x faster than v1. For N = 500 (local build), v0 takes ~54ms, v1 with map takes ~90ms, so v0 is 1.8x faster than v1. Bug: 901063 Change-Id: Iec006fcafca1e368ab97f40d909362dbcf74a08e Reviewed-on: https://chromium-review.googlesource.com/c/1328622Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#606764}
-
Marcin Wiacek authored
Error: ../../content/browser/service_worker/service_worker_database.h:398:5: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow] UNINITIALIZED, ^ ../../content/browser/service_worker/service_worker_storage.h:566:5: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow] UNINITIALIZED, ^ ./../../content/browser/browser_thread_impl.cc:36:3: note: previous declaration is here UNINITIALIZED = 0, ^ Example compilation settings: target_os="android" target_cpu="arm" enable_nacl=false symbol_level=0 remove_webcore_debug_symbols=true is_debug=false dcheck_always_on=false is_component_build=false use_jumbo_build=true BUG=903460 Change-Id: Ie8c6ef88ac299e02724bcbbeb1db69e67515f62b Reviewed-on: https://chromium-review.googlesource.com/c/1327213Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#606763}
-
Stuart Langley authored
- Fixes the spelling of "arbitrary" in the mojom. - Adds the fields specified in FolderFeature to EntryProperties so they are accessible from the app. - Updates the browser test code and fake_drivefs to support setting FolderFeature values in an entry. Bug: 884020 Change-Id: Ica46d66478e7352724454426a9306f8a447c1c55 Reviewed-on: https://chromium-review.googlesource.com/c/1322337 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606762}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d864aa84bdd0..27fe62b3b2f9 Created with: gclient setdep -r src-internal@27fe62b3b2f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3feafba203193666bf297a61a2bb73768a55c5 Reviewed-on: https://chromium-review.googlesource.com/c/1328522Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606761}
-
Marc Treib authored
Some const correctness, some control flow simplification, etc. Also contains one actual fix: Handling errors from |pending_customer_data_query_|. Bug: none Change-Id: I0300b04cc4c32dc9e52dde4a115031390f417e5c Reviewed-on: https://chromium-review.googlesource.com/c/1326483Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606760}
-