GitLab

This reverts commit a98a5c5c.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disable AutofillAssistant...#testKeyboardIsHiddenOnLostFocus on P
> 
> BUG=1041870
> TBR=aluo@chromium.org,arbesser@chromium.org
> 
> Change-Id: I5c0670220cd35f0915cf2be7d55d2248739626dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999248
> Commit-Queue: Theresa  <twellington@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731558}

TBR=twellington@chromium.org,aluo@chromium.org,arbesser@chromium.org

Change-Id: I18d739e6edb90835c47eeb504540554b44c66e3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002870Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731977}

This CL removes the below functions currently unused:
- ThreadControllerImpl::CreateSequenceFunneled
- SequenceManagerImpl::CreateSequenceFunneled

This CL is a follow-up CL to:
https://chromium.googlesource.com/chromium/src/+/2a7d7125598fefd1b2af83387af78ffe4eab0c15

Bug: None
Change-Id: Ib17dca5deb1e70f9362c28dc4ffc4a74aef00e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002550Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731976}

Bug: 1042136
Change-Id: I20241a0cb7db2e38cd56c0c7c26672c388c166ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002001
Auto-Submit: Francois Marier <francois@brave.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731975}

The auto-generated bindings of IDL dictionaries have been split into two;
one as {core,modules}/xxx/yyy.{h,cc} and the other as
bindings/{core,modules}/v8/v8_yyy.{h,cc}.  This is because Blink had a
policy that only bindings/ can access V8 APIs and neither of core/ nor
modules/ must not access V8 APIs.

Blink changed the policy and there is no need to split IDL dictionary's
bindings into two.

Plus, the old style doesn't work in case that multiple partial
dictionary definitions exist in modules/.  An example case is below.

  core/xxx/main_dictionary.idl  => core/xxx/main_dictionary.{h,cc}
  modules/yyy/partial_dict1.idl => where???
  modules/zzz/partial_dict2.idl

We need to merge partial_dict1 and partial_dict2 above, but it's not
trivial where the header should be generated.

The new style generates IDL dictionary's bindings into either of
bindings/core/v8/v8_xxx.{h,cc} or bindings/modules/v8/v8_xxx.{h,cc},
and this new style is the same as other IDL definitions such as IDL
interface, IDL callback function, etc.


This CL has no behavioral change, because the replacing header includes
the replaced header.


Bug: 839389, 1034398
Change-Id: I30ac56e41f4077ffb8b509b9e0cf6011417fcb27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000446Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731974}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 1041419
Change-Id: Ie25c12992c368d4eef4c08086d2ceaa4ce1e334a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998288
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731973}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=xhwang@chromium.org

Bug: 1041419
Change-Id: I0c1813bde553f28351b4e9aee5d21494f2fd4f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998171
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731972}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 1041419
Change-Id: I9187a53e9aee3170d666ea396b96e85b6d8237ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998034
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731971}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fab248d2..cb92763d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I986ecab69dcb4c6870c5501ff008b4bcac15c045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001166Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731970}

On Windows, a visible restored tab starts loading in the following stack,
before FirstWebContentsProfiler is created:

  content::NavigationControllerImpl::LoadIfNecessary
  content::NavigationControllerImpl::SetActive
  ...
  content::WebContentsImpl::UpdateWebContentsVisibility
  content::WebContentsViewAura::UpdateWebContentsVisibility
  ...
  BrowserView::Show
  SessionRestoreImpl::ShowBrowser
  SessionRestoreImpl::RestoreTab
  SessionRestoreImpl::RestoreTabsToBrowser
  SessionRestoreImpl::ProcessSessionWindows
  SessionRestoreImpl::ProcessSessionWindowsAndNotify
  SessionRestoreImpl::Restore
  SessionRestore::RestoreSession
  ...
  StartupBrowserCreator::Start
  ...
  content::BrowserMainLoop::PreMainMessageLoopRun

On Mac, it starts loading in the following stack, after
FirstWebContentsProfiler is created:

  content::NavigationControllerImpl::LoadIfNecessary
  content::NavigationControllerImpl::SetActive
  ...
  content::WebContentsImpl::UpdateWebContentsVisibility
  content::WebContentsViewMac::OnWindowVisibilityChanged
  -[WebContentsViewCocoa updateWebContentsVisibility]
  -[WebContentsViewCocoa windowChangedOcclusionState:]
  ...
  base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run
  ...
  ChromeBrowserMainParts::MainMessageLoopRun

This prevents FirstWebContentsProfiler from having strict cross-platform
expectations about events it observes. With this CL, we ensure that visible
restored tab start loading in the following stack on all platforms:

  content::NavigationControllerImpl::LoadIfNecessary
  chrome::`anonymous namespace'::CreateRestoredTab
  chrome::AddRestoredTab
  ...
  SessionRestoreImpl::Restore
  SessionRestore::RestoreSession
  ...
  StartupBrowserCreator::Start
  ...
  content::BrowserMainLoop::PreMainMessageLoopRun

This allows us to enforce strict cross-platform expectations about events
observed by FirstWebContentsProfiler, and also have the nice benefits that
navigation isn't delayed until we get a window visibility update during a
Mac session restore.

Bug: 1035419, 1020549, 1022492
Change-Id: I26f1a1a7cfa73cf95a3bdb32a83bf2dc1722d3f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976500Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731969}

https://android.googlesource.com/platform/external/perfetto.git/+log/6fa4a067079c..947555efc3ea

git log 6fa4a067079c..947555efc3ea --date=short --first-parent --format='%ad %ae %s'
2020-01-15 primiano@google.com Merge "ui: minor fixes for feature-detection and record page"

Created with:
  gclient setdep -r src/third_party/perfetto@947555efc3ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ifbf6199c64eaeba74d744b852ff5140d5e1aa539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001731Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731968}

https://swiftshader.googlesource.com/SwiftShader.git/+log/146e16f68fdc..8842c8f43b4e

git log 146e16f68fdc..8842c8f43b4e --date=short --first-parent --format='%ad %ae %s'
2020-01-15 bclayton@google.com SpirvShader: 2-way imported extensions lookup
2020-01-15 bclayton@google.com .vscode: Add spirv-tools-ext to include path

Created with:
  gclient setdep -r src/third_party/swiftshader@8842c8f43b4e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ie91f9cf8b87f5adcc4092a2f3df4e3e3575a1451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001956Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731967}

Maps IPP attributes, enumerations and keywords to localization
resource ids. The generator filters out values that are not
implemented.

Bug: 964919
Change-Id: I3cf242f05455c15fa4b49af17733fb8c0766b6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965575
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731966}

Following bot results are included.
969 972 974 975 977 978 979 980 986 988 989

30 lines were removed and 6 lines were deflaked by consecutive
results since 960.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I9790f779bf290e601835fc2628399eb35e739733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999971Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731965}

Before this patch, list markers were only pseudo-elements when 'content'
was different than 'normal'. Otherwise they were anonymous boxes.
This makes them be pseudo-elements in that case too.

This only affects LayoutNG, in legacy they continue being anonymous.

BUG=457718

TEST=accessibility/aria-owns-sends-notification.html
TEST=editing/selection/drag-to-contenteditable-iframe.html
TEST=editing/selection/selectNode.html
TEST=editing/selection/selectNodeContents.html
TEST=external/wpt/css/css-pseudo/marker-computed-size.html
TEST=external/wpt/css/css-pseudo/marker-content-014.html
TEST=blink_unittests --gtest_filter=NGInlineCursorTest/NGInlineCursorTest.NextWithListItem/*
TEST=blink_unittests --gtest_filter=ParameterizedTextPaintTimingDetectorTest.CapturingListMarkers/*
TEST=content_browsertests --gtest_filter=All/DumpAccessibilityTreeTest.AccessibilityLi/*

marker-content-014.html still fails in legacy since markers are not
pseudo-elements yet.

marker-computed-size.html also fails in legacy, and one of the subcases
fails in LayoutNG since 'content: none' doesn't work yet in ::marker.

fast/multicol/span/list-multi-column-crash.html now crashes with
LayoutNGBlockFragmentation enabled due to bug 1040947. The crash was
already happening with ::before and ::after, so it's expected.

Change-Id: I51d9661f32b2e1c0c392c261853f8127b74136fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985952
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731964}

This reverts commit d54dd097.

Reason for revert: test still flakes: 
https://ci.chromium.org/p/chromium/builders/ci/Mac%20Retina%20Debug%20%28AMD%29?limit=200
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVAsSBUZsYWtlIkljaHJvbWl1bUB0ZWxlbWV0cnlfZ3B1X2ludGVncmF0aW9uX3Rlc3RAUGl4ZWxfQ1NTRmlsdGVyRWZmZWN0c19Ob092ZXJsYXlzDA

Original change's description:
> Reland "Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation""
> 
> This is a reland of f3a7d44e
> 
> No new images for a few days, should no longer fail when re-enabled.
> 
> Original change's description:
> > Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation"
> >
> > This reverts commit b4099b2c.
> >
> > Reason for revert: new image has been triaged in Skia Gold.
> >
> > Original change's description:
> > > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation"
> > >
> > > This reverts commit 7076daa4.
> > >
> > > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202
> > >
> > > Original change's description:
> > > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation
> > > >
> > > > Test was producing a minor image diff, has been triaged.
> > > >
> > > > Bug: 1040202
> > > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564
> > > > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > > > Commit-Queue: Brandon Jones <bajones@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#729597}
> > >
> > > TBR=kbr@chromium.org,bajones@chromium.org
> > >
> > > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1040202
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367
> > > Reviewed-by: sebsg <sebsg@chromium.org>
> > > Commit-Queue: sebsg <sebsg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#729736}
> >
> > TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org
> >
> > Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1040202
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Commit-Queue: Kenneth Russell <kbr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#729838}
> 
> TBR=kbr@chromium.org
> 
> Bug: 1040202
> Change-Id: I1045d7601496b271faf1ca41dd7a7707889ec733
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001225
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731755}

TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org,bsheedy@chromium.org

Change-Id: I87b30cebf26122406ec7249e7d87be462c6acd53
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002808Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731963}

Bug: 1017166
Change-Id: I00d38c7d4ea61ce9d1d7146459a7ecbe91a93075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002668Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731962}

This change extends the expiration date of the BlacklistedSitesHiRes and
AccessPasswordInSettings histograms. Furthermore it declares the former
histogram as a base, as it is only intended to be used in conjunction
with the {With,Without}CustomPassphrase suffixes.

Bug: 1037188
Fix: 1037188
Change-Id: I7b1c9e4443418ab86c98ae78aaed2c828f9dbb93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993825
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731961}

Bug: 1042192
Change-Id: I9770af6d0aa0cc42e311c8eef8046dd9ae21849c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000630Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731960}

Create an infobar for sync related errors that require user interaction.
This infobar would be shown at most once every hour on new tab navigation.

Design Doc: http://go/clank-sync-infobar

Bug: 1009954
Change-Id: I3c52b4f19d859802a64e6aedc934828acb9f69e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824275
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731959}

https://chromium.googlesource.com/catapult.git/+log/b9bb682ff61f..6a138fbe7ca9

git log b9bb682ff61f..6a138fbe7ca9 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 phoglund@google.com Add JSON converter and proto test driver.

Created with:
  gclient setdep -r src/third_party/catapult@6a138fbe7ca9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029452
Tbr: wenbinzhang@google.com
Change-Id: Ibce1ae6d69252930aa53268e0c1f2c256f8525fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001954Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731958}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/989f726ff7f5..5933290adf49

git log 989f726ff7f5..5933290adf49 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 szuend@chromium.org [fix-it] Port SourceMap test that checks the 'sections' format
2020-01-15 aerotwist@chromium.org Migrates protocol_monitor/ to ESM internally
2020-01-15 tvanderlippe@chromium.org Print full stacktrace on promise failures
2020-01-15 sigurds@chromium.org [karma-tests] Add tests for TextRange
2020-01-15 szuend@chromium.org Port SourceMap unit tests that check empty lines and empty segments

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@5933290adf49

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1032561
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0941ca3ffbcbb9218dc2299ab3eb4fc51fc2d896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001732Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731957}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67efdaf4f226..eb16c3879516


Created with:
  gclient setdep -r src-internal@eb16c3879516

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ib2a37bfd73d9190dde43b9c1fce0ffb990a346b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001730Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731956}

SyncedSessionTracker keeps raw pointers to tabs in |synced_tab_map|,
with the ownership either in |unmapped_tabs| or for mapped tabs in
the actual session window (SessionWindow::tabs).

Prior to this patch, the clearing of tabs in
PopulateSyncedSessionWindowFromSpecifics() could lead to dangling
pointers in |unmapped_tabs|, leading to undefined behavior. This
specifically affected the case where the input contains duplicate
window IDs, since any other window should have no tabs as a result
of ResetSessionTracking().

The presence of dangling pointers in |synced_tab_map| led to a CHECK
failure in PutTabInWindow() because of how
SyncedSessionTracker::GetTab() is implemented, which would return
the dangling pointer to freed memory, not linked to any known
window, and detected by a CHECK failure in PutTabInWindow() before the
pointer itself was dereferenced.

After this patch, if a header entity contains duplicate window IDs, it
gets filtered out early. Based on that, the problematic tabs.clear()
call in PopulateSyncedSessionWindowFromSpecifics() is replaced with a
CHECK.

Bug: 803205
Change-Id: Id2f3fd4f0cc5012ed169065b39c5363ee9c23c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001303
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731955}

ProfileHelper::ClearSigninProfile may be called after profile_manager
was destructed.

Bug: 977137
Change-Id: I6811f4327065a3f69c6c0cbdcd0257e774a6ccab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968979Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731954}

- Add IDLObject
- Add V8T::HasInstance

Bug: 839389
Change-Id: I08edcb3428e31a74d546ab8e11c0da2e549a9fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000395Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731953}

Currently, when the user changes the UserAgent, the behavior is to
create a new entry in the navigation history.
Those two entries correspond to the two UserAgents.
Navigating from one to the other changes the UserAgent.

This CL removes this behavior. Now there is only one navigation entry
and the user cannot change the UserAgent by navigating back/forward.

Bug: 1031124
Change-Id: I161cc29269035dfcb1fa38d52c1f0d384ef0179a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953711
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731952}

Bug: 1030266
Change-Id: Ibc872d96c9a246b4111cdc8ee807b795382100f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995322
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731951}

See https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers

I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4Fidt4JqkTk

Bug: 999895
Change-Id: I8275ea42664d411f635e80123ca01d2b07008a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986885
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731950}

After recent refactoring in http://crrev.com/c/1990126, the code
now compute the set label for the OK button even if when no OK button
is shown.

This caused DCHECK failure. Details are in the linked bug.

This CL fixes this problem.

Bug: 1041494
Change-Id: If3f7be64e2957511b2d7e2c3e18d113094eb9cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998178Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731949}

Bug: 772839
Change-Id: I741914b52a3dea26b20e62af19168d22b94b34e8
TBR: fdoray@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002608Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731948}

In order to test that no report was sent, the WPT tests set a timeout
and check that no report was received once it expires. The current value
of the timeout is a bit too long, causing the test to sometimes timeout
in a flaky manner. This CL reduces the timeout and re-enables the test.

Bug: 850170
Change-Id: Ibc39291fa0bcfafa94cd84233b78973d74afff1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995261
Auto-Submit: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731947}

To better support WASM debugging, we need asyncified source mapping
support. Upcoming CLs will asyncify
'DebuggerWorkspaceBinding.uiLocationToRawLocations' and all
corresponding use-sites.

This CL changes relevant layout tests that are using APIs that will
be async in the future. One of the tests is disabled until the
necessary changes are landed in the DevTools frontend.

Bug: chromium:1032016
Change-Id: I23c4894f492a598f35e814bd3eed785e54cb726d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981162Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731946}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=cliffordcheng@chromium.org

Bug: 1041419
Change-Id: I29d396de609e7884b440204a3b04212507363c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998636
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731945}

Adds an EG test that cuts and pastes after focusing the omnibox. This
verifies that pre-edit state doesn't break the keyboard shortcut cmd+X,
which had happened before.

Bug: none
Change-Id: Iff1f8f5d2e30006fde72663faed5315bfdd81c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993463
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731944}

https://pdfium.googlesource.com/pdfium.git/+log/997e797922ae..de6595c71442

git log 997e797922ae..de6595c71442 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 shwali@microsoft.com Add support in FPDFAnnot_SetAP() for transparent appearance streams

Created with:
  gclient setdep -r src/third_party/pdfium@de6595c71442

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I01d00ece59b8283746202a08799fd7a237a7ea54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001950Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731943}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/786589f59eef..989f726ff7f5

git log 786589f59eef..989f726ff7f5 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 szuend@chromium.org Port layout test for basic {TextSourceMap} parsing to Karma
2020-01-15 mathias@chromium.org Simplify tests for utilities.js
2020-01-15 mathias@chromium.org Add tests for ListModel operations

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@989f726ff7f5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032561
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4d0b921af8ce9ec8ea53298ee29191da5e0d418e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001949Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731942}

https://android.googlesource.com/platform/external/perfetto.git/+log/0a486a62378b..6fa4a067079c

git log 0a486a62378b..6fa4a067079c --date=short --first-parent --format='%ad %ae %s'
2020-01-15 eseckler@google.com ui extension: Allow connections from localhost

Created with:
  gclient setdep -r src/third_party/perfetto@6fa4a067079c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I03fa283a4c59babf8246877f0ba1f8628cf0cc11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001952Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731941}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80dbf39f7784..67efdaf4f226


Created with:
  gclient setdep -r src-internal@67efdaf4f226

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Id053e2d88b414a09f51bbcedff3d9aee7bbf7145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001953Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731940}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=benwells@chromium.org

Bug: 1041419
Change-Id: I8bd35171cb1e83eb86d245fbd7c70c38547fc593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994513
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731939}

Transfers focus across activation on Android (desktop chrome already
works). Also adds a chrome/ browser test and android instrumentation
test.

Bug: 1030838
Change-Id: I4d3daa99a54ed35c2b8dbec97f3c6f12ee3ced7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949119Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731938}