- 25 Apr, 2018 5 commits
-
-
Lei Zhang authored
BUG=833380 TBR=mcnee@chromium.org Change-Id: I21f9aba5266d2f8c44e29c5cc3ed75ad0dd78cde Reviewed-on: https://chromium-review.googlesource.com/1026846Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553383}
-
dpapad authored
- Move some styles from shared_style_css.html to paper_button_style_css.html. - Update paper-button styles per latest spec. - Collapse previously different types of buttons "primary" and "action" into a single button type. Note this change is intentionally changing the shared styling for buttons. If a certain WebUI page needs a different pre-MD refresh style, should be updated individually to override (hopefully there are no such cases though). Bug: 832173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8558db8ffd121ad09b100f8ba6ab4d843022f73f Reviewed-on: https://chromium-review.googlesource.com/1013330 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553382}
-
Devlin Cronin authored
ExtensionSettingsUIBrowserTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib0d7f277f7c2d79a941c689962e84030d24fe5b7 Reviewed-on: https://chromium-review.googlesource.com/1026086Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553381}
-
wutao authored
This cl adds more ChromeLauncherControllerTest to test the internal app window creation, close, and change of window property. Bug: 824437 Test: New ChromeLauncherControllerTest. Change-Id: I914b2aa931cfe8c3f845c1017b73025848fe29b3 Reviewed-on: https://chromium-review.googlesource.com/1023180 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#553380}
-
Daniel Cheng authored
Bug: 728219 Change-Id: I605f0a5897863c0059f0260598c2a4283e8e981e Reviewed-on: https://chromium-review.googlesource.com/1024236Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553379}
-
- 24 Apr, 2018 35 commits
-
-
Daniel Cheng authored
This allows more complex expressions to be used without confusing the compiler. TBR=mkwst@chromium.org Change-Id: I0b6d3a9526ac932bf1a8e3f7e9b3a76e3da34927 Reviewed-on: https://chromium-review.googlesource.com/1026805 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553378}
-
Filip Gorski authored
TBR=mariakhomenko@chromium.org Change-Id: I78bd913572ebc8460b7f7c02d400636ac6cd02bd Reviewed-on: https://chromium-review.googlesource.com/1026705Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#553377}
-
Jonathan Metzman authored
TBR=mmoroz@chromium.org Change-Id: I2250bc5a81f41b226bc2cadb6e24e083ef4a173d Reviewed-on: https://chromium-review.googlesource.com/1026934 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553376}
-
Oksana Zhuravlova authored
Bug: 799482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idce0482d4e8d2a2b0ac52769b73246850f1480a3 Reviewed-on: https://chromium-review.googlesource.com/1026207Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#553375}
-
Stefan Zager authored
BUG=825854 R=bokan@chromium.org Change-Id: Ic7533778665ce8e980b3f269d348aa0448f2bc3f Reviewed-on: https://chromium-review.googlesource.com/1026529Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#553374}
-
Xiaohan Wang authored
We used to have these checks in PpapiCdmAdapter, but they were lost when we added media::CdmAdapter. In summary: - Only allow storage ID when |allow_persistent_state| is true. - Only allow File IO when |allow_persistent_state| is true. - Only allow platform challenge when |allow_distinctive_identifier| is true. Also post tasks in CdmAdapter in failure cases to avoid reentrance into the CDM instance. this change. Filed crbug.com/836046 to refactor CdmAdapter and tests. Test: The current CdmAdapterTest makes it harder to add unittest for Bug: 510088,836046 Change-Id: I5a88c253a75a3af00f553681b65792198f31dba7 Reviewed-on: https://chromium-review.googlesource.com/1025220Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553373}
-
Jacob Dufault authored
There was one crash report in this method, but the crash did not seem to include local variables. Log the value of authentication_stage_ to capture it. Bug: 820671 Change-Id: I82c25b8a58f0993a9eef94c497c2c3e06c48b255 Reviewed-on: https://chromium-review.googlesource.com/1015880Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#553372}
-
Weidong Guo authored
Changes: Show the context menu in home launcher in the same way as that in wallpaper when the background is long-pressed or right clicked. BUG=832993 Change-Id: I5f2d769884b2313a8a32254522428a73e13b9665 Reviewed-on: https://chromium-review.googlesource.com/1024728 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553371}
-
Peter Boström authored
This change: * Displays the generic avatar icon instead of profile icon when there's only one non-signed-in user. This matches the current AvatarButton behavior. * Displays the guest badge instead of the generic avatar icon when the user is in guest mode. * Replaces the avatar icon getter to use entry->GetAvatarIcon() instead of AvatarMenu::GetImageForMenuButton. The image retrieved for MenuButton was non-square and didn't fill the entire circle icon. Now the avatar profile icon is instead cropped and fills the circle. This matches the icons displayed in ProfileChooserView. Bug: chromium:822070 Change-Id: I3599ca708e7f866d9c2f437f33c0d8cc141f5c13 Reviewed-on: https://chromium-review.googlesource.com/1026093Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553370}
-
Jun Cai authored
This CL fixes some LoginPromptBrowserTest related to cancelling auth request, in this case, LoginHandler::OnRequestCancelled() needs to be called. Bug: 783990 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id87ce38aec5191e40b3b282b4cde0304ea769d92 Reviewed-on: https://chromium-review.googlesource.com/1008846Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#553369}
-
https://pdfium.googlesource.com/pdfium.git/+log/6453a67d84dc..b242943f5e94 $ git log 6453a67d8..b242943f5 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 dsinclair Remove m_CurNodeType from CFX_XMLParser 2018-04-24 rharrison Switch declaration order to prevent UAF Created with: roll-dep src/third_party/pdfium BUG=chromium:808333 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ica15741534c4ee7dcc743f8715fb0271a1dae843 Reviewed-on: https://chromium-review.googlesource.com/1026525Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553368}
-
Bo Liu authored
Use ChildProcessTerminationInfo in these content APIs: * BrowserChildProcessObserver::BrowserChildProcessCrashed/Killed * NOTIFICATION_RENDERER_PROCESS_CLOSED (instead of RendererClosedDetails) * RenderProcessHostObserver::RenderProcessExited On desktop platforms, ChildProcessTerminationInfo replaces base::TerminationStatus and exit_code. On Android, ChildProcessTerminationInfo also contains two additional fields, since "child" process launching is fairly different on Android. There is one non-refactor change: RenderProcessHostImpl::Cleanup now calls ChildProcessLauncher::GetTerminationStatus. On Android, this is important to populate the Android-only fields. And for all platforms, this has the side effect of closing the base::Process earlier, which is visible through RenderProcessHost::GetProcess. Everything else is a pure refactor. chromecast/ review tbr TBR=slan@chromium.org Bug: 693484 Change-Id: I64d40b19797483918d9777352fd9c4eec4e398f9 Reviewed-on: https://chromium-review.googlesource.com/1017386 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#553367}
-
Kyle Horimoto authored
This function returns various debug data about the DeviceSync service and is intended to be used only by the chrome://proximity-auth debug page. Bug: 824568, 752273 Change-Id: Iaea72dfcb251488cc42c1211c3143b25d96b48cf Reviewed-on: https://chromium-review.googlesource.com/1020155 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#553366}
-
Kyle Horimoto authored
Previously, GetSyncedDevices() returned an array of RemoteDevice structs (in error cases, an empty list was returned). This was problematic because a client of this service had no way of differentiating between the case where there actually are no synced devices and an error case. This CL changes the return type to be a nullable array of RemoteDevice structs; now, in error cases, null is returned instead of an empty list. Bug: 824568, 752273 Change-Id: I6cfaa3933730beeb36082c8351d0f5b5ade0b086 Reviewed-on: https://chromium-review.googlesource.com/1020290 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553365}
-
Dan Sanders authored
Using DecoderBuffer removes the need to provided SharedMemoryHandles in cases that SharedMemory is not already allocated (in particular, when VDAs are used through MojoVideoDecoder+VdaVideoDecoder). Since base::SharedMemory is not an interface, a new type is required, and DecoderBuffer already implements a suitable interface for this use case. This CL adds: - A VideoDecodeAccelerator::Decode() overload for decoding DecoderBuffers, which VDAs may optionally implement. Note that VdaVideoDecoder will require this, and therefore all VDAs will be updated to support DecoderBuffers over time. - Support for SHM in DecoderBuffer. This eases the transition by allowing BitstreamBuffers to be easily converted to equivalent DecoderBuffers. - An implementation of the new VideoDecodeAccelerator::Decode() overload in VTVideoDecodeAccelerator. - Calling the new overload from VdaVideoDecoder. Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib932c3524b37e339f592b150685937ea94d4199d Reviewed-on: https://chromium-review.googlesource.com/1015965Reviewed-by:Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#553364}
-
Xianzhu Wang authored
CompositedLayerRasterInvalidator::PaintChunkInfo::property_tree_state no longer holds references to the property nodes which may be freed after this structure is created. We never dereference the pointers and newly created property nodes always have Changed() flag set, so this is good for property change detection. This avoids the structure holding the whole out-dated paint property tree (in the worst case). Bug: 833496 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If16082f7371dbc59b816e274ee02a87158952b08 Reviewed-on: https://chromium-review.googlesource.com/1017768Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#553363}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sergeyu@chromium.org Bug: 825327 Change-Id: Ic3521abdd745c1c048dfd9828232eb0e6c351fc2 Reviewed-on: https://chromium-review.googlesource.com/1024760Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553362}
-
Jonathan Metzman authored
This reverts commit 1dc170da. Reason for revert: <INSERT REASONING HERE> Original change's description: > [LPM] Add documentation on writing targets that accept multiple inputs. > > Bug: 769578 > Change-Id: Ic4f0adc56337330496020942940c28fc9b0ba89d > Reviewed-on: https://chromium-review.googlesource.com/1026708 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553346} TBR=mmoroz@chromium.org,metzman@chromium.org Change-Id: Ibcff0cbf42e010bdeb362feb0ae816284e352502 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769578 Reviewed-on: https://chromium-review.googlesource.com/1026910Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553361}
-
Marina Ciocea authored
Needed for sending media::UserInputMonitor::GetKeyPressCount() over IPC. Bug: https://crbug.com/828864 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifa391e3f6b9c75971616eb7ed6596f73bc9ddec8 Reviewed-on: https://chromium-review.googlesource.com/1025814 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553360}
-
Min Qin authored
Currently the InProgressCache is owned by ChromeDownloadManagerDelegate. In order for download to work as a service, the InProgressDownloadManager should be able to manage InProgressCache. It should read from the cache and recreate the download before resuming it. This CL moves the InProgressCache from ChromeDownloadManagerDelegate into InProgressDownloadmanager. And it also moves StartDownload() method as this is needed when resuming the download without DownloadManagerImpl. DownloadManagerImpl now becomes a delegate of InProgressDownloadManager. It will provide InProgressDownloadManager the information to create a new download. When resuming a download after launching download service, DownloadManagerImpl is not needed. BUG=803135 Change-Id: Ie7a22213e935638dac10dd82d2e079326e8083f2 Reviewed-on: https://chromium-review.googlesource.com/1024723 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#553359}
-
https://skia.googlesource.com/skia.git/+log/f50c283f0b53..a11f7d0a5991 $ git log f50c283f0..a11f7d0a5 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms 73399c8..cca4d5d (1 commits) 2018-04-24 brianosman Make SkColorSpace::Make(skcms_ICCProfile) stricter 2018-04-24 halcanary include/private/SkTemplates: SkInPlaceNewCheck uses ... 2018-04-24 caryclark prepare to remove obsolete macros 2018-04-24 borenet [infra] internal_hardware_label is a string now 2018-04-24 halcanary include/private/SkTemplates: Cleanup bare pointers. 2018-04-24 egdaniel Update flag checks when validating surface being assigned to proxy. 2018-04-23 mtklein Reland "call skcms_OptimizeForSpeed()" 2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms 8e64fbf..73399c8 (1 commits) 2018-04-24 caryclark update md files 2018-04-24 kjlubick IWYU for fuzz binary 2018-04-24 halcanary sk_tools/Resources: optional SK_TOOLS_REQUIRE_RESOURCES flag 2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms 4028d14..8e64fbf (1 commits) 2018-04-24 borenet [infra] Fix missing internal_hardware_label property 2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms 011b6142..4028d14 (1 commits) 2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms 5cbdc0a..011b6142 (1 commits) 2018-04-23 bungeman Properly restore from image filter save layers. 2018-04-23 csmartdalton ccpr: Cull extremely thin triangles 2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms 6a4194e..5cbdc0a (1 commits) 2018-04-23 kjlubick Make fuzz autodetect file names Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I1c4d38bb70bd9054bf94e0e22e34a1e98c784735 Reviewed-on: https://chromium-review.googlesource.com/1026554 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553358}
-
Kent Tamura authored
It will supersedes //third_party/WebKit/Tools/Scripts/lint-test-expectations. lint-test-expectaions isn't removed yet due to dependency from build/scripts/slave/chromium/. Bug: 829697 Change-Id: I213b413304240e2f8672a1d2209a2800331b1ade Reviewed-on: https://chromium-review.googlesource.com/1025437Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553357}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=juliatuttle@chromium.org Bug: 825327 Change-Id: Iddd6fb67987e98cbc4fa6a4b09167124e1f31388 Reviewed-on: https://chromium-review.googlesource.com/1024470Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553356}
-
Kent Tamura authored
New name is merge_web_test_results.py. Note that we decided to rename LayoutTests to web_tests. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/KKNbuzj-3HY/H8FWgtKrBgAJ Bug: 829697 Change-Id: I24bf833ba794316734d04495e7c1f30f9dad5090 Reviewed-on: https://chromium-review.googlesource.com/1025618Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553355}
-
Dominic Mazzoni authored
This is a follow-up to http://crrev.com/c/1011229, which introduced AXTableInfo. In this change, Mac and Windows accessibility code uses AXTableInfo to get cell IDs, column headers, and row headers, rather than relying on those attributes from Blink. This speeds up Blink serialization and will make it easier for our table handling code to be even more fast and robust. TBR=estark@chromium.org Bug: 832289, 651614, 789748, 753125 Change-Id: I4d859e0a5973f172b1b3e587ad871607d127f6cd Reviewed-on: https://chromium-review.googlesource.com/1012447 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553354}
-
Malay Keshav authored
Subpixel positioning was needed because text layout was performed at 1x device scale factor and then rastered to the final display device scale factor leading to glyph artifacts and inconsistent glyph positioning. With pixel canvas enabled on chrome os, the text layout is now always performed at the final display device scale factor. This, coupled with the replacement of ui scale with display zoom, the text on Chrome OS is now always rastered with the correct glyph positioning and it no longer requires subpixel positioning. Bug:835187,824154,716662 Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 Component: Text render, subpixel positioning, font TBR=derat@chromium.org Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 Reviewed-on: https://chromium-review.googlesource.com/1026636Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553353}
-
James Wallace-Lee authored
Add the page https://en.wikipedia.org/wiki/File:Rotating_earth_(large).gif to the stories run in power.typical_10_mobile. This tests power usage when an animated GIF is running slower than chrome's 60fps animation speed. Bug: 737101 Change-Id: Ica34e8fb78446a2c61069268a502ac5e031649bc Reviewed-on: https://chromium-review.googlesource.com/1018200Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#553352}
-
Kent Tamura authored
* Add "third_party/blink/renderer/" to some values in CoreProbes.json5 and PlatformProbes.json5. * make_instrumenting_probes.py passes a directory name relative to out/$config/gen/, and a template uses it to generate #includes. Bug: 836071 Change-Id: I31ac5efaba5b96914e342d5c4f54a236b5c3fab1 Reviewed-on: https://chromium-review.googlesource.com/1025233Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553351}
-
Ben Pastene authored
Mostly for humans. The bots should all have kvm installed and available. Also use logging instead of print. Bug: 828607 Change-Id: Ifee1ead435932d6d2752c0a418cd38618a66228e Reviewed-on: https://chromium-review.googlesource.com/1026569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#553350}
-
Qiyu Hu authored
This was updated quite a while ago in bluez. https://chromium.git.corp.google.com/chromiumos/third_party/bluez/+/48fe55b7610257bdb9ea075f1382440ae013be42%5E%21/#F0 Roll src/third_party/cros_system_api/ dea305b1a..62d5021bb (1 commit) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/dea305b1a70d..62d5021bb6d4 $ git log dea305b1a..62d5021bb --date=short --no-merges --format='%ad %ae %s' 2018-04-23 qiyuh Update gatt error message in dbus for bluez. Created with: roll-dep src/third_party/cros_system_api BUG=b:69965109 TEST=Pass CtsVerifier test on reading w/o permissions Change-Id: Id0eb9122c02ca255ebbb50caf718d9020fd8d1ab Reviewed-on: https://chromium-review.googlesource.com/1026075Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#553349}
-
Kyle Horimoto authored
This CL adds two additional API functions: (1) SetSoftwareFeatureState(): Enables or disables the given software feature for the device with the given public key. (2) FindEligibleDevices(): Finds devices which are eligible for the given feature. This CL adds a SoftwareFeatureManager object to DeviceSyncImpl, which it uses to execute these function calls. Bug: 824568, 752273 Change-Id: I717d7732754dc9fb9bd91aec3eaad81513725fcb Reviewed-on: https://chromium-review.googlesource.com/1018007Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553348}
-
Theresa authored
BUG=832685 Change-Id: Ie8088a65f8d264de00b8930aea4e16d06317eb98 Reviewed-on: https://chromium-review.googlesource.com/1026649Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#553347}
-
Jonathan Metzman authored
Bug: 769578 Change-Id: Ic4f0adc56337330496020942940c28fc9b0ba89d Reviewed-on: https://chromium-review.googlesource.com/1026708Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553346}
-
David Jacobo authored
If the user chooses to continue their navigation via 'Use app' on the intent picker, thus escaping Chrome, make sure to either close the current tab or navigate to the previous entry (if any). Opening a desktop PWA reparents the tab which implicitly closes it in the current browser and sends it to an app window, this is why we don't use the new CloseOrGoBack method for the PWA case. Bug: 678141 Test: Build. Change-Id: Ie1bf38db0fce959a13ac94e751a6fa20495b0040 Reviewed-on: https://chromium-review.googlesource.com/756313Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#553345}
-
Fabrice de Gans-Riberi authored
Bug: 835405 Change-Id: I0dc49d7d8dd4c5cb05e93007c020bca4cf7830b0 Reviewed-on: https://chromium-review.googlesource.com/1013061Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553344}
-