- 26 Nov, 2019 40 commits
-
-
Chris Blume authored
This reverts commit ea6b9281. Reason for revert: It turns out the V8 team needs the MSVC build. :) I tried installing the Clang compiler as part of Visual Studio 2017 and 2019 but neither of them became options in the toolchain. I'll need to spend more time figuring out how to get Clang on Windows. Original change's description: > Remove use of inline ASM in insert_string_sse > > It seems that some years ago clang@Windows didn't have the > proper intrinsic required, which prompted the use of inline > ASM. > > It has a side effect in that it will allow compilation of the > optimized function within the same compilation unit while using regular > compiler flags (i.e. 'crc32' instruction on x86 requires some special > compiler flags). > > Main issue is that inline ASM is blocked on dependencies (e.g. 'base') > that will be linked to NaCl. > > The main idea here is to allow the whole Chromium code base to use the > highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported > through an interface (i.e. base::Crc32()). > > This patch fixes this issue by removing the use of inline ASM. > > The workaround is to use clang/gcc 'target attributes' to instruct the > backend to use different code generation options for the optimized > function, see: > https://clang.llvm.org/docs/AttributeReference.html#target > > Bug: 902789 > Change-Id: I0d139268aefb8335310c0e3f6533006be9af6470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931272 > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718788} TBR=cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com Change-Id: I6b3fcce10197121b548300855710e99f7048f1ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936189Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#719105}
-
Oriol Brufau authored
The specification added a step to increase sizes to accommodate spanning items crossing flexible tracks instead of ignoring their contents completely. This is done after handling all grid items that don't cross such tracks, and this time items are considered together, not grouped by their span size. This is a reland of r705228, which was reverted due to a performance regression. The main problem was that non-spanning items in flex tracks have to be handled with a variant of the algorithm for arbitrary spans, which was much slower. But now that has been greatly improved by r714511 and r715665. I have also refactored the patch to avoid worsening the performance of spanning items that don't cross flex tracks. However, the algorithm for arbitrary spans is still a bit slower than the one for span of 1. Therefore the nested-grid perf test will decrease by ~5%. This is expected since it has lots of non-spanning items in flexible tracks, that will now be handled with the arbitrary span algo. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items BUG=935102 TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html Change-Id: I4dfae4a0293aea611b04b59738cfced5e4fe8d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913406 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#719104}
-
Antonio Gomes authored
BUG=787254, 939192 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic4d7594070d71ca8ca9153ca197a8d9b4ade053f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932089 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719103}
-
Mikel Astiz authored
Sync change events are posted in the background thread and BookmarkPromoHeader is not intended to be used in the background thread, so task-posting is required. Bug: None Change-Id: If2998f82fef6f66101d176bc8932c2a3a7b6c1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929056 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719102}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ed1ad81. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idc03c1a7fbbd04cb6c71fededccc0d8557d8b904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936387Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719101}
-
Tim Schumann authored
TBR=rockot@google.com BUG: 1027940 Change-Id: Icbcb8571b994c8de778c952654037095f7578bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936215Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719100}
-
Mark Cogan authored
This CL updates the page control assets for Incognito with the updated designs used elsewhere in the app. Also, this CL removes all of the (unneeded) 1x assets from the tab grid, removing the associated parts of the Contents.json and BUILD.gn files. Bug: 1021891 Change-Id: I9f790a89233748e644133676057d900590db8aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929234 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719099}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/72e6cb0b3f54..d5e2f215d65d git log 72e6cb0b3f54..d5e2f215d65d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 handellm@webrtc.org VideoRtpTrackSource: implement encoded source methods. Created with: gclient setdep -r src/third_party/webrtc@d5e2f215d65d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013590 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I16c7adc64bba9e1c1d2e820839a433534b2261bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719098}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52e6614e..5069a6c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I20b49f0341aee78fac27f1044f387d6a2d8abc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936388Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/070dba7c5d32..da4c7cba65d0 Created with: gclient setdep -r src-internal@da4c7cba65d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1023605 Tbr: jbudorick@google.com Change-Id: Ie9878fd1ce77d1e54bb549a38218f870c39653c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936123Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719096}
-
Fergal Daly authored
This makes the Fake usable in more circumstances and is in line with the real implementation. Bug: 1024716 Change-Id: I7ca40f3df08f4575255c0008e9db010888e1788e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928108Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#719095}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f2637d0dd7eb..ae3c27d5c5c3 git log f2637d0dd7eb..ae3c27d5c5c3 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 bclayton@google.com Merge changes I672a4d28,I4a74212f,I5c51e8aa,I323ea936 Created with: gclient setdep -r src/third_party/swiftshader@ae3c27d5c5c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I851697aa16d7f54df98b752c1ffc50b03c16fabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936118Reviewed-by:
-
Maksim Ivanov authored
This removes the "Learn more" link from the <security-token-pin> Polymer element, which is shown during SAML-based login when the smart card authentication is used. The link was a placeholder anyway, and, now that it was negotiated with UX and Product that we won't have any help article for it, we're removing it from the UI. Bug: 1024251 Change-Id: I23cfc4e69e650e97e84353ec53c562dd6b0a91fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932665Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#719093}
-
Ewann authored
- Deletes margin. - screenshots: https://photos.app.goo.gl/KrJZVkFKRnb4Avxk8 Bug: 1021893, 1022450 Change-Id: Ic598ef50fc69384824bc969f1930efd23fa45586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904084 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719092}
-
Yuta Kasai authored
This patch is a part of FetchEvent WorkerTiming patches. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch passes a Mojo pending receiver for WorkerTimingContainer to blink::PerformanceResourceTiming by TakePendingWorkerTimingReceiver() when the request is completed. In order to achieve it, this patch adds receiver to blink::ResourceTimingInfo as a mutable member variable and extends all AddResourceTiming() to pass receivers. The reason of the mutable variable is that it must be passed to blink::PerformanceResourceTiming by move semantics but blink::ResourceTimingInfo is passed only by const reference. blink::ResourceTimingInfo can't be changed to pass by value because blink::ResourceTimingInfo is created by scoped_refptr and it passes its pointer to PerformanceNavigationTiming now. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: I04bee9dc1990564db3c102b5f2ce64266cb76a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923869 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#719091}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f65b212492ec..ab63fd28450a git log f65b212492ec..ab63fd28450a --date=short --first-parent --format='%ad %ae %s' 2019-11-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 39b3005ba560..6f6e3371c92a (1 commits) Created with: gclient setdep -r src/third_party/angle@ab63fd28450a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: I778ff3f6384f519621570e6846b43ab81a20d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936114Reviewed-by:
-
Felipe Andrade authored
Replace auth_policy by authpolicy on files and variables names to make them consistent across the codebase Bug: 964911 Change-Id: I291c8ed90512136dc312fd69699ff5d7c974cad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929245Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#719089}
-
Tim Schumann authored
Fails on linux-chromeos-dbg. TBR=yoshiki@chromium.org BUG: 1027919 Change-Id: I9006192cdc5a8c850f61d9d127b68092bbbf9dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936214Reviewed-by:
-
Jiewei Qian authored
Bug: 1021813 Change-Id: Ie148398f2e670164c3acd82c666335c9d2a71781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921600 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#719087}
-
Jiewei Qian authored
Report system web app install error codes by profile category. Also report CRX Install errors (if occurs) and DisableReason if SWA is disabled somehow. Bug: 1021813 Change-Id: Id46bc63e451784b7ddf1d3bb8628af91bec98c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921599 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platforms where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ie59fa348b9715a95c1030a66d0316897f967e360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930822 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I3c96dc4acd12ed1bb848b384086065afa52e9149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930825 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#719084}
-
Antonio Gomes authored
BUG=78725 R=guidou@chromium.org Change-Id: Ib20bee0a0267a89a6f551c5b746063212b227edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933486Reviewed-by:
-
Tim Schumann authored
It's flaky on Win7 (32) builders. BUG: 1025335 TBR=msarda@chromium.org,svenzheng@google.com Change-Id: Ib9eb763d27ecee548b965c9829ae7d6e8da72244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936213Reviewed-by:
-
Carlos IL authored
The existing 'Insecure Content' setting will now disable autoupgrades for passive mixed content in sites it is set. This CL also removes support for the opt-out header. Bug: 988921, 1009562 Change-Id: I70734629d0f0a13d782a84ee75466c204992f8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929775 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#719081}
-
Ramin Halavati authored
Missing annotation in weblayer/browser/content_browser_client_impl.cc is blocking network traffic annotation trybots and is removed from tests until it is updated. Change-Id: Iafdf5ad8f2e5273cd8a23f138c3aa35a5b00a9c3 TBR: nicolaso@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936307Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#719080}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: Ib1f56707705847f85df1f691cd01b33d4c7fb3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934331 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719079}
-
Chris Lu authored
This change introduces InfobarTranslateSelectLanguageTableViewController to allow the user to change either the source or target language. It is populated by the InfobarTranslateLanguageSelectionConsumer protocol, and will use InfobarTranslateLanguageSelectionDelegate to send signals back to the coordinator about user selections. Bug: 1014959 Change-Id: Ibd6705ffac0f1beb924bc7170db353450b56343b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926134 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Yuta Kasai authored
This patch is a part of FetchEvent WorkerTiming patches. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch prepares for passing a Mojo pending receiver for WorkerTimingContainer to blink::PerformanceResourceTiming. In order to identify a Mojo receiver corresponding to a FetchEvent, WebWorkerFetchContextImpl has a map from |request_id| to a pending receiver. This patch adds a method to take a Mojo pending receiver from content::WebWorkerFetchContextImpl. It's used to pass Mojo pending receivers to blink::PerformanceResourceTiming in later patches. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: I3d1119362b2eabbce4df1d709f392a87ba42cc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924343 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Ricky Liang authored
GpuVideoAcceleratorFactories::SharedImageInterface returns nullptr when the GL context cannot be created or is lost. Bug: 982201 Bug: b:144805331 Change-Id: Ie97eb8c2a962c024a8acc6f1248ce5b4f5def0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932146Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a549754468c..070dba7c5d32 Created with: gclient setdep -r src-internal@070dba7c5d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id6b785ad9c7b56448071a66daa19ac2cbc59cde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936116Reviewed-by:
-
Hitoshi Yoshida authored
Implements Create() that creates a Blink object from a V8 object. In case we have an exception internally, Create() returns a nullptr. Bug: 839389 Change-Id: Iaebd4c1b2a7e9f510eed7a0d13bb5cd7999e9591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911799 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719074}
-
Colin Blundell authored
Currently, user_prefs::UserPrefs::Get() is only needed within the context of WebLayer's safe browsing implementation on Android. However, it will shortly also be needed by WebLayer's SSL implementation (when we change that implementation to be based on the shared //components-level one rather than being a fork). SSL interstitials run on all platforms (concretely, Linux as well as Android). In preparation for that change, this CL moves the creation and ownership of WebLayer's user prefs service into BrowserContextImpl. This change both ensures that the PrefService is created and registered on all platforms rather than only Android and also aligns WebLayer with how user pref service creation and ownership is structured in other embedders in which user_prefs::UserPrefs::Get() is broadly used (e.g., Android WebView and Chrome). Bug: 1026591 Change-Id: Ibab57af127aca76f3944389896f538b1f2571e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930658Reviewed-by:
-
Martin Robinson authored
Similar to what happens for the Windows port, the AuraLinux accessibility implementation should walk up the transient window chain when returning parents of dialogs in transient windows. This fixes an issue where bubbles show up twice in the accessibility tree and where bubbles did not return their frame parents when calling atk_object_get_parent. Bug: 1024342 Change-Id: I15fc2db6c6d21a7368eae92798127e597ba8b0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919930 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719072}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1f0fda29b7e8..e705827b369b git log 1f0fda29b7e8..e705827b369b --date=short --first-parent --format='%ad %ae %s' 2019-11-26 fancl@chromium.org Keep working directory clean 2019-11-26 dberris@chromium.org Vendor d3.js v5 Created with: gclient setdep -r src/third_party/catapult@e705827b369b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986772 Tbr: skyostil@google.com Change-Id: I728be8b1bf4fd248b766a1f01c81770fa3264b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936112Reviewed-by:
-
Fredrik Söderquist authored
Rather than having |current_value_| be null when an animation is not active, have it point to the same value as |base_value_|. This avoids having to null-check |current_value_| for each access (in CurrentValue). Bug: 1017723 Change-Id: I39c56ec30ee9c92692db4f68be49a8094bf012b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932542Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#719070}
-
Yu-Hsuan Hsu authored
The change is related to CL:1926067. Add histogram information in histograms.xml to make the histogram visible on chromedashboard. BUG=b:144818607 Change-Id: I54e33685aa4f792e3d2e2e2f99c822a3cdd34fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933848 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#719069}
-
Igor authored
When the user session is stopped, we don't have access to user logs anymore, yet it's important to have information on the reason why the session was stopped. BUG=chromium:1014538 TEST=Check that reason is logged at sign out. Change-Id: I2869b000db5750cafba8566f8d1e13cb1c2369c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871673 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#719068}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9db46c2bd8737240c0ead624b46dcb00ac7affd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935642Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719067}
-
David Munro authored
Bug: chromium:1024718 Test: Build + CQ Change-Id: Icd5642e66beb4512090295e673421b5e002505e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935572 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#719066}
-
