GitLab

This reverts commit b2457b26.

Reason for revert: suspected of causing assertion failure running merge_web_test_results.py in not_site_per_process_webkit_layout_tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53956

2018-11-02 10:44:57,220 - root: [INFO] Running with isolated arguments
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/merge_web_test_results.py", line 12, in <module>
    main(sys.argv[1:])
  File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/blinkpy/web_tests/merge_results.py", line 775, in main
    assert args.positional
AssertionError


Original change's description:
> Make layout tests use default isolation (e.g. site-per-process on desktop).
> 
> Summary
> =======
> 
> This CL makes layout tests use the default site isolation from the
> platform they are run on (instead of opting out of strict site isolation
> via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
> Additionally, on platforms where strict site isolation is enabled,
> layout tests opt into slightly stricter isolation by enabling isolation
> of same-site origins used by Web Platform Tests - this ensures that
> features covered by WPT also get sufficient coverage of out-of-process
> iframes (OOPIFs).
> 
> After this CL, expectations for tests that differ in behavior with and
> without OOPIFs are being moved from
> LayoutTests/FlagExpectations/site-per-process to:
> - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
> - LayoutTests/virtual/not-site-per-process/README.md
> - LayoutTests/TestExpectations and LayoutTests/NeverFixTests
>   ("Site Isolation failures" section)
> 
> 
> Desirability
> ============
> 
> The CL helps with the following:
> 
> - Focusing on testing the mode that is actually shipped to end users
> - Helping ensure that newly developed features get site-per-process
>   coverage without having to set up a separate step (i.e. it is
>   sufficient to set-up a bot that runs layout tests with
>   --enable-features=NewFeature without also having to have a separate
>   test step for runing layout tests with *both*
>   --enable-features=NewFeature *and* --site-per-process
> 
> This CL does *not* help with reducing requirements for CQ capacity,
> because we need to maintain a separate
> not_site_per_process_webkit_layout_tests step to make sure that tests
> pass without isolation (which is the mode Chrome ships on Android).
> Also note that layout test coverage on Android is very sparse - see
> https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion
> 
> 
> Preserving test coverage
> ========================
> 
> Most tests
> ----------
> 
> The CL preserves covering most layout tests with and without OOPIFs, by
> relying on the fact that CQ/waterfall run layout tests on both kinds of
> platforms - ones that default to strict site isolation (desktop
> platforms) and ones that default to no site isolation (Android).
> 
> 
> Tests that used to be excluded FlagExpectations/site-per-process
> ----------------------------------------------------------------
> 
> Around 40 tests fail when run in presence of OOPIFs.  Such tests are
> disabled by this CL by moving test expectations from
> FlagExpectations/site-per-process into the main TestExpectations file.
> The CL preserves non-OOPIF test coverage provided by the disabled tests
> by introducing virtual/not-site-per-process directory which runs all
> such tests with site isolation disabled.  Using a virtual test suites
> for preserving the test coverage relies on the ability to have separate
> test expectations for these tests (i.e. relying on the fact that
> disabling these tests in TestExpectations doesn't disable their
> virtual/not-site-per-process equivalents).
> 
> Note that the CL keeps isolating "oopif.test" site even in
> virtual/not-site-per-process suite.  This site should only be used by
> tests that require an OOPIF.
> 
> 
> Preserving site-per-process-specific test expectations
> ------------------------------------------------------
> 
> Some tests have site-per-process-specific expectations:
> - http/tests/inspector-protocol/network/security-info-on-response.js
> - http/tests/inspector-protocol/network/raw-headers-for-protected-document.js
> 
> The tests above highlight that cross-origin cookies are not displayed in
> site-per-process mode (a known regression tracked by
> https://crbug.com/849483).  This CL preserves expectations and coverage
> by shuffling things around:
> - old, main expectation -> android expectation
> - old, site-per-process expectation -> main expectation
> 
> 
> There is one additional test with site-per-process-specific
> expectations:
> - external/wpt/dom/events/EventListener-addEventListener.sub.window.js
> 
> Unlike the other 2 tests, it seems less important to preserve exact test
> expectations for the case when the test fails with Site Isolation.
> Therefore this test is covered by virtual/not-site-per-process test
> suite and an expectation for this test is added to the main
> TestExpectations.
> 
> 
> Lost test coverage
> ------------------
> 
> Even with extra caution described above, some test coverage may be lost:
> 
> - Features covered by tests only on one kind of platform (e.g. disabled
>   on Android) are at risk of losing OOPIF or non-OOPIF coverage.
> 
> - Before this CL, site-per-process was also applied to all other
>   `virtual/...` test suites.  After this CL,
>   `virtual/not-site-per-process` will not provide such coverage.
> 
> 
> Cleaned up test expectations
> ----------------------------
> 
> Some additional test expectations clean-up is done, while preserving
> test coverage:
> 
> - The http/tests/perf/large-inlined-script.html test has been already
>   present in `SlowTests` and therefore I didn't include this test in the
>   new `virtual/not-site-per-process` suite.
> 
> - The http/tests/devtools/network/network-datareceived.js test was
>   already marked as expecting a `[Failure]` in TestExpectations and
>   therefore I didn't include this test in the new
>   `virtual/not-site-per-process` suite.
> 
> - The http/tests/devtools/console-cross-origin-iframe-logging.js test
>   was already marked as `[Timeout]` in the old TestExpectations but for
>   Win only.  Since I can repro a timeout on Linux (with and without site
>   isolation), I just extended the old expectation to all platforms and I
>   didn't include this test in the new `virtual/not-site-per-process`
>   suite.  I also removed the test from SlowTests (since timeouts in the
>   test are not expected everywhere).
> 
> 
> Bug: 870761
> Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64
> Reviewed-on: https://chromium-review.googlesource.com/c/1302662
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604955}

TBR=dpranke@chromium.org,alexmos@chromium.org,lukasza@chromium.org

Change-Id: I54b6a36922bebfbc8a3f1467bc3d4807c2322604
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870761
Reviewed-on: https://chromium-review.googlesource.com/c/1315960Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605039}

The PRD in the bug explains how we wanted it to look, and when we wanted it to appear.

SCREENSHOT: https://screenshot.googleplex.com/WEy35zvdt6O.png
SCREENCAST: https://drive.google.com/open?id=1SURR2EP4UN35lPZQYUw2iceivWGnDO2y

Bug:883456

Change-Id: Ib94be66d45cd809f995d01c6429e563371e550f1
Reviewed-on: https://chromium-review.googlesource.com/c/1259806
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605038}

This works around a bug where the fallback language (English) doesn't
get installed by Play.

Bug: 901284
Change-Id: Iff059d45903e444fa74335845a0bac280dff456f
Reviewed-on: https://chromium-review.googlesource.com/c/1315692
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605037}

GetNetworkServiceFromConnector() may be called in the early startup before the
full browser starts. Therefore, it can't use
DCHECK_CURRENTLY_ON(content::BrowserThread::UI) to check whether it is called
on the same thread. Instead, we check whether the connector is accessed on the
valid sequence to replace this DCHECK.

Bug: 729596
Change-Id: I97e2b0cae7a4a7e0dded919b9b120f60eb18fea6
Reviewed-on: https://chromium-review.googlesource.com/c/1308977Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605036}

Add a new UMA histograms metrics to record the entry point where Assistant UI
becomes visible (e.g, when AssistantVisibility changed from kClosed/kHidden
to kVisible).

Test: local compile and manually test.
Change-Id: I440ace2a719ce2bed2eda921fc9025809b414b6d
Reviewed-on: https://chromium-review.googlesource.com/c/1313117
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605035}

A new UKM event, PreviewsResourceLoadingHints, is being added. This
tracks the usage of the patterns associated with a resource loading
hints based preview and the total number of resource requests blocked
at each resource load priority.

The UKM is recorded after the URL's document finished loading and uses
the NavigationID from the browser's NavigationHandle as the source id.

Bug: 891453, 884815
Change-Id: I429a6ef5e6222d7f569c8d2eb5539d815af6ff02
Reviewed-on: https://chromium-review.googlesource.com/c/1307057
Commit-Queue: Jered Gray <jegray@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605034}

This does not add any new functionality, but sets the stage for things
like requesting the host to show a file picker.

Bug: 679313
Change-Id: Id0a25d038f274584dfd6661df50658437ad29258
Reviewed-on: https://chromium-review.googlesource.com/c/1265028
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605033}

This should make OOMs less likely for large queues, although it won't
stop misbehaving code from posting too many tasks which will lead to
and OOM.

Bug: 895930
Change-Id: Ia424dd1c2bbfaf27d1714f36c47067485060143d
Reviewed-on: https://chromium-review.googlesource.com/c/1314629
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605032}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b5f94ce7..04108353

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia223bc128fe2a07c678ff7ffebd6ee490fc10ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1315360Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605031}

clang automatically checks this value is correctly set, and it
simplifies macro usage.

Bug: 742517
Change-Id: I3b53752a7ac00e33167b9fb42fb3801ef8e7d378
Reviewed-on: https://chromium-review.googlesource.com/c/1308082Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605030}

ScopedFD will close the file descriptor on destruction, so the closes
here will end up closing the file descriptor twice, resulting in
badness if another thread opens a file descriptor between the two
closes.

Change-Id: Ib92efa06e879e1f820d51911fbaecc6cd9410268
Reviewed-on: https://chromium-review.googlesource.com/c/1315988Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Josh Gao <jmgao@google.com>
Cr-Commit-Position: refs/heads/master@{#605029}

There's evidence that some web iframes embedded on extension
background pages may be doing a lot of work with the assumption that
since this work isn't on a foreground tab, it doesn't need to be
optimized for responsiveness.  However, OOPIFs currently use an
aggressive process reuse policy, which also affects this use case,
making it possible for a web iframe on an extension to get into
another tab's process and adversely affect its performance.  This CL
avoids using that reuse policy for web iframes on extensions.

Caveats:

- When over the process limit, web iframes on extensions will still
  attempt to reuse an existing process.

- OOPIFs from normal tabs may still join processes for web iframes on
  extensions.  This and the previous point imply that there won't be a
  guarantee of perfect performance isolation for web iframes on
  extensions; the goal is to be more resilient to problems in the
  common case.

- We will stop potentially useful process reuse between same-site
  iframes on multiple instances of extensions, even for instances of
  the same extension.  We expect this to be rare in practice though.

Bug: 899418, 899838
Change-Id: I35f6ecc1945292f9fab1c21f65d1ac4b7970dbe3
Reviewed-on: https://chromium-review.googlesource.com/c/1306410Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605028}

Bug: 899183
Change-Id: I36a9c92556215d79bc40dbe9aed6ec8f1d5fa5c1
Reviewed-on: https://chromium-review.googlesource.com/c/1315627Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605027}

Bug: 610222
Change-Id: I9e94153e836f504c61ef216990d2dfd1ae77771c
Reviewed-on: https://chromium-review.googlesource.com/c/1313590
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605026}

Precisely, this disallows them when the event loop's
termination nesting level is nonzero.

This is now part of the spec,
https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name

> The window open steps, given a string url, a string target, and a string features, are as follows:
> 1. If the event loop's termination nesting level is nonzero, return null.

BUG=844455

Change-Id: I85fb003063f5ed051049c7c263391835421902ac
Reviewed-on: https://chromium-review.googlesource.com/c/1180296
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605025}

R=rch@chromium.org

Change-Id: I0dc88fee136ebc8b15260856d03be3163b566ccd
Reviewed-on: https://chromium-review.googlesource.com/c/1313849Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605024}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e6f5134d1aa..f2cc71e5cbea


git log 9e6f5134d1aa..f2cc71e5cbea --date=short --no-merges --format='%ad %ae %s'
2018-11-02 stevenperron@google.com Handle OpMemberDecorateStringGOOGLE in ACDE (#2029)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@f2cc71e5cbea

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I96010e11cd4bdfa8d76b923cb2e4dbd2a926557b
Reviewed-on: https://chromium-review.googlesource.com/c/1315667Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605023}

https://chromium.googlesource.com/angle/angle.git/+log/99d0463cd940..6ba22ee13768


git log 99d0463cd940..6ba22ee13768 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 geofflang@chromium.org GL: Implement EGL_ANDROID_get_frame_timestamps.


Created with:
  gclient setdep -r src/third_party/angle@6ba22ee13768

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I7e7d199f1adee2c6b3a34119c9e5d16b0328166e
Reviewed-on: https://chromium-review.googlesource.com/c/1315728Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605022}

The below changes were added to fix a crash on GTK4.  However, this introduced a
crash on GTK3.  I'm unable to reproduce the crash and I'm going to be afk for 4
weeks after today, so I'm reverting these changes since GTK3 is currently
supported but GTK4 is not, and I want to get the revert merged to M71.  The
changes can be relanded in the future once we have reliable repro steps.

GTK4: Fix event processing after closing dialogs
Fix crash in SelectFileDialogImplGTK::OnFileChooserDestroyThunk.
[GTK] Speculative fix for crash in SelectFileDialogImplGTK
Fix heap-use-after-free in SelectFileDialogImplGTK

BUG=880073,901282
R=sky

Change-Id: Id046e9a54527e4df251884e6447f8830a3b859d3
Reviewed-on: https://chromium-review.googlesource.com/c/1314636Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605021}

The autofill profile validator is a pointer, it is a good
practice to initialized it to null. Also, in Init, the
initialization should happen before WebDataService check.
Otherwise, sometimes (like in AutofillManager tests)
We'll miss initializing it.

Change-Id: Ibc0a74b40df40cb58b705c66925217a9bc7b8884
Reviewed-on: https://chromium-review.googlesource.com/c/1315668
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605020}

The app doesn't change state anymore so there is nothing to monitor.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I7daa43cb9137e37b3f38cece458d7aa921239f46
Reviewed-on: https://chromium-review.googlesource.com/c/1315351Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605019}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ic0e717072a242ab397aad86a5ce651d4ea7de970
Reviewed-on: https://chromium-review.googlesource.com/c/1315488Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605018}

This is preferable because it avoids adding trace events while the
thread is idle (for which there is no precedent).

The delta between the instant events can be used to perform the same
analysis which could be performed previously (and these will be in
Slow Reports per being in an enabled category).

R=fdoray@chromium.org

Bug: 899897
Change-Id: I40d31df9f4db3ea8959f760323b7cd8f56299ce3
Reviewed-on: https://chromium-review.googlesource.com/c/1312928Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605017}

TBMv2 versions are added in
https://chromium-review.googlesource.com/c/catapult/+/1308815

Bug: 890757
Change-Id: If9f56016acbcd7f218a4e5516dcd74d0ae1a5327
Reviewed-on: https://chromium-review.googlesource.com/c/1313548Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605016}

Also,
- Enable a couple locally passing tests that don't have bugs attached.
- Disable EncryptedMediaTest suite on Chrome OS asan/lsan, to match
  Linux asan/lsan, due to flake (not unique to Mash).

Bug: 793426
Change-Id: Ia01b402234e33e5fda0f587fc8d47fad7897cbb7
Reviewed-on: https://chromium-review.googlesource.com/c/1315809
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605015}

This CL changes the behaviour of
H2OTransparentLauncherActivity#onHostBrowserSelected() in the edge
case (not sure if the edge case is possible) that both H2OMainActivity
and SplashActivity are enabled.

When both H2OMainActivity and SplashActivity are enabled, this CL
changes the behaviour of
H2OTransparentLauncherActivity#onHostBrowserSelected() to do
a normal launch instead of relaunching the WebAPK with the goal
of changing the enabled component. This change also brings the code
in line with the code comments.

BUG=817263

Change-Id: Iedfdabce4245eaf0db689ac2d4968b967096eaab
Reviewed-on: https://chromium-review.googlesource.com/c/1314615Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605014}

At OnLoad event, the renderer notifies browser process of the
anchor elements in the viewport. The browser uses this information
to predict the navigation probability of each of these anchor
elements.

This CL changes the logic in the render side to skip reporting
of elements that are part of ad frames since we expect these
to be clicked less often.

Bug: 899339
Change-Id: I171cce5d4b9f722039222865753f3b7cbe6d8a79
TBR: holte@chromium.org,ryansturm@chromium.org,kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1315529Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605013}

This CL fixes the test flakyness and enables the test on Android.

Bug: 892004
Change-Id: Ibc08897c300ce9704cebf861249b8c7f719cf474
Reviewed-on: https://chromium-review.googlesource.com/c/1313735
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: AJITH KUMAR V <ajith.v@samsung.com>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605012}

Avoid integer overflow when computing a total buffer size from a base
buffer and small partial sequence buffer.

Bug: 901030
Change-Id: Ic82db2c6af770bd748fb1ec881999d0dfaac30f0
Reviewed-on: https://chromium-review.googlesource.com/c/1313833Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605011}

At one point we identified sync registrations by an id instead of by
the tag. But we've long since only used the tag. Remove the id.

Bug: 901034
Change-Id: I94eb60fb51e9e036c98dff78c6fc8cd2f190232d
Reviewed-on: https://chromium-review.googlesource.com/c/1313190Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605010}

Until https://critique.corp.google.com/#review/206234268 is submitted,
enumerations cannot be configured because their proportion values will
change significantly with that chnage.

Bug: 900230
Change-Id: I1670dabf72e4a2d6d00dd1c295961571b61fe9fa
Reviewed-on: https://chromium-review.googlesource.com/c/1313189Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605009}

Does not yet start using windows in Arc.
See go/a11y-arc++-window-mapping for more.

Bug: 891483
Change-Id: Ibbd47b12b4440f3200edb9e57a14658f489e4cd5
Reviewed-on: https://chromium-review.googlesource.com/c/1308079
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605008}

https://android.googlesource.com/platform/external/perfetto.git/+log/5d27da308ea5..5af3a96bfa9f


git log 5d27da308ea5..5af3a96bfa9f --date=short --no-merges --format='%ad %ae %s'
2018-11-02 primiano@google.com UI: use distinct colors for distinct processes


Created with:
  gclient setdep -r src/third_party/perfetto@5af3a96bfa9f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I8fecaf1b67d819b39185c747886a749f290fba2f
Reviewed-on: https://chromium-review.googlesource.com/c/1315332Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605007}

1. Better (more vertically centered) position for hosted app windows.
2. Correct sizing (29x29 instead of crunching to 24x24) for browser and
   hosted app windows. Packaged apps were already using 29x29.
3. Get rid of outline. GetAvatarImageFor{User,Context} already adds a
   white border.

Bug: 901127
Change-Id: I5b0fcb1bcd3266c988e1a62c84b4f8455b53df35
Reviewed-on: https://chromium-review.googlesource.com/c/1313746
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605006}

There's no need to do the TLS lookup twice.

Bug: 897751
Change-Id: I628297659ce38971bd16f204e29bace267679b71
Reviewed-on: https://chromium-review.googlesource.com/c/1314593
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605005}

This CL enabled display compositor pixel dumps by default, which caused
this group of tests to fail due to either a) minor antialiasing artifacts,
or b) known differences in output due to being captured from the browser
side.

https://chromium-review.googlesource.com/c/chromium/src/+/1213864

These bugs should be resolved with this CL:
 - crbug.com/881040: Media controls now contain an overflow menu.
 - crbug.com/667551: A bunch of tests are listed under this bug, and just
                     require rebaselining to fix non-material single-pixel
                     antialiasing failures.
 - crbug.com/895556: These tests double their background size when the flag
                     is enabled. These were already fixed by another CL,
                     so they are NOT being rebaselined here, just removed
                     from TestExpectations.


Bug: 895912, 881040, 667551, 895556
Change-Id: I14a1065df604151ed06f2a6be4da7eaa53968705
Reviewed-on: https://chromium-review.googlesource.com/c/1303179
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605004}

The possible crash senario is like following:
1) Regular SuggestionMarker with suggestions get clicked, timeout
   triggered.
2) IME removes original SuggestionMarker, then added another
   SuggestionMarker with no suggestion.
3) SuggestionMenuTimeoutCallback() get called.
4) Crash happens because we are getting the first suggestion in
   suggestion_infos vector.

This CL checks if suggestion_infos is empty to avoid the crash.

Bug: 901135, 869261
Change-Id: I5949c370e3cbc2c760502f7357ba5463c7d909bb
Reviewed-on: https://chromium-review.googlesource.com/c/1314130
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605003}

https://webrtc.googlesource.com/src.git/+log/42e7d9c929ef..0367d1a1fb0a


git log 42e7d9c929ef..0367d1a1fb0a --date=short --no-merges --format='%ad %ae %s'
2018-11-02 yinwa@webrtc.org Adds a field trial parameter to configure waiting time before sending Nack packets.
2018-11-02 eladalon@webrtc.org Change to RtcEvent::Copy
2018-11-02 kwiberg@webrtc.org Hide the AudioEncoderCng class behind a create function


Created with:
  gclient setdep -r src/third_party/webrtc@0367d1a1fb0a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7505ba5732a32e3caaf450b55955575211cf2d85
Reviewed-on: https://chromium-review.googlesource.com/c/1315333Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605002}

And remove cpu:x64 from the defaults.

TBR=jbudorick

Bug: 901205
Change-Id: I64be7685d85a2b5d895dafde6df0193b8db0c6bf
Reviewed-on: https://chromium-review.googlesource.com/c/1315693Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605001}

BUG=None

Change-Id: Ibfccc7663c3d5091574af4cd50254e42dbb79190
Reviewed-on: https://chromium-review.googlesource.com/c/1313068
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605000}