GitLab

This CL add logic for monitering visibility of CCA window and close
camera stream when window is idle (not recording) and is non-visible in
tablet mode.

Bug: 1035653
Test: Pass tast run <DUT> 'camera.CCAUI*'.
Test: Manually test camera stream is closed when CCA is idle and is
invisible in tablet mode.
Test: Manually test recording can be continued when CCA is invisible in
tablet mode.

Change-Id: I05c1ddf3c16dce3897d694e07208b18fd78acc42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986468Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728464}

https://skia.googlesource.com/skia.git/+log/03f3f75e4828..f1db2661f17c

git log 03f3f75e4828..f1db2661f17c --date=short --first-parent --format='%ad %ae %s'
2020-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1fdf6ca5141d..1031d2c65b5e (5 commits)

Created with:
  gclient setdep -r src/third_party/skia@f1db2661f17c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: Id39eeff323d1046a248b4101f66e86246b150934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987316Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728463}

Now the OOR-CORS m79 rollout is started. To follow the best practices
for incremental feature rollouts, this patch enables the OOR-CORS
by default on TOT.

NOAUTOREVERT=true

Bug: 905971, 1001450, 1035763, 1039165
Change-Id: I2ca742eab6a14891968892f7f1ef40adbe8bad67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988127
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728462}

This CL implements eviction when clients.claim is called on bfcached
client.
In order for the claim API to see the bfcached clients, this CL adds
|include_cached_clients| option for ServiceWorkerContainerHost
iterator, which defaults to false.

Bug: 1036744
Change-Id: I654698aee083f881c3dd6ff19486b34835206004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980522
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728461}

As the comment in service_worker_navigation_handle.h, rename
ServiceWorkerNavigationHandle to ServiceWorkerMainResourceHandle.

This CL has no behavior changes.

Change-Id: I44ace8344e6feff740dc89517bafbb96d9c1b229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982513Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#728460}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1573f3772170..57923928ffaf


Created with:
  gclient setdep -r src-internal@57923928ffaf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Id7942703ac9aebf8d4ba17a7f4ce97b9d8ac7163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987207Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728459}

https://skia.googlesource.com/skia.git/+log/d445e2b6fcf1..03f3f75e4828

git log d445e2b6fcf1..03f3f75e4828 --date=short --first-parent --format='%ad %ae %s'
2020-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a12a9d87..3beaf136 (315 commits)

Created with:
  gclient setdep -r src/third_party/skia@03f3f75e4828

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: Ib01302f7936b071d3ec13360088e0b4e8dd47812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987382Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728458}

Bug: 141518780
Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on
both HALv1 and v3 devices.

Change-Id: I8273ed4dd738b740700f51098a2456a8d2030581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986537
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728457}

Bug: 141518780
Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on
both HALv1 and v3 devices.

Change-Id: I3e0c50fa838a2b5ce3878d79f7d7137db66ff17e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986647
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728456}

Incorporate information into the main documentation and link to them.

Change-Id: I16432d5454ab39a52fe5212cf38239717e4f132c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983691Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728455}

Bug: 141518780
Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on
both HALv1 and v3 devices.

Change-Id: I1e51752fc913e8f2d4072f17d170a74a82e72d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980258
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728454}

if blitsurface failed, then return directly.

Bug: 1031436
Change-Id: Ie351d8a22d94f1b3116b2470432db9264db6c57a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988024Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728453}

Mostly initializing variables in declarations and shortening code.

Also changed AppInfoDialogViewsTest.ViewInStore to call the link
callback instead of pressing the link directly, since in a future CL
I'll be removing the link member variable, so the test wouldn't work.

Bug: none
Change-Id: I90c689be86785a9b297b3161dafb01a0a8bb3568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983510
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728452}

Bug: 795989
Change-Id: I8185bf021d255ab279bea5ff03651b70ab4eb2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982340Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728451}

We used to pass a vector of DMABuf FDs to the GL/EGL image creation
functions. This was very error-prone, as these vectors could contain
less FDs than there were planes in the buffer, and this information
was used to signal that the last FD contained several planes. The
function receiving these incomplete FDs would then try to figure out the
actual planes layout, with more or less luck, often introducing bugs in
the way.

Solve this issue once and for all by passing all importable buffer
information within the VDAs through NativePixmapHandles: they always
contain as many FDs as there are planes, and also have detailed layout
information. On top of that, they are what we receive when using import
mode (which means we can pass the exact layout information down to
GL/EGL), and we already have a function that creates them from a
VideoFrame. This helps reduce the amount of code, all the while making
it safer and more readable.

BUG=b:146842214
TEST=VDAtest passes on Hana.
TEST=VDAtest passes on Kevin with VD disabled.
TEST=VDAtest passes on Kukui.
TEST=crosvideo.appspot.com plays videos properly on Hana.
TEST=crosvideo.appspot.com plays videos properly on Kevin with VD disabled.
TEST=crosvideo.appspot.com plays videos properly on Kukui.
TEST=Youtube Android plays properly on Hana.
TEST=Youtube Android plays properly on Kevin with VD disabled.
TEST=Youtube Android plays properly on Kukui.

Change-Id: I88a78b786b1c90820221c9f0770a52a339913537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982499
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728450}

makes dictionary generation routine follow interface generation.


Bug: 89389
Change-Id: I71001dd1e55a739bd0059a101fc05d7d0fb82eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984784Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728449}

As "[WebSocket] Do not send response headers for failed handshake."
https://chromium-review.googlesource.com/c/chromium/src/+/1847592
patch stops sending WebSocketHandshakeResponseInfo for failed handshake,
we don't need OnFinishOpeningHandshake in-advance function bringing it
but only need to send WebSocketHandshakeResponseInfo with other
 mojom::WebSocketHandshakeResponse contents (actually we're already
doing that on network-renderer mojo level).
This patch does similar refactoring between
WebSocketStream-network::WebSocket calls.

Change-Id: Ie3f2cd114121a8bcfdbb71b10a52c4aa8c0d36c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949808Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728448}

r728439 <crrev.com/c/1980663> included comments that should
have been removed before landing. This patch removes it.

TBR=ikilpatrick@chromium.org

Bug: 982194
Change-Id: I9e7c61bf2db9a04824f22abe53dc1ed270dabf0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986566
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728447}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e850d191a29..1573f3772170


Created with:
  gclient setdep -r src-internal@1573f3772170

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I7d5da858802d24d0a02156c38d0fd0effa563bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987581Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728446}

This fixes a variety of color issues:
* Reported bugs, e.g. incorrectly using the native theme colors when a
  custom theme is installed
* Unreported bugs, e.g. not correctly plumbing all colors for PWAs

Bug: 1033922
Change-Id: I335ab7160bcb0796494c16d53e45494a823fed50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968156
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728445}

Using wpt-import in Chromium e630bf9d.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id8604e5f4a1c3f6b7ac9e9ea40b6f6225ed075f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986143Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728444}

Use the Fourcc class instead of uin32_t with the GL/EGL image creation
methods. This simplifies their logic a bit.

BUG=None
TEST=Video plays properly on Hana and Kevin non-VD.

Change-Id: I50ae21d1ce34d3dba4c08bb59887d5f208b41a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982348Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728443}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I2b9520d6d7805d7c202a27b9cb72bae27e742812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986022Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728442}

(see: i18n/input/javascript/chos/testing/integration/automation_ext/manifest.json)

This extension is used for Essential Inputs testing, and permission is
needed to enable typing on Virtual Keyboard.

Change-Id: I5fcfc5a8de8d2f12c7302904146e3c36ee21e6bb
Bug: 1039158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983686
Commit-Queue: Alex Bergman <abergman@google.com>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728441}

These are still useful and for the foreseeable future, so extend by
one year (plus one month to avoid alerts during the holiday season).

Bug: 1037275, 1037273, 1037272, 1037271, 1037266
Change-Id: I26cad90d4dd9cc366ac7db920b71b2dbf6d225a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981235
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728440}

This patch changes |NGInlineLayoutAlgorithm| to place inline
box placeholders to before children.

Before this patch, they were created after children, only
when the inline box is not culled. This change:
1. Reduces the insertion to |Vector| in |CreateBoxFragments|,
   which involves memory copy. This is not common today, but
   will be common when |NGFragmentItem| is enabled.
2. Allows easier implementation to "disable culled inline
   boxes" when |NGFragmetnItem| is enabled.

There should be no behavior changes.

Bug: 982194
Change-Id: I0d7077e4c9b78b99276afc2e7919258b33bd4ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980663Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728439}

This is a part of effort for using [RaisesException] when synchronously
rejecting a promise.

It uses [RaisesException] for
//third_party/blink/renderer/modules/webgl.

Bug: 1001114
Change-Id: Idac16870d09425fbe140ef5ed93b5558d4b555c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986476Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#728438}

The V4L2Device::Create(EGL|GL)Image methods took a const reference to
the vector of DMAbufs representing the buffer. This suggests that the
reference to the DMAbufs is borrowed, while the methods take full
ownership of them.

The clients of these methods are already correctly duplicating the FDs
before passing them. However, for clarity make these methods take
explicit ownership through a rvalue reference.

BUG=None
TEST=VDAtest passes on Hana
TEST=crosvideo.appspot.com plays videos properly on Hana.
TEST=VDAtest passes on Kevin
TEST=crosvideo.appspot.com plays videos properly on Kevin with VD disabled.

Change-Id: I91c1ba964c24ed4d8d8db4d0e1612c6eb147b7c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981965Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728437}

CL:1978684 increased the ChromeOS DEBUG bot timeout, and since that CL
FilesApp browser tests do not flake in DEBUG anymore, issue 981420.

Re-enable the FilesApp copyBetweenWindows tests that were marked flaky
on the DEBUG bots, issue 1008909.

Bug: 981420, 1008909
Change-Id: Ibb253b8aa79b093935db312448339f5feaa350f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983681
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728436}

This is a part of effort for using [RaisesException] when
synchronously rejecting a promise.

It uses [RaisesException] for
//third_party/blink/renderer/modules/cache_storage.

Bug: 1001114
Change-Id: I78e3b02518e5c04725f50abb9e6ca54b191f3bc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985833Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#728435}

This CL adds several wpt tests for Web NFC:
  - Test push operation fails when data transfer fails
  - Verify pushed message for empty record type
  - Test reading message with multiple records should succeed

Bug: 520391
Change-Id: Iadb13f6cebaf30514ba7bef65a69302b368e4359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982271
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#728434}

This patch reverts |LayoutInline::CollectLineBoxRects| not to
use |NGInlineCursor|, by manually merging parts of r706815
<crrev.com/c/1862534> and r710694 <crrev.com/c/1888624>.

|NGInlineCursor| is rapidly changing that reverting is not
easy. This patch reverts not to use it for |getClientRects|
and a few other callers.

Testing more on culled inline box indicates that the phase 1
of LayoutNG regressed some cases from legacy, and
|NGInlineCursor| work regressed further. We might want to fix
when NGFragmentItem ships, but better not to change the
behavior until then.

Bug: 1036358
Change-Id: I47a60f5d3a505d4b43eba0d8b5adc64e02cbcd28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971632Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728433}

Although overlay cannot process HDR video without colorspace degraded,
renderpass will still be sent to OverlayProcessor. Since there isn't an
explicit skipping policy for processing HDR content with overlay in HDR
mode, this CL adds an condition to skip further processing when target
colorspace is HDR.


Change-Id: I14d2c39a332827990b950ee04f5174ddac0f1ee0
Bug: 1036736
Change-Id: I14d2c39a332827990b950ee04f5174ddac0f1ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977848Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#728432}

This reverts commit 547be407.

Reason for revert: Causes a CFI Failure
https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16082

../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:1625:9: runtime error: control flow integrity check for type 'content::NativeWebKeyboardEvent' failed during base-to-derived cast (vtable address 0x55aaa1c38368)
0x55aaa1c38368: note: vtable is of type 'blink::WebKeyboardEvent'

 const NativeWebKeyboardEvent* native_key_event =
        static_cast<const NativeWebKeyboardEvent*>(
            events[0]->ToEvent()->Event()->web_event.get());

Original change's description:
> Modernize WebInputEvent
> 
> Since the class is no longer memcopied between processes we can
> use virtuals.
> - Add virtual destructor
> - Add pure virtual cloning
> - Remove memset
> - Remove size attribute
> 
> BUG=836826
> 
> Change-Id: I92f7c1394009223d0e7970929ae5cdfc4bec2b00
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972167
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728205}

TBR=nasko@chromium.org,bokan@chromium.org,jbroman@chromium.org,dtapuska@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836826
Change-Id: Id8d19c45afaa236288b9a03abecd91ad12b1e031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988025Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728431}

Bug: chromium:1038610
Test: Deploy and view.
Change-Id: I5eda1e169936c3ab3c8eb0419564b5615688de4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985826
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Jason Lin <lxj@google.com>
Reviewed-by: Julian Watson <juwa@google.com>
Commit-Queue: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#728430}

The [1] CL enabled the FormControlsRefresh feature by default for
Windows, Linux, and ChromeOS. In the process, many layout tests were
disabled, because the form controls have a different appearance with
the feature enabled. This is one of several patches rebaselining those
disabled tests.

[1] http://crrev.com/c/1967608

Bug: 1035582
Change-Id: I1cf7247ed3f0b866db223f2bc927c7755fc9f8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986263
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728429}

This reverts commit c907f4bb.

Reason for revert: 
https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16085
Contained the revert and the same tests are failing.

Original change's description:
> Revert "Remove CompositorFrame handling in render_host"
> 
> This reverts commit aad41255.
> 
> Reason for revert:
> This is being reverted by the build sheriff on suspicion of causing the following break.
> 
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16082
> 
> The following two tests seem to fail consistently after this changelist:
> RenderWidgetHostViewAuraTest.KeyEventRoutingWithKeyboardLockActiveForAllKeys
> 
> RenderWidgetHostViewAuraTest.KeyEventRoutingWithKeyboardLockActiveForOneKey
> 
> 
> Original change's description:
> > Remove CompositorFrame handling in render_host
> > 
> > This CL starts to remove code in content/browser/renderer_host/ that
> > existed to receive CompositorFrames and submit them to the display
> > compositor running on the browser UI thread. The VizDisplayCompositor
> > feature has launched so this code is no longer used.
> > 
> > This CL is a first pass to delete code that doesn't have require
> > significant changes to tests.
> > 
> > TBR=sky@chromium.org
> > 
> > Bug: 759653, 812322, 1038683
> > Change-Id: I7bf29f57e7418eb8d3a16b86169f2b30bb9fbf80
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978997
> > Reviewed-by: Saman Sami <samans@chromium.org>
> > Commit-Queue: kylechar <kylechar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#728209}
> 
> TBR=sky@chromium.org,kylechar@chromium.org,samans@chromium.org
> 
> Change-Id: Ia0b20ebad951e8f22fb0f108cb9d09160e1a645c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 759653, 812322, 1038683
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986978
> Reviewed-by: Peter Williamson <petewil@chromium.org>
> Commit-Queue: Peter Williamson <petewil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728341}

TBR=sky@chromium.org,petewil@chromium.org,kylechar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 759653, 812322, 1038683
Change-Id: I8e27abb2e5e6cc818f08f3473a1eb626c7bcaa66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983687Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728428}

BUG=968439

Change-Id: If92868debe3c0a2b1c2532a05e97fa953c50901c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939148
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728427}

It wasn't being used meaningfully, and we want to remove the class.

Bug: 651119
Change-Id: Id479b735d1ef677d7eb55faf5e44ab2de859cd2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971755Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728426}

Specifically, the caption colors need to update.  On Ash this was happening
indirectly already, since BrowserNonClientFrameViewAsh::OnThemeChanged() was
calling UpdateFrameColor().  But on other platforms, it was not.

Handling this eliminates the need to set these colors at construction or in
BrowserNonClientFrameViewAsh::Init(), since OnThemeChanged() will always be
called when the frame is added to a widget, which happens after both those.
This also eliminates the need to null-check the frame view in
WebAppFrameToolbarView::UpdateCaptionColors(), since by OnThemeChanged() that
will always be set.  Finally, this eliminates the need for
BrowserNonClientFrameViewAsh::OnThemeChanged() to indirectly call
WebAppFrameToolbarView::UpdateCaptionColors(), since that is now called locally.

Also, the BrowserNonClientFrameView need not explicitly SchedulePaint(), since
if any children of the web app frame actually change color, they will invalidate
themselves as necessary.

Bug: none
Change-Id: If0a24ccebcf8ce105dc3662ee6468d6b9b36d419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980166Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728425}