GitLab

- SyncWorker: Construct / Destruct
- SyncWorker::Observer: Destruct


BUG=347425
TEST=./unit_tests --gtest_filter="SyncEngineTest.*:DriveBackendSyncTest.*"

Review URL: https://codereview.chromium.org/288193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272876 0039d316-1c4b-4281-b951-d872f2087c98

1) Fix a typo in ScoredHistoryMatch::GetFrequency name
2) Fix a cpplint warning

BUG=370850

Review URL: https://codereview.chromium.org/300433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272875 0039d316-1c4b-4281-b951-d872f2087c98

This avoids a GL error from a buggy glGetIntegerv(GL_MAX_SAMPLES_ANGLE)
call. Based on patch by mkisilev@yandex-team.ru

BUG=362435
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/296133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272874 0039d316-1c4b-4281-b951-d872f2087c98

Introduced in https://codereview.chromium.org/294033002/

NOTRY=true
BUG=None
TBR=noms@chromium.org

Review URL: https://codereview.chromium.org/297393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375679

Review URL: https://codereview.chromium.org/298873007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272872 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a unit test for the experimental app list that instantiates
the app list in experimental mode and performs a series of very basic
checks.

BUG=349727

Review URL: https://codereview.chromium.org/291653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272871 0039d316-1c4b-4281-b951-d872f2087c98

Phase one : introduce future screen classes before moving code from handler.

BUG=373314

Review URL: https://codereview.chromium.org/293613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272868 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272867 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Support "Pin to taskbar" for hosted app windows. (https://codereview.chromium.org/258243002/)

Reason for revert:
Suspect to cause failure on Vista machines: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40163

Original issue's description:
> Support "Pin to taskbar" for hosted app windows.
> 
> This CL allows hosted app windows to be pinned to the taskbar by
> right-clicking the taskbar icon and pressing the "Pin to taskbar" button.
> 
> This CL pulls out the code that sets the relaunch details of v2 app
> windows into web::UpdateRelaunchDetails.
> 
> BUG=368101
> TEST=Run a hosted app as a window. Pin it from the taskbar icon right click
> menu. Relaunch the app from the pinned icon.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272851


NOTRY=true
NOTREECHECKS=true
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/298003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272866 0039d316-1c4b-4281-b951-d872f2087c98

Multi-sided patch:
1/3: chromium-side, THIS PATCH
2/3: blink-side, https://codereview.chromium.org/287363004/
3/3: chromium-side, cleanup & re-enable test (n/a yet)

BUG=376733
TEST=LayoutTests is to be added, content_browsertests is to be re-enabled
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/299003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272865 0039d316-1c4b-4281-b951-d872f2087c98

- introduce a minimum number of frames for bitrate tests; if a stream is
  too short, loop it over as many times as needed to reach that minimum
- instead of using additional black frames to flush the encoder at the
  end of encode, just rewind and reuse frames from the beginning;
  this also eliminates the need for the CS_FINISHING state;
- switch to a more demanding/varied stream for bitrate tests (bear)

- also move the starting point of encoder FPS calculation from Initialize()
  to after setting up the buffers to slightly better estimate actual encoder
  performance
- minor additions to the documentation of and fixes for input buffer size
  calculation
- add ifdefs to only check alignment on ARM

BUG=366158
TEST=run test, ensure bitrates converge properly on relevant platforms

Review URL: https://codereview.chromium.org/290643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272864 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes old Gallery files and related codes.
Along the way, the CL also fixes the file handler specification so that the Gallery can handle multiple selected video files.

BUG=358698,376240
TEST=manually

Review URL: https://codereview.chromium.org/291893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272863 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272862 0039d316-1c4b-4281-b951-d872f2087c98

and Use ExtensionRegistry functions instead of deprecated  ExtensionService functions.

R=xiyuan@chromium.org,rdevlin.cronin@chromium.org
BUG=354046, 354458

Review URL: https://codereview.chromium.org/275503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272861 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/299353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272860 0039d316-1c4b-4281-b951-d872f2087c98

Revert of non-new-profile-management creates a "no-op" style account_reconcilor, (https://codereview.chromium.org/276463002/)

Reason for revert:
unit tests fail on mac

Original issue's description:
> non-new-profile-management creates a "no-op" style account_reconcilor,
> useful for tracking stats but won't have any real effects.
> 
> Modify the AccountReconcilor_unittest to execute with the new_profile_management flag on.
> 
> BUG=357693
> TEST=Account Reconciler should function normally when
> new_profile_management flag is on. Should not have effects when the
> flag is off, but UMA stats (histograms) and logging (for
> --vmodule=account_reconcilor=1) should still trace the execution path.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272131
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272826

NOTRY=true
NOTREECHECKS=true
TBR=mlerman@chromium.org

Review URL: https://codereview.chromium.org/297303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272859 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Reparent SWProcessManager onto SWContextWrapper. (https://codereview.chromium.org/292973003/)

Reason for revert:
I suspect this broke ServiceWorkerDispatcherHostTest.EarlyContextDeletion on linux

Original issue's description:
> Reparent SWProcessManager onto SWContextWrapper.
> 
> This will allow Wrapper::Shutdown to drop all process references synchronously
> in a future change, which will make it possible to shutdown Chrome with service
> workers running and without hitting the DCHECK in
> ProfileDestroyer::DestroyProfileWhenAppropriate().
> 
> BUG=368570
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272839

TBR=falken@chromium.org,kinuko@chromium.org,jyasskin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368570

Review URL: https://codereview.chromium.org/307443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272858 0039d316-1c4b-4281-b951-d872f2087c98

 * Add TaskLogger class to log per-task status.
 * Wire up it SyncFileSystemService to SyncTaskManager.

BUG=344769

Review URL: https://codereview.chromium.org/291403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369249

Review URL: https://codereview.chromium.org/291303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272856 0039d316-1c4b-4281-b951-d872f2087c98

r272157 introduced a regression where ephemeral apps would be synced
when Chrome restarts, causing them to be installed.

BUG=374018

Review URL: https://codereview.chromium.org/295203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272855 0039d316-1c4b-4281-b951-d872f2087c98

On Linux, the OS theme can change, which affects the default background
colour of the avatar bubble. This means that using a frame overlay to
display the profile avatar as an image is not actually feasible.

This also adds a small change to the ClipPath function of gfx::Canvas,
to allow controlling the anti-aliasing option.

BUG=372721
TEST=Start Chrome with --new-profile-management. Click on the avatar button. The avatar should still be displayed as a circle.

Review URL: https://codereview.chromium.org/290333012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272854 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through header file.
3) Fix method names to use CamelCase style.
4) Rename file name to web_test_runner.

BUG=331299
TEST=content_unittests, content_shell. No functional changes
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/297273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272853 0039d316-1c4b-4281-b951-d872f2087c98

Gave the App Info Dialog a 10px 'gap' around the edges (so
the app list is visible through it), and a larger gap in
the wide app list so it appears as a vertical column down
the middle.

Also made a white background overlay that appears/disappears
with the dialog.

BUG=369888,374080,374076

Review URL: https://codereview.chromium.org/276833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272852 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows hosted app windows to be pinned to the taskbar by
right-clicking the taskbar icon and pressing the "Pin to taskbar" button.

This CL pulls out the code that sets the relaunch details of v2 app
windows into web::UpdateRelaunchDetails.

BUG=368101
TEST=Run a hosted app as a window. Pin it from the taskbar icon right click
menu. Relaunch the app from the pinned icon.

Review URL: https://codereview.chromium.org/258243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272851 0039d316-1c4b-4281-b951-d872f2087c98

Remove unused part for shared worker.


Solve conflicts from rebase.

Conflicts:
	chrome/renderer/content_settings_observer.cc
	chrome/renderer/content_settings_observer.h

BUG=343382

Review URL: https://codereview.chromium.org/290573010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272850 0039d316-1c4b-4281-b951-d872f2087c98

This is a minimal amount to get the `views` target compiling on Mac. It
adds an implementation of NativeWidgetMac that spews NOTIMPLEMENTED().
So, nothing works yet, but this gives an FYI builder something to chew
on to catch regressions in things ported so far.

BUG=366007

Review URL: https://codereview.chromium.org/249113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272849 0039d316-1c4b-4281-b951-d872f2087c98

This test depends on the initialization of ResourceBundle, now that we
have GfxTestSuite initializating it we can move it into gfx_unittests
target.

BUG=331829
TEST=ui_unittests, gfx_unittests
TBR=danakj@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/298083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272848 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) dom_action_types.h
2) install_warning.h

Review URL: https://codereview.chromium.org/296173011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272847 0039d316-1c4b-4281-b951-d872f2087c98

VideoDecoderVpx has supported VP9 for a while, but was missing a colour
conversion codepath from I444 frames to ARGB.

BUG=377239,260879,134202

Review URL: https://codereview.chromium.org/300653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370175

Review URL: https://codereview.chromium.org/292663018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272845 0039d316-1c4b-4281-b951-d872f2087c98

into view seems to be not working. Implement user pod scroll into view depending
on the number of user pod rows available.

Login pods scroll into view is triggered only on window resize and when keyboard is shown.
This means that if keyboard is already shown (i.e. no resize is happening) and user selects
another user pod in different row no scrolling happens i.e. relying on user to scroll pods manually.

Also updating outer-container min-height based on primary display resolution.

Note: Lock screen has overscroll enabled since default scroll into view implementation is working fine there.

Main changes are in
login_display_host_impl.cc
display_manager.js
user_pod_row.js
keyboard_util.cc
The rest is just adding 2 new common methods into the interfaces.

To disable this feature: --disable-login-scroll-into-view

Screenshots: https://folio.googleplex.com/loginvk

BUG=363635
TEST=Manual: 1..6 rows of user pods, bring up VK. Both landscape and portrait mode, incl. screen rotation.

Review URL: https://codereview.chromium.org/292233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272843 0039d316-1c4b-4281-b951-d872f2087c98

As far as update engine that process Rollback requests requires rootfs verification, we're unable to set usual flag for testing Rollback option.

So existence of /tmp/enable_rollback_ui.flag file is the new flag for Rollback reset option.

BUG=368860

Review URL: https://codereview.chromium.org/292973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272840 0039d316-1c4b-4281-b951-d872f2087c98

This will allow Wrapper::Shutdown to drop all process references synchronously
in a future change, which will make it possible to shutdown Chrome with service
workers running and without hitting the DCHECK in
ProfileDestroyer::DestroyProfileWhenAppropriate().

BUG=368570

Review URL: https://codereview.chromium.org/292973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272839 0039d316-1c4b-4281-b951-d872f2087c98

It seems there is a problem running gsutil on cros dtus, so adding few
extra log statements around that code.

BUG=351143

Review URL: https://codereview.chromium.org/298863016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=rsesek

Review URL: https://codereview.chromium.org/304443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272837 0039d316-1c4b-4281-b951-d872f2087c98

+ Flip a coin and if we have persisted 1000 MRU servers, then load only
  either 200 or 1000 servers from disk.

+ Persist only one server (or don't duplicate server names) that
  spoke QUIC for canonical suffixes like:
  + .c.youtube.com
  + .googlevideo.com

+ Bumped up the version number of http_server_properties.

+ Added two histograms to measure the impact of persisting 1000
  alternate protocol servers.
  ++ Net.AlternateProtocolUsage.200Truncated
  ++ Net.AlternateProtocolUsage.1000Truncated

R=jar@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/298683010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81979

Review URL: https://codereview.chromium.org/301483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81979

Review URL: https://codereview.chromium.org/293343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272834 0039d316-1c4b-4281-b951-d872f2087c98