- 16 Mar, 2018 40 commits
-
-
Charles Harrison authored
This CL adds a variation parameter which encodes a threshold for the Site Engagement score [1] required to do tab-unders. By default, we allow tab-unders to origins that have any non-zero engagement. This moves the Tab.TabUnder.EngagementScore metric as the last check of IsSuspiciousClientRedirect, to simulate the scores blocked tab-unders would have if we removed that check. [1]: https://www.chromium.org/developers/design-documents/site-engagement Bug: 661629 Change-Id: I48ba83ab8cc58641cc21dcad062c313f1d1290ef Reviewed-on: https://chromium-review.googlesource.com/965403Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#543779}
-
Ria Jiang authored
1. Clients used to submit local_surface_id in hit-test data; however, this can be racy because we have primary_surface_id and fallback_surface_id and we can use any of the latest one in that range. Change it to not using local_surface_id submitted from clients, but instead asking SurfaceAggregator at HitTestAggregator ::Aggregator() time for the latest local_surface_id to use - this is done by adding LatestLocalSurfaceIdLookupDelegate in surfaces to talk to viz::Display, where we have access to the surfaces SurfaceAggregator used at aggregation time. Add FrameSinkIdMap in SurfaceAggregator to keep track of previously contained frame sinks. 2. Keep track of the list of child regions we've aggregated so far in HitTestAggregator to prevent cycles. 3. When preparing hit-test data, skip the quad if its FrameSinkId has changed between fallback and primary because we don't know which FrameSinkId would be used to draw this quad. 4. Add viz::TestLatestLocalSurfaceIdLookupDelegate to be used in tests. Bug: 819057, 819435 Test: viz_unittests, content_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I35ec40ae00af1ba4e3937002c1c0d261dae8b136 Reviewed-on: https://chromium-review.googlesource.com/957881 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543778}
-
https://chromium.googlesource.com/catapult.git/+log/6733f341991f..16322a374abb $ git log 6733f3419..16322a374 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 perezju [Telemetry] Remove Cherry_Mobile_Android_One condition Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0e17eb56979559a363dcb76f40a2e1e755d20768 Reviewed-on: https://chromium-review.googlesource.com/966584Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543777}
-
Daniel Murphy authored
Bug: 822723 Change-Id: Ifdfe9ac1a72c39fd9a65a82da25f27b1ec246b9c Reviewed-on: https://chromium-review.googlesource.com/966865Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#543776}
-
Julia Tuttle authored
...and take the opportunity to prune and reorder enums. Change-Id: I260f24bbe33781f27d41cf37296be0b84070f26f Reviewed-on: https://chromium-review.googlesource.com/957163 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#543775}
-
Michael Giuffrida authored
Add the app_shell_linux_symbols target to gn_all for official Linux desktop buliders. Bug: 818078 Change-Id: I3af605e18fe5fb85ab87f70ee3131d5176de8dde Reviewed-on: https://chromium-review.googlesource.com/963754Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543774}
-
Marijn Kruisselbrink authored
Which means that we abort transporting bytes for blobs we don't need. Also fixes a memory leak if blob is dereferenced while allocating quota. Bug: 740596 Change-Id: I03a32b920f4e213adf59b54745c2d5fe071b3132 Reviewed-on: https://chromium-review.googlesource.com/965243 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#543773}
-
Mikhail Atuchin authored
1. Fix the destruction order in extensions_tests; 2. Declare the explicit dependency: AlarmManager => ExtensionRegistry. Change-Id: Ibe734d3b39ba9a0d3dfae7c233c82c77336ec4bd Reviewed-on: https://chromium-review.googlesource.com/964144Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#543772}
-
Corentin Wallez authored
BUG=chromium:811827 BUG=chromium:811806 BUG=chromium:811790 BUG=chromium:811825 BUG=chromium:811872 BUG=chromium:811829 BUG=chromium:811819 BUG=chromium:811810 BUG=chromium:811808 BUG=chromium:811832 BUG=chromium:811797 Change-Id: Ib535f9792b3534553614617db6db976542f49201 Reviewed-on: https://chromium-review.googlesource.com/963605Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#543771}
-
liberato@chromium.org authored
Previously, DialogOverlayImpl did not close the overlay client when cleaning up. This caused the mojo router in |mClient| to be closed only when the client was GC'd, and issued warnings in logcat. Now, DialogOverlayImpl closes |mClient| properly. AndroidOverlayProviderImpl also closes the client if it fails before providing the client to a DialogOverlayImpl. Bug: 822798 Change-Id: I57657b4e1bc77e07e79a1182c5467e243d947002 Reviewed-on: https://chromium-review.googlesource.com/966868Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#543770}
-
Leonard Grey authored
Bug: 804950 Change-Id: I931bfdeefeefbbdbda626905dd14afe83e438821 Reviewed-on: https://chromium-review.googlesource.com/966929Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#543769}
-
Michael Giuffrida authored
This fixes deps and enables gn check for: //extensions/shell:app_shell //extensions/shell:app_shell_lib //extensions/shell:app_shell_unittests //extensions/shell/browser/system_logs which lets us specify //extensions/shell/* in //.gn. Some headers (esp. for NaCl) need to be annotated with // nogncheck because gn doesn't run the preprocessor: https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#what-gets-checked Bug: 367595 Change-Id: If37c5935cb993aa13f7586ee8ff17cdb23dddfc3 Reviewed-on: https://chromium-review.googlesource.com/958282Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543768}
-
Tommy Steimel authored
This CL adds 'poster' to the list of attributes that the MediaElementMutationCallback listens for. When changed, the CSS classes of the media controls are updated. This fixes a bug where a poster added after page load would not show up because it was hidden behind the default poster. Bug: 814956 Change-Id: I4b39e6995ddb35829d886e138fe8a1d573dd8036 Reviewed-on: https://chromium-review.googlesource.com/965589Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543767}
-
Stephen Chenney authored
This reverts commit c0a946a4. Reason for revert: Breaks content all over the web. Bug: 820163, 822673, 820561, 812148, 821333 Original change's description: > Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c > > This fixes a number of bugs found on clusterfuzz. > > Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 > Bug: 790944 > Bug: 793715 > Bug: 796804 > Bug: 799707 > Reviewed-on: https://chromium-review.googlesource.com/897220 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533953} TBR=dcheng@chromium.org,scottmg@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790944, 793715, 796804, 799707 Change-Id: Ic6b934d384229b9cf9092d559b865bbe8f278f38 Reviewed-on: https://chromium-review.googlesource.com/966684Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#543766}
-
Sahel Sharifymoghaddam authored
This reverts commit f2bf009a. Reason for revert: There has been a few bug fixes related to oopif and latching, I will enable the latching flag to see if the failing tests are fixed or not. If not I will disable the tests again addressing crbug.com/822764 bug as well. Original change's description: > Disable wheel scroll latching in failing content_browsertests. > > I cannot reproduce the test failures on my local official windows build, > in this cl I force wheel scroll latching to be disabled in the tests to > see if it changes the test results on Win official or not. > > Bug: 800822 > Change-Id: Ife07a29617ca5e0142e75f926967685cb61e2a08 > Reviewed-on: https://chromium-review.googlesource.com/895842 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533347} TBR=nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 800822, 822764 Change-Id: I563672dfbcb01298324a2b884cbed0e69c220339 Reviewed-on: https://chromium-review.googlesource.com/966687Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543765}
-
Chris Palmer authored
Bug: None Change-Id: Ie37f3a53bbdde9db917e8687778a2fcb5f9c402c Reviewed-on: https://chromium-review.googlesource.com/966863 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#543764}
-
Peter Kotwicz authored
Invalid share targets will now be ignored, rather than showing up in the picker and being rejected at launch time. This brings the implementation in line with the spec: https://wicg.github.io/web-share-target/ This CL: - Makes manifest_parser.cc check the share target url_template placeholder syntax. - Refactors ReplacePlaceholders() so that it does no string copying when called with url_template_filled==nullptr BUG=694380, 788191 Change-Id: Icd2a5af5e3100fd93a3fa3cd9ba00a23905355b7 Reviewed-on: https://chromium-review.googlesource.com/927581 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Karan Bhatia authored
TBR=ntfschr@chromium.org BUG=822753 Change-Id: I0ff8b5d2b1a9d5abe930e80d8a21e886ab32c457 Reviewed-on: https://chromium-review.googlesource.com/966866Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543762}
-
Raphael Kubo da Costa authored
Commit 8d49c506 ("DevTools: implement a URLLoader-based request interception proxy") introduced code that triggers GCC bug 71882: declaring a class from an unnamed namespace as a friend of a class inside a named namespace does not work. ../../content/browser/devtools/devtools_url_loader_interceptor.cc: In member function ‘void content::{anonymous}::InterceptionJob::NotifyClient(std::unique_ptr<content::InterceptedRequestInfo>)’: ../../content/browser/devtools/devtools_url_loader_interceptor.cc:907:36: error: ‘content::{anonymous}::RequestInterceptedCallback content::DevToolsURLLoaderInterceptor::Impl::request_intercepted_callback_’ is private within this context base::BindOnce(interceptor_->request_intercepted_callback_, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../content/browser/devtools/devtools_url_loader_interceptor.cc:342:30: note: declared private here RequestInterceptedCallback request_intercepted_callback_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../content/browser/devtools/devtools_url_loader_interceptor.cc: In member function ‘void content::{anonymous}::InterceptionJob::Shutdown()’: ../../content/browser/devtools/devtools_url_loader_interceptor.cc:913:32: error: ‘void content::DevToolsURLLoaderInterceptor::Impl::RemoveJob(const string&)’ is private within this context interceptor_->RemoveJob(id_); ^ ../../content/browser/devtools/devtools_url_loader_interceptor.cc:339:8: note: declared private here void RemoveJob(const std::string& id) { jobs_.erase(id); } ^~~~~~~~~ Work around the issue by fully specifying |InterceptionJob|'s namespace when declaring it a friend of |DevToolsURLLoaderInterceptor::Impl|. Change-Id: I565e169586ae0ce6ce1cd0ddbc36bd404847b386 Reviewed-on: https://chromium-review.googlesource.com/966601Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#543761}
-
Mark Pilgrim authored
BUG=714018 TBR=nick@chromium.org Change-Id: Ic30f482175460a71c0a5cd78796bf9296ebc13c7 Reviewed-on: https://chromium-review.googlesource.com/963084 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#543760}
-
Farah Charab authored
Add RendererScheduler.TaskDurationPerUseCase histogram to record time we spend running tasks split per RendererScheduler's UseCase. Change-Id: I0f9a2cf0976d6a8531bc2b9f4483aa0a511b01ec Reviewed-on: https://chromium-review.googlesource.com/960821 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543759}
-
Daniel Nicoara authored
This format is better supported and is the default format used for scanout buffer allocation. Bug: b/74993970 Test: Ran on device and ensured buffer allocation doesn't fail. Change-Id: I8743c9166e6ad41588418d10059fe2bac34fce35 Reviewed-on: https://chromium-review.googlesource.com/964893Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/af9e87b8c5bb..bf3dbb4a692f $ git log af9e87b8c..bf3dbb4a6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5c59e5cc263d132e2431ec05da2f66bfdfaa0086 Reviewed-on: https://chromium-review.googlesource.com/966593Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543757}
-
chaopeng authored
This issue is caused by we create vertical overlay scrollbar for <select> but not call ShowOverlayScrollbar since it does not need it. But we set the scrollbars hidden to false in ScrollableArea ctor which is not correct for overlay scrollbars. Overlay scrollbars (include Android, Aura, Mac) are hidden when creation. In this patch, we set scrollbars_hidden_if_overlay_ true in ScrollableArea ctor. It would not affect to non overlay scrollbars since we check for UsesOverlayScrollbars() before read scrollbars_hidden_if_overlay_. This patch also rename scrollbars_hidden_ to scrollbars_hidden_if_overlay_. Bug: 816714 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5256fb99750cd3e7b7081231eada87572817bfe3 Reviewed-on: https://chromium-review.googlesource.com/957480 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#543756}
-
Brian White authored
This reverts commit f17d7a0c. Reason for revert the revert: revert did not fix problem so re-landing Original change's description: > Revert "media: Use BindOnce everywhere in GMBVFP." > > This reverts commit f35e389b. > > Reason for revert: This CL is suspicious in Android WebKit test failures: > > The first failure: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/75367 > > Error message: > virtual/media-gpu-accelerated/external/wpt/media-source/mediasource-config-change-mp4-av-framesize.html failed unexpectedly (gpu crashed) > > Error log: > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F75367%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout > > Original change's description: > > media: Use BindOnce everywhere in GMBVFP. > > > > Changes the use of Bind and Closure to BindOnce and OnceClosure in > > GpuMemoryBufferVideoFramePool. > > > > It additionally introduces a trampoline in MailboxHoldersReleased so > > that if the callback is called on media_thread it can skip going trough > > the message loop. > > Previous the callback would be bound to the media_thread loop. > > > > Two DCHECKs have also be added to check thread expectations. > > > > Change-Id: Ie704f6f6bdc4b7d9b8dd0f5ffec4675cd060d5e2 > > Reviewed-on: https://chromium-review.googlesource.com/959382 > > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543609} > > TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org > > Change-Id: I600ddbf046ad44d4d80bf93ea81543e29dd8d46b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/966321 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543667} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,dvadym@chromium.org Change-Id: I0293daf17496e6eeeb132c74fcd74fda97a38203 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/966688Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#543755}
-
Michael Giuffrida authored
Crash intentionally, e.g. to test out the crash reporter. Example: $ ./out/rel/app_shell --crash_test --enable-reporting DevTools listening on ws://127.0.0.1:37703/devtools/browser/ef324347-b8b4-4660-9270-aca50d1fb9d8 Redirecting output to ‘wget-log’. Crash dump id: d920a038bd86b598 zsh: illegal hardware instruction ./out/rel/app_shell Bug: None Change-Id: I3f69080f19a81b2661cce4b7ee867378ea166b13 Reviewed-on: https://chromium-review.googlesource.com/966545Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543754}
-
David Black authored
Bug: b:75033730 Change-Id: I164d8798d4587a816cb11ccecb6027a2b8eec695 Reviewed-on: https://chromium-review.googlesource.com/964615 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543753}
-
Steven Bennetts authored
Bug: none Change-Id: I23f0200f68aae38baeccb266b20fffe604128651 Reviewed-on: https://chromium-review.googlesource.com/965622Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543752}
-
Mark Cogan authored
Bug: 804552 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I183368403e1977c28dd0696532feff849fcbf0df Reviewed-on: https://chromium-review.googlesource.com/966625 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543751}
-
Maks Orlovich authored
... Since there is no longer need for it to implement HttpUserAgentSettings anymore, just to provide some functions related to the language pref. Change-Id: I5afffca7f918e395df874ebddbffa970f2320d5f Reviewed-on: https://chromium-review.googlesource.com/965936 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543750}
-
Jeremy Roman authored
Just a simplification. Change-Id: I5aea1364540c0ab7b9266dca03884b079468e574 Reviewed-on: https://chromium-review.googlesource.com/964393 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543749}
-
James Cook authored
ShelfController outlives TabletModeController. However, it looks like Shell destruction can trigger display layout changes, which are observed by ShelfController. These may be dependent on screen rotation animation state, and hence are hard to repro. Add a null check to avoid the crash, since this is simple and safe to backport. A followup CL will clean up the shutdown ordering. Bug: 817522 Change-Id: I7d02faf6179768457e56dff8bfdf2a74c8701b4c Reviewed-on: https://chromium-review.googlesource.com/966785Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/5ae6ee457860..6f5444da73ae $ git log 5ae6ee457..6f5444da7 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 jmadill Remove HasIndexRange. 2018-03-15 jiawei.shao Clean up link validations on interface blocks Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie5e9f7232d7061a7e5f623c379ae303ead5893ef Reviewed-on: https://chromium-review.googlesource.com/966592 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543747}
-
Tommy Steimel authored
This CL removes the code that created the current time scrubbing popup in the modern media controls. It also changes the CSS to show the button panel during scrubbing. Bug: 817591, 816442 Change-Id: I8ad2bd5a634f0706884ca6648a36f506af620c23 Reviewed-on: https://chromium-review.googlesource.com/964904Reviewed-by:
-
Hans Wennborg authored
Clang r326867 turned on SafeStack when targeting Fuchsia by default. Turn it off in our build config until all the tests pass. Bug: 817298, 821951 Change-Id: Id2d9f911eb62fe6823365baeba55a4ccc0b484ce Reviewed-on: https://chromium-review.googlesource.com/959003Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543745}
-
https://skia.googlesource.com/skia.git/+log/6e9a4f6327d1..8b858526faf4 $ git log 6e9a4f632..8b858526f --date=short --no-merges --format='%ad %ae %s' 2018-03-16 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5ae6ee457..1c08cbb39 (1 commit) 2018-03-16 reed fix nextContour bug 2018-03-16 egdaniel Fix Vulkan Copy as draw shader 2018-03-16 robertphillips Prevent crash when flushing while DDL recording 2018-03-15 brianosman Support GL_OES_EGL_image_external on newer GLSL without essl3 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I483b6a2403c5cef903b5bed56d30fdea2988c21e Reviewed-on: https://chromium-review.googlesource.com/966586 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543744}
-
Helen Li authored
This test is flaky because the test closes client connection during each for-loop iteration. When server checks whether the connection is still connected using accepted_socket_->GetPeerAddress() in network::TCPServerSocket::OnAcceptCompleted(), it will get net::ERR_SOCKET_NOT_CONNECTED (-15). This test keeps the client sockets alive and delay disconnecting them until server finishes all Accept() callbacks. Bug: 821224 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7bf12704272f9ccc23c085c6d72db28a3d0dbe67 Reviewed-on: https://chromium-review.googlesource.com/966802Reviewed-by:
-
Xing Liu authored
Disable ParallelDownloadTest.ResumptionLastSliceFinished because it's flaky on ChromeOS. TBR=dtrainor@chromium.org, qinmin@chromium.org Bug: 822450 Change-Id: I90d737a8397a453af90288d05c7dc6bd8eefe23f Reviewed-on: https://chromium-review.googlesource.com/965569Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543742}
-
Ramin Halavati authored
This reverts commit 5bea452c. Reason for revert: This CL was for collecting debug data on FYI bot. Data is now collected. Original change's description: > Add debug data for Traffic Annotation FYI bot. > > Traffic annotations FYI bot cannot access some files in build_path/gen. > Some Debug data is added to find out why? > > TBR=msramek > > Bug: 690323 > Change-Id: I4fb716d8b843704bf48cfbb62d5b09a3791eb732 > Reviewed-on: https://chromium-review.googlesource.com/966303 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543702} TBR=msramek@chromium.org,rhalavati@chromium.org Change-Id: Ia3c53a938c1f19122e4b82ca77b357502feaeb89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 690323 Reviewed-on: https://chromium-review.googlesource.com/966762Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543741}
-
Jeremy Roman authored
A context was erroneously passed where an isolate is now expected. Introduced in: https://chromium.googlesource.com/chromium/src/+/eb8a2f1758cf71197e44bdbd79e59105ad845b51 Change-Id: I1b69c4533c7f607e6813c532eae78a2a0c7d50ca Reviewed-on: https://chromium-review.googlesource.com/964390Reviewed-by:
-
