- 24 Mar, 2020 12 commits
-
-
chrome://*Mason Freed authored
Prior to this CL, if chrome://* URLs used deprecated Web Components v0 features, they were neither reported as warnings, nor counted as uses of those features. With this change, the warnings will now be shown, but the use counters will still not be incremented. Bug: 1057337 Change-Id: If3f631b01a205e2249421e809537da7ed5691df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113790 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752659}
-
Nicholas Verne authored
The original implementation ended the Crostini Upgrade by displaying a Terminal connected to the upgraded Crostini container. This is not wanted when the user has canceled the upgrade. Bug: 1060770 Change-Id: If27c8dd90657eac76c3478b1c57351fadfba00e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109571Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#752658}
-
bttk authored
Bug: 1063948 Change-Id: Id9d88a8a860e19f9f9fe32eae6ce69aae8b49929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107427Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#752657}
-
nancy authored
Modify app_it to use the shelf id, not the ARC shelf id, when the task is created, to align with other cases. Modify app id to get the correct app_id from ARC sheld id for ARC shortcut in AppServiceAppWindowLauncherController. BUG=1063386 Change-Id: I97b5d50c205ff2d1a0351f95730d244867569f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114474Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752656}
-
Peter Kasting authored
If permission is denied to call an extension function, the function is currently destroyed without responding. This causes a DCHECK failure in its destructor. Instead, ask the function to respond with an error in this case, which makes did_respond() return true, which avoids the DCHECK. This showed up during some trybot runs of an unrelated change, so this fixes some test flakiness. Bug: none Change-Id: I6cc5481157161b00a493504b6a403c0e492bef09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116537 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#752655}
-
Katie D authored
When a page is detected as DANGEROUS, dom_distiller does not send positive distillability results even if pages are technically distillable. Bug: 1061055 Change-Id: I12e902173770ff5335f85d4e794afb3508dae04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111075 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752654}
-
Karandeep Bhatia authored
The class ReindexHelper manages its own lifetime and dispatches tasks to reindex rulesets. However these tasks can return synchronously. This can cause |callback_count_| to become 0 in ReindexHelper::OnReindexCompleted, causing ReindexHelper to be freed. We might still be in the loop which dispatches reindexing tasks in ReindexHelper::Start, leading to a use after free. In debug builds, this should cause a DCHECK in OnReindexCompleted. Fix this by using ref counting for ReindexHelper ownership. Also use a BarrierClosure since it simplifies the code. BUG=1063177 Change-Id: I0a56e33a508e44b7fe465f148c05f048e9b05deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111393 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752653}
-
Chris Lu authored
If ShouldScopeFullscreenControllerToBrowser is true, then FullscreenController is being scoped to a Browser, so retrieve it from the Browser object. Bug: 790886 Change-Id: I28e6e99e7e263e4057b2939f47a8d8f9a2d5bf99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108083 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#752652}
-
Maggie Cai authored
This CL adds one unit test to test when there is overlap of intent filter stored in the preferred app. BUG=853604 Change-Id: Icb1e27f03445243940865627830ef98381dd0cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109390Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#752651}
-
Jesse McKenna authored
This change adds histogram suffixes PageLoad.PaintTiming.NavigationToFirstContentfulPaint.OnBattery and PageLoad.PaintTiming.NavigationToFirstContentfulPaint.NotOnBattery, which will allow the filtering of FirstContentfulPaint measurements by whether the system was on battery or wall power during page load. This will be useful for filtering FirstContentfulPaint regressions by battery-specific Finch experiments (e.g., SlowDCTimerInterruptsWin, which slows the system timer-interrupt frequency only when on battery power). Filtering will provide a more accurate view of the impact of such experiments on their affected clients. Bug: 1040724 Change-Id: Ia0845f731c1281bdb508e2360bc393ad33f28095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025491Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#752650}
-
Julie Jeongeun Kim authored
This is a follow-up cl of https://crrev.com/c/2103997. It should not have CHECK with the return value from GetOrCreateAtkObject() since it could return nullptr. Bug: 1061429 Change-Id: I5258ddfa5cb61a350c20886644804daad9a6dd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114601 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#752649}
-
Ahmed Mehfooz authored
This CL makes sure the control buttons view in arc notifications is not set to visible when the message center is collapsed. Also fixes GetLastFocusableChild to account for arc notifications. Bug: 1057988 Change-Id: If4e9988e7362783f4e0331b7bf8cb3c2fe2ce447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114166Reviewed-by:
-
- 23 Mar, 2020 28 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10d9c49f23c8..ae3586b5380f git log 10d9c49f23c8..ae3586b5380f --date=short --first-parent --format='%ad %ae %s' 2020-03-23 ehmaldonado@google.com depot_tools: Use gclient_utils.AskForData instead of raw_input. Created with: gclient setdep -r src/third_party/depot_tools@ae3586b5380f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063976 Tbr: agable@chromium.org Change-Id: I4b99b3fbcca4555fc01c9f28c2100a0913d62195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752647}
-
Jeremy Roman authored
Since https://codereview.chromium.org/1677303002, there is only one table that is ever searched, so we can unconditionally use that table and inline assumptions about it, like that the string is never actually null. The std::map is a premature optimization and is almost certainly now a pessimization in practice: linear scans of 16 entries are very cheap and as a bonus are thread-safe and easy to reason about. If better performance were needed, we could sort kPersistingImages by IDR but this too seems like a premature optimization as long as it remains relatively small. Change-Id: I0f9bbb2c6357b650903538235eb5f5112709c958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098850 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752646}
-
Lijin Shen authored
testTopToolbar_WithGTS_WithBottomToolbar_New_Tab_Search_Share failing on 2 stable builder(s): android-arm-stable-tests and android-arm64-stable-tests. Since this variation has benn ramped down, the test can be disabled. Bug: 1062634 Change-Id: If7e3d52cd3b6fd23214b02eb2479bbeaa48e7695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115765Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#752645}
-
Garrett Beaty authored
The recipes code has been updated so that we don't attempt to trigger these jobs, so they are no longer necessary. Bug: 819899 Change-Id: Ife039539bffb0c3fadacdb383c1be014f19ad6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115874Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#752644}
-
Caleb Rouleau authored
GitHub mirror is not being used anymore, so better to use the main source for the docs link. Bug: 1059913w Change-Id: Iab2d7e1eb180a6a79e4487e827e6e1f97edb1edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116785 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752643}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib39c23df559079bb38d410f56fb9afdbaf35ea15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117073Reviewed-by:
-
Salvador Guerrero authored
This reverts commit 1231840e. Reason for revert: Causing build failures in android-internal-chromium-tot https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot Original change's description: > metrics: Remove CachedMetrics > > Bug: 1048429 > Change-Id: Ib5b5ee1d07492eb30b754320f6527acd5cda60f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079255 > Commit-Queue: bttk <bttk@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752614} TBR=yfriedman@chromium.org,fgorski@chromium.org,pavely@chromium.org,bttk@chromium.org Change-Id: I3af9a0200e42e332c647ccb3d73f2cd756b0dc04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117153Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#752641}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/0be7fce4c6e4..84639a15fe70 $ git log 0be7fce4c..84639a15f --date=short --no-merges --format='%ad %ae %s' 2020-03-23 bnc Add QuicSpdySession::EnableServerPush(). Re-enable QuicSimpleServerSessionServerPushTests. 2020-03-21 fayang gfe-relnote: In QUIC, add a helper function to get N consecutive retransmission timeout delay. Only affecting client, no functional change expected, not protected. 2020-03-20 bnc gfe-relnote: Add and call Http3DebugVisitor methods. Not protected. 2020-03-20 danzh gfe-relnote: n/a(test only) Nice mock send algorithm to reduce GMOCK WARNING. 2020-03-20 wub Enable //gfe/gfe2/quic:quic_backend_connection_test in gfe_cb_feature_flags. 2020-03-20 wub Internal QUICHE change 2020-03-20 fayang gfe-relnote: In QUIC, send H3 SETTINGs once 1-RTT write key is available (instead of both keys are available). Protected by gfe2_restart_flag_quic_send_settings_on_write_key_available. 2020-03-20 renjietang Simplify QuicUtils::GetMaxStreamCount() because it's never used in gQUIC. 2020-03-19 fayang gfe-relnote: Stop using SetDefaultEncryptionLevel in TLS handshake. Instead, use OnOneRttKeysAvailable. Refactor only, no functional change expected, not protected. 2020-03-19 renjietang Update QuicFramer methods' names to match IETF draft specs. Also removed unused peer methods. 2020-03-19 quiche-dev Change QuartcPeerTest to use a MockSendAlgorithm. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I69d2d1301aeb2dd1c4c34bec5f758aa1a735d2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115781 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#752640}
-
Archana Simha authored
Collects the size of the leaked ExtensionFunctions as well as the name and count of the ExtensionFunction with the most instances at the time of the dump. Change-Id: Ic52f79e2b002be8577f46d7e611c223577eae2c4 Bug: 893656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985816Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#752639}
-
Haiyang Pan authored
Bug: 1054829 Change-Id: I9a9113dff3932e9cc0f54604a9ca207254111d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116835Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#752638}
-
Avi Drissman authored
Each SxS-capable Chrome channel can have a different brand code, so update the Keystone glue to know that. This can be tricky because the old, non-SxS-capable Chromes are still built from this code, so be sure to handle that case. Overview plan at https://docs.google.com/document/d/1MVANxDLPPeN1x-NsfgsLSjbX8twzQi69Wb1iPK-owaU/edit Bug: 1061486 Change-Id: I2cbc2d6ba698b085ee00536a1fbfffa3336ddecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102642 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752637}
-
Yue Zhang authored
http://crrev.com/c/2110684 makes TabSelectionEditor adapt to different layouts of tab switcher. However, for carousel tab switcher we might still want the selection editor to follow a grid style. This CL fixes this issue by adding one extra check. Bug: 1063746 Change-Id: I5c0a2379d985acec8794b9a2a93758bd33e664f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116771Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG=1027549,1062563 Change-Id: I1f950aa62f091776595be7234c7a92ac6b1b2c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116135 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752635}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3e74fb81116b..cd1f1eb24f50 git log 3e74fb81116b..cd1f1eb24f50 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 thestig@chromium.org Fix JPEG2000 decoding when there is no /ColorSpace. 2020-03-23 thestig@chromium.org Use GetDecoderArray() in CPDF_DIB. 2020-03-23 thestig@chromium.org Make CPDF_DIB::ValidateDictParam() more consistent. 2020-03-23 thestig@chromium.org Treat no filters as an empty array in GetDecoderArray(). 2020-03-23 thestig@chromium.org Fix more nits in GetDecoderArray(). 2020-03-23 thestig@chromium.org Add unit tests for GetDecoderArray(). 2020-03-23 tsepez@chromium.org Test extracting values from variables contexts. 2020-03-23 tsepez@chromium.org Cover special |xfa| propname in CFXJSE_Engine::NormalPropertyGetter() 2020-03-23 thestig@chromium.org Move FlateDecode/Encode tests to fpdf_parser_decode_unittest.cpp. 2020-03-23 thestig@chromium.org Fix nits with GetDecoderArray(). Created with: gclient setdep -r src/third_party/pdfium@cd1f1eb24f50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I5e48a83c586a63762e7e87b1df9ffe589df893f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116705Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7eab0a820f9c..f1df04b094fe git log 7eab0a820f9c..f1df04b094fe --date=short --first-parent --format='%ad %ae %s' 2020-03-23 mbonadei@webrtc.org Fix -Wunreachable-code on Linux. 2020-03-23 sprang@webrtc.org Remove RtpPacketSendInfo.has_rtp_sequence_number Created with: gclient setdep -r src/third_party/webrtc@f1df04b094fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie17989ac9f6dc16d4e7a16eba2a22155b75cd32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116704Reviewed-by:
-
Robert Liao authored
PrintableSkColor transforms the test error output from... original Which is: 4293454573 to original Which is: SkColorARGB(0xff, 0xe8, 0xea, 0xed) Because SkColor is type aliased to uint32_t, a simple overload of operator<< will not pick it up, requiring a type container to trigger the overload. BUG= Change-Id: I56217ca8e166441f7fca0a257b7f5591469729d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116894 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by: -
Ahmed authored
BUG=1064104 TEST=Manually. Change-Id: Ifbdd85d252a4cf5d13a43d6e3e566be8c0f3fa06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116784Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#752631}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cde8177699c..82dd375715f3 git log 4cde8177699c..82dd375715f3 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 primiano@google.com Fix Chromium roll Win+Fuchsia 2020-03-23 fmayer@google.com Merge "Ingest location for dex / apk / jar for classes." 2020-03-23 treehugger-gerrit@google.com Merge "subprocess: Fix unused result warning in unit test" 2020-03-23 treehugger-gerrit@google.com Merge "Add /proc/<pid>/smaps parser." 2020-03-23 taylori@google.com Merge "perfetto-ui: Always show CPU slice" 2020-03-23 taylori@google.com Merge "perfetto-ui: Fix record page scrolling" 2020-03-23 lalitm@google.com Merge "perfetto: add script to strip binary in Android tree" 2020-03-22 taylori@google.com Merge "perfetto-ui: Fix file bug link" 2020-03-20 lalitm@google.com tp: allow semi-colon to delimit queries in query files 2020-03-20 skyostil@google.com Merge "TrackEvent: Add more documentation for app instrumentation" 2020-03-19 primiano@google.com Fix Win+Nacl builds 2020-03-19 primiano@google.com Merge "test: fix GetCurExecutableDir() on Mac" 2020-03-18 taylori@google.com Merge "ui: Fix showing details for slices where ts = 0" 2020-03-18 primiano@google.com Merge changes Ibc7838ee,I3deb0245 2020-03-18 rsavitski@google.com Merge "traced_perf: metatrace: encode PID that is being unwound as a "counter"" 2020-03-18 rsavitski@google.com Merge "traced_perf: fix unnecessarily retained heap allocations" Created with: gclient setdep -r src/third_party/perfetto@82dd375715f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:151968761 Tbr: perfetto-bugs@google.com Change-Id: I4771efc6769de4caa1934a45b93f6025eb815bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116702Reviewed-by:
-
David Tseng authored
- initial bindings ExpectSpeech, Call added to SpeechMonitor - convert a few tests; see how it goes on bots before converting more Test: browser_tests --gtest_filter=*Spoken*.* Change-Id: I17fa771d7a7f6bc32cd7d7d85bdf40ae77a72f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115877Reviewed-by:
-
Moe Ahmadi authored
This CL introduces a feature flag (enabled by default) that allows disabling the Doodle notifier spinner in order to study its performance drawback on an official build. This CL may be reverted at a later time once the performance analysis is done. Bug: 1046786 Change-Id: I078f265bc30a32ae5b5bae173955107d42676773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116558Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#752628}
-
Maria Villarreal authored
This follows the guidance given in the comments of the bug to eliminate the use of hardcoded SkColorSet* in ui/. Part 1 cleans colors in combobox, bubble_frame_view, canvas_paint_mac, touch_selection_menu_views, message_view, image_skia_operations, clipboard_win, tween, dialog_example. Bug: 1056950 Change-Id: Iceb8e431b0b6346136eaa6b57537e3f6000c0ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108573 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Tricia Crichton authored
Verify that a colon exists before attempting to substring based on the position of the colon. Bug: chromedriver:3234 Change-Id: Iafb4ed1bf928fcebf28e0a430bc0bc1f7ceb7185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111051Reviewed-by:
-
Jesse Schettler authored
Initial user feedback is still being gathered for ARC printing. Extend the flag's expiry milestone to M84 to allow the feature to be toggled on and off in M83. Bug: b:152244509 Change-Id: I90c36a596220d47adae4e512dde32899f905160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116933Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#752625}
-
Ryan Hansberry authored
NetworkStateHandler has never been meant to honor calls to its RequestUpdateForNetwork() method for Tether networks (as per its documentation) but never explicitly enforced that. A recent CL, crrev.com/c/2078372, exposed this oversight by calling RequestUpdateForNetwork() on a Tether network, causing a crash. This CL corrects that oversight by early-returning within RequestUpdateForNetwork() if a Tether network is provided. Bug: 1061780 Change-Id: Iea2ab7d73c4417408ccb1b5e7622dd87a7dcd71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111352 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752624}
-
Wei-Yin Chen (陳威尹) authored
Make sure all TabToGTSAnimation annotations in StartSurfaceLayoutTest are correct. Bug: 964406 Change-Id: I437040b668b1e9a397c90863d9142dadc2c0eabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114209Reviewed-by:
-
garzonou authored
Change-Id: I4cb1539a93be286bdaaef436d94da036d5aa86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011629 Commit-Queue: Jiajun Ou <garzonou@google.com> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752622}
-
Jared Saul authored
Also cleans up the fieldtrial_testing_config entry for the SyncButterWallet launch now that it's enabled ToT (and 100% launched). Per request, not going to clean up the code usage of the flag quite yet because Butter for Mobile may be coming in the near future. Bug: 983940 Change-Id: Icfb628cb509c77960d7686c3ad8c5a6161ca7547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092064 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#752621}
-
Lan Wei authored
To simplify the use of the scroll function, we can use the smoothScroll function in gesture-util.js instead of chrome.gpuBenchmarking.smoothScrollBy in all the layout tests. Bug: 1047176 Change-Id: I6764bd72e42d54a2623b453a808061f96d045687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115798Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#752620}
-
