- 21 May, 2015 38 commits
-
-
xiyuan authored
- Return canonicalized email from GetUserEmail because sign-in manager gives back the Gaia email which is not necessarily the same as the one used on the login screen; - Sign-in manager gives empty user email when underlying refresh token is revoked. Bail out in this case. BUG=489890 Review URL: https://codereview.chromium.org/1149873003 Cr-Commit-Position: refs/heads/master@{#330890}
-
nhiroki authored
BUG=489636 TEST=n/a Review URL: https://codereview.chromium.org/1142873004 Cr-Commit-Position: refs/heads/master@{#330889}
-
agrieve authored
Having load_library_from_zip_file end with "_file" causes a GYP exception when the value is overriden. BUG=488135 Review URL: https://codereview.chromium.org/1142353003 Cr-Commit-Position: refs/heads/master@{#330888}
-
tengs authored
BUG=420315 TEST=unit test Committed: https://crrev.com/27e044cfc5c2a43b6c575508aca64763bfa2deba Cr-Commit-Position: refs/heads/master@{#330713} Review URL: https://codereview.chromium.org/1147563002 Cr-Commit-Position: refs/heads/master@{#330887}
-
groby authored
Replacing "he/she" with "they". BUG=none R=dbeam@chromium.org Review URL: https://codereview.chromium.org/1145373002 Cr-Commit-Position: refs/heads/master@{#330886}
-
jdonnelly authored
See https://codereview.chromium.org/1058473002/ for background. BUG=484806 Review URL: https://codereview.chromium.org/1148123003 Cr-Commit-Position: refs/heads/master@{#330885}
-
yzshen authored
This CL adds WebSocket support and correspnoding tests. BUG=478249 TEST=Newly added tests. Review URL: https://codereview.chromium.org/1144843002 Cr-Commit-Position: refs/heads/master@{#330884}
-
ortuno authored
Now connectGATT connects to the BLE device. This is the first step towards fully implementing connectGATT. Also adds BluetoothMsg_ConnectGATTError. Layout tests are in: http://crrev.com/1150523004 BUG=421668 Review URL: https://codereview.chromium.org/1120373004 Cr-Commit-Position: refs/heads/master@{#330883}
-
rsleevi authored
Make it easier to create der::Input's from constants by the magical power of Templates. Old and busted: der::Input foo(kFoo, arraysize(kFoo)); New hotness: der::Input foo(kFoo); BUG=none R=mattm@chromium.org Review URL: https://codereview.chromium.org/1146283004 Cr-Commit-Position: refs/heads/master@{#330882}
-
amistry authored
And change the task manager to use it. Review URL: https://codereview.chromium.org/1137803005 Cr-Commit-Position: refs/heads/master@{#330881}
-
Bo Liu authored
This fixes a DCHECK after https://codereview.chromium.org/1149803002. Trybots didn't catch this because android trybots do not have DCHECKs turned on. BUG=484934 TBR=sievers@chromium.org Review URL: https://codereview.chromium.org/1147143003 Cr-Commit-Position: refs/heads/master@{#330880}
-
John Abd-El-Malek authored
Review URL: https://codereview.chromium.org/1151733003 Cr-Commit-Position: refs/heads/master@{#330879}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#330878}
-
Newton Allen authored
This adds plenty of Android-specific code (Java, C++, and resources) in a few new folders: - chrome/android/java_staging: will be merged into chrome/android/java in the nearish future - chrome/android/javatests: chrome/android/javatests_shell will be merged into here incrementally as ChromeShell tests are converted to run against ChromePublic - chrome/test/android/javatests_staging: will be merged into chrome/test/android/javatests in the nearish future There are two important new build targets: chrome_public_apk and chrome_public_test_apk. chrome_public_apk is similar to chrome_shell_apk, but with even more features. Expected effect on bot times: The new tests take about 5 minutes to run. Initially they'll be enabled on an FYI bot, but will soon be moved to the CQ and main bots. BUG=484934 R=cjhopman@chromium.org, jianli@chromium.org, maruel@chromium.org, mnaganov@chromium.org, sclittle@chromium.org, tedchoc@chromium.org, yfriedman@chromium.org Review URL: https://codereview.chromium.org/1141283003 Cr-Commit-Position: refs/heads/master@{#330877}
-
dbeam authored
Revert of NTP Zombie Code Slayer Part IV: Most Visited (patchset #6 id:100001 of https://codereview.chromium.org/1129903008/) Reason for revert: Duplicate pref registration on Android somehow. Original issue's description: > NTP Zombie Code Slayer Part IV: Most Visited > > This is where things get complicated. > > NTP4 had a most visited pane. It showed your top sites. > So does the current NTP; so I'm trying to remove everything > that deals with most visited tiles on NTP4 without accidentally > breaking the same named thing on the current NTP. > > Here's what used to exist that I'm trying to remove: > http://bostandjiev.com/Content/Google/chrome.jpg > > Here's what currently exists that I'm trying not to break: > http://cdn.ghacks.net/wp-content/uploads/2013/04/chrome-new-tab-page.jpg > > BUG=329637 > > Committed: https://crrev.com/1fc345cd960f7efd4e6b07d1f050615239d82d60 > Cr-Commit-Position: refs/heads/master@{#330845} TBR=samarth@chromium.org,rdevlin.cronin@chromium.org,sky@chromium.org,xiyuan@chromium.org,gab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=329637 Review URL: https://codereview.chromium.org/1151563005 Cr-Commit-Position: refs/heads/master@{#330876}
-
sergeyu authored
Moved flags initialization from FakePortAllocatorSession into FakePortAllocator, so that they are passed to the PortAllocatorSession ctor rather than being set via set_flags() in the FakePortAllocatorSession ctor. This is required because some flags (specifically PORTALLOCATOR_ENABLE_SHARED_UFRAG) are ignored if applied to PortAllocatorSession via set_flags(). Review URL: https://codereview.chromium.org/1143893002 Cr-Commit-Position: refs/heads/master@{#330875}
-
chrome://appschrome://historydbeam authored
NTPLoginHandler was originally used to handle login from the NTP. It now handles login on chrome://apps and chrome://history and employs a dirty little hack to be re-used. Undo that hack (exposing of ntp.updateLogin on chrome://history) and split the handler logically, slimming the history handler (which runs on mobile). R=mad@chromium.org BUG=329637 Review URL: https://codereview.chromium.org/1143963002 Cr-Commit-Position: refs/heads/master@{#330874}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/a7b3901..07b5cd0 TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org Review URL: https://codereview.chromium.org/1143253006 Cr-Commit-Position: refs/heads/master@{#330873}
-
apacible authored
Review URL: https://codereview.chromium.org/1149763003 Cr-Commit-Position: refs/heads/master@{#330872}
-
groby authored
Replacing the unwieldy "he/she" with "they". TBR=brettw@chromium.org BUG=none Review URL: https://codereview.chromium.org/1144413002 Cr-Commit-Position: refs/heads/master@{#330871}
-
reillyg authored
Log platform errors so that it is possible to determine from logs what caused the chrome.serial API to return the generic "system_error" message. Review URL: https://codereview.chromium.org/1147223002 Cr-Commit-Position: refs/heads/master@{#330870}
-
Newton Allen authored
These two methods were being obfuscated or removed by proguard, which cause the release build to fail for chrome_public_test_apk. BUG=484934 R=pvalenzuela@chromium.org Review URL: https://codereview.chromium.org/1150853003 Cr-Commit-Position: refs/heads/master@{#330869}
-
rsleevi authored
Update the set of known roots for Windows and Mac. This affects the |is_issued_by_known_roots| check on these platforms, which controls things such as the enforcement of Baseline Requirements. BUG=481573 R=davidben@chromium.org Review URL: https://codereview.chromium.org/1141173003 Cr-Commit-Position: refs/heads/master@{#330868}
-
isherman authored
Stop calling BluetoothAdapter::IsDiscoverable() on non-ChromeOS platforms, as this method is only implemented on ChromeOS, and the feature code that was calling it currently only runs on ChromeOS. BUG=488263 TEST=none R=tengs@chromium.org Review URL: https://codereview.chromium.org/1148713002 Cr-Commit-Position: refs/heads/master@{#330867}
-
sgurun authored
BUG=490440 This test started failing consistently, and I could not find the reason. Since it was already disabled on win platforms, now I am disabling completely. TBR=miket@chromium.org Review URL: https://codereview.chromium.org/1144083003 Cr-Commit-Position: refs/heads/master@{#330866}
-
dpranke authored
List of changes: https://chromium.googlesource.com/chromium/buildtools/+log/b73e5f70d7ac..dc487f429cb9 commit dc487f429cb90cac92ec7a9cd9d49db13648064d Author: Dirk Pranke <dpranke@chromium.org> Date: Wed May 20 14:44:08 2015 -0700 Roll GN 329298:330790 (c947c407..9d04333f) List of changes in tools/gn: https://chromium.googlesource.com/chromium/src/+log/c947c40710fe..9d04333fe102/tools/gn This roll mostly pulls in two new GN features: 1) a new 'gn path' command for finding the dependencies linking two targets 2) the 'runtime_deps' option to 'gn desc', which will compute the list of files needed to for a target to run based on the dependencies and data files listed on the targets. If --runtime-deps-list-file is specified when 'gn gen' is run, GN will also write out the dependencies for the targets listed in the file to $target.runtime_deps files. TBR=brettw@chromium.org BUG=480053 R=brettw@chromium.org BUG=480053 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel Review URL: https://codereview.chromium.org/1148283002 Cr-Commit-Position: refs/heads/master@{#330865}
-
jam authored
Previously we were doing them inside html_viewer because NavigatorHost was throwing out that extra data before it got to the network service. The fix is to pass through this url request information. Also: -add support for netlog to make debugging network issues easier. Use --log-net-log=file_path -ensure that mojo shell uses the same user agent as html_viewer. since this UA is sent to websites, they need to match or else there are bugs with Gmail (since it sees different UAs when logging in) BUG=481153 Review URL: https://codereview.chromium.org/1121783003 Cr-Commit-Position: refs/heads/master@{#330864}
-
cernekee authored
We'll add an upstart job on the Chrome OS side to log whether the failure is seen on each boot. BUG=458878 R=jrbarnette@chromium.org,vapier@chromium.org,semenzato@chromium.org,olofj@chromium.org,ejcaruso@chromium.org,isherman@chromium.org Signed-off-by:
Kevin Cernekee <cernekee@chromium.org> Review URL: https://codereview.chromium.org/1133493008 Cr-Commit-Position: refs/heads/master@{#330863}
-
dpranke authored
This adds the tests on the GN bots that are currently configured recipe-side in the chromium_gn recipe to //testing/scripts, so that they can be configured repo-side and we will need to modify the recipe less often. R=phajdan.jr@chromium.org BUG=481693 Review URL: https://codereview.chromium.org/1145513005 Cr-Commit-Position: refs/heads/master@{#330862}
-
qinmin authored
user-agent may not present in URlRequest->extra_request_headers() if the field is not overriden. In this case, we should pass browser's UA to the android download manager. We have done something similar in MediaPlayerBridge too. BUG=488444 Review URL: https://codereview.chromium.org/1145303004 Cr-Commit-Position: refs/heads/master@{#330861}
-
danakj authored
Single-thread compositing is only used in layout tests which also wants synchronous compositing. So remove the optionality of synchronous single-thread in the renderer and just always use the two together when the thread is disabled there. Also move the decision to use zero copy in synchronous single threaded mode out to the browser process and just DCHECK it in cc, so that the browser can make decisions based on using zero or one copy authoritively. R=enne BUG=489447 Review URL: https://codereview.chromium.org/1149803002 Cr-Commit-Position: refs/heads/master@{#330860}
-
tsergeant authored
This icon now matches the icon in the omnibox, making it easier to understand where the downgraded security status has come from. BUG=413552 Review URL: https://codereview.chromium.org/1146903002 Cr-Commit-Position: refs/heads/master@{#330859}
-
oshima authored
BUG=None Review URL: https://codereview.chromium.org/1150723004 Cr-Commit-Position: refs/heads/master@{#330858}
-
estade authored
BUG=487866 Review URL: https://codereview.chromium.org/1137623006 Cr-Commit-Position: refs/heads/master@{#330857}
-
tombergan authored
BUG=474397 Review URL: https://codereview.chromium.org/1065763002 Cr-Commit-Position: refs/heads/master@{#330856}
-
ckehoe authored
BUG=489442 Review URL: https://codereview.chromium.org/1151603003 Cr-Commit-Position: refs/heads/master@{#330855}
-
sbc authored
Use subprocess.call() rather than Popen + communicate. The shell argument to Popen defaults to False so was redundant. Use any() rather than explicit loop. Review URL: https://codereview.chromium.org/1144383002 Cr-Commit-Position: refs/heads/master@{#330854}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/22483d9..f2539d5 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1149893002 Cr-Commit-Position: refs/heads/master@{#330853}
-
- 20 May, 2015 2 commits
-
-
rch authored
Review URL: https://codereview.chromium.org/1135833004 Cr-Commit-Position: refs/heads/master@{#330852}
-
szager authored
This reverts commit 0e80c361, which appears to be causing blink test failures. Example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/41877 TBR=hans@chromium.org,dpranke@chromium.org NOTRY=true NOPRESUBMIT=true BUG=483026 Review URL: https://codereview.chromium.org/1149913003 Cr-Commit-Position: refs/heads/master@{#330851}
-