- 15 Mar, 2012 40 commits
-
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/9703013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126860 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=chromium-os:16557 TEST=build success Review URL: http://codereview.chromium.org/9702005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126859 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
1) text in bubble should be black (title can stay blue) -> Made radio buttons and checkbox explicitly black. 2) fix alignment of radios/checkboxes (work w/ roma@) align checkbox to left of text (“S” in “Send” in title) -> Add local CheckboxNativeThemeBorder without left/right insets, removed padding column. 3) when you hit [Send] button -> change button text to “Sending...” (disable Send and Cancel button) button size should not change -> Set Sending... text in disabled Send button during animation. 4) then “Sent!” (disabled Send and Cancel buttons) (for a few seconds) then dismiss the bubble automatically ideally, we would add the error message to this bubble inline instead of showing a new bubble (not gating for launch) -> Set Sent/Error text in Send button; close after 3s (on success), add red error message on failure. BUG=102709 TEST=Updated bubble looks as prescribed. Review URL: https://chromiumcodereview.appspot.com/9702016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126858 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
The new interface is C-based so the CreateMemoryObject() callback now takes an int rather than a bool. I have opted to wrap content::MakeSharedMemorySegmentViaIPC() rather than change the types in the "content" tree: arguably NaCl's use of a C interface here should not spill over too far into Chromium's C++ code. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2651 TEST=nacl_integration Review URL: https://chromiumcodereview.appspot.com/9695062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126855 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
LoadURL and DidStartLoading. Failing test has no DidStartLoading (in RVHImpl) in failing test, so the request must be lost somewhere. This will tell us where the request gets lost. BUG=chromium-os:26646 TEST=none Review URL: https://chromiumcodereview.appspot.com/9709001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126854 0039d316-1c4b-4281-b951-d872f2087c98
-
falken@google.com authored
It seems it needed to be added to api_page_generator.js. Also, renamed experimental.fonts.json to experimental.fontSettings.json for consistency. BUG=114148 TEST=none Review URL: https://chromiumcodereview.appspot.com/9689054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126853 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Uploading counterpart of http://crrev.com/124146. Provide a method for the users of URLFetcher to obtain upload progress. Different from the download case, even the internals of URLFetcher (= URLRequest) doesn't provide callback mechanism for upload progress. So the current implementation runs a timer and poll the progress status. BUG=chromium-os:27370 TEST=content_unittests --gtest_filter='*URLFetcher*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126589 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=126611 (XP test bots hung at URLFetcher test) Review URL: https://chromiumcodereview.appspot.com/9618051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126850 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
easier to sort in about:net-internals, making the world a happier, fuzzier place. Also slightly simplifies the functions to add NetLog entries, and makes it impossible to create a BoundNetLog with both an invalid source and a non-NULL NetLog. BUG=116597 Review URL: https://chromiumcodereview.appspot.com/9585026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126849 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Exposed GetSecurityState and GetPageType to pyAuto. The GetSecurityState retrieves different security states for the current tab. The GetPageType returns the type of page showing (normal, interstitial, error). Added additional tests that uses the exposed hooks. - testSSLCertOK - testSSLCertIsExpiredAndCertNameMismatches - testSSLCertAuthorityOK TEST=none BUG=none Review URL: https://chromiumcodereview.appspot.com/9535022 TBR=dyu@chromium.org Review URL: https://chromiumcodereview.appspot.com/9705052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126848 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
BUG=none TEST=type that command. see tests run. Review URL: https://chromiumcodereview.appspot.com/9545019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126847 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
GDataOperationRegistry needs this information to provide user-friendly list of in-flight operations. BUG=chromium-os:27371 TEST=unit_test --gtest_filter='*GData*' Review URL: https://chromiumcodereview.appspot.com/9705048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126846 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9691033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126845 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
Currently InputMethodMenu continues to read/write the /home/chronos/Default/Preferences file, rather than /home/chronos/user/Preferences, even after sign in because InputMethodMenu gets a pointer to Profile by calling ProfileManager::GetDefaultProfile() *before* sign in. We have to do it after sign in since the GetDefaultProfile() function returns a different instance depending on the user is signed in or not. This is the same fix as http://crrev.com/125787 . BUG=118142 TEST=see the bug Review URL: https://chromiumcodereview.appspot.com/9651023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126844 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=118345 Review URL: https://chromiumcodereview.appspot.com/9702061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126843 0039d316-1c4b-4281-b951-d872f2087c98
-
kochi@google.com authored
This will properly disable "Disconnect my account..." button on ChromeOS. cr.isChromeOs (note the last small "s", not capital "S") returned "undefined" and thus "Disconnect..." button's hidden attribute was always false (i.e. visible on ChromeOS). BUG=116342 TEST=manually open chrome://settings with signed-in account and see "Disconnect your google account" button won't appear. Review URL: https://chromiumcodereview.appspot.com/9702051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126842 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Replace chrome/app/theme/mobile[_lit][_1_25x|2x].png files. Roma made these new images after UI review (3/13/12). I ran PNGCrush and PNGSlim (6,691 bytes -> 804 bytes). BUG=102709 TEST=New images shown Review URL: https://chromiumcodereview.appspot.com/9700052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126841 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Added the fields for the URL, the type of the operation, and the state of transfer (starting/in-progress/finished?). The actual data is not filled yet (it will come soon). BUG=chromium-os:27371 TEST=unit_tests --gtest_filter='*GData*' Review URL: https://chromiumcodereview.appspot.com/9702057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126840 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@google.com authored
Used TEST_P to parameterize SPDY/2 vs SPDY/3 versions so that spdy_framer_test and spdy_protocol_test are similar to the server code. BUG=117755 R=rch TEST=network unit tests Review URL: https://chromiumcodereview.appspot.com/9689078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126839 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@google.com authored
- Deleted the code that read and wrote the SpdySettings data from preferences. - Disabled the code that persisted the SpdySettings data. - Disabled the unit tests that tested persisting of SpdySettings. BUG=118148 R=willchan TEST=browser unit tests Review URL: https://chromiumcodereview.appspot.com/9703050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126838 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
TBR=jam@chromium.org BUG=115540 TEST=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9706050 TBR=zhaoqin@google.com Review URL: https://chromiumcodereview.appspot.com/9699064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126837 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Previously, if an identity preference for a server existed, such as those created by Safari, then the client certificate would not be checked to ensure it matched the server's CertificateRequest. As a result, it was possible to send a potentially invalid client certificate - and this would be the default client certificate presented to users. BUG=118306 TEST=See bug R=wtc@chromium.org Review URL: https://chromiumcodereview.appspot.com/9699058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126836 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Make the content::DOMStorageContext methods callable on the main thread and hide the threading details from the embedder. Review URL: https://chromiumcodereview.appspot.com/9704048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126835 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=satorux@chromium.org BUG=118336 TEST=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9699063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126834 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
NOTRY=true Review URL: http://codereview.chromium.org/9702030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126833 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
xp-release-dual-core: moz 3% virtual memory regression. http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=50&rev=126809&graph=vm_peak_r Started in 126412, when tcmalloc was updated to branch r144. BUG=118329 TBR=cmp Review URL: https://chromiumcodereview.appspot.com/9699062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126832 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@google.com authored
Bluetooth is to be enabled by default for R19, the UI already includes a separate "Enable bluetooth" checkbox that is connected to the radio power, so there is no need to leave the flag in place. BUG=chromium-os:23022,chromium:106446 TEST=verified bluetooth now enabled by default Change-Id: I0814b903d4764774cb63fb0b2c003ee0d5c9a49e Review URL: http://codereview.chromium.org/9702028 TBR=keybuk@chromium.org Review URL: https://chromiumcodereview.appspot.com/9701056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126831 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
mac-release-10.5: 100% vm size final memory increase for chrome processes (excluding browser) http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl2/report.html?history=300&rev=126775&graph=vm_size_final_r mac-release-10.5: 50% vm size final memory increase for chrome processes (including browser) http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl2/report.html?history=300&rev=126775&graph=vm_size_final_t seems to start in 124803, "Automatically start the GPU process 5s after browser startup." BUG=118321 TBR=cmp Review URL: https://chromiumcodereview.appspot.com/9705047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126830 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
Add BluetoothDevice::Disconnect and BluetoothDevice::Forget that both disconnect the application-level connections and low-level ACL, and in the latter case, deletes link keys and pairing information too. BUG=chromium-os:27765 TEST=verified on device change-Id: I5a2613b23fac6b7c68a8fcaaf4265cccda938328 Review URL: http://codereview.chromium.org/9701007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126827 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@google.com authored
Fixed by WK rollout + roll TBR=abarth BUG=118293 Review URL: https://chromiumcodereview.appspot.com/9699061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126826 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=jam@chromium.org BUG=118319 test=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9702060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126825 0039d316-1c4b-4281-b951-d872f2087c98
-
flackr@chromium.org authored
BUG=118070 TEST=None Review URL: http://codereview.chromium.org/9706013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126824 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=jam@chromium.org BUG=115540 TEST=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9706050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126822 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@google.com authored
TBR=abarth BUG=118293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126789 Review URL: https://chromiumcodereview.appspot.com/9703043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126821 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126820 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
The thumbnailer can kick in while the tab is hidden, and we released our back buffer, causing all sorts of problems. Temporarily don't release the back buffer to avoid this, waiting for a more proper fix. BUG=115343 TEST=run chrome --ui-use-gpu-process --force-compositing-mode. open 2 long-to-load tabs, make sure one is hidden as it finishes loading. wait 1 sec, switch back to it, move the mouse, observe no black flashes. Review URL: http://codereview.chromium.org/9699047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126819 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
It is my belief that http://crrev.com/126334 fixes the underlying cause and that http://crrev.com/126280 makes the tests a little more robust against it. BUG=81479 TEST=chrome_frame_tests.exe covers it TBR=robertshield@chromium.org Review URL: https://chromiumcodereview.appspot.com/9699060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126818 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
This test exercises reading a file on a remote file point, via RemoteFileSystemProxyInterface::CreateSnapshotFile(). BUG=chromium-os:23516 TEST=browser_tests --gtest_filter=*FileSystemExtensionApiTest.* Review URL: https://chromiumcodereview.appspot.com/9699052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126817 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126816 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=nkostylev@chromium.org BUG=116996 TEST=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9699059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126815 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
To keep the idle logout dialog with the rest of the popups on ChromeOS and following the policy of not using WebUI unless the UI is in a tab, we've moved the implementation from based on HtmlDialogUI to a views based dialog. Reviews requested, sky: Primary review jhawkins: OWNER's review for removed code from ui/webui zelidrag: OWNER's review for removed code from ui/webui/chromeos and resources/chromeos R=zelidrag@chromium.org,jhawkins@chromium.org,sky@chromium.org BUG=chromium-os:27545,chromium-os:27542 TEST=Tested with --enable-kiosk-mode flags. Review URL: https://chromiumcodereview.appspot.com/9665031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126814 0039d316-1c4b-4281-b951-d872f2087c98
-