- 22 Oct, 2020 40 commits
-
-
Aaron Leventhal authored
- Lengthen crash key strings and shorten data. 64 characters was not enough, especially when the crash key name uses some of that. - Temporarily remove the illegal reparenting dumps, as they are currently too noisy. TBR=dmazzoni@chromium.org AX-Relnotes: n/a Bug: 1141441 Change-Id: Ibaa6c91f2b17f04db1d724b49251a9fc3440545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490115 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819897}
-
Nate Chapin authored
Change-Id: I8c19316f71a74160d470cbc9cd0fd5073b25435b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491001 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#819896}
-
Ryan Daum authored
* Relanding of functionality in chromium/2422501 * With fixes to register the IME observer in OnVisible instead of AttachTo, and breaks the observer out into its own source unit. * Registers and watch for text input focus events within webview content. * Defines a new gRPC payload for said events, and broadcasts them. Bug: internal b/161811385 Test: on device & manually with wayland client tool Change-Id: I3d264f5a76931becae2e83c35ae18dceb13b84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490359Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#819895}
-
Ryan Sturm authored
The rate limiting is based on the number of attempted prefetches in the last minute (technically, it is the number of prefetches in the caching limit that were not served). Bug: 1138650 Change-Id: I0ed6108a8f065c2fb7acc5a90521d978dca0f830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490551Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819894}
-
Emily Stark authored
This reverts commit f11131a3. Reason for revert: We want to take a more cautious approach that doesn't immediately re-enable elision for existing extension users. Original change's description: > Remove unelide feature from Suspicious Site Reporter extension > > Since there is now a context menu option to show full URLs, this > feature is no longer needed in the Chrome extension. This allows > more flexibility, since users can now use the extension and keep > simplified domain display. > > Change-Id: I4e8a3b7baeca34983ee2bff82535bd332c1087cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435960 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812155} TBR=ellyjones@chromium.org,meacer@chromium.org,vakh@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib4e8b4c155df78a44bf281c1a4e207cdc4b29e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491976Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819893}
-
James Cook authored
platform_util contains utilities for showing a file in a file explorer and opening a URL with an external protocol handler. These will need to be plumbed from lacros to ash via crosapi. Introduce a stub file for lacros. Rename the existing _chromeos file to _ash to match our naming scheme. No functional changes. Bug: 1139128, 1140585 Change-Id: I51d50f3687010f8397c8ea584cce21caccbe6982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488084 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#819892}
-
Jan Wilken Dörrie authored
This change adds a feature flag that allows treating heuristics to find new_password fields as reliable. This increases the number of password forms on which password generation can be offered, but might lead to false positives. Bug: 1140493 Change-Id: Ie7083a14664b811d2bac87c4dac302e35575a79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490116Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819891}
-
Ryan Sturm authored
Search pages are considered stale after 60 seconds (finch param that probably won't be set). This CL adds a OneShot Timer map entry match the prefetch entry and removes them in sync as well. The Timer triggers removal if it has not already occurred. Bug: 1138639 Change-Id: I5442eba3fb6855aa4edcf0e0d51fcec8db8b4f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490984Reviewed-by:
-
sandromaggi authored
Bug: 1140957 Change-Id: I620da71cea62a553eba7a756065aac0e2d47cfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489989 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819889}
-
minch authored
FloatingMenuButton only reuses little logic of TopShortcutButton. e.g, set the tooltip. And TopShortcutButton named as the top shortcut button at the system tray menu. Make FloatingMenuButton as ImageButton instead. And AutoclickScrollCloseButton to be a FloatingMenuButton to reuse its logic. Then simplify TopShortcutButton to have only one constructor. Bug: 1131543 Change-Id: I68bc2ed7e535b45319c47271c2dfc4cd8f0e2626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485563 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#819888}
-
Aaron Colwell authored
Removing old test code that is no longer correct and was not even being used anymore. The comment in the block being removed refers to a bug that has been closed for over a year. The coverage data also shows that this path was no longer executed. I also removed a --site-per-process early return that is no longer needed because that case is handled by the AreDefaultSiteInstancesEnabled() comparison. Bug: 1015882 Change-Id: I8664a2818b7678984b483138eca625b714f9f0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490869 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819887}
-
minch authored
Get the focus ring color from AshColorProvider instead. Bug: 1133748 Change-Id: I681a6dde5fcf635fc4cee4f0628de17eb3cdd0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481686Reviewed-by:
-
Brian Sheedy authored
Causes GPU trybots to upload their Telemetry-based test results to a new luci-resultdb.chromium.gpu_try_test_results table. This is the same as the earlier crrev.com/c/2446893, but for try instead of CI. Bug: 1134751 Change-Id: Iab59f9057c8d41db4f3c8358da93afae7eb5b429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490144Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819885}
-
Johann authored
A static local |instance| is set up in GetInstance. |instance_| is unused. Change-Id: Ia84422f46643eb869d1f03d0a73fbfe7d91bff11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492280 Commit-Queue: Johann Koenig <johannkoenig@google.com> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819884}
-
Jesse McKenna authored
This change makes IdleWakeups interpret a numeric target process as a process ID. When a process ID is provided as the target, IdleWakeups will track that process and its child processes. This is useful for measuring a particular version of Chrome, e.g., a local Chromium build, without needing to close all other running versions. Example usage: idlewakeups.exe 22612 The above makes IdleWakeups take measurements for process ID 22612, plus all of its child processes. Change-Id: I267bfc1dda8f5c0600f3fc677e40ca0f6bb26f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490253 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#819883}
-
Cammie Smith Barnes authored
This makes the histogram obsolete and removes the lines that record and test it. Bug: 1135299 Change-Id: I2339582b892bb1536139459516f74b9101d74002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485298Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819882}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c7f0284516a..5641e3c185a8 2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84f5eeb6dd9b to e02d8938821a (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ib00743d981ce2ca05a92c6e829563b62febef40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819881}
-
Steven Bingler authored
This change makes the regexp more strict and cleans up the test's cookies when finished. Bug: 1141450 Change-Id: I706e42f321f4dbcc58931634356bab2b1e56fb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492240 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#819880}
-
Sky Malice authored
TBR: reillyg@chromium.org Bug: 1139470 Change-Id: I0e3847f0d9532f44d6cfb5a688c45fcb052e2f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480631Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#819879}
-
Ian Kilpatrick authored
... and respect box-sizing. Ok where to begin. The code which originally introduced this was: https://chromium.googlesource.com/chromium/src/+/b5d4683b6da963698fb5e3a82ac0b5b0f5c1c56e%5E%21/#F16 Basically this meant that percentages of replaced elements would resolve against their *instrinic* size only if they were located within table-cells. This wasn't matching IE's behaviour or at the time. Despite the claim. This was somewhat of a work around for the code at that time not having a good concept of table-cells within the "measure" or "layout" phase. In order to deal with resolving percentages incorrectly, treating some elements as border-box, instead of content-box was introduced (also incorrect). This patch matches the behaviour of Firefox and EdgeHTML. Effectively replaced elements if they can't resolve their percentages will return the intrinsic size. In addition we stop the box-sizing quirk, which makes some elements appear to be oversized within an element. (Again the tests which have been rebaselined match Firefox and EdgeHTML). I've implemented this behind a flag, as not super confident, and would like an easy way to turn this off without a large merge. Bug: 1122025 Change-Id: Ifd4780adc723c32754758b7ae857abf871bfc995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487780 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819878}
-
Sammie Quon authored
Altering this number makes a trackpad swipe move around one desk at a time. This was mostly based off of my own manual testing, and I do not expect this to be a final value, but in the meantime this unblocks UX as the previous threshold had the desks moving way too fast for them to make decisions. Test: manual Change-Id: I73ebb2ab3e67fb8b53242698ce7822401fc56d3d Fixed: 1134738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490854Reviewed-by:
-
Yu Su authored
- Decouple Lens Chip onClick from Lens Shopping Menu item selection. - Switch to use #queryImage in LensAsyncManager. Will deprecate #classifyImage in a follow up cl. - Support using the Lens intent type in Lens Prime API callback when creating Lens deeplink intent. Change-Id: I541d080e4ec269fee4577153183037f15e78f576 Bug: 1099982, b/170126006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463455 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#819876}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I41890da092bb22dfca7c9bc92a1af0365407c16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490548 Commit-Queue: Joon Ahn <joonbug@chromium.org> Auto-Submit: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#819875}
-
Justin Cohen authored
Bug: 1140474 Change-Id: I53d57e95867a29bd682bbc1e726d2327ab047195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491544Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819874}
-
Azeem Arshad authored
This CL fixes mobile-data network summary row not showing arrow button when tethering is enabled but has no active tether connections. Clicking the row in this case, however, does indeed navigate to the subpage to allow user to scan and show tethering information. Fixed this with a more correct check for arrow button visibility. Fixed: 1141238 Change-Id: I7eec6495562942ed068e5c826c2ba258fe027962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491103Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819873}
-
Matt Jones authored
This patch replaces usages of the layout LayoutUpdateHost that only use the requestUpdate method to instead depend on a Runnable. Bug: 1070281 Change-Id: I4af2b265cd5d3e3121afb8134729ed7a79ac09cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490237Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819872}
-
Hidehiko Abe authored
Then, migrate EvdevCodeToNativeCode and NativeCodeToEvdevCode into the new functions. Bug: 1135034 Test: Built locally. Change-Id: Ibfa0ff101649e1087f547147ca53201067b6ae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461166Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Sharon Yang authored
Add conversion so when action requests tied to node IDs are received from the Fuchsia side, the correct node ID is used. Test: AXTreeConverterTest.ConvertToAxNodeId Bug: 1135323 Change-Id: I3c4587cf581f115ddbfc5d8ed27b87f131ccc449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453890Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#819870}
-
Mariia Shvedchenko authored
If the page_language has no entries (e.g., if it's the empty string), return all patterns. Bug: 1141012 Change-Id: I9809a2c034df47b13a9c5c21ac62f47b5fea8b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489997 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#819869}
-
Aga Wronska authored
Observes cros settings on login screen and in session to prevent users from using the device if policy was disabled. Makes sure that the policy is handled correctly when users' allowlist is evaluated. Bug: 1138199 Change-Id: Ie0ce1a597e25867bf3d1bcb69b73faaf8866759b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448059Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#819868}
-
Koji Ishii authored
|NGBlockLayoutAlgorithm| has two branches, one when |lines_until_clamp_| becomes |<= 0| by the layout, and another when it is |== 0|. To make sure we run all these logic, this patch: * Updates |lines_until_clamp_| by the number of reused lines. * Limits reusing only up to 1, so that conditions above go normal layout codepath. Bug: 1140951 Change-Id: I15fe81b4957fe70d23bb88aae700642297bb1550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491561Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819867}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010220700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/-UBwQixuGMTrCC6fT6wDK3ak5Gkt558wUizuOD2eaKoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ia7fd7de353ed584810d50523579dac4e3d713812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492061Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819866}
-
Robert Ogden authored
This crash is caused by the callback being run after the original SRP has been navigated away from, causing the metrics collector to be null. This CL adds a check to skip the callback if the url isn't in the set of predicted urls, and also adds an additional guard to check that the metrics collector is not null. Bug: 1141319,1136174 Change-Id: Ia8a8542cf5c6833abdd1e88d5c2317966ebf4cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490211 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819865}
-
Bruce Dawson authored
Now that the main thread's stack size is set independently from the default stack size of the process (by using a fiber) it is possible to increase the main thread's stack size without significantly impacting address space usage. By setting it to 4 MiB we can make it roughly consistent with the 8 MiB stack of 64-bit Chrome (based on the assumption that half-sized pointers should give us half-dized stack frames). This change, therefore, is basically a continuation of the change landed in crrev.com/c/1682227 to fix bug 977387, and it was enabled by the work to load the stack reservation of non-main threads (bug 981238). The net result of all of these changes is that the main thread has a much larger stack size, while total space used by stacks is lower than before (due to the process-default stack size being 0.5 MiB). Bug: 977387, 981238 Change-Id: Ia09b7b7c44d1e51dd6fe3cd1e549bd71c1a98b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490667Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#819864}
-
Vasilii Sukhanov authored
Change-Id: I3bb9c70cc809f763334202f95b93a70edbf2ce05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489651 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819863}
-
Hitoshi Yoshida authored
This CL is actually a revert of https://crrev.com/c/2298053 Currently, WorkItemLoadingScript and WorkItemNonLoadingScript refers a TestRunnerBindings to know which RenderFrame they work with. However, if we swap RenderFrameHost over processes on navigations, the references of the bound TestRunnerBindings become wrong. This CL removes the tight bindings again, and let work items know the frames dynamically. This CL also introduces an assumption again that the frames are the main window's one. Bug: 1136383, 1132180 Change-Id: If5257ed3be881ad806e9a65d610779581412a960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469419Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819862}
-
Alex Turner authored
Many users of ProfileManager::Create{,Multi}ProfileAsync use a callback constructed with base::Bind. That method is deprecated and should be replaced with the more explicit base::BindRepeating. base::BindOnce cannot be used as the callback may be called multiple times. This resolves all remaining users of base::Bind/Callback in chrome/test/ other than a single file, so the legacy presubmit exception is made more specific. Bug: 1140573 Change-Id: Ie90b385051e42ef95442d7e40175b7250dbbfc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488041Reviewed-by:Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819861}
-
Peter Kotwicz authored
This CL makes fetch_all_androidx.py pass in a path relative to the current working directory instead of a path relative to the chromium src for fetch_all.py's --android-deps-dir argument. BUG=1064277 Change-Id: I01ad71331f33c7c0925f005dfe7eaac4a5b1be74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491523Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819860}
-
Patrick Brosset authored
The new component structure in devtools makes this test fail, so I'm disabling it temporarily to land the frontend. Bug: 1137438 Change-Id: I285d7069c5746a7c9dbb91f5e9e142af5c015206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491984Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819859}
-
Katie Dillon authored
A few places in the scheduling code take a queue as an argument to recording metrics but don't actually use the queue for anything. This CL removes those references. This CL is also a pre-requiste for crrev.com/c/2453591 which refactors MainThreadTaskQueue to not extend TaskQueue. Removing these unecessary references makes that refactor simpler. Change-Id: Ie98e19e44be2e5d156981a775c757f97766d0c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486214 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819858}
-
