GitLab

Both socket implementations have client auth logic to remove a session from the
session cache in case of client auth. In both cases, this doesn't do anything.
The OpenSSL one was copied from the NSS one. It was always dead code and became
a no-op when we stopped using the internal session cache (see
https://crbug.com/466352).

The NSS one dates to http://codereview.chromium.org/276037. At that time, we
returned SECFailure rather than SECWouldBlock, so the handshake would continue
and potentially poison the session cache. As of
http://codereview.chromium.org/669198, this was no longer an issue.

BUG=none

Review URL: https://codereview.chromium.org/1013193004

Cr-Commit-Position: refs/heads/master@{#322178}

range-based loops is one of the C++11 allowed features. See
https://chromium-cpp.appspot.com/ and
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/hpzz4EqbVmc.

This patch was generated with the following command lines:

$ ninja -C out/Debug -t compdb cxx > out/Debug/compile_commands.json
$ cd out/Debug
$ find ../../tools/gn -name '*.cc'  | xargs -n 16 -P 32 \
~/src/repos/llvm/build/bin/clang-modernize -loop-convert -p . -include \
tools/gn -format -style=Chromium
$ ninja gn gn_unittests
$ ./gn_unittests

BUG=None
TEST=gn && gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/986113002

Cr-Commit-Position: refs/heads/master@{#322177}

Move pending navigation parameters to RenderFrame, and use the HistoryController to distribute them to affected frames.

BUG=369661
TEST=existing tests

Review URL: https://codereview.chromium.org/1027863002

Cr-Commit-Position: refs/heads/master@{#322176}

Revert of content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. (patchset #1 id:1 of https://codereview.chromium.org/1033553003/)

Reason for revert:
Still flaky

Original issue's description:
> content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test.
>
> BUG=
> TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory
>
> Committed: https://crrev.com/98e563846f88a2df7107e170381a6a5e8bd4454b
> Cr-Commit-Position: refs/heads/master@{#322122}

TBR=avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1038703002

Cr-Commit-Position: refs/heads/master@{#322175}

This is related to https://codereview.chromium.org/1027693004/ and should be submitted before (although doesn't matter much).

This obsoletes the unowned:
Net.HttpSocketType
Net.HttpConnectionLatency

and removes writing to:
Net.SocketIdleTimeBeforeNextUse_UnusedSocket
Net.SocketIdleTimeBeforeNextUse_ReusedSocket

which were made obsolete in
https://codereview.chromium.org/1027693004/

Are any of these histograms being looked at?

BUG=469288

Review URL: https://codereview.chromium.org/1025073002

Cr-Commit-Position: refs/heads/master@{#322174}

These will be used in the Media Router WebUI custom Polymer elements, which will be submitted in future patches.

BUG=464222

Review URL: https://codereview.chromium.org/1029213002

Cr-Commit-Position: refs/heads/master@{#322173}

Create a basic pageset that uses the newly supported fling interaction,
paralleling the existing SimpleMobileSites pageset that uses smooth
scrolling. This should allow basic comparisons between touch scrolling
and fling performance. More stressful fling-related pages will be added
in a separate set.

BUG=321141

Review URL: https://codereview.chromium.org/1023763004

Cr-Commit-Position: refs/heads/master@{#322172}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c7c9180..7a01184

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1030173003

Cr-Commit-Position: refs/heads/master@{#322171}

Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget (patchset #10 id:270001 of https://codereview.chromium.org/1001573003/)

Reason for revert:
Breaks Android WebView which does not call ApplicationStatus.initialize

Original issue's description:
> [Android] Preserve the front buffer when the activity is paused
>
> Currently, when an activity is stopped, we explicitly hide the
> foreground Tab. This is problematic, as current hiding semantics
> might clear the visual front buffer before the window is hidden.
> This in turn causes an unpleasant flickering during activity
> transitions, e.g., when backgrounding Chrome or locking the screen.
>
> Wire Activity onPause/onResume notifications to WindowAndroidObservers,
> allowing the foreground tab to preserve its front buffer while hiding
> its web content. If the tab is explicitly hidden, or the root window
> is lost, the front buffer will be cleared as usual.
>
> BUG=462752,434401
>
> Committed: https://crrev.com/764f31d287a4995f0c89915745f5749e1c7063af
> Cr-Commit-Position: refs/heads/master@{#322052}

TBR=sievers@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org,piman@chromium.org,torne@chromium.org,jdduke@chromium.org
BUG=462752,434401

Review URL: https://codereview.chromium.org/1038573004

Cr-Commit-Position: refs/heads/master@{#322170}

A previous CL split the AutofillManager::OnFormSubmitted logic into OnWillSubmit and OnFormSubmitted to support AJAX forms. This change splits the logged events similarly and introduces AutofillMetrics::FormEventLogger::OnWillSubmitForm, which is logged anytime a form is about to be submitted. We move FormEventLogger::OnDidSubmitForm back into AutofillManager::OnFormSubmitted, since it more closely matches what happened before.

We will use the extra "will submit" logged events to determine the proportion of submitted forms that are AJAX (don't end up calling OnFormSubmitted).

BUG=460488
TEST=AutofillMetricsTest

Review URL: https://codereview.chromium.org/1010263002

Cr-Commit-Position: refs/heads/master@{#322169}

net: add (www.)healthcare.gov to HSTS preloaded.
Cr-Commit-Position: refs/heads/master@{#322168}

BUG=462221

Review URL: https://codereview.chromium.org/977323003

Cr-Commit-Position: refs/heads/master@{#322167}

R=phajdan.jr@chromium.org
BUG=468335

Review URL: https://codereview.chromium.org/1026413003

Cr-Commit-Position: refs/heads/master@{#322166}

Backport https://www.sqlite.org/src/info/eddc05e7bb31fae7
"Fix a problem causing collation sequence names to be dequoted
multiple times under some circumstances."

BUG=469082

Review URL: https://codereview.chromium.org/1022423004

Cr-Commit-Position: refs/heads/master@{#322165}

It allows us to forward declare it instead of including the file everywhere.

BUG=437770

Review URL: https://codereview.chromium.org/1020683003

Cr-Commit-Position: refs/heads/master@{#322164}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6b9ef90..c7c9180

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1014723010

Cr-Commit-Position: refs/heads/master@{#322163}

Removed PresentationSessionDispatcher since the session messages are going through the
PresentationService (to reduce the number of Mojo pipes used).

Depends on the Blink change: https://codereview.chromium.org/1020303004

BUG=459006

Review URL: https://codereview.chromium.org/1024903003

Cr-Commit-Position: refs/heads/master@{#322162}

This propagates the presence of IconNTP/Enabled to the local NTP, so we
keep display old design and conditionally render (upcoming) new design.

BUG=467712

Review URL: https://codereview.chromium.org/1020853012

Cr-Commit-Position: refs/heads/master@{#322161}

WebRTC 8852:8857
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3918de6..edd91ff

Libjingle 8851:8855
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d3e61c0..bb52e6e

TBR=
BUG=

Review URL: https://codereview.chromium.org/1036433003

Cr-Commit-Position: refs/heads/master@{#322160}

WebView creates a WindowAndroid class per AwContents, but never calls
destroy on it, so the native WindowAndroid leaks. Do this in
CleanupReference of AwContents.

Also make native WindowAndroid hold a strong reference, so removes
the requirement to null check the ref, which are mostly missing anyway.

Notes:
* This adds the requirement that WindowAndroid cannot hold strong ref
  that would prevent AwContents/ContentViewCore from being gc-ed,
  which currently is the case.
* This does not address the issue that WindowAndroid should be
  per-activity, not per ContentViewCore.

BUG=469803

Review URL: https://codereview.chromium.org/1034593002

Cr-Commit-Position: refs/heads/master@{#322159}

These broke Closure at http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/18644

BUG=461800
TBR=vasilii@chromium.org

Review URL: https://codereview.chromium.org/1020863011

Cr-Commit-Position: refs/heads/master@{#322158}

The class used to be in components\favicon_base. The DEP changes arise
due to movement of fallback icon drawing code.

BUG=467712

Review URL: https://codereview.chromium.org/1032683002

Cr-Commit-Position: refs/heads/master@{#322157}

BUG=468982
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/1019393004

Cr-Commit-Position: refs/heads/master@{#322156}

This upstreams the exising "third"-party HTML tokenizer used for
network-level injection, which is used to find the insertion point
for network JS injection.

BUG=464810

Review URL: https://codereview.chromium.org/1031023002

Cr-Commit-Position: refs/heads/master@{#322155}

Revert of Roll src/third_party/WebKit 698efc0:7d47c95 (svn 192500:192506) (patchset #1 id:1 of https://codereview.chromium.org/1037703002/)

Reason for revert:
Broke compilation with GN:

https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/6697/steps/gn/logs/stdio

caused by this Blink commit:
https://chromium.googlesource.com/chromium/blink/+/7d47c95bc49510d29e36fc2895eef3e67706ef41

Original issue's description:
> Roll src/third_party/WebKit 698efc0:7d47c95 (svn 192500:192506)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/698efc0..7d47c95
>
> TBR=jchaffraix@chromium.org
>
> Committed: https://crrev.com/60a49fc315e7eaed780da86aad1eecd40f149f70
> Cr-Commit-Position: refs/heads/master@{#322139}

TBR=jchaffraix@chromium.org,blink-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1032603004

Cr-Commit-Position: refs/heads/master@{#322154}

This will help avoid buildbot killing it when no output
is produced for too long (expected with xz -9 for a large file).

BUG=433338
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1037753002

Cr-Commit-Position: refs/heads/master@{#322153}

These benchmarks were crashing as a result of a style-related ASSERT. The
offending CLs have been reverted (see bug) so I'm reenabling these.

BUG=470071
TBR=rune@opera.com

Review URL: https://codereview.chromium.org/1030183002

Cr-Commit-Position: refs/heads/master@{#322152}

This version has been obsolete for longer than the 2 year deprecation window.
Maintaining backwards support for this would greatly complicate schema migration
and recovery in the transition to schema version 8, which adds support for
tracking the last_requested time of a given icon bitmap.

BUG=467712

Review URL: https://codereview.chromium.org/1010973011

Cr-Commit-Position: refs/heads/master@{#322151}

I accidentally landed the wrong patchset. :(

BUG=462636
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1004683003

Cr-Commit-Position: refs/heads/master@{#322150}

BUG=462636
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1019213003

Cr-Commit-Position: refs/heads/master@{#322149}

This adds missing plumbing to single_thread_proxy to forward max pending frames from the surface to the compositor, but keeps max pending value the same for the time being. Currently the call to SetMaxSwapsPendingOnImplThread in layer_tree_host_impl.cc gets dropped on the floor for ChromeOS.

Previously, driver implementation of eglSwapBuffers returned before page flip actually happened, allowing the browser compositor to start scheduling the next frame while the front buffer was still shown.

With switch to freon, SwapBuffersACK is sent on page flip, affecting scheduler timing. This enables the browser compositor to queue up a new frame earlier when necessary.

BUG=465599

Review URL: https://codereview.chromium.org/1011823005

Cr-Commit-Position: refs/heads/master@{#322148}

Cr-Commit-Position: refs/heads/master@{#322147}

chrome://settings/passwords currently displays a blank input field for
federated credentials. This patch adjusts things to support displaying
the hostname of the federation with which the credential is bound. That
is, it will display "via facebook.com" if you've signed into a website
using Facebook, and saved that credential via the Credential Manager
API.

BUG=461800
R=vasilii@chromium.org

Review URL: https://codereview.chromium.org/960493004

Cr-Commit-Position: refs/heads/master@{#322146}

Widen a suppression and exclude two tests.

BUG=470517, 470507, 463261
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1001843003

Cr-Commit-Position: refs/heads/master@{#322145}

Disabling this test will make a bot go green. See bug for details.

BUG=470499

Review URL: https://codereview.chromium.org/1031943004

Cr-Commit-Position: refs/heads/master@{#322144}

BUG=158922
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1029583010

Cr-Commit-Position: refs/heads/master@{#322143}

This adds a check that the requested algorithm is actually permitted by the certificate as defined in the algorithm field of the Subject Public Key Info.

BUG=466584

Review URL: https://codereview.chromium.org/998293002

Cr-Commit-Position: refs/heads/master@{#322142}

module_test_case.py was removed from trace-viewer.
See the bug for more details.

TBR=nduca@chromium.org
BUG=470463

Review URL: https://codereview.chromium.org/1033933002

Cr-Commit-Position: refs/heads/master@{#322141}

Make profiler less dependent on src/base

BUG=406277

Review URL: https://codereview.chromium.org/1020853013

Cr-Commit-Position: refs/heads/master@{#322140}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/698efc0..7d47c95

TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/1037703002

Cr-Commit-Position: refs/heads/master@{#322139}