- 04 Dec, 2018 40 commits
-
-
Lily Chen authored
https://crrev.com/c/1343047 incorrectly used ConvertRequestPriorityToSpdyPriority when it should have used ConvertRequestPriorityToQuicPriority when setting the priority of a QuicProxyClientSocket. Bug: 166689 Change-Id: I82fd9e9b0a851df1fce4450172d320f554cf379c Reviewed-on: https://chromium-review.googlesource.com/c/1362183Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#613756}
-
Stuart Langley authored
We should be turning down the code that supplied these metrics in M73, updated expiry to M74. Bug: 911296 Change-Id: I48f79d75966f53cb3aae3548b49cd4b895125d25 Reviewed-on: https://chromium-review.googlesource.com/c/1361746Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#613755}
-
Min Qin authored
DownloadProtectionService::SetEnabled(false) could destroy all CheckClientDownloadRequests before they are finished. If that happens, we need to remove the latter from all the DownloadItems' observer list they are observing. Otherwise, DownloadItemImpl dtor could hit NPE due to these deleted observers. BUG=906004 Change-Id: Ic4971c0e95087315433ca30ad5a56684abc112e3 Reviewed-on: https://chromium-review.googlesource.com/c/1359470Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613754}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dab5d9cfb7dc..6f87fb214b3c git log dab5d9cfb7dc..6f87fb214b3c --date=short --no-merges --format='%ad %ae %s' 2018-12-04 dgarrett@google.com generic_stage.GetRepoRepository: Make arguments flexible. Created with: gclient setdep -r src/third_party/chromite@6f87fb214b3c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibe17d9997ccac8753c850e1253204325e586a03d Reviewed-on: https://chromium-review.googlesource.com/c/1361789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613753}
-
Robert Liao authored
BUG=911829 TBR=agrieve@chromium.org Trivial addition to untranslated_grds. Change-Id: I4af0b90f8e2b03a905d1c604169370617f464820 Reviewed-on: https://chromium-review.googlesource.com/c/1362289Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613752}
-
Aiden Benner authored
This is a reland of d958e2ee Original change's description: > Refactor AnimationFrameTimeHistogram to use mockable static natives > > This CL adds the necessary dependencies to use the JNI annotation > processor in base/java and converts AnimationFrameTimeHistogram to > use mockable static methods. > > This abstraction should have little overhead once R8 is used instead > of proguard but for now it still adds methods. > > Bug: 898261 > Change-Id: I73141dfeb5916c40aafc3c58ae606fe0af7a392e > Reviewed-on: https://chromium-review.googlesource.com/c/1347202 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Aiden Benner <abenner@google.com> > Cr-Commit-Position: refs/heads/master@{#610514} Bug: 898261 Change-Id: I3c0d32da9e72e103cea229f03cf80e93fbe9eb64 Reviewed-on: https://chromium-review.googlesource.com/c/1349855 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#613751}
-
Ovidio Henriquez authored
This change adds the HandleGetChooserExceptionList and HandleResetChooserExceptionForSite methods to SiteSettingsHandler to prepare them for use in site settings. These two methods will eventually replace the existing HandleFetchUsbDevices and HandleRemoveUsbDevice and allow future chooser exception types to use them. They will also make it easier to create Polymer elements to handle chooser exceptions, instead of the current Polymer element that only handles USB exceptions. The HandleGetChooserExceptionList will return a list of chooser exceptions using the new GetChooserExceptionListFromProfile method is site_settings_helper.h. These new chooser objects will allow the chooser's site exceptions to be grouped together under the same chooser object in the UI. The HandleResetChooserExceptionForSite will reset the site exception for the given chooser. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I5536cae3946338b48042087c9b6d6b4abccbebdd Reviewed-on: https://chromium-review.googlesource.com/c/1321850 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#613750}
-
Moe Ahmadi authored
Bug: 910994 Change-Id: I7f59a65fed447d2ffb960fbc901f92ea35c84c35 Reviewed-on: https://chromium-review.googlesource.com/c/1340533 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613749}
-
Wenzhao (Colin) Zang authored
This reverts commit cc675998. Reason for revert: crbug.com/911236 Original change's description: > Enable DriveFS by default. > > Bug: 819822 > Change-Id: I1900ba4bf4c3a1e3c2f407b1fb45f883b0ff5d25 > Reviewed-on: https://chromium-review.googlesource.com/c/1263677 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612994} TBR=sammc@chromium.org,lucmult@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 819822 Change-Id: Iacf380ce30a8445b3f06d06d3df81626e9b3abc1 Reviewed-on: https://chromium-review.googlesource.com/c/1362280Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613748}
-
Robert Flack authored
Relands disabling flaky timeouts patch with DISABLED macro corrected for WRAPPED_INSTANTIATE_TEST_CASE_P TBR=lucmult@chromium.org,bartfab@chromium.org,pmarko@chromium.org Bug: 911661 Change-Id: I16b7c76102854d398b8e130f66cef568bb5126b9 Reviewed-on: https://chromium-review.googlesource.com/c/1361574Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613747}
-
Shawn Gallea authored
Conditionally instantiate the Wayland server based on a BUILDFLAG in Chromecast. This change also splits out the WaylandWatcher from Ash code so that it is shared between different builds. Bug: 896710 Test: Compile cast_shell Change-Id: I2d2e129add5f0bcf6f2368909c5c83b2ad00a9cc Reviewed-on: https://chromium-review.googlesource.com/c/1329858 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#613746}
-
Clark DuVall authored
These were calling GetRequestContext() when NS was run in-process, which DCHECKs. Split the setup code into two different functions, so the one that needs GetRequestContext() isn't run with NS enabled. Bug: 908993 Change-Id: I33713fb9da9d2a44d05ecce24db6c59445096918 Reviewed-on: https://chromium-review.googlesource.com/c/1361704Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#613745}
-
John Rummell authored
Media licenses will now be deleted when "Cookies and site data" is selected. BUG=901993 TEST=manual inspection of CBD dialog Change-Id: I1b3858d45090d37ce4fdc155f3a5e5392d5c155e Reviewed-on: https://chromium-review.googlesource.com/c/1330887Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#613744}
-
Brandon Wylie authored
Also adding a couple of tests. Bug: 909978 Change-Id: Ic63d5b35a1112c86a3430f4c52f476444b53c666 Reviewed-on: https://chromium-review.googlesource.com/c/1355879Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#613743}
-
Peter Kotwicz authored
BUG=911316 Change-Id: If2b2c01109655b3f9066776a716ac811d8afa103 Reviewed-on: https://chromium-review.googlesource.com/c/1362103Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#613742}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e3e680ca47dc..654b3c56c6a4 git log e3e680ca47dc..654b3c56c6a4 --date=short --no-merges --format='%ad %ae %s' 2018-12-04 syoussefi@chromium.org Vulkan: Fix multi-layer image readback Created with: gclient setdep -r src/third_party/angle@654b3c56c6a4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5c325a1b69030b45854390cd0b3c07454d5ad1cb Reviewed-on: https://chromium-review.googlesource.com/c/1361984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613741}
-
danakj authored
This was done to show the Page which was hidden accidentally when hiding the main frame's RenderWidgetHost when detaching a main frame. Detaching a main frame doesn't destroy the RenderWidgetHost because the renderer's RenderWidget's lifetime is tied to RenderView. Now the Page is no longer hiding with the main frame RenderWidget so this code does not need to show the Page when creating a subframe in a tree that was empty but used to hold a local main frame. Lots of investigation/details in crbug.com/908582 from #15 to #19. R=alexmos@chromium.org, creis@chromium.org Change-Id: Ie03115c94883c2a19840f7b9e16fc4c94789ede2 Bug: 419087, 908582, 638375 Reviewed-on: https://chromium-review.googlesource.com/c/1357629 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#613740}
-
Manas Verma authored
This feature has been approved for launch. Bug: 855182 Change-Id: I4cb3dc5d0ca4824c4915c933bdbd5e5ccc684977 Reviewed-on: https://chromium-review.googlesource.com/c/1359593Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#613739}
-
Zhiqiang Zhang authored
This CL does the following fixes: * In CafRemoting MRP, return the proper FlingingController. * When session started, CafRotingMRP should call super.onSessionStarted so the notification shows up. * Cache the stream position when getting the media time. This is because when casting is stopped, the native side might have one call to GetMediaTime but the Java-side is already teared down. Bug: 711860 Change-Id: I2295f2cec17d806659a704f248bac060f797bfc3 Reviewed-on: https://chromium-review.googlesource.com/c/1361834Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613738}
-
Maks Orlovich authored
Unneeded since https://chromium-review.googlesource.com/c/chromium/src/+/1315948/21/chrome/browser/invalidation/deprecated_profile_invalidation_provider_factory.cc Change-Id: I6c15e8b30793d4f6479c757d134a07598989a6bf Reviewed-on: https://chromium-review.googlesource.com/c/1362184Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#613737}
-
Aidan Wolter authored
This new sandbox policy starts by adding these extra permissions: * fuchsia.bluetooth.gatt.Server * fuchsia.bluetooth.le.Peripheral * fuchsia.wlan.server.Server Bug: None Test: None Change-Id: I58c08b70bd86fa66858037c41c765677fb242beb Reviewed-on: https://chromium-review.googlesource.com/c/1343520Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#613736}
-
Nate Fischer authored
This removes WebView's token binding code, since this is no longer supported by chromium. This removes everything in the AW-layer, and most of the glue layer (we're limited in that we must implement the getTokenBindingService() method. Bug: 910758 Test: it compiles Test: install Google WebView on P device, it starts up OK Change-Id: Id5a1335a67b2224148b9280c48032b7f5f658685 Reviewed-on: https://chromium-review.googlesource.com/c/1357762Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613735}
-
Steven Bennetts authored
This feature has been enabled by default since 2014. Bug: None Change-Id: I404ce94ff6d420daa96cb2730e6cd25985b637cf Reviewed-on: https://chromium-review.googlesource.com/c/1361647 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#613734}
-
Noel Gordon authored
- remove file_tasks_unittest.html - add BUILD rules to auto-generate and compile this unittest - file_tasks depends on naming_controller: add a build dep - add unittest @types and document test cases and helpers - add failWithMessage(): undefined according to the compiler - define mockChrome: install it during unittest Setup() - fix Closure compiler errors and auto-format JS code No change in test behavior. Bug: 910975 Change-Id: I54d68d6a0364e677d74648eee819d2909368b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/1360911Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613733}
-
Megan Jablonski authored
Bug: 909915 Change-Id: I6e17ea7904a818a04061fcd07ef45368bf5b591b Reviewed-on: https://chromium-review.googlesource.com/c/1359855 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#613732}
-
Dale Curtis authored
Some cleanups I noticed while working on adding the async callback; does the following: - Fixes some spelling errors. - Removes the need to save a callback to subscribe for errors. - Removes a stale comment associated with the error callbcks. - Removes some unused methods from the ARM interface. - Always posts the OutputDeviceInfoCB per documented contract. - Switches to "using", "RepeatingCallback", etc where appropriate. - Switches to base::flat_set/map where appropriate. BUG=905506 TEST=existing tests all pass. Change-Id: Ib670c04ed59b98b07c18cc3f3afac44d802a2a68 Reviewed-on: https://chromium-review.googlesource.com/c/1357540Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613731}
-
Matthew Jones authored
This patch fixes an issue where Duet was attempting to query the IPH tracker prior to it being completely initialized. The fix is simply wrapping the IPH trigger in an init callback. Bug: 911797 Change-Id: Ie5e375fa2dde14a441ea260cb70d48150e3c1d7b Reviewed-on: https://chromium-review.googlesource.com/c/1361864Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#613730}
-
Chris Blume authored
The draw functor relies on C++ rules to fill in values for ABI. This can be a tad dangerous. Someone may accidentally add a value in the middle and change the values filled into the enum. This CL explicitly sets a value for each enum option. Change-Id: I2a637fd3fbefc2ee03f3f05c84fe4594de00a936 Reviewed-on: https://chromium-review.googlesource.com/c/1361832 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#613729}
-
Ned Nguyen authored
This CL does: 1) Update flags usage of generate_perf_sharding to fetch new timing data by default. 2) Update error reporting when users don't have bq in their PATH. 3) Update --builders flag to append, so that one can update many selective builders at once by passing "-b builder_1 -b builder_2" Change-Id: Idb89e3a0d9d03317364115bdb141bf02191269ee Reviewed-on: https://chromium-review.googlesource.com/c/1361442 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#613728}
-
Lukasz Anforowicz authored
After this CL, a "stability and security will suffer" infobar warning will be shown if an individual user: 1. Uses --disable-site-isolation-trials (aka switches::kDisableSiteIsolation) cmdline switch 2. Uses chrome://flags/#site-isolation-trial-opt-out To avoid showing the warning if Site Isolation is opted out via Enterprise Policy, the CL introduces a separate API for disabling Site Isolation and switches Enterprise Policy scenarios to use the new API . This avoids showing the new warning in Enterprise Policy scenarios. Bug: 900998 Change-Id: I93bf3d9233c09072c85deaceda0659b9e25a2075 Reviewed-on: https://chromium-review.googlesource.com/c/1318443Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#613727}
-
John Chen authored
Add W3C defined properites in Status response. Fixes WPT test /webdriver/tests/status/status.py test_get_status_no_session. Bug: chromedriver:2688 Change-Id: I387f506173b0e255b188da1fecc5787df8a941f8 Reviewed-on: https://chromium-review.googlesource.com/c/1362185Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#613726}
-
bsheedy authored
The patch that was causing it to be flaky has been reverted. TBR=billorr@chromium.org Bug: 910549 Change-Id: I9d9e9ea32e2b2666655cdd89af4b73fc42dc923b Reviewed-on: https://chromium-review.googlesource.com/c/1361839Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613725}
-
Ola Karlsson authored
Bug: 889221 Change-Id: I5fc264fa1f884e312f49fd456797389932b75837 Reviewed-on: https://chromium-review.googlesource.com/c/1280084Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ola Karlsson <olakar@chromium.org> Cr-Commit-Position: refs/heads/master@{#613724}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia088cfa9dcff0301d2e99265b7f4e74787b9f4cb Reviewed-on: https://chromium-review.googlesource.com/c/1361995Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613723}
-
Boris Sazonov authored
This CL adds base::android::RunRunnableAndroid method which is similar to existing Run.*CallbackAndroid methods, but for java.lang.Runnable. To illustrate the usage of this method, this CL also replaces Callback<Void> in FeedSchedulerBridge with Runnable. Bug: None Change-Id: I334fb63b816185d1b9564bdfe629669ac6bb973a Reviewed-on: https://chromium-review.googlesource.com/c/1353984Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#613722}
-
Dave Tapuska authored
Sometimes the View is null and we can't get a ChromeClient. Change the API to take the ChromeClient as a ptr, which also implies the auto_cancel field. BUG=907125 Change-Id: I123845c2294ec2c4f155500012280a48ff623c86 Reviewed-on: https://chromium-review.googlesource.com/c/1359056Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#613721}
-
Theresa authored
BUG= Change-Id: I8f76b04dc6e14d6edecbf87c540237d3bd0f9efa Reviewed-on: https://chromium-review.googlesource.com/c/1361295 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#613720}
-
Cary Clark authored
review.skia.org/129243 changes some layout test results in a minor way; add define to keep old skia behavior on the way to rebaselining the tests R=fmalita@chromium.org Bug: 843966 Change-Id: If09ad8e97c02dab56934ec387ab4a4911bd24b29 Reviewed-on: https://chromium-review.googlesource.com/c/1361632Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#613719}
-
dstockwell authored
I'm making this component reusable for use in the annotation toolbar. * dropdown is now positioned relative to the button (rather than absolutely to the right side of the screen) * dropdown handles dismissing itself when a pointer down event occurs anywhere outside its tree. (Previously tapping on the top bar would not dismiss the bookmarks dropdown). * width can now be customized * header is now optional Bug: 902646 Change-Id: Ic1c4cb59810417339d67a17586cc0ca106ae9818 Reviewed-on: https://chromium-review.googlesource.com/c/1352080Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#613718}
-
Peter K. Lee authored
This is a follow up to http://crrev/c/1353895 Bug: 909726 Change-Id: I16a0a015df47c4f8a7c1824bbdceb6bc57580c93 Reviewed-on: https://chromium-review.googlesource.com/c/1359027 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#613717}
-