- 23 Oct, 2018 40 commits
-
-
Tatsuhisa Yamaguchi authored
The managed device icon in the system tray should only be shown while in the public session mode, unlike the "managed" indicator shown in the unified system tray bubble. Bug: 895718 Test: manually tested with public session on an enrolled device Change-Id: Ic86be2a42e5d3a0be89cf5eb6c80aab14bec0f32 Reviewed-on: https://chromium-review.googlesource.com/c/1288093 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#601845}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. In the process, Introduce BrowserWindow::OnTabDetached() When closing a tab with old API, expected order of calls are.. 1. Browser::TabDetached 2. BrowserView::TabDetached -> this resets contents_web_view_. 3. Browser::ActiveTabChanged() -> This will call BrowserWindow(BrowserView)::OnActiveTabChange() : Set new contents to contents_web_view_ But, if we use the new observer API it would be 1. Browser::OnTabStripModelChanged() * handles things Browser::TabDetached() used to do. * handles things Browser::ActiveTabChanged() used to 2. BrowserView::OnTabStripModelChanged() * handles BrowserView:TabDetachedAt() used to do. As a result, contents_web_view_ is cleared out with null contents. Repro step and the result would be, 1. Open browser 2. Create new tab 3. Close active tab. -> Then new active tab's contents won't be visible. Therefore, Introduce BrowserWindow::OnTabDetached() and let the Browser control the flow. Change-Id: I88c08f05d365f83146602197374299d4b4fdb14c Reviewed-on: https://chromium-review.googlesource.com/c/1205975 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601844}
-
Stuart Langley authored
This CL updates file_table_unittest & file_list_selection_model_unittest to be autogenerated from dependencies. Required fixing VolumeManager, where a method was only defined in FilteredVolumeManager and not in the interface. Populate the base class with a method that always logs an error to keep the closure compiler happy. Bug: 860355 Change-Id: I90192479d7faf4368a140460400357dae0f2da4c Reviewed-on: https://chromium-review.googlesource.com/c/1295429Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#601843}
-
Dmitry Gozman authored
This patch moves all logic related to constructing DocumentLoader to it's constructor. It also removes the methods which we only need when creating a DocumentLoader. Bug: 855189 Change-Id: I32521ab453b78c80e3f8266d07eb5a1268df0786 Reviewed-on: https://chromium-review.googlesource.com/c/1274836 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#601842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b789e264a44..7e40bdd94cb1 Created with: gclient setdep -r src-internal@7e40bdd94cb1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29f0cffd656a1aaf9dae8f6092b19ad30f49bbbd Reviewed-on: https://chromium-review.googlesource.com/c/1295730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601841}
-
Tetsui Ohkubo authored
Notification inline reply did not support notification update after its creation properly. TEST=NotificationViewMD.TestInlineReplyRemovedByUpdate BUG=894638 Change-Id: Ib03b92ea580fa45d5c4fc58de0bca2a1c7399e50 Reviewed-on: https://chromium-review.googlesource.com/c/1290234 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601840}
-
Peter Kasting authored
This also removes a bunch of other #includes from bookmark_utils_desktop.cc (when I got suspicious that it wasn't using them all) and removes the word "material" from a constant (and inlines it). Bug: none Change-Id: Ibc1736a2b198210b0d29f2eecd779e401ab4a0e3 TBR: sky Reviewed-on: https://chromium-review.googlesource.com/c/1295299Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ifc5264d3916f9c30f1be09e3fe6110b7660b1faf Reviewed-on: https://chromium-review.googlesource.com/c/1295770Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601838}
-
Christopher Lam authored
This CL alters the System App installation pipeline in order to allow the full PWA setup experience to succeed for System Apps (mostly adding exceptions for chrome:// URLs), allowing System Apps to be installed with a scope. It also adds a browser test which installs a System PWA end to end. Bug: 836128 Change-Id: Ida32fa45484661d32a9607b44e06f28f272d4cc3 Reviewed-on: https://chromium-review.googlesource.com/c/1272636 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601837}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39feabe35c51..9a5da497b568 git log 39feabe35c51..9a5da497b568 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 yujo@chromium.org Split out a separate target for SimulcastEncoderAdapter 2018-10-22 magjed@webrtc.org Reland "Remove deprecated barcode scanning functionality" Created with: gclient setdep -r src/third_party/webrtc@9a5da497b568 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b51edeb23c2658cbde9e1c01adb4592c947130b Reviewed-on: https://chromium-review.googlesource.com/c/1295571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601836}
-
Vikas Soni authored
This reverts commit bafb8331. Reverting the patch since the CHECK macro is no longer needed now. Original change's description: > Adding CHECK macro to debug crash. > > Moving a DCHCEK to CHECK and adding a new CHECK macro to debug crash > which are hard to reproduce on local devices. This CHECK will soon > be moved back to DCHECK. > > Bug: 892354 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I44e237db73cec5259b90bb312e7940b41553d332 > Reviewed-on: https://chromium-review.googlesource.com/c/1282104 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599885} TBR=piman@chromium.org,vikassoni@chromium.org Bug: 892354 Change-Id: Id75912831cb8087976b481feb51293d941263da1 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1295314 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601835}
-
“weigua” authored
For now metadata only includes visual experience controller version. BUG=chromium:897552 Change-Id: I3766daf31d03f3931054b1ba25d277a324723f77 Reviewed-on: https://chromium-review.googlesource.com/c/1293101 Commit-Queue: Wei Guan <weigua@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#601834}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/98eda2822c18..12724252ffc5 git log 98eda2822c18..12724252ffc5 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 saklein@chromium.org install_toolchain: simplify libc extraction 2018-10-23 saklein@chromium.org install_toolchain: port to chromite python script. Created with: gclient setdep -r src/third_party/chromite@12724252ffc5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic6b7f5f8348595204bd36cf190b317be7f37a6cf Reviewed-on: https://chromium-review.googlesource.com/c/1295411Reviewed-by:
-
Eliot Courtney authored
This will be used in an upcoming CL. We want the Picture-in-Picture window to avoid system ui areas such as the message center and virtual keyboard. In order to support this, this CL adds a new WM event to fire when something changes about a 'system ui area,' which currently includes the virtual keyboard (floating or normal) and the message center. Bug: b/115291749 Bug: 841886 Bug: 874545 Bug: b/112668491 Test: Added unittest Change-Id: Ic3b0cde8800bfc98dd2ffbe0d17137a6e1a26809 Reviewed-on: https://chromium-review.googlesource.com/c/1219366 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#601832}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. The new API callbacks are only invoked when the internal state of TabStripModel is consistent. The old API callbacks would be invoked while the internal state of TabStripModel was inconsistent. FullscreenController's implementation was relying on an inconsistent state for TabStripModel. So FullscreenController is modified too. FullscreenController::IsFullscreenForTabOrPending() checks if |web_contents| is same with the active tab. But when it's handling tab deactivation, the active tab is already changed to the newly activated tab. Therefore we shouldn't assert in that case. Change-Id: I10a9f055ae111d43ba20ad6b9155196abe638e5b Bug: 842194 Reviewed-on: https://chromium-review.googlesource.com/c/1196287Reviewed-by:
-
Timothy Gu authored
This is a reland of 254369a5. It addresses bug 888025 by adding ASAN test expectations, as the relevant V8 feature does not yet support running on ASAN builds. Original change's description: > bindings: Implement timers with V8Function > > This fixes bug 866610 by using the IDL infrastructure to properly enter > the v8::Context before calling the registered callback. > > Also ensure eager finalization of ScheduledAction in DOMTimer to > prevent a memory leak. Added two more effective DCHECKs to confirm. > > Bug: 866610 > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > Reviewed-on: https://chromium-review.googlesource.com/1220486 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593108} TBR=japhet@chromium.org Bug: 866610, 888025 Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a Reviewed-on: https://chromium-review.googlesource.com/c/1239624Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601830}
-
Tetsui Ohkubo authored
NotificationViewMD overrides ScrollRectToVisible in order to show the entire notification when scrolled by tab focus, but it's not necessary. * ScrollRectToVisible(GetLocalBounds()) is called at least once from NotificationViewMD::OnFocus() so the entire notification is shown at this point. * Overriding ScrollRectToVisible makes child buttons to not be scrolled properly when the notification is too tall. TEST=manual BUG=854151 Change-Id: Ic890cc33b2f74e41caf7a9e1a3b98d850cb937b3 Reviewed-on: https://chromium-review.googlesource.com/c/1293062Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 895723 Change-Id: If7918de7e3717b01619ee21fa87eeaffb971287c Reviewed-on: https://chromium-review.googlesource.com/c/1292661Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#601828}
-
Toni Barzic authored
This removes Web Store Widget app code, and with it, the whole components/chrome_apps dir (which currently contains only the app in question). The app was used as a wrapper around Web Store Widget UI. The widget provides way of displaying filtered list of extensions in Chrome Web Store and is able to request an extension installation. The widget itself is still used in Files app (and has been moved alongside other Files app resources), but the Web Store Widget component app, which was used to list printer provider extensions for a printer when the printer gets plugged in is not used anymore (https://crbug.com/734161), and can be removed. BUG=1288076 Change-Id: I1818a9fcce6f4bf9fc9877158ba839b22d825fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1291839Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#601827}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/20f55e63..9dd320d2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8625d102fa6bb710a472a46c9686e382b98528bd Reviewed-on: https://chromium-review.googlesource.com/c/1295332Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601826}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4a228b2788a..3b789e264a44 Created with: gclient setdep -r src-internal@3b789e264a44 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I77373e9dc07b8a94f90fb62c3a344096f4e0f893 Reviewed-on: https://chromium-review.googlesource.com/c/1295573Reviewed-by:
-
yoshiki iguchi authored
- Unblock notifications in SessionStateNotificationBlocker - Hide the message center by seeing the session sate (previously, it saw the count of notifications) - Change height below scroll, by checking the visibility of message center (previously, it checked only the height) Bug: 893945 Test: manual Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880 Reviewed-on: https://chromium-review.googlesource.com/c/1282426Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
-
Miguel Casas authored
GpuMemoryBufferImplAndroidHardwareBuffer::Create() can return a nullptr [1], this CL handles that situation appropriately. I found this path while investigating the bug below. It might be related or not -- my android got into some metastate and it won't install clankium images, but in the meantime this fix seems legit to me. [1] https://cs.chromium.org/chromium/src/gpu/ipc/common/gpu_memory_buffer_impl_android_hardware_buffer.cc?type=cs&sq=package:chromium&g=0&l=85 Bug: 865957 Change-Id: I37f431e70d90b955d812dd037076648bc3d30331 Reviewed-on: https://chromium-review.googlesource.com/c/1295249Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#601823}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/20f804166944..7259c048b9a3 git log 20f804166944..7259c048b9a3 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 tsepez@chromium.org Modernize app.* JS method tests. Created with: gclient setdep -r src/third_party/pdfium@7259c048b9a3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9f931f1ac6938ed878bf6e225dcb3b701e014ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1295412Reviewed-by:
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=scottmg@chromium.org Bug: 681136 Change-Id: Id22ba18bda2f051b12b5ca439df66eab6f42260d Reviewed-on: https://chromium-review.googlesource.com/c/1288511 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601821}
-
Scott Chen authored
For signed-in new users, if they chose an email provider on a previous step, they would be prompted by a page which will direct them to the selected email provider url. Change-Id: Iccf0f61c0548923f63e022e66e408bf3595d54f1 Reviewed-on: https://chromium-review.googlesource.com/c/1256213 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#601820}
-
Xi Cheng authored
This is a reland of b011ab56 In the original change, NotificationImageRetainerTest.CleanupFilesFromPrevSessions and NotificationImageRetainerTest.RegisterTemporaryImage failed on Win and Win64 trunk official.desktop.continuous builders. The root cause is that for some reason, chrome::DIR_USER_DATA used in the test alternated between the chrome-bot directory (i.e., C:/Users/chrome-bot/AppData...) and the full directory (i.e., C:/Users/CHROME~1/AppData). From the test results, they clearly referred to the same file, so the code is working fine in production. However, the mismatch of the two strings failed the string comparison in the tests. This CL attempted to fix it. Original change's description: > Upgrade image file management for Win 10 native notification > > This CL makes the following changes: > 1) Change to run image folder cleanup after Chrome startup using a background > task, rather than running it at Chrome shutdown using a high priority task. > 2) Retain the image folder to avoid deleting and creating it repeatedly. > 3) Remove <subdir> from the full path for the temp file, which is unnecessary. > 4) Delete the temp files in batch. > > These changes have the following benefits: > 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users > as in the current implementation. > 2) Save some disk IO related to the sub-directories in the image folder and the > image folder itself. > 3) Avoid creating a deletion task for each file, otherwise the overhead can be > large when there is a steady stream of notifications coming rapidly. > > Bug: 888276 > Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b > Reviewed-on: https://chromium-review.googlesource.com/c/1260498 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601227} TBR=isherman@chromium.org, grt@chromium.org, finnur@chromium.org Bug: 888276, 897352 Change-Id: I9b1bde98be8545f8634473e7540b0a2a3bee7172 Reviewed-on: https://chromium-review.googlesource.com/c/1292894Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#601819}
-
Guohui Deng authored
1. Fix the following problem: When Stopped, CastAudioOutputStream would crash stopping the |io_thread_|, which is also unecessary. 2. Make the unit tests of CastAudioOutputStream and CastAudioManager only test CMABackend implementation of CastAudioOutputStream because they are not ready to test the newer MixerService implementation. Bug: internal b/29571387 Test: 1. Play a lasting sin wave audio on two devices, to make sure the AudioOutputStream plays fine whether or not MixerService is used. 2. Run cast_media_unittests on estelle and all the tests passed. 3. Run internal CQ and the CQ including cast_media_unittests passed. Change-Id: I380991235344348af56293ae214fb8c0e2be80b0 Reviewed-on: https://chromium-review.googlesource.com/c/1294190 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#601818}
-
Andrey Kosyakov authored
This is network service-only. Bug: 896924 Change-Id: I240d743089735c5a647112fb83c13081b55bd64b Reviewed-on: https://chromium-review.googlesource.com/c/1289962 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601817}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8241b8e3. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26581 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If08282d45c0947e9d5d6741856e8000cf3ca504f Reviewed-on: https://chromium-review.googlesource.com/c/1295175 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601816}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1868688a387..b4a228b2788a Created with: gclient setdep -r src-internal@b4a228b2788a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8fa506bef62b01e77e3d7ab8c90214416615ff1a Reviewed-on: https://chromium-review.googlesource.com/c/1295409Reviewed-by:
-
Lei Zhang authored
- Initialize members in the header. - Move static members / functions into an anonymous namespace. - Make a const char* array const. Change-Id: Iba2de156748c7618908b08031dca10f5c8ab1fdc Reviewed-on: https://chromium-review.googlesource.com/c/1294846 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#601814}
-
Eric Karl authored
We appear to frequently time-out the GPU channel when the appliction backgrounds (or is already backgrounded) during an attempt to establish a GPU channel. This change causes timeouts to be surpressed while the application is backgrounded Bug: 897272 Change-Id: I3bc6307f737b0847d54525071ea946ce4a92b38c Reviewed-on: https://chromium-review.googlesource.com/c/1292519Reviewed-by:
-
Timothy Loh authored
This CL adds a details pane in the file manager's .deb install dialog to provide package name, version, and a description of the package. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I43833f2ce83645ea45d6c9a30f7bd3acd89a9cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1167005Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601812}
-
David Tseng authored
Update the documentation to run brltty on linux as well. This is sometimes hard to [re]discover. Change-Id: Ia6cfefa2af9465762fc31c8077fec7310edca083 Reviewed-on: https://chromium-review.googlesource.com/c/1294512Reviewed-by:
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Ie198ab8247aa95cd1a3ead64d79bb94d66a853a0 Reviewed-on: https://chromium-review.googlesource.com/c/1295313Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#601810}
-
Evan Stade authored
This makes ShelfLayoutManager::UpdateVisibilityState correctly update state to SHELF_AUTO_HIDE, which triggers Shelf::AutoHideEventHandler, which already works without updates. Bug: 897968 Change-Id: Id2e5f785dbf24a0999088b13fe4971ee6758e32e Reviewed-on: https://chromium-review.googlesource.com/c/1295176Reviewed-by:
-
Bret Sepulveda authored
TabStripModel::IsNewTabAtEndOfTabStrip is called during a tab navigation and is intended to prevent the opener relationship of that tab from being forgotten if it returns true. However, GetURL was changed to return the visible URL (i.e. the one being loaded) instead of the last committed URL, so this would always fail. Also updates the associated test, which was not doing a navigation. Bug: 896929 Change-Id: I3f00e3f6f84da2986bab96b85aeb5eb04ef3cb21 Reviewed-on: https://chromium-review.googlesource.com/c/1292003 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Alexei Filippov authored
Do not use Number.p.toLocaleString as it recreates the formatter on every invocation. Change-Id: I5b98ed61e448ca867a1d5317ffc50e0066760b50 Reviewed-on: https://chromium-review.googlesource.com/c/1295311Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#601807}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/36623f65c39c..20f804166944 git log 36623f65c39c..20f804166944 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 tsepez@chromium.org Remove third arg to CFX_DIBitmap::LoadChannel() 2018-10-22 tsepez@chromium.org Consolidate app_*.in tests into app_methods.in Created with: gclient setdep -r src/third_party/pdfium@20f804166944 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I91bc803db8b443ecbaa45a723a99631ddf3d419e Reviewed-on: https://chromium-review.googlesource.com/c/1295289Reviewed-by:
-
