- 26 Jul, 2018 38 commits
-
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I93d8c963e2d40a409aab5985625659e39f3ffb87 Reviewed-on: https://chromium-review.googlesource.com/1150883Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#578172}
-
Matt Wolenetz authored
This is a reland of 61697367, which had been reverted in 9a4096be as part of reverting 568cc6a9 which had broken some builders. That CL has now been fixed and relanded (a9b7a993). This reland is the same as the original. Original change's description: > MSE: Log when MP4 keyframe-ness mismatches the compressed media > > Logs to chrome://media-internals when the container's keyframe metadata > for a frame mismatches the contents of that frame (if the latter was > determined by the respective bitstream converter's Analyze() > implementation, of whom only AVC currently does any keyframe analysis). > > BUG=860420,584384 > TEST=Repro crbug 860420 shows logs, new MP4StreamParserTest.AVC_Key* and media > > Change-Id: Ic87eab8726ad76b36b569df08ab2212b267008c2 > Reviewed-on: https://chromium-review.googlesource.com/1149153 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577751} TBR=sandersd@chromium.org Bug: 860420, 584384 Change-Id: I5a00819883e71ca9fd8c1a211956bdca66047b54 Reviewed-on: https://chromium-review.googlesource.com/1150541Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#578171}
-
Kyle Milka authored
Make custom backgrounds accessible via screen readers, keyboard navigation, and mouse navigation. For pure mouse-navigation hide all focus outlines. To make this work properly keyboard navigation of the dialogs is treated as the default. Opening a dialog with the mouse will force the UI into mouse-navigation, hiding focus rings until the user attempts to navigate using the keyboard (tab or arrow keys). Change the tabstops to align with recommendations from the a11y team. Most notably the entire tile container is now one tabstop and the individual tiles can then be navigated using the arrow keys. Bug: 858885 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I567552991777cd369fdfe456eda00a47383cf68f Reviewed-on: https://chromium-review.googlesource.com/1141167 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578170}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01ce05914f99..ad463c9517e3 git log 01ce05914f99..ad463c9517e3 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 ehmaldonado@chromium.org git-cl: Report known project urls. Created with: gclient setdep -r src/third_party/depot_tools@ad463c9517e3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386 TBR=agable@chromium.org Change-Id: I916e36750d4892c931a8be2a51a40a94d296c205 Reviewed-on: https://chromium-review.googlesource.com/1150055Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578169}
-
sczs authored
Bug: 862744 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4952bee3b44ccd9b9c3c564fab88dd5a7c18668 Reviewed-on: https://chromium-review.googlesource.com/1150904Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#578168}
-
Andrey Lushnikov authored
DevTools should initiate browser-side reload so that reload button doesn't change behavior with and without devtools open. R=dgozman Bug: 817413 Change-Id: Ia69070c82e7ea46e165c485081ab2fe965fae531 Reviewed-on: https://chromium-review.googlesource.com/1107118 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578167}
-
Yoichi Osato authored
This reverts commit d6ec8154. Reason for revert: Findit identified the culprit r577957 with confidence 100.0% in the config "chromium.mac / Mac10.11 Tests" Original change's description: > Enable FlingSchedulerMac > > Enable tests that were disabled because of this functionality missing. > > Bug: 842325 > Change-Id: I6f540460f4e5f81d7ff8dd36e4abf369f0bd4785 > Reviewed-on: https://chromium-review.googlesource.com/1149612 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577957} TBR=ccameron@chromium.org,jonross@chromium.org Change-Id: I4a38151ba5333ca99fb28c00f57f93f057f5fd4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842325, 867668 Reviewed-on: https://chromium-review.googlesource.com/1150946Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578166}
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaf96f48918f1a8556e3f7de94cc2f2470034245e Reviewed-on: https://chromium-review.googlesource.com/1149663Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578165}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb4b86975848..203b26f27d00 git log eb4b86975848..203b26f27d00 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 jiawei.shao@intel.com ES31: Translate compute shader HLSL system variables in compile time Created with: gclient setdep -r src/third_party/angle@203b26f27d00 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ide4416326f1c07a364fa09c07a33f3e42cfaf77c Reviewed-on: https://chromium-review.googlesource.com/1150370Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578164}
-
Darren Shen authored
For overscrolling, we calculate the overlap between the virtual keyboard and the window bounds of the render widget. This doesn't work for webviews used as dialogs, as the window of a webview is the same as its parent, which has a much larger size of the actual webview. We change the overscrolling code to compute the overlap based on the webview bounds rather than window bounds. Bug: 865774 Change-Id: I26c4e87215c2c168a8dc827f6d6b6859fdb6268c Reviewed-on: https://chromium-review.googlesource.com/1150012Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#578163}
-
Yuichiro Hanada authored
ash::Shell is created in PreProfileInit() step and ArcImeService is started in PostProfileInit() step, so it is safe to register FocusObserver in the constructor of ArcImeService. This CL also cleans up IsExoWindow() and IsArcWindow() in ArcWindowDelegateImpl. Bug: 866784 Test: browser_tests, components_unittests Change-Id: I3bd32f4e888f86cbd215791e559901e1457694e2 Reviewed-on: https://chromium-review.googlesource.com/1148089 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#578162}
-
sczs authored
RecentTabs was changed and it can now be opened from incognito, for this reason we now need to update restoreTabWithSessionID to make sure it always uses the non-incognito browserState. Bug: 866854 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc7147df943997a1f0784af926ac95cf9735fdaa Reviewed-on: https://chromium-review.googlesource.com/1150579Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Sara Kato authored
Dialog may be activated using ctrl+search+(d or m or h). Previously when using the accelerators on the signin screen, the dialog would be displayed after signing in. Bug: 860093 Test: Manual Change-Id: Idb8031d46951d80cd4f5dbcdb0af283b50bbb62d Reviewed-on: https://chromium-review.googlesource.com/1144581 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#578160}
-
Yuichiro Hanada authored
If ArcInputMethodManagerService fails to switch active IME in Android , active IME in Chrome OS should be switched to previous active IME automatically. Bug: 845079 Change-Id: Ibcdaf14db66459557c2bd0738d04d8ac44f0aa76 Reviewed-on: https://chromium-review.googlesource.com/1148308 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a5d2bf1131fe..91b8302dec04 git log a5d2bf1131fe..91b8302dec04 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 tsepez@chromium.org Use incomplete type CFX_BmpContext in place of void* 2018-07-25 thestig@chromium.org Change GetHeaderOffset() to return Optional<FX_FILESIZE>. 2018-07-25 hnakashima@chromium.org Create popup with Contents only for same annotations subtypes. Created with: gclient setdep -r src/third_party/pdfium@91b8302dec04 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856331 TBR=dsinclair@chromium.org Change-Id: I057ec93d3344dec364419351204f575254990b25 Reviewed-on: https://chromium-review.googlesource.com/1150368Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578158}
-
Andrew Moylan authored
Change-Id: Ibd4377f09450a4e235304d24a522150f2bb13158 Reviewed-on: https://chromium-review.googlesource.com/1150019Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578157}
-
Jiajia Qin authored
This CL adds the es31 header to command buffer. Meanwhile, we add the first API DispatchCompute to command buffer. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I77182ab07b597496839f9ca0f3f8562c6cfcf137 Reviewed-on: https://chromium-review.googlesource.com/1144789Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#578156}
-
David Black authored
When an input modality layout container is animating, it should not process events (e.g. click, press, etc.). Once it is fully visible, we re-enable event processing. This fixes a bug in which the mic icon in the keyboard modality layout container was failing to respond to click events. Bug: b:111768205 Change-Id: Ic03f40bd8d95affe0d228b2ce1aaebee85aedeab Reviewed-on: https://chromium-review.googlesource.com/1148656Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#578155}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1789af3378c..68300c270916 git log e1789af3378c..68300c270916 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@68300c270916 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I1b46d36e63a3a859c3c233968989b79232c9c535 Reviewed-on: https://chromium-review.googlesource.com/1150366Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578154}
-
Xida Chen authored
Right now the touch action rects are compute during the pre-paint tree walk, and we do account for the paint offset with regards to the layout object. However, when we project that to the graphics layer's coordinate space, we need to account for the paint offset of the graphics layer with regards to the layout object. We add a new layout test specially for this. Bug: 853912 Change-Id: I6054f564c7e3f71f6c4c874180802112b5dd37c4 Reviewed-on: https://chromium-review.googlesource.com/1149456Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578153}
-
sczs authored
After crbug.com/836562 was fixed it introduced crbug.com/860649. In order to solve this we need to keep track of which indexPaths are being inserted and if 2 items are inserted in the same indexPath we need to manually shift the previous indexPath row, if not we will end up with 2 insertions in the same indexPath and get a consistency crash. Because of this and the fact that we want to get rid of the initial insertion and search animations (crbug.com/859736) I decided to get rid of the historyInserter updates and just reloadData. We will still update individual rows for the status message and deletion when editing. Bug: 860649, 859736 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8c7488110441727be767ead22903700927f69d1 Reviewed-on: https://chromium-review.googlesource.com/1141127 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578152}
-
Kent Tamura authored
DecodeURLEscapeSequences() decoded some parts of an input string in UTF-8, and other parts of the string in isomorphic encoding. This behavior doesn't make sense, is harmful against browser interoperability, and is used only in 0.0013% of page views (only in scroll-to-fragment cases). DecodeURLEscapeSequences() is used in many code paths, and we have usage data only for scroll-to-framgnet. However this CL tries to remove this weird behavior entirely. Bug: 845824 Change-Id: Ib1cbbd3e1c26ebaaca7b3537b9732121835fdc9f Reviewed-on: https://chromium-review.googlesource.com/1146535Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#578151}
-
tzik authored
`new FailCaller` in oauth2_access_token_fetcher_immediate_error.cc may return a stale pointer if PostTask in its ctor failed, since base::Bind there increments the ref count, and the callback destruction releases it. This CL moves the PostTask after the completion of the ctor call. Bug: 866456 Change-Id: Id185e46292238955b3da9015903dfa6a8c94e7e9 Reviewed-on: https://chromium-review.googlesource.com/1146345Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578150}
-
Shenghuai Ji authored
In integrated mode, CronetEngine is allowed to use the shared network task runner by other Chromium-based clients (like webview, Chrome Android, Cronet) without self-initialization, which make it avaialbe to expose Cronet Java API in Chromium-based clients without creating 2 different network stacks. Besides, multiple CronetEngine instances could also share the same network stack in integrated mode. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I83678f78f420d033db2a0df75a9934abf4021465 Reviewed-on: https://chromium-review.googlesource.com/1136338 Commit-Queue: Shenghuai Ji <shenghuai@google.com> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#578149}
-
bsheedy authored
Implements a Python version of the robot arm control code using a Maestro servo controller. This will eventually replace the older Arduino-based version that requires new control code versions to be flashed onto the Arduino. Bug: 849341 Change-Id: Ib89e21984d9f73aa2637cb5444468ff000373c19 Reviewed-on: https://chromium-review.googlesource.com/1097697 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#578148}
-
Mike Wasserman authored
Re-enable several tests that were broken without this change: DesktopWindowTreeHostMusTest.Deactivate DesktopWindowTreeHostMusTest.StackAbove WidgetTestInteractive.ExitFullscreenRestoreState WidgetObserverTest.ActivationChange (WindowTree::SetFocus would fail and revert without a root window) (tests mayby passed flakily by not getting revert responses in time) Add logging; remove unused WidgetObserverTest widget; cleanup. Bug: 864614, 864615, 864618, 864800 Test: automated tests don't flake (passed 100+ runs for me) Change-Id: Idf34e6b4cae9a268eb580ecdbadb023da711b102 Reviewed-on: https://chromium-review.googlesource.com/1149087 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578147}
-
Tao Bai authored
Bug: 831271 Change-Id: Ib86785e129c7ca9398734fe582e0fa446a5c3cf2 Reviewed-on: https://chromium-review.googlesource.com/1150857Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#578146}
-
Tommy Steimel authored
This CL adds "content" to the list of URI schemes that we don't want to save into history. This fixes an issue where media opened via the MediaLauncherActivity were being saved into history. Bug: 864777 Change-Id: I4c438aace5a4da62fa73a958db79756c63391b2f Reviewed-on: https://chromium-review.googlesource.com/1150608Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
tzik authored
Add a missing dependency from web_applications/extensions to //chrome/common, as BookmarkAppDataRetriever uses chrome::mojom::ChromeRenderFrame. This should fix a flaky build error on bots: ../..\chrome/browser/web_applications/extensions/bookmark_app_data_retriever.h(12,10): fatal error: 'chrome/common/chrome_render_frame.mojom.h' file not found #include "chrome/common/chrome_render_frame.mojom.h" https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/71019 Change-Id: I3f2e71533551378681ef91cd402988b427c0d750 Reviewed-on: https://chromium-review.googlesource.com/1149665Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#578144}
-
Darren Shen authored
In the new virtual keyboard UI, the floating virtual keyboard has a an irregular shape. This is implemented by drawing the shape over a transparent background, so it looks like the window has the correct shape. However, clicking the transparent areas does not propagate to the window behind the keyboard, breaking the illusion. We add a new private extension API for setting a custom hit test area for the virtual keyboard from the IME extension. By using this API, the IME can specify the exact shape of the virtual keyboard so that events are propagated correctly based on the shape. Only the new UI will be calling this API, so nothing changes for the old UI (hit test area == window bounds). Bug: 866380 Change-Id: I38d9cc7f263d09cb3343be6d298667bdba7dd9ea Reviewed-on: https://chromium-review.googlesource.com/1147680 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578143}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9e4a06374b3..68936b1f34e6 git log d9e4a06374b3..68936b1f34e6 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 buildbot@webrtc.org Roll chromium_revision f2569c57..17efa884 (577860:577964) Created with: gclient setdep -r src/third_party/webrtc@68936b1f34e6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I36d0bf4685c28d85a8dbb9ed4415271459ee2449 Reviewed-on: https://chromium-review.googlesource.com/1150781Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578142}
-
Sergio Collazos authored
This reverts commit ccc23774. Reason for revert: After fixing the TableViewDisclosureHeaderFooterView constraints by using optional padding on a different CL, this change is causing issues on iPhoneX, will revert this CL. Original change's description: > [ios] Fixes cutoff Disclosure header subtitle label > > Changes the vertical stackView distribution to > UIStackViewDistributionFillProportionally,so the stackView > doesn't cut the subtitle label for lack of space. > > > Bug: 862744 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I524dacb378515088faae9e99c0db408ad3f9b4b0 > Reviewed-on: https://chromium-review.googlesource.com/1147541 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577401} TBR=kkhorimoto@chromium.org,edchin@chromium.org,sczs@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862744 Change-Id: I58feef6efd7bc449a6d06b531eb8c2c977af534b Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1150542Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#578141}
-
Quan Nguyen authored
Bug: 865520 Change-Id: I7a8a5539db8bf793abe086e1f02ff07a17a58ef8 Reviewed-on: https://chromium-review.googlesource.com/1148692 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#578140}
-
Saman Sami authored
It just means root surface doesn't exist or doesn't have an active frame so update the naming. Bug: 867594 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I42a4b5db05ef8168c31f6a2fd9b9694b8cf5200c Reviewed-on: https://chromium-review.googlesource.com/1150613Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#578139}
-
Peter Kvitek authored
Change-Id: Iaf007e192df6f094583545db9c18b60573404bb1 Reviewed-on: https://chromium-review.googlesource.com/1149414Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578138}
-
Darren Shen authored
The base class KeyboardUI doesn't call ShouldWindowOverscroll, so it doesn't really need to be on the base class. ShouldWindowOverscroll is only used by ChromeKeyboardUI, so we just move it to be a private method on that class. TBR=yhanada@chromium.org Change-Id: I5b95c83d64f6e2d8d2c8d50ac42bb34416a06aaa Reviewed-on: https://chromium-review.googlesource.com/1150014Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#578137}
-
Paul Miller authored
There were 4 mechanisms for enabling/disabling variations in WebView: - a command-line flag (mEnabledByCmd) - the AGSA experiment in m67 (mEnabledByExperiment) - the hard-coded setting (sVariationsAlwaysEnabled) - the hold-back experiment in m68 & m69 (sEnableState) Remove all of them, so that variations is always enabled. Set the hold-back experiment histogram, VariationsEnableState, to expire after m69. Don't mark it as obsolete yet, because we'll want to watch it for the lifetime of m68 & m69. BUG=851045 Change-Id: I44bd36789019074f422ec0c25be2afadba95b8c4 Reviewed-on: https://chromium-review.googlesource.com/1150772Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578136}
-
Miguel Casas authored
This CL homogeneises the if-else bracketing style in said file: these blocks get {} if either the condition or the body in either branch is > 1 line. Otherwise, no brackets. Simplified the logic of a few service methods too, and extracted the calculation of CanvasResourceProvider::ResourceUsage |usage| in GetOrCreateCanvasResourceProvider() so that it looks similar\ on both sides of the branch. No new functionality intended. Bug: 839970 Change-Id: I6e275a330f145aea861ae9344aa172ffc5840a27 Reviewed-on: https://chromium-review.googlesource.com/1150437 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578135}
-
- 25 Jul, 2018 2 commits
-
-
Nate Chapin authored
* Have a single public constructor, instead of separate constructors for sync and async requests. This means sync requests now need to call Start(). * Determine sync/async based on the ResourceLoaderOption parameter's synchronous_policy * Before this change, the constructor took a ThreadableLoaderOptions parameter, which was just a single-member struct for setting a timeout. Remove the unnecessary struct wrapper, and change the timeout from an unsigned long specifying the timeout in milliseconds (where 0 means no timeout) to a base::Optional<TimeDelta>. TBR=peter@chromium.org,yhirano@chromium.org Change-Id: If312cfeec7494a8f74ca28992e2688eec8e923a1 Reviewed-on: https://chromium-review.googlesource.com/1150570 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#578134}
-
Vladimir Levin authored
This patch ensures that if we've changed mix-blend-mode property, then we call SetNeedsPropertyTreeUpdate. R=pdr@chromium.org Bug: 867403 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcd6e54c1d6ca3db0d0e088038cc144def2789b8 Reviewed-on: https://chromium-review.googlesource.com/1150687 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
-
