GitLab

This patch copies "FrameSelection.{cpp,h}" to "SelectionEditor.{cpp,h}" as
a preparation of moving |FrameSelection::modify()| to |SelectionEditor| class
for inheriting change history.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes
NOTRY=true

Review URL: https://codereview.chromium.org/1331543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ScriptPromiseProperty to return same promise every time, until the
FontFaceSet switches from loaded to loading state. This is in line with
the spec, and also simplifies the code a bit.

TEST=fast/css/fontfaceset-ready.html
BUG=510434

Review URL: https://codereview.chromium.org/1313853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes "move-by-line-006.html" to use "monospace" font instead of
"Ahem" font to mitigate flakiness on local Windows desktop.

When I run "move-by-line-006.html" on local Windows desktop, it is flaky, e.g.
failed on parallel test execution but succeeded on single execution.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1314643006

git-svn-id: svn://svn.chromium.org/blink/trunk@201856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@7e34e95043bc21d087cd3e4d96e39050dea4a601
imported web-platform-tests@32ba9293b8e933dc7d2c2521eedac32ec86f457b

* css-writing-modes-3
  - 1 removed file removed from W3CImportExpectations.
  - 8 files renamed.
  - 1 test bug fixed in upstream and now pass.

* shadow-dom
  - 1 test updated, still fail.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org
BUG=492664, 505364

Review URL: https://codereview.chromium.org/1308393009

git-svn-id: svn://svn.chromium.org/blink/trunk@201855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves an implementation of |LayoutView::commitPendingSelection()| to
|PendingSelection::commit()| as a preparation of moving it to "editing/",
for reducing exposing editing functions to layout layer.

Following patch will move |PendingSelection| to "editing/".

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315423006

git-svn-id: svn://svn.chromium.org/blink/trunk@201854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1329763004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1329023002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528177

Review URL: https://codereview.chromium.org/1315983010

git-svn-id: svn://svn.chromium.org/blink/trunk@201851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Initialize simple members in header files
* Mark const members as such
* Range-based iteration over containers
* Remove unused typedefs
* Use nullptr instead of 0

No behavior change.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1323323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch:
- Use WI.SourceMap.Entry instead of an array tuples.
- Establish correct reversed mappings

BUG=527993,463023
R=pfeldman

Review URL: https://codereview.chromium.org/1328843002

git-svn-id: svn://svn.chromium.org/blink/trunk@201848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes constructBidiRunsForLine() to handle the nested
'unicode-bidi: isolate' runs with the correct containing isolate.

crbug.com/274717 fixed the nested case by updating currentRoot to the
root of the last nested runs. While this fixed simple cases, it does
not set the correct root when nested in multiple levels.

The wrong root can let highestContainingIsolateWithinRoot() to find
ancestors up to the root elements. This will find ancestors that were
already processed, and results in an infinite loop.

BUG=520282

Review URL: https://codereview.chromium.org/1328633002

git-svn-id: svn://svn.chromium.org/blink/trunk@201847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was inadvertently added in this CL:
  https://codereview.chromium.org/1318963006

TBR=chrishtr@chromium.org
BUG=527617

Review URL: https://codereview.chromium.org/1303043005

git-svn-id: svn://svn.chromium.org/blink/trunk@201846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527681

Review URL: https://codereview.chromium.org/1312033008

git-svn-id: svn://svn.chromium.org/blink/trunk@201844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently it affects all iframes, but only the main resource.

BUG=

Review URL: https://codereview.chromium.org/1328763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add inline style in the element's scope. (patchset #1 id:1 of https://codereview.chromium.org/1322753006/ )

Reason for revert:
This caused regression.
https://code.google.com/p/chromium/issues/detail?id=528370


Original issue's description:
> Add inline style in the element's scope.
> 
> Style attribute declarations were added in a separate scope after all
> other author origins. Instead add style attribute declarations right after
> collecting matching rules from the element's scope. This means that we can
> override values set on the style attribute from outer scopes, like we can
> with values from inner scope's stylesheet.
> 
> Without this fix, you would get green on orange below:
> 
> <style>html /deep/ span { color: green; background-color: lime }</style>
> <host>
>   <host:root>
>     <style>span { color:red }</style>
>     <span style="background:orange">Green on orange?</span>
>   </host:root>
> </host>
> 
> With this change, we will get green on lime.
> 
> The regression (issue 526634) was not relying on this, but it would be
> more complex code to fix the regression without fixing the style attribute
> cascading order.
> 
> R=kochi@chromium.org,hayato@chromium.org
> BUG=526634
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201620

TBR=hayato@chromium.org,rune@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526634

Review URL: https://codereview.chromium.org/1329013002

git-svn-id: svn://svn.chromium.org/blink/trunk@201842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527617

Review URL: https://codereview.chromium.org/1318963006

git-svn-id: svn://svn.chromium.org/blink/trunk@201840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The methods are logically const (besides setData, which was left
unchanged). The mutable fields are merely caches, to make subsequent
nearby accesses (which are likely) faster.

Make BMP methods using FastSharedBufferReader const.

BUG=439655

Review URL: https://codereview.chromium.org/1309363006

git-svn-id: svn://svn.chromium.org/blink/trunk@201839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was walking the children of the root (usually the <head> and <body>) on
every call even if nothing was dirty. This meant each call was 5 branches
plus a trace macro, the macro often being more expensive than the no-op work.

Lets instead abort early if nothing is dirty and skip the trace macro when
possible to avoid polluting traces with trace overhead spam.

BUG=527982

Review URL: https://codereview.chromium.org/1328013002

git-svn-id: svn://svn.chromium.org/blink/trunk@201838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- introduce ResourceTreeModel.{suspendReload,resumeReload} to temporarily
    suspend page reloading;
- use the former to disable page reload for the period we fetch trace in
    the network FilmStripRecorder, as we can't start tracing while
    still retrieving traces;
- disregard DeferredTempFile writes after file was deleted;
- properly indicate frames are being recorded in FilmStripView when reload
    happens during frame recording.

This gets rid of "Tracing is already started" and other errors while repeatedly
reloading a network panel with screenshot recording on.

BUG=

Review URL: https://codereview.chromium.org/1314783010

git-svn-id: svn://svn.chromium.org/blink/trunk@201837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By default, pass the data as a single, pre-merged SharedBuffer, to imitate
decoding an image whose encoded data is stored in the Blink MemoryCache.

Add an option (supplied by a command line flag) to supply the data in chunks.
This simulates network traffic. It also allows us to better evaluate the
impact of calling SharedBuffer::data() in every call to decode.

TBR=tkent@chromium.org
BUG=467772

Review URL: https://codereview.chromium.org/1318713005

git-svn-id: svn://svn.chromium.org/blink/trunk@201836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The GN optimization config setup is being moved. This patch allows blink to switch between the new and old ones.

Review URL: https://codereview.chromium.org/1330693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=295792

Review URL: https://codereview.chromium.org/1323613005

git-svn-id: svn://svn.chromium.org/blink/trunk@201834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1310923003

git-svn-id: svn://svn.chromium.org/blink/trunk@201833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is valid to do this:

linearRampToValueAtTime(0, 1);
setValueCurveAtTime(curve, 1, 1);

Previously, this caused an error because the code thought the two
methods overlapped.

BUG=528423
TEST=audioparam-setValueCurve-exceptions.html updated with more tests

Review URL: https://codereview.chromium.org/1328963003

git-svn-id: svn://svn.chromium.org/blink/trunk@201832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528186

Review URL: https://codereview.chromium.org/1313223005

git-svn-id: svn://svn.chromium.org/blink/trunk@201831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201813

BUG=524134
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1317353008 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a long-standing bug where crashing reftests would not
show some crash logs on the layout tests results page.

single_test_runner.py has an optimization to not run reftests when
the base test crashes. This optimization accidentally failed to write
crash logs (done through write_test_result(...)) as well. This patch
fixes this bug and adds a small test.

This is a reland of https://codereview.chromium.org/1312693002 which
was rolled out due to crashes on Win10 (see http://crbug.com/524248#50).
This patch has two potential fixes for the crashes seen before:
1) test results are only written for crash tests, not timeouts.
2) The non-null expected_driver_output is used in the call for
write_test_result instead of reference_output which is null and
caused asserts.

Review URL: https://codereview.chromium.org/1313533004

git-svn-id: svn://svn.chromium.org/blink/trunk@201827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527138
R=benjhayden@chromium.org,dsinclair@chromium.org

Review URL: https://codereview.chromium.org/1305043007

git-svn-id: svn://svn.chromium.org/blink/trunk@201825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutBlocks delay updating their scrolling information until the
uppermost flex box has finished layout.  However, if the flex item
has overflow:auto, this means that the scrollbar width is not
included in the flex item's logical height during flexing.  This
leads to spurious scrollbars in the flex direction.

The original reason for delaying the update of scrolling information
was to fix a bug where scroll positions would be lost when a flexbox
changed:

https://bugs.webkit.org/show_bug.cgi?id=97706

For better or worse, this also turned out to be a performance
optimization (albeit at the expense of correctness).  Updating the
scroll information can cause a block to run layout again, if the
existence of scrollbars has changed for the block.  If a block in a
nested hierarchy of flexboxes runs layout N times during flexing, it
would then potentially run one additional layout at the end of
flexing, for a total of N+1.  However, if the the optimization is
removed (i.e., scroll info updating for the flex item is not delayed, but
run immediately at the end of layout, potentially triggering a second
layout if scrollbars changed), then the potential maximum number of
layouts during flexing is N*2.

This patch fixes the correctness issue while preserving the
optimization: when a flex item runs layout, and its scrollbars have
changed, it immediately adds the size of the scrollbars to its
logical width/height, but defers the second layout until flexing is
finished.  The implementation splits the existing code from
DeprecatedPaintLayerScrollableArea::updateAfterLayout() into the
methods updateScrollDimensions, which is called immediately at the
end of layout; and finalizeScrollDimensions, which is called at the
end of flexing.  When layout happens outside the context of flexing,
the two methods are called in immediate sequence, preserving existing
behavior.

BUG=512229
R=ojan@chromium.org,cbiesinger@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1295933003

git-svn-id: svn://svn.chromium.org/blink/trunk@201824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test didn't need to setTimeout, so lets speed it up by 10+ms.

TBR=estaab

Review URL: https://codereview.chromium.org/1312903016

git-svn-id: svn://svn.chromium.org/blink/trunk@201823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

command buffer side CL: https://codereview.chromium.org/1319453010/

BUG=527249
TEST=conformance2/state/gl-object-get-calls.html related parts pass
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/1303343009

git-svn-id: svn://svn.chromium.org/blink/trunk@201822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Suppress failures on fixed-img-src-change-after-scroll.html and background-image-paint-invalidation.html

BUG=528431
TBR=wangxianzhu
NOTRY=true

Review URL: https://codereview.chromium.org/1331483002

git-svn-id: svn://svn.chromium.org/blink/trunk@201821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For all display items for one object, if we check for interect rect
intersection and early return, we must use the same rule. Otherwise,
we may generate display item A but not display item B in some cases;
and once we generate display item B again, we'll mistakenly generate
CachedDisplayItem for it because we think the object is validly cached.

Table cell may generate more than two display items for backgrounds,
one drawing backgrounds from containers, one drawing its own background.
Previously they use different early return rules.

Now let them use the same rule (BlockPainter::isVisibleInPaintRect()).

Also add DisplayItem::TableCellBackgroundFromContainers because the
display items are issued by TableSectionPainter which doesn't know if
TableCellPainter::paint() would use the phase for other display items.

BUG=522338
TEST=DisplayItemListPaintTest.TableCellBackbroundInterestRect

Review URL: https://codereview.chromium.org/1312493007

git-svn-id: svn://svn.chromium.org/blink/trunk@201820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch marks fast/repaint/fixed-in-page-scale.html as timing out on
windows. For more information, see the bug.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Frepaint%2Ffixed-in-page-scale.html&showExpectations=true

TBR=bokan
BUG=528421
NOTRY=true

Review URL: https://codereview.chromium.org/1301423007

git-svn-id: svn://svn.chromium.org/blink/trunk@201819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521663
TEST=this is a test only change
r=japhet@chromium.org

Review URL: https://codereview.chromium.org/1302333003

git-svn-id: svn://svn.chromium.org/blink/trunk@201818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This may be helpful when we call showDebugData() during the merge
algorithm.

Review URL: https://codereview.chromium.org/1323263002

git-svn-id: svn://svn.chromium.org/blink/trunk@201817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added class level comments to DeprecatedPaintLayerClipper
and DeprecatedPaintLayerStackingNode.

While touching DeprecatedPaintLayerStackingNode, added a comment
about NormalFlowChildren.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201805

Review URL: https://codereview.chromium.org/1327483003

git-svn-id: svn://svn.chromium.org/blink/trunk@201815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change adds some documentation about how we structure <table>
internally. In particular, it explains LayoutTable::m_column and
LayoutTableSection::m_grid  and the role of LayoutTable as a grand
coordinator for determining the table structure.

It's still missing some pieces but it's a good start and will be
completed as I clear my thoughts on the code.

Review URL: https://codereview.chromium.org/1319453009

git-svn-id: svn://svn.chromium.org/blink/trunk@201814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ensures test coverage of repaint tests for spv2.

paint/invalidation/spv2/resources/convert.sh is a semi-automatic tool to
convert an text-based-repaint test to a spv2 paint invalidation test.

See https://codereview.chromium.org/1324763002/ for details about spv2 paint
invalidation test.

Removed fast/repaint and compositing/repaint as spv2 virtual suites.
Run paint/invalidation/spv2 as spv2 physical suite.

BUG=524236,524134,527242

Review URL: https://codereview.chromium.org/1302183007

git-svn-id: svn://svn.chromium.org/blink/trunk@201813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove obsolete WebThread::Task class.

Patch 1: https://codereview.chromium.org/1325073002
Patch 2: https://codereview.chromium.org/1308183005
Patch 3: https://codereview.chromium.org/1303153005
Patch 4: https://codereview.chromium.org/1309423004

BUG=510398, 497761

Review URL: https://codereview.chromium.org/1310253009

git-svn-id: svn://svn.chromium.org/blink/trunk@201812 bbb929c8-8fbe-4397-9dbb-9b2b20218538