- 19 May, 2020 40 commits
-
-
Sean Harrison authored
Bug: 1032584 Change-Id: I2fc56e7c318d35e5cb61888a5d7429437ed1c162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209072 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#770135}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b9216562504..719446c0dbbd 2020-05-19 tvanderlippe@chromium.org Include workaround for TypeScript compiler bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1081686 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaa1c4488e69ceadf37e72976256d08dc13b49c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770134}
-
Chris Harrelson authored
The code landed in 2016, has never shipped, and was abandoned last year (see issue 535803). Bug: 535803 Change-Id: Ia434742eccef8f35e541c1330bbd947f6d78bc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208175Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#770133}
-
Devlin Cronin authored
Wire up the new SettingsOverridden extension dialog views for use with search settings overrides. When an extension overrides search settings, this allows us to display a dialog instead of a bubble. Add a method to provide the parameters for a search-oriented version of the dialog, as well as an end-to-end UI test displaying the dialog when an extension overriding search is installed. As with the other versions of the SettingsOverridden dialog, this is guarded behind the ExtensionSettingsOverriddenDialogs feature flag. Bug: 1079364 Change-Id: I183bc4d923a567771476fc7289e792f20fd3884c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199680Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770132}
-
Eugene But authored
NavigationItemImpl uses empty GURL in place of "virtual URL" if "virtual URL" is the same as "URL". So there is no need to store "virtual URL" in the session storage and use more memory than necessary. This CL does not store "virtual URL" if it's the same as "URL". Create computed CRWNavigationItemStorage.virtualURL getter to make sure that clients always get non-empty virtualURL if URL was stored. Bug: 1082279 Change-Id: Ib85e2a6c0ccb1c2e2bbd45c24be7de6980843c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204673 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#770131}
-
Liquan (Max) Gu authored
Context: ExpandablePaymentHandler UI has its own custom scrim life cycle[1]. This makes it BottomSheetManager skips the tab obscuring. According to BottomSheetManager's design, when a bottom-sheet has its own custom scrim life cycle, it would be its responsibility to obscure the tab. Since ExpandablePH did not do that, the tab content was still accessible to the screen readers though under scrim. This CL is to fix this issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1935431 [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java;l=81;drc=2a14a0a548cdb5b8650e444fd96e2a04be6a39a5 Before: Talkback, Select-to-speak would read the content behind the payment sheet. After: Talkback, Select-to-speak no longer read the content behind the payment sheet. Change: * Obscure the tab when payment sheet shows up. * Move the PaymentRequestImpl's scrim into PaymentHandlerCoordinator. Bug: 1046973, 1082294 Change-Id: Ib82769502290076e785e941e326d2bd3eed28ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198681Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770130}
-
Tom Anderson authored
Some X11 APIs take a "variant" of two or more types. Eg. GetGeometry takes a drawable which can be either a window or a pixmap. To more easily deal with these types without having to cast, this CL changes these types to be structs with implicit conversion operators to and from their underlying types. Eg. drawable now gets generated like this: struct Drawable { Drawable() : value{} {} Drawable(Window value) : value{static_cast<uint32_t>(value)} {} operator Window() const { return static_cast<Window>(value); } Drawable(Pixmap value) : value{static_cast<uint32_t>(value)} {} operator Pixmap() const { return static_cast<Pixmap>(value); } uint32_t value; }; BUG=1066670 R=msisov CC=sky Change-Id: Ief6c2fe49973c59502d529e6f9991719a98b7d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208255Reviewed-by:Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#770129}
-
Elly Fong-Jones authored
This change moves BubbleDialogDelegateView from inheriting from DialogDelegateView (which itself inherits from DialogDelegate and View) to inheriting from DialogDelegate and from View. BDDV = BubbleDialogDelegateView BDD = BubbleDialogDelegate (doesn't yet exist) DDV = DialogDelegateView DD = DialogDelegate WD = WidgetDelegate V = View This CL is the first step in this process: 1. BDDV inherits from DD & V 2. Break BDDV into BDD (which inherits from DD) and BDDV (which inherits from both), like the current DD/DDV split 3. For each client class that subclasses BDDV, move that class to subclassing View and containing a BDD member, which is used when a BDD, DD, or WD is needed. 4. Delete BDDV itself 5. Repeat (3) for DDV instead of BDDV 6. Delete DDV itself 7. Remove any remaining subclasses of BDD or DD Note that this involves temporarily duplicating some logic between DDV and BDDV which was previously inherited from DDV. Bug: 1075649, 1011446 Change-Id: Iab5e46fed0887eda75a3c6585570f666b362161f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208073 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770128}
-
Tim van der Lippe authored
These tests are sniffing on internal methods that are changing in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2207238 They need to be updated after DevTools rolls into Chromium to use the object notation instead. TBR=sigurds@chromium.org Bug: 1011811 Change-Id: Ib9a75c917d77f8e3f06d079c0a4f309f2057c1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207463Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#770127}
-
Antonio Sartori authored
When a resource was being blocked because of a Content Security Policy violation after a redirect happened, we were using the final URL (after the redirect) in the CSP reporting. This is a security issue, since it could expose confidential information such as a token contained in the redirect URL. As stated in https://w3c.github.io/webappsec-csp/#create-violation-for-request ("We use request's url, and not its current url, as the latter might contain information about redirect targets to which the page MUST NOT be given access."), whe should instead report the request's original URL. Bug: 932892 Change-Id: I1864e6e9e4cc266615e49276012ba7f9d96672f7 Fixed: 932892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181363Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#770126}
-
Sylvain Defresne authored
There is no correct default value for this variable, so leave it blank and force developer to configure them if they enable the codesigning. Bug: none Change-Id: I60b877226d6efed32f0ca99301d97b48559e6f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198780 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770125}
-
Antonio Gomes authored
Target interfaces are blink.mojom.RemoteFrame and blink.mojom.LocalFrame. Similarly to blink::RemoteFrame, blink::LocalFrame adds a map of its instances, hashed by each frame's base::UnguessableToken. R=avi@chromium.org, dominickn@chromium.org, dtapuska@chromium.org Bug: 1051144 Change-Id: I1b8895f64b57c3637ffda45b1e55065c4b34273a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207618 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#770124}
-
Alex Gough authored
The default type is kUtility. It seems the buildflag for this code is not specified frequently as the type changed a while back. Bug: 1065087 Change-Id: I31c053343701bf4e626acabbc3311a3d8eb7a9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207758Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#770123}
-
Marc Treib authored
The Sync USS migrator itself isn't really needed anymore and will be removed soon, so no need to keep these histograms around any longer. Bug: 1084057 Change-Id: I535ba01ddf809622516ebc718770740addbc55fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208975Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Etienne Pierre-doray authored
Forwarding calls to base::PostJob and mapping priority. Bug: 1012816 Change-Id: I5a56f38fcb4bb28dd89db9e50ddcba07312bdc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036387Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#770121}
-
Daniel McArdle authored
Bug: 1084214 Change-Id: I0a10324c305438d01873cf1415c35ffc94e597a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207757 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#770120}
-
Greg Daniel authored
Bug: skia:10118 Change-Id: I46b7cd461741280e869be4fb853b68c09bc72c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207411Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#770119}
-
Sean Harrison authored
Add ImprovedCookieControls to the experiment Bug: 1032584 Change-Id: I430f52ed7f2fc786d8ccd7aae21619b8496a7c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207166 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
-
Stephen McGruer authored
These are symptomatic of crbug.com/1047818, but to stop the pain for sheriffs lets mark them timeout=long for now. TBR=lpz@chromium.org Bug: 1084362 Change-Id: I737edb4278733698833765e7dbe92d345539e0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207863Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#770117}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48b827981322..e9cd6177eb21 git log 48b827981322..e9cd6177eb21 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 peah@webrtc.org Add ability for audioproc_f to operate on any AudioProcessing object. Created with: gclient setdep -r src/third_party/webrtc@e9cd6177eb21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifa94ce2d0a7bf29ddda99b8086d2c3df7720b79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208956Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9e4db33a563e..7b9216562504 git log 9e4db33a563e..7b9216562504 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 sigurds@chromium.org Convert TextUtils.ContentProvider.DeferredContent to tagged union 2020-05-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@7b9216562504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6cf6831384a05fdc8ae2b348ac2caf54c2bdd9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208955Reviewed-by:
-
Peng Huang authored
The problem is because we assume work submit to vulkan device queue should be done, when a done callback of a following skia flush() call is invoked. But the done callback could be called immediately, if there is no work to flush. Fix the problem by removing dcheck, and handling the fence is not ready situation properly Bug: 1083462,1078702 Change-Id: I1f1d7401bf34bf25ae8980fee7c946e8ad257073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207523 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/efeaf3d8..d59fe391 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie6ecc3aeb803a56deff0d9f8cf3e29eafd71028d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208917Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770113}
-
Vasiliy Telezhnikov authored
UpdateRotatedVisibleSize and OnFrameAvailable are not ordered, so the situation possible when we'll try to get coded size from TextureOwner without knowing natural size. For StreamTexture path it will produce bad values. This CL fixes this by delaying sending first OnFrameWithInfoAvailable till MediaPlayer will report size via UpdateRotatedVisibleSize. Bug: 1081695, 1076564 Change-Id: I02b24a6fdc9ee83a2f0be1cb9ac7c8cfb7d8910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204309Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#770112}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6c8c8930be5e319f2bf498851e7e3111f38a55b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208957Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b6da71c6. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I5a8309eaaeb86683eaa0472a80d147b7b35e4cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208633Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770110}
-
Mason Freed authored
This policy allowed Enterprise users to opt back in to the "legacy" form control look and feel for several milestones. It was supported until M84, which has now branched for Beta. Bug: 1054511 Change-Id: Ib1bab9d3a1d87254eebe763aceca42370cb34497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204300 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 1070303 Change-Id: Ie683f7b5a52b2a20f1bd3d1085ef6f415b3f783d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160028Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#770108}
-
Yunke Zhou authored
1. Change the optional diagnostic and usage data on EULA screen to checkbox instead of a toggle 2. Change the checkbox style (padding, alignment) on ARC TOS to follow the feature specs Bug: 878474 Change-Id: Ica7bcb51c8ed0c0baae88859a775e165822162b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205934Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#770107}
-
Roman Sorokin authored
Also removed redundant WizardControllerTest::WaitUntilJSIsReady - waiting is done in the OobeBaseTest. Bug: 904841 Change-Id: I82e3d04215033231f9d1bfaf41e7b93c92eee207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190638Reviewed-by:
-
Geoff Lang authored
Tbr: shrekshao@google.com No-Try: True Bug: 1018028 Change-Id: I5e3cbca86405981ca8a41576c4b27ee11626e18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208537Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770105}
-
Side Yilmaz authored
This CL fixes wrong usages of profile at EditorDialog and unsafe usages of profile at PaymentRequestImpl. Currently, both classes uses regular profile always that is not correct, while by this CL regular or incognito profile will be used. Since settings always runs with regular profile, all setting classes use |Profile#getLastUsedRegularProfile|. For other classes, profile is created by WebContents that may give regular or incognito profile depending on the context. Bug: 1041781, 1048632, 1075562 Change-Id: If1bf77dd5a5b0c0bae5a73a38c05863d8ce3cbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201597Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770104}
-
David Bienvenu authored
This is needed for Mohnstrudel. Bug: 229301 Change-Id: I1181c510e8d42635a697666b9254481d9452dad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207935Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770103}
-
Andrew Grieve authored
Rather than silently not deobfuscating things. Bug: 1081438 Change-Id: I263956d55b819db8a5c0dce269687e9d44c56d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204969Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#770102}
-
Andrew Grieve authored
This reverts commit aedd4a45. Reason for reland: Use imap() rather than imap_unordered() Original change's description: > Revert "Android: Use non-dummy multiprocessing in compile_resources.py" > > This reverts commit fbbdb5fe. > > Reason for revert: Causing badging issue: crbug.com/1082741 > > Bug: 1082741 > > Original change's description: > > Android: Use non-dummy multiprocessing in compile_resources.py > > > > Will be more relevant if we use more arsc filters. > > Even so, speeds up command on my machine: 10.3s -> 7.7s > > > > Bug: 636448 > > Change-Id: I9b3db23782282e3e13c613b0b64ff1375fb1422d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186756 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#766469} > > TBR=huangs@chromium.org,agrieve@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 636448 > Change-Id: I46916d8d8dbc4e00b004883734924bf49c01c1d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202520 > Reviewed-by: Ben Mason <benmason@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768919} Bug: 1082741, 636448 Change-Id: Ib66cd41cf2d31dd57c5e6462d5c1a2d40f0455f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204966Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#770101}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d077e6a3d013..ca76920e7875 2020-05-19 bsalomon@google.com Split bleed GM into two: one tests kStrict and tests kFast. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I7122736c087eef16d44ef84d84ca929d0365b89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208952Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/612fae5937af..90ec1ccfec93 Created with: gclient setdep -r src-internal@90ec1ccfec93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: I9cbcc96055985b70449b159f1ea1b6d44a1e14a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208668Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770099}
-
Pavol Marko authored
This CL makes CertificatesHandler handle the refreshCertificateProvisioningProcesses and triggerCertificateProvisioningProcessUpdate commands from the certificate manager webui. CertificatesHandler collects information about the in-progress certificate provisioning processes and passes them to the Web UI using the "certificate-provisioning-processes-changed" event. Bug: 1045895, 1081396 Change-Id: Id9745caa63020e9c950c0fe3a5c64cf4258f8fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199463Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770098}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I81bd4927aff86683d834df4f7ae2d0b2d0c7b331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185400Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#770097}
-
ckitagawa authored
While there was a NewApi lint outage a new method was added to MultiWindowUtils that should have been annotated with TargetApi. This CL adds the missing annotation and adds a check to make sure this won't cause a crash if called from a pathway on a lower API version. Bug: 1081242 Change-Id: Idd54a73d849daadd5ab915158d10be43f5dc6fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199718Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
