GitLab

'HTMLTreeBuilderSimulator' doesn't currently understand that we shouldn't
hop into PLAINTEXTState or RAWTEXTState inside '<select>' elements. This
has the unfortunate side-effect of enabling dangling markup injection
attacks that exfiltrate data via '<select><option><plaintext>' and etc.

This patch ensures that `<select>` behaves as specified, matching Safari,
Firefox, and Edge's behavior.

Thanks to @zcorpan for pointing out Blink's error in the thread ad
https://github.com/whatwg/html/issues/2252.

BUG=680072

Review-Url: https://codereview.chromium.org/2625103002
Cr-Commit-Position: refs/heads/master@{#443573}

The NoStatePrefetchTTFCP are obsolete and don't conain any useful data.
They have been replaced by PrefetchTTFCP histograms.

Review-Url: https://codereview.chromium.org/2628173004
Cr-Commit-Position: refs/heads/master@{#443572}

The symbol reading logic of google::FindSymbol was reading symbols in
blocks of N, not accounting for that a section might not have a multiple
of N symbols in it.

This makes it read in blocks of N or the number of symbols remaining,
whichever is smallest.

BUG=672481

Review-Url: https://codereview.chromium.org/2566623003
Cr-Commit-Position: refs/heads/master@{#443571}

There appears to be a Mac related failure on the FYI bots.
Disabling SwiftShader tests on Mac for now.

BUG=630728, 680820
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2629403002
Cr-Commit-Position: refs/heads/master@{#443570}

Review-Url: https://codereview.chromium.org/2629603005
Cr-Commit-Position: refs/heads/master@{#443569}

RequestTrackerImpl::CancelRequests clear the content of
live_requests_ but no object are ever added to that set
and so is obsolete.

BUG=585700

Review-Url: https://codereview.chromium.org/2622393004
Cr-Commit-Position: refs/heads/master@{#443568}

This CL removes several layout tests from teh filter that are now
working. Making this is no try since there are no code changes and the
filter is only used on an FYI bot.

BUG=551000
TBR=arthursonzogni@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2635513002
Cr-Commit-Position: refs/heads/master@{#443567}

Revert of Change the keyboard bounds when moving to another display. (patchset #3 id:40001 of https://codereview.chromium.org/2620273002/ )

Reason for revert:
This CL is causing Win10 Tests x64 to fail keyboard_unittests on windows-10-10586

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/7528

Original issue's description:
> Change the keyboard bounds when moving to another display.
>
> BUG=303429
> TEST=Manual test by the instruction described in the issue.
>
> Review-Url: https://codereview.chromium.org/2620273002
> Cr-Commit-Position: refs/heads/master@{#443382}
> Committed: https://chromium.googlesource.com/chromium/src/+/28bbd7f5406de93446143d93f4b8056267ef8fbf

TBR=bshe@chromium.org,yhanada@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=303429

Review-Url: https://codereview.chromium.org/2629233003
Cr-Commit-Position: refs/heads/master@{#443566}

https://skia.googlesource.com/skia.git/+log/aeef5610d7a3..7adde145d391

$ git log aeef5610d..7adde145d --date=short --no-merges --format='%ad %ae %s'
2017-01-11 joel.liang Optimize SkBlend by using NEON intrinsics
2017-01-13 mtklein Attempt 3: SkRasterPipelineBlitter: support A8

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2628923005
Cr-Commit-Position: refs/heads/master@{#443565}

BUG=679108

Review-Url: https://codereview.chromium.org/2625373002
Cr-Commit-Position: refs/heads/master@{#443564}

https://chromium.googlesource.com/angle/angle.git/+log/b4533de..6a6b09c

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2626073008
Cr-Commit-Position: refs/heads/master@{#443563}

Page state and context menu tests were disabled and have more
specific bugs than the TODO contains.

BUG=675015,675399,675247

Review-Url: https://codereview.chromium.org/2623333004
Cr-Commit-Position: refs/heads/master@{#443562}

This CL cleans up the menu implementation.

First, it removes the burden of dismissing the menu when non-menu
screen areas are tapped from the menu view controller. The menu
presentation controller does this, having been handed a ToolbarCommands
object to use for this.

Second, TabContainerViewController implements ZoomTransitionDelegate,
passing the call into the toolbar view controller if it can. It also
uses that information to implement MenuPresentationDelegate such that
the menu is positioned with one corner over the zoom location used for
the menu.

BUG=

Review-Url: https://codereview.chromium.org/2603783002
Cr-Commit-Position: refs/heads/master@{#443561}

The account full name might not have been fetched yet. Show the user
email in the meantime.

BUG=656994

Review-Url: https://codereview.chromium.org/2628313003
Cr-Commit-Position: refs/heads/master@{#443560}

Plumb a viewport intersection rect from a parent frame to any out of
process iframes that it embeds, and allow IntersectionObserver to
account for that rect when it computes viewport intersection.

This modifies LayoutView::MapToVisualRectInAncestorSpace and
mapLocalToAncestor to treat null ancestor pointers at implicit
references to the root frame, even if the root is remote.

For testing this enables the Intersection Observer layout tests that
were disabled with the --site-per-process flag.

BUG=615156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2431473003
Cr-Commit-Position: refs/heads/master@{#443559}

This is now available in Material Roboto Font Loader directly.

BUG=673904
R=marq@chromium.org

Review-Url: https://codereview.chromium.org/2629543009
Cr-Commit-Position: refs/heads/master@{#443558}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4bd198f6a85c..e6b04fef1997

$ git log 4bd198f6a..e6b04fef1 --date=short --no-merges --format='%ad %ae %s'
2017-01-13 hjd [Telemetry] Support specifying container element for action_runner.ScrollToElement API

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2629893002
Cr-Commit-Position: refs/heads/master@{#443557}

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a different horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG=680722

Review-Url: https://codereview.chromium.org/2629723002
Cr-Commit-Position: refs/heads/master@{#443556}

Failing to do this may lead to a CHECK in some cases.

BUG=680687

Review-Url: https://codereview.chromium.org/2632633004
Cr-Commit-Position: refs/heads/master@{#443555}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e638a5a6..ba7c95ff

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2630723003
Cr-Commit-Position: refs/heads/master@{#443554}

The new search geolocation system will automatically grant geolocation
API access to the default search engine. This change shows the
disclosure UI when this happens so the user is aware of it.

This change also fixes a bug with showing the API introduced by an
earlier change that prevented the disclosure from being shown on
omnibox queries.

BUG=674398

Review-Url: https://codereview.chromium.org/2627853002
Cr-Commit-Position: refs/heads/master@{#443553}

Replace a gn dependency on webrtc's common_video by video_frame_api.

BUG=webrtc:5880

Review-Url: https://codereview.chromium.org/2628283003
Cr-Commit-Position: refs/heads/master@{#443552}

This will be used to simplify some of the performance critical
logic in render_widget_host_latency_tracker.cc.

Review-Url: https://codereview.chromium.org/2614403002
Cr-Commit-Position: refs/heads/master@{#443551}

Record metrics for interactions with notifications. Stop exposing
openUrl() to native code, but keep it around; we use our own intent for
notification taps to track metrics now.

There are at three problems exposed by the metrics in their current
state:

  * At (first?) startup, we get multiple consecutive fetches for some
    reason. This results in two impressions, although the notifications
    have the same data, and Android only shows one. (In practice, users
    aren’t likely to frantically tap away on startup, the way I do, so
    these notifications would be suppressed by the frontmost-checking,
    which I’m trying to avoid)

  * None of the “HIDE” actions are conditional on the notification still
    being visible, so we record a HIDE_DEADLINE for each notification,
    even if the user tapped or swiped it away, and we record
    HIDE_FRONTMOST every time Chrome becomes frontmost, even if there’s
    no notification.

Broadly speaking, we want the “Actions” histogram to match the units of
the “Impressions” histogram, so that we can infer the fraction of
displayed notifications that received each action. To do that, we should
keep a list of which notifications we believe are being shown in prefs
(to support Android L, which doesn’t have the getActiveNotifications()
API) …in the next CL.

BUG=675561

Review-Url: https://codereview.chromium.org/2626643002
Cr-Commit-Position: refs/heads/master@{#443550}

BUG=675660
TBR=jam@chromium.org,eugenebut@chromium.org

Review-Url: https://codereview.chromium.org/2629583003
Cr-Commit-Position: refs/heads/master@{#443549}

BUG=gab needs to reduce ownership load

Review-Url: https://codereview.chromium.org/2622413003
Cr-Commit-Position: refs/heads/master@{#443548}

It ties SessionManager, AuthPolicy, Cryptohome

BUG=677497
TEST=manual

Review-Url: https://codereview.chromium.org/2601283002
Cr-Commit-Position: refs/heads/master@{#443547}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2627093004
Cr-Commit-Position: refs/heads/master@{#443546}

Implement check against overriding provisional saved forms when the origin is the same but the scheme is insecure. Adds logging to understand how often this occurs.

BUG=571580

Review-Url: https://codereview.chromium.org/2607413003
Cr-Commit-Position: refs/heads/master@{#443545}

HTML's parsing mechanism will automatically close form controls at the
end of a file. This is fine from a parsing perspective, but the behavior
does enable dangling markup attacks, such as those described in
http://www.thespanner.co.uk/2011/12/21/html-scriptless-attacks/ and
section 2 of http://lcamtuf.coredump.cx/postxss/.

Based on some discussion at https://github.com/whatwg/html/issues/2253,
this patch adds metrics to measure how often this happens in the wild
for `<textarea>` and `<select>` elements, and an experimental flag which
prevents form submission in the presence of those elements if they're
closed by reaching the end-of-file.

BUG=680462

Review-Url: https://codereview.chromium.org/2628723004
Cr-Commit-Position: refs/heads/master@{#443544}

This patch is to check if the mismatching EmbeddedWorker was launched on a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633

Review-Url: https://codereview.chromium.org/2627723004
Cr-Commit-Position: refs/heads/master@{#443543}

Now that the per-thread heaps have been shipped, HeapCompact no longer needs to
support multiple threads. This CL removes that code.

BUG=671856

Review-Url: https://codereview.chromium.org/2633463006
Cr-Commit-Position: refs/heads/master@{#443542}

ApplicationCache is a per-DOMWindow thing instead of a per-ExecutionContext thing.
It should use DOMWindowClient instead of ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2631653002
Cr-Commit-Position: refs/heads/master@{#443541}

This CL updates the ShareExtensionView, allowing the URL to be displayed on 3
lines and changes the animation of the screenshot view to have it expanding
from the right instead of sliding in from the left.

BUG=680912

Review-Url: https://codereview.chromium.org/2629853003
Cr-Commit-Position: refs/heads/master@{#443540}

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2620633004
Cr-Commit-Position: refs/heads/master@{#443539}

This also modifies HeadlessDevToolsManagerDelegate to send error
responses if required parameters are missing.

BUG=679343,546953

Review-Url: https://codereview.chromium.org/2626823003
Cr-Commit-Position: refs/heads/master@{#443538}

BUG=603396
TBR=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/2612903008
Cr-Commit-Position: refs/heads/master@{#443537}

In a real browser process, threads are started as BrowserThreadImpl
objects are created. TestBrowserThreadBundle should do the same.

This is a pre-requisite to add the option to create a real TaskScheduler
in TestBrowserThreadBundle, because TaskScheduler has to be created and
started at the same time.

BUG=659191

Review-Url: https://codereview.chromium.org/2628903002
Cr-Commit-Position: refs/heads/master@{#443536}

This patch adds flag "enable_ios_bitcode" to the build configuration
for iOS applications, frameworks, and libraries. It triggers adding
the "-fembed-bitcode" option when compiling and linking parts of the
projects for production builds (is_debug = false), and it triggers
adding the "-fembed-bitcode-marker" option in the case of debug builds.
That is along the lines of how Xcode does it, since the introduction
of the bitcode support and corresponding options.

The option only makes sense for Xcode build tools now and for iOS SDK
compatible builds (iOS, watchOS, tvOS). Thus, it the options is only
applicable when building for iOS with use_xcode_clang = true. And only
when building for real devices (with ARM CPUs). The latter limitation
is due to the usage of Intel assembly syntax and the Yasm tool when
building for iOS simulator (Yasm cannot emit bitcode sections now).
But it does not affect the workflow for the generated applications,
frameworks and libraries at the moment of submitting this patch:
For now, Xcode only cares about the availability of bitcode sections
in _all_ the pre-compiled parts of bitcode-enabled projects when
building those projects for ARM-based devices. Building for iOS
simulator, it handles the projects just fine, with or without bitcode
sections available in the linked libraries. That may change in the
future, of course, but currently it should be fine.

BUG=680711

Review-Url: https://codereview.chromium.org/2631573002
Cr-Commit-Position: refs/heads/master@{#443535}

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=678292

Review-Url: https://codereview.chromium.org/2612063002
Cr-Commit-Position: refs/heads/master@{#443534}