- 12 Aug, 2014 40 commits
-
-
acolwell@chromium.org authored
DecodeTimestamp is a thin wrapper around base::TimeDelta that makes it possible to easily differentiate decode timestamps from presentation timestamps. Using a separate type also forces conversions between these two domains to be done explicitly through conversion functions. This change introduces the class and updates all the variables that contain decode timestamps. It also puts in place the necessary conversion calls for converting between timestamp types. There should be no functional change as a result of this patch. This class is mainly to allow the compiler to highlight where conversions between timestamp types occur. Having DecodeTimestamp will make it much easier to rework SourceBufferStream so that it properly handles B-frame content and reports buffered ranges in terms of presentation time instead of decode time. BUG=398130 TEST=All existing tests still pass. Review URL: https://codereview.chromium.org/447963003 Cr-Commit-Position: refs/heads/master@{#289031} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289031 0039d316-1c4b-4281-b951-d872f2087c98
-
hanxi@chromium.org authored
1. Update guest_view_manager_unittest.cc. 2. Move guest_view code to extensions. 3. Add namespace extensions for classes within guest_view/web_view/app_view. BUG=352290 Review URL: https://codereview.chromium.org/464533002 Cr-Commit-Position: refs/heads/master@{#289030} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289030 0039d316-1c4b-4281-b951-d872f2087c98
-
posciak@chromium.org authored
Add Cast.Sender.VideoEncodeAcceleratorInitializeSuccess indicating whether we were successful in initializing an external video encode accelerator for cast sender. BUG=397038 TEST=Cast, check histograms Review URL: https://codereview.chromium.org/458693004 Cr-Commit-Position: refs/heads/master@{#289029} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289029 0039d316-1c4b-4281-b951-d872f2087c98
-
dmikurube@chromium.org authored
BUG=None TEST=None Review URL: https://codereview.chromium.org/315393004 Cr-Commit-Position: refs/heads/master@{#289028} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289028 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=None Test=None Review URL: https://codereview.chromium.org/452413002 Cr-Commit-Position: refs/heads/master@{#289026} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289026 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289024} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289024 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=libyuv:346 TESTED=set GYP_DEFINES=target_arch=ia32 libyuv_disable_jpeg=1 R=mcasas@chromium.org Review URL: https://codereview.chromium.org/428533009 Cr-Commit-Position: refs/heads/master@{#289023} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289023 0039d316-1c4b-4281-b951-d872f2087c98
-
feng@chromium.org authored
Discoverd that we never got LibraryLoader.NativeLibraryHack in UMA histograms server. Found that's because UMA session was not started yet right after native libraries are loaded. By delaying recording until UMA session is started, these stats shown up in chrome://histograms. BUG=311644 Review URL: https://codereview.chromium.org/452923004 Cr-Commit-Position: refs/heads/master@{#289022} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289022 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=399149 Review URL: https://codereview.chromium.org/436563005 Cr-Commit-Position: refs/heads/master@{#289021} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289021 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
This removes the need for a lot of additional boilerplate in proxying capturer implementations, and makes it possible to implement DesktopEnvironment using any kind of DesktopCapturer, e.g. ScreenCapturer or WindowCapturer, for example. Review URL: https://codereview.chromium.org/455073004 Cr-Commit-Position: refs/heads/master@{#289020} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289020 0039d316-1c4b-4281-b951-d872f2087c98
-
henrika@chromium.org authored
BUG=395733 TEST=https://simpl.info/getusermedia/sources/ Review URL: https://codereview.chromium.org/459363003 Cr-Commit-Position: refs/heads/master@{#289019} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289019 0039d316-1c4b-4281-b951-d872f2087c98
-
dhnishi@chromium.org authored
BUG=388893 Review URL: https://codereview.chromium.org/456863003 Cr-Commit-Position: refs/heads/master@{#289018} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289018 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. (https://codereview.chromium.org/454153002/) Reason for revert: Breaks ProfileChooserControllerTest.InitialLayoutWithFastUserSwitcher,ProfileChooserControllerTest.InitialLayoutWithNewMenu,ProfileChooserControllerTest.OtherProfilesSortedAlphabetically on the waterfall. Original issue's description: > [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. > > - remove the profile preference that used to keep track of showing the > tutorial any time the user manager was shown for a particular profile. > > - show the upgrade bubble for local profiles as well (so that local profiles > have a chance to see the tutorial) > > - for the local profiles upgrade bubble, don't show the "Not you?" link as > it doesn't really make sense. > > BUG=399679 > TBR=rpetterson@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289005 TBR=guohui@chromium.org,rlp@chromium.org,sky@chromium.org,asvitkine@chromium.org NOTREECHECKS=true NOTRY=true BUG=399679 Review URL: https://codereview.chromium.org/461093002 Cr-Commit-Position: refs/heads/master@{#289017} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289017 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Also sets myself as the owner for these. BUG=223859 NOTRY=true Review URL: https://codereview.chromium.org/456003002 Cr-Commit-Position: refs/heads/master@{#289016} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289016 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
(I still have to write tests and convert some uses. I also want to add more logic to the async destruction, so that the |Channel| knows that it's about to be torn down.) R=yzshen@chromium.org Review URL: https://codereview.chromium.org/466563002 Cr-Commit-Position: refs/heads/master@{#289015} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289015 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289014} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289014 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
TBR=jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/465903003 Cr-Commit-Position: refs/heads/master@{#289013} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289013 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=393486 TEST=Tree is open more of the time TBR=horo NOTRY=TRUE Review URL: https://codereview.chromium.org/463143002 Cr-Commit-Position: refs/heads/master@{#289012} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289012 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
Created safe alternative which is called GetProfileByUser. The plan is to investigate all usages of GetProfileByUserUnsafe one by one and replace them with a safe version, if possible. Also warning message added for cases when GetProfileByUserUnsafe returns profile of a wrong user or signin profile. That will help us to detect suspicious calls to GetProfileByUserUnsafe while work in progress. BUG=361528 TBR=yoz,dcheng,agl,dewittj,skuhne,derat Review URL: https://codereview.chromium.org/445353004 Cr-Commit-Position: refs/heads/master@{#289011} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289011 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
These nits were noted when a new storage type was added in crrev.com/394063003 and this CL applies those style changes and other suggestions to the other files. Standardize on DCHECK(!x), use DCHECK_CURRENTLY_ON() where possible, use empty() rather than !size(), all the trivial cpplint.py findings, and add/use ASSERTs in mock classes (vs. CHECK/DCHECKs) No functional changes. R=bauerb@chromium.org Review URL: https://codereview.chromium.org/459233002 Cr-Commit-Position: refs/heads/master@{#289010} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289010 0039d316-1c4b-4281-b951-d872f2087c98
-
merkulova@chromium.org authored
Screenshots https://drive.google.com/a/google.com/folderview?id=0B0Pq_70XQgc1YzAxUWVXV2JyWkE&usp=sharing BUG=398880 NOTRY=true Review URL: https://codereview.chromium.org/461943002 Cr-Commit-Position: refs/heads/master@{#289009} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289009 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
This is a fix for a latent bug. Tentatively, this is also causing http://crbug.com/394315. BUG=380463, 394315 Review URL: https://codereview.chromium.org/464853002 Cr-Commit-Position: refs/heads/master@{#289008} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289008 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
Except for webrtc, this produces content_shell and webkit_unit_tests binaries that link and run successfully on linux. R=brettw@chromium.org Review URL: https://codereview.chromium.org/462983002 Cr-Commit-Position: refs/heads/master@{#289007} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289007 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
This maintains the fixes for the mac isolate files, and switches around the targets used in the gyp files to fix the unit tests in component builds. BUG=386799 First Review URL: https://codereview.chromium.org/413303002 Second Review URL: https://codereview.chromium.org/448873002 Review URL: https://codereview.chromium.org/460743002 Cr-Commit-Position: refs/heads/master@{#289006} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289006 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
- remove the profile preference that used to keep track of showing the tutorial any time the user manager was shown for a particular profile. - show the upgrade bubble for local profiles as well (so that local profiles have a chance to see the tutorial) - for the local profiles upgrade bubble, don't show the "Not you?" link as it doesn't really make sense. BUG=399679 TBR=rpetterson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817 Review URL: https://codereview.chromium.org/454153002 Cr-Commit-Position: refs/heads/master@{#289005} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289005 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=402766 TBR=xhwang@chromium.org Review URL: https://codereview.chromium.org/463933002 Cr-Commit-Position: refs/heads/master@{#289003} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289003 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=372381 Review URL: https://codereview.chromium.org/460383002 Cr-Commit-Position: refs/heads/master@{#289002} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289002 0039d316-1c4b-4281-b951-d872f2087c98
-
eranm@chromium.org authored
Fetches the list of EV certificate hashes using the component updater. Once this is in, we could gather data on how many EV certificates do not appear in any Certificate Transparency log. BUG=339128 Review URL: https://codereview.chromium.org/465443002 Cr-Commit-Position: refs/heads/master@{#289001} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289001 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
BUG=372381 Review URL: https://codereview.chromium.org/466723003 Cr-Commit-Position: refs/heads/master@{#288999} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288999 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
TBR=mgiuca BUG=171450 Review URL: https://codereview.chromium.org/460833004 Cr-Commit-Position: refs/heads/master@{#288998} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288998 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/465933002 Cr-Commit-Position: refs/heads/master@{#288997} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288997 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#288996} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288996 0039d316-1c4b-4281-b951-d872f2087c98
-
jkarlin@chromium.org authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/459903002 Cr-Commit-Position: refs/heads/master@{#288995} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288995 0039d316-1c4b-4281-b951-d872f2087c98
-
falken@chromium.org authored
As per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#unregister-algorithm Unregister shouldn't doom the active worker or delete the registration until the active worker no longer controls a document. This means that if register() is called before that happens, the unregistration is effectively canceled. BUG=388095 TEST=https://codereview.chromium.org/416003003/ Review URL: https://codereview.chromium.org/413063004 Cr-Commit-Position: refs/heads/master@{#288994} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288994 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Fix an issue with view manager init service where you had to retain a connection to the init service until the window tree host was created otherwise embed calls would be dropped. R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/463523003 Cr-Commit-Position: refs/heads/master@{#288993} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288993 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
This changes the webview implementation of wrap_contents mode from custom code explicitly calculating the layout size to a pair of settings: "ignore viewport tag" (for older apps) and "set layout size height to 0". This means this code gets simpler and means we don't have to fix a bunch of races present in the current version of the code. BUG=392460, 398445 TBR=cevans@chromium.org Review URL: https://codereview.chromium.org/418883002 Cr-Commit-Position: refs/heads/master@{#288992} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288992 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
After running Delete() method, the iterator is expected to index the next entry, if exists. BUG=347425 TEST=./unit_tests --gtest_filter="LevelDBWrapper*" Review URL: https://codereview.chromium.org/461823002 Cr-Commit-Position: refs/heads/master@{#288991} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288991 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288990} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288990 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
TBR=jochen@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/459373002 Cr-Commit-Position: refs/heads/master@{#288989} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288989 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
This matches the gyp build and is important for parts of the code that guard their API with UNIT_TEST. For instance, chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText function guarded by #if UNIT_TEST that shadows a protected function GetRenderText from its parent class views::Textfield, but with different const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST set, it attempts to use the guarded member function instead of the base class which fails to compile. R=brettw@chromium.org Review URL: https://codereview.chromium.org/464503003 Cr-Commit-Position: refs/heads/master@{#288988} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288988 0039d316-1c4b-4281-b951-d872f2087c98
-