GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98719 0039d316-1c4b-4281-b951-d872f2087c98

Conceptually, the function to call is known at compile time.
There is no reason to save it into a static variable.  It turns out
doing causes the compiler to emit a static initializer to track whether
free_ has been initialized.

This change removes static initializers from eight .o files on my local
Release build.

BUG=87171

Review URL: http://codereview.chromium.org/7795008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98718 0039d316-1c4b-4281-b951-d872f2087c98

So that we show Gaia horizonally center.

BUG=chromium-os:19779
TEST=Verify fix for chromium-os:19779.


Review URL: http://codereview.chromium.org/7792009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98717 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7764006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98716 0039d316-1c4b-4281-b951-d872f2087c98

1. install to the correct page (0 -> -1 in crx_installer)
2. scroll to show the app (scrollTop change in apps_page.js)
3. reset tiles after trashing an app (trash.js change)
4. fix install-display for already-open NTPs. The old technique of always navigating stacked up history entries when the NTP had already been open. It was also flaky (seemed to be vulnerable to some race). Now we use an install notification which the NTP in question will be listening for.

BUG=92995,91583
TEST=manual

Review URL: http://codereview.chromium.org/7776001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98715 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/7791007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98713 0039d316-1c4b-4281-b951-d872f2087c98

The flow is:
1. Fetch store metadata as JSON (using URLFetcher)
2. Parse response in utility process (via SafeWebstoreResponseParser)
3. Parse manifest and get icon data using WebstoreInstallHelper
4. Show install UI
5. Whitelist extension ID for download and start download

Still missing are a way of informing the page that the inline install succeeded
or failed.

Also removes ExtensionTabHelper::GetCustomFrameNativeWindow, since it wasn't
actually overriding anything (the method was removed from
ExtensionFunctionDispatcher::Delegate by r74835).

R=asargent@chromium.org

Review URL: http://codereview.chromium.org/7741037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98712 0039d316-1c4b-4281-b951-d872f2087c98

Now with fixes for builds that trybots don't cover by default.

(This yak needs shaving because chunks of gtk using code in chrome/ are being
moved to content/ to build the content_shell, but we can't depend on code in
chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig
constants, widget factory functions, etc instead of just moving the file.)

BUG=93804
TEST=none; code move
First Review URL: http://codereview.chromium.org/7737001

Review URL: http://codereview.chromium.org/7748026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98711 0039d316-1c4b-4281-b951-d872f2087c98

This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In
the current version, we simulate the performance of the existing forward
rendering model; coming changes will prototype a new model.

BUG=None
TEST=self

This is http://codereview.chromium.org/7718020/ with trivial fixes
Original change by Joshua Trask <joshtrask@google.com>

Review URL: http://codereview.chromium.org/7792002
Patch from Joshua Trask <joshtrask@google.com>.

TBR=piman@google.com
Review URL: http://codereview.chromium.org/7792016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98710 0039d316-1c4b-4281-b951-d872f2087c98

 chrome/app/theme/large_tab_active_center.png   |  Bin 47721 -> 13026 bytes
 chrome/app/theme/large_tab_active_left.png     |  Bin 49114 -> 13782 bytes
 chrome/app/theme/large_tab_active_right.png    |  Bin 48883 -> 13502 bytes
 chrome/app/theme/large_tab_alpha_left.png      |  Bin 48033 -> 13349 bytes
 chrome/app/theme/large_tab_alpha_right.png     |  Bin 49813 -> 13238 bytes
 chrome/app/theme/large_tab_close.png           |  Bin 47134 -> 13018 bytes
 chrome/app/theme/large_tab_close_h.png         |  Bin 53363 -> 13621 bytes
 chrome/app/theme/large_tab_close_mask.png      |  Bin 48963 -> 13366 bytes
 chrome/app/theme/large_tab_close_p.png         |  Bin 54518 -> 13749 bytes
 chrome/app/theme/large_tab_drop_down.png       |  Bin 51151 -> 13789 bytes
 chrome/app/theme/large_tab_drop_up.png         |  Bin 50911 -> 13808 bytes
 chrome/app/theme/large_tab_inactive_center.png |  Bin 47525 -> 13086 bytes
 chrome/app/theme/large_tab_inactive_left.png   |  Bin 50316 -> 13808 bytes
 chrome/app/theme/large_tab_inactive_right.png  |  Bin 48411 -> 13477 bytes

BUG=none
TEST=none
TBR=sail@chromium.org

Review URL: http://codereview.chromium.org/7794009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=bots
Review URL: http://codereview.chromium.org/7764012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98708 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98707 0039d316-1c4b-4281-b951-d872f2087c98

This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In
the current version, we simulate the performance of the existing forward
rendering model; coming changes will prototype a new model.

BUG=None
TEST=self

This is http://codereview.chromium.org/7718020/ with trivial fixes
Original change by Joshua Trask <joshtrask@google.com>

Review URL: http://codereview.chromium.org/7792002
Patch from Joshua Trask <joshtrask@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Chrome builds and runs on ChromeOS

Review URL: http://codereview.chromium.org/7779004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98705 0039d316-1c4b-4281-b951-d872f2087c98

temporary file so that the subsequent rename always operates
with data in disk.

BUG=89356
TEST=none
Review URL: http://codereview.chromium.org/7695014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94642
TEST=BUILD

Review URL: http://codereview.chromium.org/7790012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98703 0039d316-1c4b-4281-b951-d872f2087c98

Add chromeish button style
Fix dialog gradient and transitions
Fix harness file creation
Fix task button rendering
Make list header gradient not leak outside of list
Show checkmark even when only a single item is selected (multi-select mode only).
Add a delay to the mock tasks callback to better simulate the real world.

BUG=chromium-os:17028, chromium-os:19373, chromium-os:19693
TEST=manual testing

Review URL: http://codereview.chromium.org/7764011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98701 0039d316-1c4b-4281-b951-d872f2087c98

of BookmarkBarView changes. My last patch added the plumbing, this
wires it up.

BUG=92994
TEST=make sure bookmark menus still work; covered by tests too.
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7787001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98700 0039d316-1c4b-4281-b951-d872f2087c98

These changes enable save and restore of minimized window state on Windows.  (Mac and Linux came prior).  The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).

BUG=43274
TEST=Manual.  Launch Chrome on Windows, create two browser windows, minimize "a" window, quit.  Relaunch, expect "a" to be minimized.


Review URL: http://codereview.chromium.org/7748036

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7790010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98699 0039d316-1c4b-4281-b951-d872f2087c98

as though a TabSTripModel is getting notified that has a NULL in
contents_data_. That doesn't seem possible though, so something weird
must be happening.

BUG=93747
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7767010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98698 0039d316-1c4b-4281-b951-d872f2087c98

in Beta channel and XP. We will crash the browser
if UI/IO threads don't respond within 24 secs
(instead of 12 secs) in Beta channel and Windows XP.

BUG=90095
R=jar
TEST=thread_watcher unit tests

Review URL: http://codereview.chromium.org/7744015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98697 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98355 (was semantically incorrect, caused assertion failures in Debug builds with some apps) - Further attempted workarounds for Mac- and NVIDIA-specific crash. Can
not reproduce this crash in house any more, so adding more code along
the lines of the earlier fix which was known to work on some hardware.

BUG=94103
TEST=none (tested manually to verify no regression)
Review URL: http://codereview.chromium.org/7756001

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7795006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98694 0039d316-1c4b-4281-b951-d872f2087c98

OptionMenuModel::translate_infobar_delegate_ has been deleted. This
may be possible if BeforeTranslateInfoBar is deleted while the menu is
showing. Changing the code like I'm doing makes sure the menu is
deleted if BeforeTranslateInfoBar is deleted too.

BUG=93314
TEST=none
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/7745057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98693 0039d316-1c4b-4281-b951-d872f2087c98

Also increase the time the test is allowed to wait for a video frame. 

TEST= 
BUG=94134

Review URL: http://codereview.chromium.org/7757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7748038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98690 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a skeleton for testing compositor API changes.

BUG=none
TEST=see unittest
Review URL: http://codereview.chromium.org/7769001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98689 0039d316-1c4b-4281-b951-d872f2087c98

bug=94454
r=pkasting
Review URL: http://codereview.chromium.org/7801001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98688 0039d316-1c4b-4281-b951-d872f2087c98

  - Call Core->ReleaseResource() on multiple graphics3d resources.
Fix for NaCl ppapi graphics 3d resource, so it can be released without
crashing the untrusted plugin.
Add a few more debug prints for future use.
BUG= none
TEST= ppapi_ppb_graphics3d.cc (included)
Review URL: http://codereview.chromium.org/7736006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94095
TEST=open ntp and chrome://extensions, spam disable/enable on something that's both an app and an extension (such as weatherbug). NTP should not start creating multiple copies of the icon.


Review URL: http://codereview.chromium.org/7764013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98685 0039d316-1c4b-4281-b951-d872f2087c98

Since I didn't land this before the NaCl proxy move to chrome, I had to incorporate the proxy changes that were in http://codereview.chromium.org/7714041/

After PDF lands, I should be able to remove backwards-compat code.

BUG=80696
TEST=ppapi tests, manual test of PDF plugin

Review URL: http://codereview.chromium.org/7718004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98684 0039d316-1c4b-4281-b951-d872f2087c98

This allows symbolization of Google Chrome Canary, Google Chrome Helper EH,
and Google Chrome Helper NP. The practical effect of this is that _main and
start will be properly symbolized by Breakpad.

BUG=94540
TEST=Look at the Breakpad crash reports for the canary browser process,
     plug-in process, and NaCl loader process. The bottom of each stack should
     show ChromeMain being called by main, which is in turn called by start.
Review URL: http://codereview.chromium.org/7799005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7790007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19010
TEST=Manual: open user image selection dialog, move to the last image and press the right arrow.


Review URL: http://codereview.chromium.org/7784003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98680 0039d316-1c4b-4281-b951-d872f2087c98

These changes enable save and restore of minimized window state on Windows.  (Mac and Linux came prior).  The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).

BUG=43274
TEST=Manual.  Launch Chrome on Windows, create two browser windows, minimize "a" window, quit.  Relaunch, expect "a" to be minimized.


Review URL: http://codereview.chromium.org/7748036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98678 0039d316-1c4b-4281-b951-d872f2087c98

Use the job object to prevent the GPU from spawning child processes on Windows.

BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/7768004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98677 0039d316-1c4b-4281-b951-d872f2087c98

 * Call OnTextInputTypeChanged from Mock class (which is used when ibus is not present)
 * Don't create InputMethod in desktop window.
 * Fix comment on RWHVV to be more accurate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7761008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98676 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=28439
TEST=none

Review URL: http://codereview.chromium.org/7790004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94308
TEST=Run unit tests - I don't have any way to reproduce the corrupted DB this CL works around.


Review URL: http://codereview.chromium.org/7747040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98673 0039d316-1c4b-4281-b951-d872f2087c98