GitLab

This is a reland of 3bcc71d8

Now code search should be fine.

Original change's description:
> Add luci-go tool to be fetched via CIPD
>
> Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes
> need to be updated.
>
> Change analyze to not ignore changes to isolate.
>
> R=tandrii@chromium.org
>
> Bug: 851596
> Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5
> Reviewed-on: https://chromium-review.googlesource.com/1097623
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569688}

Bug: 851596
Change-Id: Icd227efde182ff844e93dbb692124c1297ab0d7c
Reviewed-on: https://chromium-review.googlesource.com/1135791Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574787}

This is the 2nd CL wiring things up with changes in AutofillClient and BrowserCommands.
There will be one following CL on unit-test and metrics.

Previous CL: 1128569.

For project details, please refer to design doc go/ib-paradise.

This project is to offer users an option to upload chrome local credit
cards to Google Pay server. This bubble UI is the entry point of the entire
flow. It should be anchored to a credit card icon in the location bar and
be shown from it.

Bug: 852904
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5a53f54fda97157cd0d0e7a8fe500728b4733515
Reviewed-on: https://chromium-review.googlesource.com/1134193
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574786}

This includes transition from \n to \0 message separation.

Change-Id: I9bcd5690dc848a6d4206d051443be2082d747824
Reviewed-on: https://chromium-review.googlesource.com/1135939Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574785}

https://pdfium.googlesource.com/pdfium.git/+log/94919f78e1bc..d8df8c35a463


git log 94919f78e1bc..d8df8c35a463 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 hnakashima@chromium.org Fix mark not saved if there are no other changes in the same object.


Created with:
  gclient setdep -r src/third_party/pdfium@d8df8c35a463

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I484bd07bb84691a0abb347821832fae20de8c029
Reviewed-on: https://chromium-review.googlesource.com/1135222Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574784}

Disabling failing tests on Waterfall for Android build bot for Chrome Beta and Stable.

Bug: chromedriver:2503
Change-Id: I75e625d8dd027109c6fd6cd2143d58342c271318
Reviewed-on: https://chromium-review.googlesource.com/1135972Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574783}

The fallback path for the Retina port in blinkpy is adjusted to 10.13
accordingly. And tests are rebaselined.

To keep the CL simple, mac10.12_retina-blink-rel isn't renamed to 10.13
yet. It needs to be renamed later on both src and build sides.

Bug: 863070
Change-Id: Ia1ae7f643e3bffaaa4b8ea133b20b8e8ec06ba5a
Reviewed-on: https://chromium-review.googlesource.com/1135707
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574782}

This patch initializes the rect_ field in SnapContainerData in copy
constructor and move constructor. Fixing a snapping issue in the
composited pages.

We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
test suite so that they are tested with the composited cases.

snap-at-user-scroll-end-manual-automation.js calls
mouseClickInTarget() of pointerevent_common_input.js. That method
invokes programmatic scrolls. The test was written before programmatic
scroll snapping was implemented so it worked at that time. However,
with programmatic scroll snapping implemented, it will always snap
in mouseClickIntarget() and cannot test whether the user scroll snaps.
This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
to avoid invoking programmatic scrolls in the test.

This patch also checks nullptr for layout_box in
ScrollManager::SnapAtGestureScrollEnd() to fix a crash.

Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
Reviewed-on: https://chromium-review.googlesource.com/1132386
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574781}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca73efa2232f..27998f763495


git log ca73efa2232f..27998f763495 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 dgarrett@google.com cbuildbot_launch/InitSdk: Remove DepotToolsEnsureBootstrap.


Created with:
  gclient setdep -r src/third_party/chromite@27998f763495

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2656770fe4d004aa28076691390936561aeb9de0
Reviewed-on: https://chromium-review.googlesource.com/1135616Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574780}

This CL adds MediaStatus and MediaStatusObserver, which are based off of
media_router.mojom.MediaStatus.

Deduplicating the MediaStatus interface from the one in the media_router
namespace will be covered in crbug.com/820277

Bug: 790766
Change-Id: I7a72bb942cb303483d3abb143318269524990f9a
Reviewed-on: https://chromium-review.googlesource.com/1134357
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574779}

Bug: b/110219351
Test: Manual Test
Change-Id: If0499953843c05288eb8d32f3e7927f9901ac8a7
Reviewed-on: https://chromium-review.googlesource.com/1134395Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574778}

FID is becoming a trusted page load metric.

Bug: 862895
Change-Id: Ib434d2f2e203a986c29928909af32427aa0c30c7
Reviewed-on: https://chromium-review.googlesource.com/1134641Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574777}

When S13nServiceWorker is enabled requests/responses directly go
from page to service worker and we don't go through the XSDB check.
As [1] noted, we wouldn't need to check responses because checking
responses would be redundant. This CL make
rossSiteDocumentBlockingServiceWorkerTest.NoNetwork to be skipped
as the test wouldn't be needed when S13nServiceWorker is enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/879348/12/content/browser/loader/cross_site_document_resource_handler.cc#587

Bug: 861644
Change-Id: Id64063995f341733fc8f39c3620c083ab07d0c94
Reviewed-on: https://chromium-review.googlesource.com/1134636
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574776}

This reverts commit 840dc0a7.

Revert "RC: Use Chrome usage time since hidden to decide if tab can be proactively discarded."

This reverts commit 3c279f29.

Revert "RC: Move parts of TabManager::PerformStateTransitions() into helper methods."

This reverts commit 79fba743.

These three CLs stack on top of each other and the first one (
840dc0a7 ,
https://chromium-review.googlesource.com/1133593 ) seems to have
introduced assertion failures and crashes per http://crbug.com/863243 .

Tbr: fdoray@chromium.org
Tbr: sky@chromium.org
Bug: 775644, 863243
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7f02f28de26a8c531e6eebe847120f45b133fd7d
Reviewed-on: https://chromium-review.googlesource.com/1135969Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574775}

This was throwing a runtime error when the unified-consent flag was
enabled.

Bug: 860854
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6e521b813ca160e5434ac066e47f73ecf61b7ba1
Reviewed-on: https://chromium-review.googlesource.com/1134515Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574774}

This provides a simple wrapper around MultiDeviceSetup service, allowing it to
easily be stubbed out in tests.

R=khorimoto@chromium.org

Bug: 824568
Change-Id: If3279d6e4e03ff2b60307aeb70d4f6ef91620b63
Reviewed-on: https://chromium-review.googlesource.com/1135654
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574773}

Bug: b/111262834
Test: Manual Test
Change-Id: Ifce7bd2e2a7be2d927301519b8e8375a326dd896
Reviewed-on: https://chromium-review.googlesource.com/1135912
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574772}

For translucent windows, don't do any CATransaction synchronization
until after the first frame has been received.

This allows us to avoid blocking the UI thread when entering the first
keystrokes in the omnibox.

While in the neighborhood, delete the dead code for using alpha to
make windows appear atomically.

Bug: 712268
Change-Id: I71cab1c1c598adc34542b6990d8f9112eda8be4f
Reviewed-on: https://chromium-review.googlesource.com/1135891
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574771}

One known problem if we switch engines elsewhere, is that LayoutNG and legacy
layout don't cooperate on margin collapsing.

This causes one test regression. The force-legacy-on-contenteditable
mechanism doesn't always work as it should. A bug has been reported.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I019f9028f6a1a51c923c9649c6add12034aa692f
Reviewed-on: https://chromium-review.googlesource.com/1127027Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574770}

Remove WebContents parameter as it isn't used.

Change-Id: I1e0069612b422498598f190cd4fdf21d05804e83
Reviewed-on: https://chromium-review.googlesource.com/1133603Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574769}

The fix prevents compositor frames from being pushed by
OffscreenCanvas whenever the push is unwarranted. Spurious pushes
cause flickering due to preserveDrawingBuffer=false behaviour.

BUG=863085

Change-Id: I24c8b4d27e6a07b41e8e0ae030d1ec626674b8d0
Reviewed-on: https://chromium-review.googlesource.com/1135520Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574768}

https://pdfium.googlesource.com/pdfium.git/+log/6aa2190f70a8..94919f78e1bc


git log 6aa2190f70a8..94919f78e1bc --date=short --no-merges --format='%ad %ae %s'
2018-07-12 thestig@chromium.org Move CJS_Field private methods into an anonymous namespace.
2018-07-12 thestig@chromium.org Remove parameter to CJS_Field::GetFormFields().
2018-07-12 thestig@chromium.org Add CJS_Field::GetFirstFormField().
2018-07-12 hnakashima@chromium.org Create API to set and get blob values from a mark dict.
2018-07-12 thestig@chromium.org Add more helper functions to check field types in CJS_Field.
2018-07-12 thestig@chromium.org Add a IsCheckBoxOrRadioButton() helper for CJS_Field.
2018-07-12 thestig@chromium.org Use pdfium::Optional in CJS_Return.
2018-07-12 thestig@chromium.org Rename 'ori' to 'backdrop' in rendering code.


Created with:
  gclient setdep -r src/third_party/pdfium@94919f78e1bc

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia1700215bfc02ab131428fa83463cb3d46be38cb
Reviewed-on: https://chromium-review.googlesource.com/1135617Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574767}

This CL has no behavior changes.

Change-Id: I729ae81845f289f2bf562c44cc37726b90417f9d
Reviewed-on: https://chromium-review.googlesource.com/1134717Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574766}

Spin up a migrate back to default network to bring the network back to
the default network.

Change-Id: I48d72420b79297de83e350937cb4eb05e97fdb38
Reviewed-on: https://chromium-review.googlesource.com/1134444
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574765}

Was formerly disabled on Mac.

Tbr: tkent@chromium.org
Bug: 862716
Change-Id: I56fa0b3c738189c9b5e89e2fbedb4655c8ca789f
Reviewed-on: https://chromium-review.googlesource.com/1135762Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574764}

- css3/filters/filter-repaint-composited-fallback-crash.html
- virtual/gpu-rasterization/images/color-profile-mask-image-svg.html

Tbr: tkent@chromium.org
Bug: 860706
Change-Id: Iaedb2f2960eb8ed975562db4d0d0e05dfbdc4cfb
Reviewed-on: https://chromium-review.googlesource.com/1135815
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574763}

Hide the Google Photos and Chrome backgrounds options when offline.

Bug: 856722
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4e915c16f40e6961f929b3a69eb3497238eb9185
Reviewed-on: https://chromium-review.googlesource.com/1121347
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574762}

src/ side

Bug: 863167
Change-Id: Id7070aab7e1da278a0329b086564b2b9cf9357d3
Reviewed-on: https://chromium-review.googlesource.com/1135556
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574761}

The logic has never been correctly hooked up for MacViews. This CL uses
ChromeCommandDispatcherDelegate to explicitly invoke
FocusManager::ProcessAccelerator. This gives Views toolkit an opportunity to
process hotkeys, regardless of focused view.

This CL removes the restriction that chrome/browser/ui/cocoa cannot depend on
ui/views, since chrome/browser/ui/cocoa can already depend on
chrome/browser/ui/views.

Bug: 848341
Change-Id: Ibf356768b28da4b2ea0c4834635c6a47f7562cc8
Reviewed-on: https://chromium-review.googlesource.com/1134200Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574760}

Add support for shaping latin-1 without first up-converting to UTF-16 in
HarfBuzzShaper and to the LayoutNG text layout & line breaking pipeline.

This allow for moderate improvements in memory usage and performance for
latin-1 content, espeically for subsequent layouts as text up-convertion
is avoided therefore allowing script segmentation to be avoided as well.

Notably the layout/line-layout-repeat-append performance test gets twice
as fast with this change. Other layout perf tests improve very slightly.

Increases performance of the ShapingLineBreakerPerfTest::ShapeLatinText
micro benchmark by about 5x. From 200 runs/s to 1000 runs/s on a T430s.

Legacy layout retains the UTF-16 up-conversion logic and isn't affected.

Bug: 636993, 693704
Test: perf_tests/layout/line-layout-repeat-append.html
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7fdb9ab228b61b22e9ef39cdfb8de6c360e83e3f
Reviewed-on: https://chromium-review.googlesource.com/1132270
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574759}

Bug: none
Change-Id: Idd235e2a2786950e0da9d228b9d321f85a14fe9e
Reviewed-on: https://chromium-review.googlesource.com/1135295Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574758}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b138f742b74..8a2e331aa718


git log 2b138f742b74..8a2e331aa718 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 ehmaldonado@chromium.org Collect metrics for 'git nav-downstream'


Created with:
  gclient setdep -r src/third_party/depot_tools@8a2e331aa718

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:832386
TBR=agable@chromium.org

Change-Id: I6b05c998dde183f9b072d17a3b194f2e398730df
Reviewed-on: https://chromium-review.googlesource.com/1135217Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574757}

_EXTERN_TEMPLATE_EXPORT and _TEMPLATE_EXPORT exist for use with
explicit template instantiation declarations and definitions,
respectively.

In the bindings templates it was used on the declaration of a regular
function (whereregular _EXPORT is correct), and on the definition of a regular
function (where nothing should be used; the definition will inherit the annotation
from its declaration).

A file in platform used these macros on an explicit template specialization.
A (full) explicit specialization is a function, not a template, so use regular _EXPORT
there too.

Remove MODULES_(EXTERN_)TEMPLATE_EXPORT and PLATFORM_(EXTERN_)TEMPLATE_EXPORT,
which are unused after removing their incorrect uses. (If someone wants to
bring them back in the future, beware that they're currently slightly wrong
too, so in that case read the linked bug and see what happened to
CORE_EXTERN_TEMPLATE_EXPORT, and bring them back with the same change applied.)

NOPRESUBMIT=true

Bug: 859989
Change-Id: I4b0218f059ff6fd71139544862a5cc3a56d0b816
Reviewed-on: https://chromium-review.googlesource.com/1135300Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574756}

[IO] Only compute intersection observations if any property tree state has changed, and only for full-frame updates.

This avoids re-computing intersection observations when nothing has changed.

It is correct for IOv1 and also IOv2. It is correct for IOv2 because at present
IOv2 and hit testing do not depend on paint output.

Bug: 831762
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I196ca3a64e26d2227bc8cbb6b73ea81c1adbb4b2
Reviewed-on: https://chromium-review.googlesource.com/1134348Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574755}

The pepper tests don't crash anymore after r574706.

TBR=cmumford@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0683a492ca50562f17a69b2ac137c2d4ad0dffcc
Reviewed-on: https://chromium-review.googlesource.com/1135821Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574754}

Add bindings code to process the options, add WPT tests to cover
the cases that are special. A pull request against the HTTP Spec
will be done shortly.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/xACYBou4f9A/Ft0-QlFMAQAJ

https://github.com/dtapuska/useractivation

BUG=846858

Change-Id: I24f570850280e6935d43793041252312c2bfc484
Reviewed-on: https://chromium-review.googlesource.com/1118850
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574753}

Bug: 859489
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9d421d204c5023fa168ed89d4d8dd15564e03a03
Reviewed-on: https://chromium-review.googlesource.com/1122974
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574752}

This patch changes the feature check for Duet to include a check for
tablets. Duet will not be enabled on tablets and is causing a crash
when the util reports that it is enabled (when it technically isn't).

Bug: 862818
Change-Id: I8117296e0397453d9c16bc73f7f72ae49ee78499
Reviewed-on: https://chromium-review.googlesource.com/1135708Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574751}

Bug: 860673
Change-Id: I64299a1c24247b00ee389c29751da14ef95e1230
Reviewed-on: https://chromium-review.googlesource.com/1135186Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574750}

This is a regression in Refresh as the avatar button exists in Incognito
for badging but no avatar bubble should be brought up. The logic
previously depended on the avatar button not existing at all in
Incognito.

The change simply early returns before showing a menu if in Incognito.

Bug: chromium:863154
Change-Id: Ifd34b4722f5ecb41d84d376f34a9adf5cf930d06
Reviewed-on: https://chromium-review.googlesource.com/1135722Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574749}

Tbr: tkent@chromium.org
Bug: 863160
Change-Id: I7ccb9e06fe38157ddfb8ab292ef035fd0233827b
Reviewed-on: https://chromium-review.googlesource.com/1135778Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574748}