- 28 Apr, 2018 40 commits
-
-
Will Harris authored
BUG=837888 Change-Id: I9cadbc1cf7f8103c28f1a7f3f4f327c7393bd885 Reviewed-on: https://chromium-review.googlesource.com/1024795 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554621}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Idd7cefe36dae06a08fc8f7a788b4b70d5961482d Reviewed-on: https://chromium-review.googlesource.com/1033906Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554620}
-
Wei Li authored
Feature flag use-pdf-compositor-service-for-print was accidentally removed from chrome://flags page in commit 48a4a526 due to use of build flag. Now we added it back so this feature can be controlled by users. BUG= TEST=Check chrome://flags, use-pdf-compositor-service-for-print should show up in that page. Change-Id: Iedd2d7a3d124b5c63de6d4488fa5f28fced1e06d Reviewed-on: https://chromium-review.googlesource.com/1033808Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554619}
-
https://skia.googlesource.com/skia.git/+log/275df2e87306..7df62b559a65 $ git log 275df2e87..7df62b559 --date=short --no-merges --format='%ad %ae %s' 2018-04-28 angle-skia-autoroll Roll third_party/externals/angle2/ de279590a..bb3255b5a (5 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I6e332d41eda950fed3fcba6eb76d840d2fee2671 Reviewed-on: https://chromium-review.googlesource.com/1034117 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554618}
-
Ken Rockot authored
Causes Chrome builds for Chrome OS to emit additional 32-bit and 64-bit copies of the mojo_core shared library built against the Android toolchain, for use from within the ARC++ container. In order to support building these library targets, this also modifies DEPS to include a minimal set of required Android support tools and libraries in chromeos checkouts. Bug: 822034 Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0 Reviewed-on: https://chromium-review.googlesource.com/1026203 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#554617}
-
Devlin Cronin authored
Completely remove chrome.send() from drag_and_drop_handler.js, and use developerPrivate.installDroppedFile() for the remaining method call that was used by chrome.send(). Bug: 820187 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7da13b41c17bbdc16d929cfaac58daa081d41184 Reviewed-on: https://chromium-review.googlesource.com/1031116 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554616}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c9979e745c1..0cbdbd28b508 $ git log 8c9979e74..0cbdbd28b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib7b64058179ca534bf9e2d826f22bc4f9c1e592e Reviewed-on: https://chromium-review.googlesource.com/1034113Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554615}
-
https://chromium.googlesource.com/angle/angle.git/+log/696434382359..bb3255b5a507 $ git log 696434382..bb3255b5a --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jiawei.shao Remove redundant computations on combined interface block counts 2018-04-24 jiawei.shao ES31: Add REFERENCED_BY_GEOMETRY_SHADER as program interface property Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I900ede76870f25c9c817a39705184c105851e3a7 Reviewed-on: https://chromium-review.googlesource.com/1034111 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554614}
-
https://webrtc.googlesource.com/src.git/+log/658ad8816b7e..e80689fcabde $ git log 658ad8816..e80689fca --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70553c388b2fad59791a3498905deb0ec3310c10 Reviewed-on: https://chromium-review.googlesource.com/1033800Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554613}
-
Xianzhu Wang authored
The crash reports are null pointer crashes at: resolved_inner_node->GetLayoutObject()->UpdateHitTestResult(... The code is executed only when resolved_inner_node is not null, so the only cause is the layout object is null. No test case because we don't have a reproduction. Bug: 835523 Change-Id: I707dcfa05d95e43c29091fc33723c29b0b28134c Reviewed-on: https://chromium-review.googlesource.com/1028366Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554612}
-
Christopher Thompson authored
This adds a new UrlFormatter.formatUrlForDisplayWithNormalEscaping() function, and uses it in the Android PageInfoPopup to make its URL display correctly de-punycode URLs that are safe to convert back to Unicode for display. This also adds url_formatter unittests for the specific usage of FormatUrl that the new function uses under a variety of URL conditions. Bug: 818839 Change-Id: Id0f50a6a37be7309c684ef180acc78f84895d729 Reviewed-on: https://chromium-review.googlesource.com/1015229 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#554611}
-
Sonny Sasaka authored
BlueZ bug makes it wrong to assume that the Discovering property is updated when StartDiscovery/StopDiscovery returns (crbug.com/822104). BlueZ bug fixing is deprioritized so here we remove the DCHECK first until BlueZ bug is fixed. This is a left-over from https://crrev.com/c/963845. BUG=814595,836427 TEST=No longer crashes Change-Id: I81167db3c3d31225279798e37bede79c56037622 Reviewed-on: https://chromium-review.googlesource.com/1033455Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#554610}
-
Chris Mumford authored
On CrOS a WebUI resource request is being made that isn't one of our allowed hosts. Temporarily adding a crash key to reveal this host to facilitate debugging. Bug: 837328 Change-Id: I26b103ee73229c92f1876448364c132cc58ad42f Reviewed-on: https://chromium-review.googlesource.com/1033998 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#554609}
-
Paul Jensen authored
This change builds maven modules for Cronet. Each maven module includes: 1. POM file defining module and listing dependent modules 2. Jars 3. Proguard files (optional) 4. Native libraries (optional) 5. Resources (optional) 6. Javadocs (optional) We build four maven modules: 1. cronet-api: the Cronet API 2. cronet-embedded: the Cronet native implementation 3. cronet-fallback: the Cronet fallback implementation 4. cronet-common: Cronet implementation in common with #3 and #4 To test the maven modules, this change builds the Cronet sample app using gradle. You can install and run the resulting app by: ninja -C out/Debug cronet_maven_test_build adb install -r out/Debug/cronet_maven/test/build/outputs/apk/debug/test-debug.apk adb install -r out/Debug/cronet_maven/test/build/outputs/apk/androidTest/debug/test-debug-androidTest.apk adb shell am instrument -w org.chromium.cronet_sample_apk.test/android.support.test.runner.AndroidJUnitRunner Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5ed27e86f3e01dc3a6441ab449bbe942553343af Reviewed-on: https://chromium-review.googlesource.com/998019 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#554608}
-
Alex Moshchuk authored
Bug: 837009 Change-Id: Ia239d85b546c2265e77564356d2c1a2e2fc3aa74 Reviewed-on: https://chromium-review.googlesource.com/1029006Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#554607}
-
Devlin Cronin authored
Update the context menu access strings for extensions with click-to-script enabled, and reorder the items to match the mocks. New strings: Allow access -> On click On all sites On example.com Note the host name should just include the domain, and should strip any leading www. Bug: 837701 Change-Id: I5f579d1922abb2c261ad566c16e0a3b7af8840cf Reviewed-on: https://chromium-review.googlesource.com/1033334Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#554606}
-
Emily Stark authored
This CL enables the HTTP-Bad feature by default and sets it to warn on all http:// pages, and updates tests accordingly. Bug: 837034 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I470aa09220df9e02833de8f8636ea2e66e2a6b05 Reviewed-on: https://chromium-review.googlesource.com/1029415 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#554605}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf02b736..90942960 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I21bd1f8ac887fd53615281c1f696e03bb86536cd Reviewed-on: https://chromium-review.googlesource.com/1033933Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554604}
-
John Budorick authored
This reverts commit 13dfb327. Reason for revert: Suspected cause of many test failures in https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71676 Original change's description: > Load resources.pak earlier in service manager main > > We need to use the content in resources.pak in service manager, but at > that time resource bundle has not been initialized. Create data pack to > load resources.pak and append the data pack to resource bundle during the > initialization. > > Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc. > > Bug: 729596, 815230 > Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181 > Reviewed-on: https://chromium-review.googlesource.com/962679 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Ran Ji <ranj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554500} TBR=sky@chromium.org,yfriedman@chromium.org,rockot@chromium.org,hanxi@chromium.org,ranj@chromium.org Change-Id: Ia23016b542b772581096492898b57f6c6ed3e075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 729596, 815230 Reviewed-on: https://chromium-review.googlesource.com/1034132Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554603}
-
https://skia.googlesource.com/skia.git/+log/34a388edbd27..275df2e87306 $ git log 34a388edb..275df2e87 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 bungeman Just pass color glyph masks to filters. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Icabb57b36bbd525f4e585b7ac09d4ece88b37a20 Reviewed-on: https://chromium-review.googlesource.com/1034026 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Siddhartha authored
This reverts commit cc0afbf7. Reason for revert: Move the variable to test file and use it only on official builds. Both Chromeos component and official build works. Original change's description: > Revert "Add utils to read elf binary and get Build id" > > This reverts commit 61248f1a. > > Reason for revert: Suspected breaking component builds (bug 837817) > > Original change's description: > > Add utils to read elf binary and get Build id > > > > Adds code to parse elf binary to get build id from > > .note.gnu.build-id section. The build ID is needed to symbolize > > heap dumps from the users. > > > > BUG=734705 > > > > Change-Id: If4365e232c060ba96071ba1e1c43618f9807e39c > > Reviewed-on: https://chromium-review.googlesource.com/1028995 > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#554304} > > TBR=thestig@chromium.org,ssid@chromium.org > > Change-Id: If512434b55bcc912990e3997a86f6f93722b15fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 734705 > Reviewed-on: https://chromium-review.googlesource.com/1033795 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554532} TBR=thestig@chromium.org,ssid@chromium.org,thomasanderson@chromium.org Change-Id: Ie2fb8f7fe0759dc418a1bc4ffc57bdb4542ba606 Bug: 734705, 837817 Reviewed-on: https://chromium-review.googlesource.com/1033498 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#554601}
-
https://chromium.googlesource.com/catapult.git/+log/32f02b5d358b..a4814ecb93e6 $ git log 32f02b5d3..a4814ecb9 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 dtu [pinpoint] Refactor Job creation and /api/new handler. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0c7778c140a2dbe12bf6876b8582e16640d2f963 Reviewed-on: https://chromium-review.googlesource.com/1033809 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554600}
-
Tommy Steimel authored
This is a reland of crrev.com/c/1028483. This CL removes a CSS rule that centered the audio element on the MediaDocument page. This fixes an issue where the overflow menu position calculation was incorrect. Bug: 835279 Change-Id: I028383f5201c5bee741a6fb5dd5a825a9a808736 Reviewed-on: https://chromium-review.googlesource.com/1033914 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#554599}
-
Scott Chen authored
This CL does the following: - add an <iron-collapse> containing <settings-personalization-options> in the sync subpage when unified-consent is enabled. - hide <settings-personalization-options> when unified-consent is enabled, and instead show description with a link to the sync subpage. screenshots: https://imgur.com/a/3keIzR3 Bug: 800973, 800975 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I94e0e2abde13c9260f5dbd8a0a444244c556f253 Reviewed-on: https://chromium-review.googlesource.com/1025314 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Emily Hanley authored
Bug: 836037 Change-Id: I9a927fe4655261a77965ca27cdfcf1055a9a0f1d Reviewed-on: https://chromium-review.googlesource.com/1030773 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
David Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554597}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fd804ac5704..8c9979e745c1 $ git log 3fd804ac5..8c9979e74 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:822826 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie787ee640402b0e7427e8ee809813608f4774b5f Reviewed-on: https://chromium-review.googlesource.com/1034001Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/65c255ad2076..7c7f78a432a4 $ git log 65c255ad2..7c7f78a43 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 tsepez Tidy cfx_gif.h. 2018-04-27 thestig Remove an obsolete TODO. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I69c67011b0219a9cb07db32dd91caca43b877934 Reviewed-on: https://chromium-review.googlesource.com/1034020 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554595}
-
Alexei Filippov authored
There were small visual misaligment issues that has been fixed. BUG=837760 Change-Id: I7724ec5165140344b966cf7133799eb1bad1f808 Reviewed-on: https://chromium-review.googlesource.com/1033588Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#554594}
-
Ted Choc authored
There has been a very long standing bug where FindToolbar#deactivate would crash because it was being called again during the initial processing. The cause of this (at least I think) is that deactivate causes some Android views to hide. That causes the parent view group to recalculate the desired focus target. In some cases, it finds the omnibox and triggers that to gain focus. When the omnibox gains focus, it tells FIP to hide itself, but since the focus happened in the original deactivate call, it has now re-entered deactivate and crashes. The solution (as proposed) is to introduce transitional states between active and deactive and handle them accordingly. If an activate call comes while processing deactive, it is postponed until the deactive fully finishes. BUG=830253,624332 Change-Id: I12eed279921667eb7340332ffb2991f256c12796 Reviewed-on: https://chromium-review.googlesource.com/1033484 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#554593}
-
Alexei Filippov authored
BUG=836030 Change-Id: I0a11b2dd04b21b06a33e0fd9e20c9cc299901c6f Reviewed-on: https://chromium-review.googlesource.com/1032232 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Alexei Filippov authored
BUG=836030 Change-Id: I8c01d3186568ac162cc1be118dd8faf06fcee074 Reviewed-on: https://chromium-review.googlesource.com/1033327Reviewed-by:
-
Tien-Ren Chen authored
This CL adds a new Blink compositing mode somewhere between SPv1.75 and SPv2. In this mode, layerization decisions will still be made by legacy PaintLayerCompositor/CompositedLayerMapping, but we won't be using the GraphicsLayer hierarchy generated in Blink. Instead, only the layers that host actual painted content will be generated, while the "meta" layers that apply properties (e.g. clip, effects) to the subtree will be gone. The cc-side property tree builder use to reverse engineer property trees from the meta layers (see cc/trees/property_tree_builder.cc). With the new compositing mode, the cc property trees will be created from the blink property trees directly by PaintArtifactCompositor (PAC). This is done by plugging all the drawable layers to PAC as foreign layers, and PAC will convert all the referenced blink property nodes to cc property nodes. This new mode can be enabled by passing a command line flag: --enable-blink-gen-property-trees Currently many critical mechanisms are still missing. Static pages are expected to display correctly, while most impl-thread mutations are likely to trigger a DCHECK or outright crash the renderer. BUG=836886 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I983f4bcd5f91440b5e11182e7cbe6313015d3fb4 Reviewed-on: https://chromium-review.googlesource.com/1031732 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554590}
-
Renee Wright authored
This CL adds a new settings section - crostini-page - to the basic settings page if --enable-features=ExperimentalCrostiniUI is set. If kCrostiniEnabled is false, crostini-page has a "TURN ON" button which launches the CrostiniInstallerView. Accepting the CrostiniInstallerView installs a new Crostini VM/Container. If kCrostiniEnabled is true crostini-page has an arrow to navigate to the subpage - crostini-subpage. On crostini-subpage there is a "REMOVE" button which launches a dialog to confirm removing the Crostini VM/Container. Confirming remove deletes the VM/Container, and navigates back to the basic settings page. Install/remove requests are all made by sending messages to CrostiniHandler via crostini_browser_proxy. -------------------------TO TEST THIS CL--------------------------- Patch this CL + this dependency CL - https://chromium-review.googlesource.com/c/chromium/src/+/1013824/ You may also want to patch the next CL in the set - https://chromium-review.googlesource.com/c/chromium/src/+/1023510 To make it possible to toggle the kCrostiniEnabled preference back to false in on ChromeOS on Linux you may need to change where we set it in CrostiniHandler.cc Build ChromeOS on Linux & run with --enable-features=ExperimentalCrostiniUI You can also test the full version by running it on an Eve ------------------------------------------------------------------ Bug: 833125 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If421b9780414336f058469f28192dd3c761cc7bf Reviewed-on: https://chromium-review.googlesource.com/1013957 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554589}
-
Daniel Kurtz authored
Currently the Microarchitecture table in cpu_identity only supports Intel Microarchitectures. In the future we will also want to support AMD microarchitectures, so rename all of the "IntelUarch" to the more generic "CpuUarch". BUG=b:69376360 TEST=unit_tests --gtest_filter="CpuIdentityTest.*" R=chongjiang@chromium.org, sque@chromium.org Change-Id: I57a7df62f86abba5203ab685cde62ee73db3da42 Reviewed-on: https://chromium-review.googlesource.com/1006372 Commit-Queue: Daniel Kurtz <djkurtz@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#554588}
-
Scott Little authored
It's possible for Frame::Detach() to be called before HTMLFrameOwnerElement::DisconnectContentFrame() is called, which means that if a lazy load is pending on that frame, this causes a DCHECK failure in debug builds and a crash in release builds. This CL changes the DCHECK asserting that there's no pending lazy load into a call to CancelPendingLazyLoad(). Bug: 837151, 773683 Change-Id: I1b4fae1a053aa57bd3f55585fddacf823ab81377 Reviewed-on: https://chromium-review.googlesource.com/1031386 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554587}
-
Kevin Bailey authored
The code has already been modified to assume this option if enabled. This CL actually removes the option. Bug: 780835 Change-Id: I6bc84f7eb7763136d1effc40659f65297396b7b8 Reviewed-on: https://chromium-review.googlesource.com/1033574 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#554586}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/179dd1e01695..65dbd539443e $ git log 179dd1e01..65dbd5394 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I227729f4c5d0cbe9977b58433eed4a2d5930b640 Reviewed-on: https://chromium-review.googlesource.com/1033723Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554585}
-
John Budorick authored
Also fix fuchsia layout test imports. TBR=dpranke@chromium.org,kmarshall@chromium.org,sahel@chromium.org Bug: 805057,837786 Change-Id: I9b90c985e95df053c2badce8038d57bef3f7cd8d Reviewed-on: https://chromium-review.googlesource.com/1034097Reviewed-by:
-
David Black authored
Part of a clean up effort to move assistant out of app_list. Bug: b:77637813 Change-Id: I5634cfb5511dfaf4bc000b3a007f4edcec1caba4 Reviewed-on: https://chromium-review.googlesource.com/1031737 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#554583}
-
Thomas Guilbert authored
This fixes the crashes that have started appearing on Canary. Bug: 837836 Change-Id: I47b0b68a436fcc81970277d4cf20939d08b39bf5 Reviewed-on: https://chromium-review.googlesource.com/1034002Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#554582}
-
