- 14 Jul, 2017 40 commits
-
-
Friedrich Horschig authored
Following Mac10.10, Mac10.11 broke, too. Mark flaky for all Mac platforms so sheriffs don't have to look for this when it hits Mac10.9. TBR=dcheng@chromium.org TBR_REASON=Update test expectations NOTRY=true Bug: 676229,742742 Change-Id: Iecda3eb55b891dc35ed47552b43786e80f9f4aa3 Reviewed-on: https://chromium-review.googlesource.com/571788Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#486748}
-
Becca Hughes authored
Record the Media Engagement score at playback to a histogram so we can see if the playback would have been blocked. BUG=740106 Change-Id: I7ed9659e64fd9ffcae3eafaccdf32e6755165ccb Reviewed-on: https://chromium-review.googlesource.com/566862 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#486747}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a29b8877..a97abb90 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I8f2f3087cca1f5aa2da0edeef6f65e6ed829bdd6 Reviewed-on: https://chromium-review.googlesource.com/571260Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486746}
-
Takashi Toyoshima authored
Current implementation dispatch MIDIConnectionEvent synchronously, but this should be done asynchronously according to the spec. BUG=735058 Change-Id: If49d588e36e092aa6fc40625fd88483c9ae1719d Reviewed-on: https://chromium-review.googlesource.com/545577 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486745}
-
dskiba authored
> Reason for revert: > This broke Win 64: > https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=56316 > > Original issue's description: > > [tracing] Add heap profiler perftests. > > > > This CL creates a generic place for heap profiler perftests, and adds > > couple of stack frame deduplicator related perftests. > > > > BUG=739378 > > > > Review-Url: https://codereview.chromium.org/2976843002 > > Cr-Commit-Position: refs/heads/master@{#486544} > > Committed: https://chromium.googlesource.com/chromium/src/+/f43d398eac5c9d4c2bccda6d2630d108bbed1c99 > > TBR=primiano@chromium.org,dskiba@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=739378 > > Review-Url: https://codereview.chromium.org/2981833002 > Cr-Commit-Position: refs/heads/master@{#486555} TBR=primiano@chromium.org BUG=739378 Review-Url: https://codereview.chromium.org/2975133004 Cr-Commit-Position: refs/heads/master@{#486744}
-
Nicolas Dossou-gbete authored
In addition to the All Dismissed item, we now also hide the footer that holds the Learn More link and the space at the bottom of the NTP when remote suggestions are disabled. Bug: 721407 Change-Id: I660f627c0d6fb0f9370e9604437d43227a5dafae Reviewed-on: https://chromium-review.googlesource.com/570447 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486743}
-
Hector Dearman authored
A refactor (crrev.com/c/555497) I made to ProcessMetricsMemoryDumpProvider which split logic out by platform introduced a bug. The bug caused us to double count rss anon bytes and never count vm swap bytes when computing the 'private footprint' UMA on all processes on Linux and Android. This produced a large increase in those UMA metrics. This fixes the bug. Bug: 742958 Change-Id: I893774e95154f50be0f30698b17c01ec4bfbcb1d Reviewed-on: https://chromium-review.googlesource.com/571804 Commit-Queue: Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486742}
-
Mounir Lamouri authored
Adding the necessary scaffolding to compute the CTR of media controls elements with as much precision as possible. This is not computing CTR using visibility to the user but hypothetical visibility on the page in the sense that the element was displayed in the controls but maybe never scrolled into view. In order for an element to be marked as displayed, the element has to have metadata downloaded or be set to not preload by the page or the browser. This CL also removes the CTR code for the download button and the cast overlay button given that this code is more precise and more generic. Bug: 651644 Change-Id: I86c2bc4d1a19ab99a211082d8b3546b79ea71144 Reviewed-on: https://chromium-review.googlesource.com/567194 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486741}
-
Hiroki Nakagawa authored
To improve code maintainability, this CL clarifies thread affinity of initialization and shutdown functions in worker classes. This does not change any existing behavior. Bug: 741227 Change-Id: I25fe7278130c90292b79cdd5607f10a0ef92f198 Reviewed-on: https://chromium-review.googlesource.com/567609 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486740}
-
tommi authored
Revert of Override rtc::Event with Chromium's implementation (patchset #2 id:20001 of https://codereview.chromium.org/2975553002/ ) Reason for revert: Reverting temporarily until the webrtc change can be rolled with it. Original issue's description: > Preparation of overriding WebRTC's rtc::Event with Chromium's implementation. > This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). > > Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. > > BUG=689520 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2975553002 > Cr-Commit-Position: refs/heads/master@{#486737} > Committed: https://chromium.googlesource.com/chromium/src/+/07019da77f12dc06fd8a2e66061c8a79c90bc439 TBR=grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689520 Review-Url: https://codereview.chromium.org/2981863002 Cr-Commit-Position: refs/heads/master@{#486739}
-
Rob Buis authored
Bug: 402536 Change-Id: I502447b230e2b587e4fd5f921be86053cf9830ed Reviewed-on: https://chromium-review.googlesource.com/568564Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
tommi authored
This change will give WebRTC the benefits of Chromium's checks and integration with thread and sequence runners (e.g. io and waitable checks). Followup changes include enabling the code from the WebRTC side (requires build file changes) and integrating the TaskQueue implementation in Chromium with sequence runners. BUG=689520 NOTRY=true Review-Url: https://codereview.chromium.org/2975553002 Cr-Commit-Position: refs/heads/master@{#486737}
-
Friedrich Horschig authored
TBR=dcheng@chromium.org TBR_REASON=Update test expectations NOTRY=true Bug: 676229,742742 Change-Id: I1aaf376ad020c6a4d8c2aec85714ef627132c7a2 Reviewed-on: https://chromium-review.googlesource.com/571704 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Some global "using namspace WTF" caused problems with jumbo builds and since WTF is also meant to be used without using namespace WTF this patch just replaces them with explicit namespaces. Bug: Change-Id: Ifc06e163c095de0e2ce5a8c69123578557ef0dee Reviewed-on: https://chromium-review.googlesource.com/565413Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#486735}
-
Juan A. Navarro Perez authored
Use --browser=android-webview on trybot command when selected bots include webview. NOTRY=True Bug: 740845 Change-Id: Ib1d7f436a6d290a9cb63a3f7aaebfb92581e07d8 Reviewed-on: https://chromium-review.googlesource.com/567933 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#486734}
-
Alexander Timin authored
R=rmcilroy@chromium.org BUG=739750 Change-Id: Iccb5f8ecaf72f2c73b2d23bd2c29bc2e2cb88cfe Reviewed-on: https://chromium-review.googlesource.com/570420Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486733}
-
Tatsuhisa Yamaguchi authored
TEST=manually tested get-info command enabled for single selection and disabled for multiple selection TEST=manually tested chrome://histograms records the new way to open QuickView as #2. Bug: 740842 Change-Id: I3c9d58f7d3877e7b059bb386a56cdc8d4e54a43b Reviewed-on: https://chromium-review.googlesource.com/571380 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486732}
-
Friedrich Horschig authored
This reverts commit 37c3e0b6. Reason for revert: Breaks some bots[1] due to ValueIteratorsTest.ConstDictIteratorOperatorNE attempting to compare iterators from different sequences. Did you mean to compare contents? [1] e.g. https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28161 Original change's description: > Add Dictionary API to base::Value > > This change introduces |FindKey|, |FindKeyOfType|, |SetKey|, |DictEnd| and > |DictItems| to base::Value. These methods are part of the new API proposal and > abstract away the pointer based underlying storage of Dictionary Values. > > Bug: 646113 > Change-Id: I09150f3b2fd47e24074caa50a30a058fc4f558a7 > Reviewed-on: https://chromium-review.googlesource.com/561682 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486709} TBR=vmpstr@chromium.org,brettw@chromium.org,jdoerrie@chromium.org Change-Id: I1f0e287a99fb5ebd6f228b762d77e446bac5b3af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 646113 Reviewed-on: https://chromium-review.googlesource.com/571782Reviewed-by:
-
Yutaka Hirano authored
This CL cleans up preload related states in Resource as following: - Removes preload_count_ and introduces is_unused_preload_. With this change, a resource can be a preload for only one request, and hence tied to one ResourceFetcher at a time. - Renames IncreasePreloadCount and DecreasePreloadCount to MarkAsPreload and MatchPreload respectively. - Removed preload_result_. - Changes the timing of kPreloadNotReferenced => kPreloadReferenced (i.e., true => false for is_unused_preload_) state transition from when a ResourceClient is added to when MatchPreload is called. - Removes PreloadReferencePolicy. Bug: 652228 Change-Id: I6564c0eed24f19051ee49c429cf87db746414023 Reviewed-on: https://chromium-review.googlesource.com/544363 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486730}
-
Marc Treib authored
Hidden behind new feature CaptureThumbnailOnNavigatingAway. This is very similar to what NavigationEntryScreenshotManager does. Hopefully this is a better time for capturing screenshots than when a page load finishes (see crbug.com/737396 and crbug.com/741856). Bug: 718413 Change-Id: I0fbcc7964b9f89c7ce589a197ac85b85a41385ba Reviewed-on: https://chromium-review.googlesource.com/570318Reviewed-by:
-
Dominic Battre authored
Replace constexpr char[] with extern const char[] in header because we are unsure whether the former does the right thing or whether there is a risk of unnecessary overhead. NOTRY=true Bug: 732846 Change-Id: Ic328d6568325072cef6ab7b9b9b0ce36bb587cb0 Reviewed-on: https://chromium-review.googlesource.com/571747 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#486728}
-
Kunihiko Sakamoto authored
This adds UMA to track the peak number of requests with "running" state in ResourceLoadScheduler. The value is reported when the frame is reached the network 2-quiet state. Bug: 729951 Change-Id: I6d2c6f5f5094a0a8071904484cb10d14de087e7c Reviewed-on: https://chromium-review.googlesource.com/564872Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486727}
-
Kouhei Ueno authored
The task handle is never cancelled, so it can be replaced w/ a simple PostTask. The task lifetime is managed by weakPersistent anyways. Bug: None Change-Id: I191c9cad4982c42ba5d0177d1464d32b31bc2354 Reviewed-on: https://chromium-review.googlesource.com/571110Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This is preparation to split LayoutSelection start/end calculation w/o canonicalization. Bug: 739062 Change-Id: I8574fec9a82433e0b7313499db2f3068d9388b22 Reviewed-on: https://chromium-review.googlesource.com/571523Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486725}
-
yhanada authored
Android notifications from ARC++ implement inline reply feature, so it needs to be able to open the virtual keyboard and the message center simultaneously. - Pass the hit NativeView instead of the hit Widget to OnPointerEventObserved. - Do not call ClickedOutsideBubble when clicking on the virtual keyboard. Bug: 722248 Test: Unit tests are added. Change-Id: I7df8a1ec6cf2c1af4a5e7274cb93c8af6b3e1022 Reviewed-on: https://chromium-review.googlesource.com/532768 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#486724}
-
Nicolas Dossou-gbete authored
This is a reland of 139a79ec Original change's description: > [Suggestions] Remove CTAs when feature is disabled > > Stops showing the Sign in Promo and the All Dismissed item when remote > suggestions are disabled and performing the advertised actions would not > provide the user with new suggestions. > > Part of this CL involves making the SuggestionsSources notifies a list > of observer rather than a single one. > > Bug: 738872 > Change-Id: I16c300fb14a1d5780578387d48d848570339befe > Reviewed-on: https://chromium-review.googlesource.com/567182 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486034} Bug: 738872 Change-Id: Ifc5f6643b4402657b9a62e08596d9e3267ce79a8 Reviewed-on: https://chromium-review.googlesource.com/571722Reviewed-by:
-
Takeshi Yoshino authored
Bug: Change-Id: Ib3b20abc3e21e02bca2aa597342ad9907c1b23aa Reviewed-on: https://chromium-review.googlesource.com/571252Reviewed-by:
-
jdoerrie authored
This change adds support for app display names to Password UI Utils. This is useful for the more human friendly display of Android credentials, as this will display the Play Store name of the App, if available. Bug: 628988, 617094, 679434 Change-Id: Ide7bc694805ce40cbbccf8e8496c32bcb677de25 Reviewed-on: https://chromium-review.googlesource.com/567936 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486721}
-
Nicolas Dossou-gbete authored
Make the SuggestionsSource be destroyed after all the other DestructionObservers to ensure they are still able to use it while they are being destroyed. Bug: 742056,738872 Change-Id: I36c299297c647c5fb9e680d49d5912a4469f02da Reviewed-on: https://chromium-review.googlesource.com/570298 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
-
yoshiki iguchi authored
This CL fixes the wrong reverse focus order of notification (see the issue for detail). Previously the close and settings buttons are skipped in reverse order. This also fixes the visibility of close and settings button. These buttons should be visible only when they have a focus. Previously they are visible even when the focus is not on these buttons but on the notification. BUG=739293 TEST=manual test Change-Id: I8af330314410bf4b1a26be51d86cee312b4344ab Reviewed-on: https://chromium-review.googlesource.com/571522Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#486719}
-
Yoshifumi Inoue authored
This patch introduces |TypingContinuation| enum class as replacement of |FrameSelection::SetSelectionOptions| to include of "FrameSelection.h" from "SpellChecker.h" for improving code health. Note: Since "Editor.h" still use |FrameSelection::SetSelectionOptions|, we could not remove it in this patch. This patch is a preparation of the patch[1]. [1] http://crrev.com/569662: Introduce SetSelectionData for FrameSelection::SetSelection() Change-Id: I87601bbca3b1cada0a30fd5a86904bed84828423 Reviewed-on: https://chromium-review.googlesource.com/569840 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#486718}
-
Christos Froussios authored
The individual setters for each parameter required for OSCrypt's initialisation are replaced by a single setter for a Config struct. The Config definition is moved to a separate file. The result is less code, especially in the top level files of OSCrypt. Bug:709096 Change-Id: If6f05129879fcae86b1b2bf032641b05418fe8ee Reviewed-on: https://chromium-review.googlesource.com/565567Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch unifies base/extent and start/end in |VisbileSelectionTemplate| to simplify |VisbileSelectionTemplate| for improving code health. Before this patch, base/extent were used for holding start position of granularity expansion and non-visibly shrunk positions, e.g. start/end hold |Most{Back,For}wardCaretPostion()|. After this patch base/extent and start/end are identical with considering direction, in forward selection base == start and extent == end, in backward selection base == end and extent == start. For changes in "TypeCommand.cpp" and "SelectionController.cpp" are canceling |Most{Back,For}wardCaretPostion()| of start/end for checking equality, for example: "|<b>foo</>" (most backward caret position) vs. "<b>|foo</b>" (most forward position). Note: |VisiblePosition| is tend to be most backward caret position. Following patch will get rid of |start_| and |end_| from |VisbileSelectionTemplate|. Note: Changes for "TypeCommand.cpp" are for "undo-delete-boundary.html": Changes for "SelectionController.cpp" are for "selection-bidi.html": Bug: 230267 Change-Id: I255cbeb331a1da36ae6a569ce7bfd9c59b018eab Reviewed-on: https://chromium-review.googlesource.com/569507Reviewed-by: -
Tatsuhisa Yamaguchi authored
This change will only add these items: - Cut, Copy - zip selection "Available offline" is not refreshed in some cases. "Get info" and "Rename" is not added by this change. Those should be fixed by another change. TEST=manually tested by check-select files and opening the menu Bug: 740842 Change-Id: Ic074b3b38eddf5c1bd9d8ae162e5c0d24bb17c8e Reviewed-on: https://chromium-review.googlesource.com/566768Reviewed-by:
-
yhanada authored
This implements the wayland extended_keyboard interface for ack_key events. The client will use this interface to send whether received key events are handled or not. This CL doesn't have to be submitted together with Android side CL. Android container can run without the Android side CL. Bug: b/28104183, b/36384707 Test: Android container runs and we can start apps. Change-Id: I8191e29ca0538b29305dcc6b707bf1b10b32d30b Reviewed-on: https://chromium-review.googlesource.com/558335 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486714}
-
Daniel Vogelheim authored
R=mkwst@chromium.org Bug: 708041 Change-Id: Ib049e39a0d8bd33b7625273614e5ad28dbb26937 Reviewed-on: https://chromium-review.googlesource.com/565403Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#486713}
-
oka@chromium.org authored
In the following scenario, time between (1) to (4) was exported. We should export the time for (4). (1) ShowKeyboard is called (2) Before animation finishes, HideKeyboard is called (3) time passes. (4) ShowKeyboard is called and keyboard is actually shown. Bug: 742721 Change-Id: I1fc3a92cea7bfce25e8efb407a3e41508a367c36 Reviewed-on: https://chromium-review.googlesource.com/571108Reviewed-by:
-
Christian Dullweber authored
Content Settings don't need to be filterable and using WebsiteSettingsFilterAdapter doesn't work in some cases. Bug: 741934 Change-Id: I765cd9683079fa7592afc3aedc0ea0f243d782ed Reviewed-on: https://chromium-review.googlesource.com/570241Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#486711}
-
Alexander Alekseev authored
This Cl removes references to iron-flex-layout in OOBE/Login UI. Bug: 719331 Change-Id: Iedde72b6e5db6c44820394cf44f4d876d43ff07e Reviewed-on: https://chromium-review.googlesource.com/566538 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#486710}
-
jdoerrie authored
This change introduces |FindKey|, |FindKeyOfType|, |SetKey|, |DictEnd| and |DictItems| to base::Value. These methods are part of the new API proposal and abstract away the pointer based underlying storage of Dictionary Values. Bug: 646113 Change-Id: I09150f3b2fd47e24074caa50a30a058fc4f558a7 Reviewed-on: https://chromium-review.googlesource.com/561682 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486709}
-
