GitLab

This should make the chromium.webrtc waterfall work like the old
test config in recipes. It incorporates some fixes made in the
recipe code and creates composite test suites for the chromium.webrtc
bots.

Bug: 877018
Change-Id: I11b91c4e9516844086978b5a63b816576197585b
Reviewed-on: https://chromium-review.googlesource.com/c/1280669Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599947}

Disable BottomToTopExpanded and BottomToTopCollapsed

TBR: marq, kkhorimoto
Bug: 880672
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If4c71557240e8589b52d6fe53491d661a5ff3a26
Reviewed-on: https://chromium-review.googlesource.com/c/1283029Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599946}

This is a reland of 48c7a842

Original change's description:
> [sync::test] Add two client integration test for custom passphrase
> 
> Add a Sync integration test which exercises custom passphrase flows in
> an end-to-end manner with two clients. The test ensures that two clients
> can sync data properly in the presence of custom passphrase-based
> encryption and different key derivation methods.
> 
> Refactor SetScryptFeatureState() from the single-client test to a scoped
> feature toggler that resides in encryption_helper, because the
> functionality now needs to also be used from the two-client test.
> 
> Bug: 894148
> Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02
> Reviewed-on: https://chromium-review.googlesource.com/c/1277648
> Commit-Queue: David Davidović <davidovic@google.com>
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599929}

Bug: 894148
Change-Id: I425db59e1427f2c3ebf1cb9cd8b2ee440fd31ce1
Reviewed-on: https://chromium-review.googlesource.com/c/1283012Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: David Davidović <davidovic@google.com>
Cr-Commit-Position: refs/heads/master@{#599945}

https://webrtc.googlesource.com/src.git/+log/f0e926fbdd8f..1927dfafabc0


git log f0e926fbdd8f..1927dfafabc0 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 magjed@webrtc.org Add tool for aligning color space of video files


Created with:
  gclient setdep -r src/third_party/webrtc@1927dfafabc0

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic041226cf06b7150fb4a320b72202eed70b8cc08
Reviewed-on: https://chromium-review.googlesource.com/c/1282333Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599944}

This CL moves the existing SettingsDetailItem to Legacy and creates a
new SettingsDetailItem which is now a subclass of the TableViewItem.
The new SettingsDetailItem now support Dynamic Type.

Bug: 894791
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia001bf2bdd59bb71a81d228ebf7f905f5600eebf
Reviewed-on: https://chromium-review.googlesource.com/c/1251625Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599943}

A recent albatross build is showing that this DCHECK is firing. Splitting apart
the DCHECK will allow diagnosing which condition is failing.

BUG=895520

Change-Id: I4dcb6a819b308ab407666c81b90536b8fcfef7cb
Reviewed-on: https://chromium-review.googlesource.com/c/1282728Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599942}

Also fix a couple of comments and make sure all icons are the
same height. We might want to enlarge them all in a future CL,
but they should at least match.

Bug: 860467
Change-Id: I78eb219771a94aa41d7eb312f072ebde8cc65d56
Reviewed-on: https://chromium-review.googlesource.com/c/1280768Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599941}

If a commit succeeds, but the response does not come back fast enough
then the |bookmark_tracker_| might assume that it was never committed.
The server will track the client that sent up the original commit and
return this in a get updates response.

This CL makes sure that the processor detects this case and updates
the persisted server id accordingly.

Bug: 516866
Change-Id: Ida0e66345b3f55b6ac8b595ddb5c676024698706
Reviewed-on: https://chromium-review.googlesource.com/c/1280434
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599940}

This feature was launched in M67.

Bug: 788621
Change-Id: I59aaf51c5b129d7c01d90076c779a0a747c81d28
Reviewed-on: https://chromium-review.googlesource.com/c/1282483Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599939}

This feature was launched in M65.

Bug: 788619
Change-Id: Ia6f9794301f05b91fbd3edc5bbeddfe24944eadd
Reviewed-on: https://chromium-review.googlesource.com/c/1282684Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599938}

When DCHECKs are enabled, this test crashes the test runner (but not when
content_shell is run manually) and blocks WPT imports. When DCHECKs are
disabled, the runner treats it as a pixel test and produces wrong results.

TBR=foolip, robertma

Bug: 895777
Change-Id: Ia0cb5bcbfb56a67e10bfd93a01ab6995fb02d328
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1283130Reviewed-by: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#599937}

This CL implements:

1.Processing of presaving of the generated password in
NewPasswordFormManager.

2.Processing of other generation related actions:
PasswordNoLongerGenerated etc

3.Teaching PasswordManager to use the right form manager for generation
related actions and adding new methods in PasswordFormManagerInterface.

4.Adding |driver| into arguments of generation related functions in
PasswordManager (in order to match correctly NewPasswordFormManager and
the form with the generated password).

Bug: 831123
Change-Id: I285a93d8a6b9b9d79cecd2aac747461f1650779e
Reviewed-on: https://chromium-review.googlesource.com/c/1261696
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599936}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Iec1e83d31a7feba4c2b6093b0597772d96a70c4a
Reviewed-on: https://chromium-review.googlesource.com/c/1282332Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599935}

Bug: 888447
Change-Id: Ia1e4f56f6c4f764602ce9c03d54906810958d902
Reviewed-on: https://chromium-review.googlesource.com/c/1280603
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599934}

This is a reland of aa6c62dc

Original change's description:
> Move InstallAttributes to chromeos/settings
>
> Necessary for moving CrosSettings to chromeos/settings, so it
> can eventually be used by Mustash.
>
> The following changes were necessary:
> 1. Move install_attributes{.h, .cc} and unit_test.cc
> 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
> (destination)
> 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
> which is included by install_attributes.h
>
> 4. Unfortunately, that same dependency lead to a circular dependency.
> I was able to avoid that by separating out a "common_constants" rule in
> components/policy/core/common, so that chromeos/settings only depends on
> that, and not on all of components/policy. So I had to change
> components/policy/core/common/BUILD.gn
> and I removed an unnecessary include from
> components/policy/core/common/cloud/cloud_policy_constants.cc
>
> 5. Update #include directives for install_attributes to point to new
> location. This is the other 22 files, all with diffs of +1 -1.
>
> Bug: 446937
> Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
> Reviewed-on: https://chromium-review.googlesource.com/c/1264757
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Commit-Queue: A Olsen <olsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599140}

Bug: 446937
Change-Id: If20ad953b2cb9c3808415c7c112eec8d0e97915b
Reviewed-on: https://chromium-review.googlesource.com/c/1278750Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599933}

https://webrtc.googlesource.com/src.git/+log/c9e6b969a452..f0e926fbdd8f


git log c9e6b969a452..f0e926fbdd8f --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tzik@chromium.org Add missing #include and deps to absl/memory
2018-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0e821c2f..0cecb6ce (599702:599821)
2018-10-15 srte@webrtc.org Reland "Deprecates legacy transport feedback adapter."
2018-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0df2607f..0e821c2f (599562:599702)


Created with:
  gclient setdep -r src/third_party/webrtc@f0e926fbdd8f

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:752720,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib8cd893ebca559660e96d2ad5f854a56091dc325
Reviewed-on: https://chromium-review.googlesource.com/c/1282329Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599932}

This reverts commit 48c7a842.

Reason for revert: Broke compile step
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20LSan%20Builder/60281


Original change's description:
> [sync::test] Add two client integration test for custom passphrase
> 
> Add a Sync integration test which exercises custom passphrase flows in
> an end-to-end manner with two clients. The test ensures that two clients
> can sync data properly in the presence of custom passphrase-based
> encryption and different key derivation methods.
> 
> Refactor SetScryptFeatureState() from the single-client test to a scoped
> feature toggler that resides in encryption_helper, because the
> functionality now needs to also be used from the two-client test.
> 
> Bug: 894148
> Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02
> Reviewed-on: https://chromium-review.googlesource.com/c/1277648
> Commit-Queue: David Davidović <davidovic@google.com>
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599929}

TBR=treib@chromium.org,vitaliii@chromium.org,davidovic@google.com

Change-Id: I8913698d352dc65ea9da27b052425a53394ff879
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894148
Reviewed-on: https://chromium-review.googlesource.com/c/1283030Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599931}

It's important to explicitly shutdown history service if it's using own
thread. Otherwise thread will keep working after calling RunUntilIdle()
and will be able to post tasks to UI thread. This tasks will not be
processed which will lead to leaking of HistoryDBTask (which is
destroyed in this tasks).

Change-Id: I63495794c257983dfdae3f3c7671d89e96eea8f8
Reviewed-on: https://chromium-review.googlesource.com/c/1280545Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#599930}

Add a Sync integration test which exercises custom passphrase flows in
an end-to-end manner with two clients. The test ensures that two clients
can sync data properly in the presence of custom passphrase-based
encryption and different key derivation methods.

Refactor SetScryptFeatureState() from the single-client test to a scoped
feature toggler that resides in encryption_helper, because the
functionality now needs to also be used from the two-client test.

Bug: 894148
Change-Id: Ia211b221f89a99092d3b19690ecae6bb4fa77d02
Reviewed-on: https://chromium-review.googlesource.com/c/1277648
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599929}

Change the following tests to use FakeExtensionProvider instead of Drive
as their instance of an external filesystem:
- ArcFileSystemBridgeTest
- FileManagerFileAPIUtilTest
- ExternalFileURLRequestJobTest
DriveFS uses a mostly-native filesystem so won't be usable for these
tests. FakeExtensionProvider will continue being usable after DriveFS is
enabled.

Change FileManagerPrivateApiTest.Mount to disable Drive. DriveFS relies
on DiskMountManager to mount. This test mocks out DiskMountManager
rendering DriveFS unable to mount.

Set up and populate a fake DriveFS instance for each profile in
MultiProfileDriveFileSystemExtensionApiTest.

Update FileManagerUrlUtilTest.GetFileManagerMainPageUrlWithParams_NoFileTypes
with correct expectations depending on whether DriveFS is enabled. Also
change it to not compare pretty-printed JSON strings so the difference
between DriveFS enabled and disabled is clear.

Bug: 891197
Change-Id: I2c1e582d0750a2a91cd24004f8ac552688e2a811
Reviewed-on: https://chromium-review.googlesource.com/c/1275826
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599928}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/642641d03012..c68a1753c53a


git log 642641d03012..c68a1753c53a --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tandrii@chromium.org git cl try-results: delete Rietveld support.
2018-10-16 tandrii@chromium.org git cl: delete no longer used Rietveld methods.
2018-10-16 tandrii@chromium.org git cl: rename and relocate CreateDescriptionFromLog func.
2018-10-16 tandrii@chromium.org git cl description: rename gerrit test.


Created with:
  gclient setdep -r src/third_party/depot_tools@c68a1753c53a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408,chromium:770408,chromium:770408
TBR=agable@chromium.org

Change-Id: Ic4f1250d1162d63fd94b4636004ba2ce4a2ffc17
Reviewed-on: https://chromium-review.googlesource.com/c/1282350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599927}

This reverts commit c3e902dd.

Reason for revert: this cl causes linux MSAN cc_unittests failures:

RasterizeWithGpuRasterizationCreatesResources.RunMultiThread_DelegatingRenderer
RasterBufferProviderTests/RasterBufferProviderTest.MeasureGpuRasterDuration/2
LayerTreeHostPictureTestResizeViewportWithGpuRaster.RunSingleThread_DelegatingRenderer

  [ RUN      ] RasterizeWithGpuRasterizationCreatesResources.RunMultiThread_DelegatingRenderer
  ==2667==WARNING: MemorySanitizer: use-of-uninitialized-value
      #0 0x5974de0 in Do<long> ./../../base/numerics/safe_math_clang_gcc_impl.h:74:13
      #1 0x5974de0 in Do<long> ./../../base/numerics/checked_math_impl.h:54:0
      #2 0x5974de0 in MathOp<CheckedAddOp, long> ./../../base/numerics/checked_math.h:245:0
      #3 0x5974de0 in operator+=<long> ./../../base/numerics/checked_math.h:339:0
      #4 0x5974de0 in base::time_internal::SaturatedAdd(base::TimeDelta, long) ./../../base/time/time.cc:70:0
      #5 0x49b3d8e in operator+ ./../../base/time/time.h:207:22
      #6 0x49b3d8e in cc::GpuRasterBufferProvider::CheckRasterFinishedQueries() ./../../cc/raster/gpu_raster_buffer_provider.cc:558:0

Seems, GetQueryObjectuivEXT doesn't always initialize gpu_duration:

GLuint gpu_duration;
    ri->GetQueryObjectuivEXT(it->query_id, GL_QUERY_RESULT_EXT, &gpu_duration);

Original change's description:
> gpu: Add UMA metric for measuring total raster task duration.
> 
> Add an UMA metric which reports the accumulated time for a raster task
> including the time from raster worker thread and the GPU main thread.
> The GPU side timer takes care of only measuring time slices when the
> decoder is processing commands.
> 
> R=​vmiura@chromium.org, piman@chromium.org
> 
> BUG: 894200
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: If02a76420dbdf5ffb5041b8290412d144d787fb4
> Reviewed-on: https://chromium-review.googlesource.com/c/1267235
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599870}

TBR=enne@chromium.org,vmiura@chromium.org,holte@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org,piman@chromium.org

Change-Id: I25b54841dca13aaa94cfc8dded8a40254f90d8e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1282519Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599926}

It was using SigninManagerBase API to get the primary (authenticated)
account id. It's now using the IdentityManager API.

Bug: 890808
Change-Id: Ifabe11ca68de07949fcad2f81c022723dcb842ef
Reviewed-on: https://chromium-review.googlesource.com/c/1276769Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#599925}

Since Origin logic was moved to Java, we can make the tests JUnit tests.

Change-Id: Ied7b7d53bddb1847e81c62995f12d8ca82472852
Reviewed-on: https://chromium-review.googlesource.com/c/1280607
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599924}

This reverts commit eb25f32f.

Reason for revert: Suspect for build failures on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device-xcode-clang


Original change's description:
> [ios] Move xcode-clang builders to Xcode 10.
> 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac
> Reviewed-on: https://chromium-review.googlesource.com/c/1278332
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599804}

TBR=justincohen@chromium.org,jbudorick@chromium.org

Bug: 895761
Change-Id: I9b1b83455bd9b27fdf9b6e7120467e3e87305007
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/c/1282949Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599923}

The well-formed JSON.stringify() proposal changes JSON.stringify() to
produce JavaScript/JSON-compatible escape sequences for any lone
surrogates in its input.

Because the test runner's `shouldBeEqualToString` uses `JSON.stringify`
before comparing strings, these tests would otherwise break when
shipping the `JSON.stringify()` change.

Bug: v8:7782
Change-Id: If6ace9c023be8997ed10c8f1dbc2dcaed18c4687
Reviewed-on: https://chromium-review.googlesource.com/c/1281965
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599922}

Rename error_util.js to error_counter.js to better describe its usage
and avoid the generic term "util".

Bug: 893430
Change-Id: I9cbb7f2f5ee09bf02d190dfb27d05e762bdde59f
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/c/1282682
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599921}

https://pdfium.googlesource.com/pdfium.git/+log/6ea4d08b905d..bb3f58dbcb71


git log 6ea4d08b905d..bb3f58dbcb71 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 thestig@chromium.org Add pdfium_test --show-pageinfo to dump page bounding boxes.
2018-10-16 thestig@chromium.org Use more unique_ptrs in cfx_psrenderer.cpp for FaxCompressData().
2018-10-16 thestig@chromium.org Make {A85,RunLength}Encode()'s buffer out parameter a unique_ptr.


Created with:
  gclient setdep -r src/third_party/pdfium@bb3f58dbcb71

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I632d5f7ef143a9f431663bd146884e8f2cf95263
Reviewed-on: https://chromium-review.googlesource.com/c/1282351Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599920}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f73b9a1f180..c98f7a176af9


Created with:
  gclient setdep -r src-internal@c98f7a176af9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id86a7a5d600f6a1160abb73aea29b6b0e7e92965
Reviewed-on: https://chromium-review.googlesource.com/c/1282328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599919}

And it's marked as such in the main expectations file.

TBR=kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1ffa182d2ca9ccbd2ef73e8f3171c0ed0355c595
Reviewed-on: https://chromium-review.googlesource.com/c/1282065
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599918}

The two-argument version of UMA_HISTOGRAM_ENUMERATION can autodeduce the
correct boundary value, so use that instead of defining a placeholder
enumerator value that needs to be ignored in switch statements.

Bug: 742517, 857134
Change-Id: I74ca2ace85fc6f3955f6f3a5e772e15bad8776e9
Reviewed-on: https://chromium-review.googlesource.com/c/1278060Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599917}

When checking for presence of an element on a page, we now also compute
the element BoxModel to make sure it is present on the page. This is
necessary because some scripts have conditional actions (e.g. click on
element X if X is on the page) which would fail if the element they act
on has no box model but is still considered on the page.

This makes the check for existence much slower, but for now correctness
is more important than speed.

Bug: 806868
Change-Id: Ibab82898c4ac3dc198b30ba8c10080d3bbebb474
Reviewed-on: https://chromium-review.googlesource.com/c/1280668
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599916}

Block sizes are also not resolvable if the available block size is
indefinite.

There was no test coverage for this in the block directions, so added
a couple of tests. They are not exportable to WPT, since we're using
-webkit-fill-available.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1020503de9e8d66ebf9d89a499937b0d58ef4c3a
Reviewed-on: https://chromium-review.googlesource.com/c/1278993
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599915}

Just update the render tree dump (it's closer to legacy now, than what
it used to be). The screenshot matches anyway.

TBR=kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ibd3815ac650375ebf7a684eea44e00e4bf70e022
Reviewed-on: https://chromium-review.googlesource.com/c/1282408
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599914}

[TreatNullAs] is applicable on DOMString, so the previous declaration
  [TreatNullAs] optional DOMString
violates WebIDL grammer.
This CL fixes it.
Its spec also needs to be updated.


Bug: 819112
Change-Id: Ifabca102c3969f3421817e41ad0d3f726643d047
Reviewed-on: https://chromium-review.googlesource.com/c/1281462Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599913}

This will allow the page_load_metrics component to observe the jank.

Also address nits in JankTracker::NotifyPrePaintFinished (empty viewport
check, DCHECK for non-zero jank fraction).

Bug: 581518
Change-Id: I22eab226dac31bd1b0ce284240bbca019ce49868
Reviewed-on: https://chromium-review.googlesource.com/c/1280616Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599912}

Bug: 888904
Change-Id: I7f6cda10647b4a14fb6b1de821603f99d1cc8008
Reviewed-on: https://chromium-review.googlesource.com/c/1282085Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599911}

This patch adds only one basic test (sxg-location.tentative.html); more
tests will be converted from layout tests in following CLs.

For now, Signed Exchange and certificate are checked-in as static files,
assuming that UAs are configured to ignore signature expiration errors.

The test is marked as tentative as this is an experimental feature.

Bug: 895723
Change-Id: If762a0bf9c498ab3339b4aa09461d37d302e0210
Reviewed-on: https://chromium-review.googlesource.com/c/1282763Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599910}

This adds both finch and about:flags flag.

Intent to ship discussions:
https://groups.google.com/forum/#!topic/v8-users/ML7gOgK8Dsg
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/74QxqINq4g0

Bug: v8:8267, chromium:893469
Change-Id: Ib5a84519d48b9b82604875ff269f0e04977914d5
Reviewed-on: https://chromium-review.googlesource.com/c/1268200
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599909}

Currently, the element timing is provided to the frame that owns the
<img> element. In particular, no origin checks are being made. This CL
fixes this by doing the following:
* Checking the image origin matches the hosting frame's origin before
performing the computations in ImageElementTiming::NotifyImagePainted.
* Plumbing the information to parent frames for as long as they exist
and are same origin as the current frame.

Bug: 879270
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If744dbc0448e3024ca5d16b59b2b1dc0f436ee58
Reviewed-on: https://chromium-review.googlesource.com/c/1277675Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599908}