- 05 Oct, 2020 40 commits
-
-
Yifan Luo authored
Bug: 1116418 Change-Id: I0aedefbba5eb452d6bbcaa934d909b1dbb65c4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416590 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#813726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/10850e1e5ba9..74f8dbb95782 2020-10-05 jleconte@google.com Fix empty alert list issue when triaging. 2020-10-05 jleconte@google.com Fix pop up statement when triaging with an existing bug. 2020-10-05 jleconte@google.com Bisect on a chart with empty Bug ID fails. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: oysteine@google.com Change-Id: I36c1cfe10376ea7ea7f985cf703838dad4793a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813725}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e56466d4848c..ef897a9c3ec2 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 375fee944c76 to b3c1e71eb1cb (2 revisions) 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d91afd8de27a to f15133788010 (3 revisions) 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from e1ba543c6789 to 94ff600cc862 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: If1a34d4f5e19a1a9280908a1f0f4d77b0546f3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813724}
-
Chris Sharp authored
This reverts commit c64eed06. Reason for revert: Broke virtual/eye-dropper/color-picker-show-eye-dropper.html on WebKit Linux MSAN Original change's description: > Add security mitigations for eye dropper IPC. > > As discussed on the security review this CL adds the following mitigations: > - require a transient user activation on the browser side, and consume > it when showing the eye dropper for the renderer (this will prevent a > compromised renderer to repeatedly ask for a color) > - require the eye dropper UI to be visible for a minimum amount of time > before color selection is allowed in order to ensure the user has a > chance to see the UI. > > There is also a fix for the popup not correctly updating the user > activation state. This happens because it is using a > EmptyLocalFrameClient and its frame is not related to the > owner element's frame. > > Bug: 992297 > Change-Id: Ia5d2aead0be153ce4b49048552062de3a6c72e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442132 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812847} TBR=avi@chromium.org,danakj@chromium.org,tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com NOTRY=true Bug: 992297 Change-Id: If16db478fb59c4caa6f4fd90190adb72ce38e68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448054 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813723}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e51078b0b92b..fbcd4c1d714d 2020-10-05 jacktfranklin@chromium.org Migrate media/PlayerMessagesView to TS 2020-10-05 szuend@chromium.org [ts] Type-check network/NetworkItemView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0f1b9d460cb3a3d5a20562f2cc0b5d22f45f8757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813722}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia6051b73d2a757045775eb89a131354200f3fa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448661Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#813721}
-
Chris Sharp authored
TBR=schenney@chromium.org NOTRY=true Bug: 626703 Change-Id: I2c309e1f37776358b8058e3d94b0452b87870374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449929Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813720}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Id57a75e0a359be08f4a14a11d8d71419705220b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446050 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813719}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ia503bd748f633f2526feafc81c823f6b78132710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446051Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43865d38f022..97440de4b947 2020-10-05 kjlubick@google.com [canvaskit] Add docs/types for Canvas. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I37227862783a51f737efa62280b9c6d3f0f3d927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813717}
-
Mikel Astiz authored
This is a follow-up to crrev.com/c/2329751 to support notifying observers, along with an API to resolve the recoverability errors. The actual TrustedVaultClient implementations are left unimplemented, except for StandaloneTrustedVaultClient where minimal logic is introduced to support semi-realistic integration tests. Change-Id: I63acc6196fee59d24edbd1d3816f19ef8e15930a Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448491 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#813716}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af6c5c622733..7cdc44f903d3 2020-10-05 hjd@google.com Merge "ui: Stitch small TraceHttpStream chunks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I53725d1e1165b39ca45468811fba435beee5a4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813715}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64b018448b3e..388b07889beb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: koerber@google.com Change-Id: I886d6b1d98426eb3d08b62cb091d76c4a928cafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449128Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813714}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fc8a89c..497b7a37 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32a0d5dec093a720b50757c097af33635f427312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813713}
-
Anna Malova authored
This is a reland of bd3b0ee6 Original change's description: > [aw] Allow to set Network in AwPacProcessor. > > Bug: 1085115 > Change-Id: I8846261a0f21ecb48692b70ab778f68996843760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414173 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Anna Malova <amalova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812494} Bug: 1085115 Change-Id: I8fc91488e417534238d916907d4d2a7c64963c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445489Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#813712}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ed3a93f690de..df909306835a 2020-10-05 cwallez@chromium.org wire::client: Make Buffer::MapAsync surface server-side errors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8746fc6fddb4eaeba750ff4d295fda7121b2f74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813711}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I8f6218da609139d1edb24b56f782bbd0eb12d1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445413Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813710}
-
Ossama Mahmoud authored
Previously, during the post login steps the Apps button stays visible, and starting an app crashes the recently started user session. This is fixed by hiding the Apps button in all post login dialogs. Hide Apps button after a user session has started Bug: 1124319 Change-Id: Ie1c1f72c4dd473b928c3f93dc5fbeaf8f03cb30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407312 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813709}
-
Kyle Williams authored
Convert the antiquated use of InterfaceRequest/InterfacePtr to its updated equivalent to comply with the current standards as well as to continue passing presubmits and other checks put in place. BUG=b:169582064 TEST=`autoninja -C out/Default chromeos:chromeos_unittests && ./out/Default/chromeos_unittests --dbus-stub --single-process-tests --gtest_filter=CfmServiceConnectionTest.*` Change-Id: Iafb58b5713964a7c6d6d5afab71c8d384000eb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436990Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#813708}
-
Ilya Nikolaevskiy authored
Bug: webrtc:11485 Change-Id: I843b0babbcc5ac1169ab09ea957d5df02bc52f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449333 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#813707}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If20b5506cfc26722eab609ca0df9d126929bbb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813706}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae5e8ebda79e..895556e19c08 2020-10-05 eshr@google.com Avoid converting frames to I420 in VideoStreamEncoder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc2a46cc30a95f20a49d2b2ba055e9f531319b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813705}
-
Richard Knoll authored
This converts the unchecked observer lists to a checked ones to catch potential use-after-free issues earlier. Bug: None Change-Id: I291a34c4f6115c32449b99725a6da57a2702e862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437372Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813704}
-
Richard Knoll authored
Both OnSlideOut() and RemoveNotification() might destroy |this|. This fix as been tried before in crrev.com/c/2001943 but that CL missed copying the |notification_id| to the stack. Bug: 983009 Change-Id: Ib4239c98a52621f912e34266558f5484fbd8d827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438055Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813703}
-
Ehimare Okoyomon authored
Bug: 1135107 Change-Id: Ieac6fff15f9a5a2c69ee6e136d481d86b5a71060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449251Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Auto-Submit: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813702}
-
Kushagra Sinha authored
Set up Mojo remote and receiver for Chrome OS Account Manager. Bug: 1117478 Test: Manually by checking the DVLOGs in the CL Change-Id: I26569473bd34460782fbff704a3dd1f9980864ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362897Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#813701}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/gcm_driver This CL was uploaded by git cl split. R=peter@chromium.org Change-Id: I027ae7ed7eb22e989a0e5a759177b6808762bcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435229 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#813700}
-
Boris Sazonov authored
Extends Signin.AndroidAccountSigninViewSeedingTime and Signin.AndroidGmsUpdatingDialogShownTime to M89 and adds a second owner. Bug: 1089512 Change-Id: If92bf10d354685ea1d70f9e9beda3fc4545d0d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435195Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813699}
-
Tarun Bansal authored
Add more logging to offline detector to help debug issues related to interactions with Android. Change-Id: I8434c1bc6056329c93959045287862c0489cc7cb Bug: 1120144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423353Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Jian Li <jianli@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813698}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d82d30da43cd..10850e1e5ba9 2020-10-05 jleconte@google.com Reland "Fix Bug ID layout on group report page." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: oysteine@google.com Change-Id: I5d675976cec914c1cbf0663fc3c6b37a4018fc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813697}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I03160ac3a6ca185583254526647a320aa7173c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442833Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813696}
-
Alice Wang authored
This CL keeps the observers in WebSigninBridge when there is a sign-in error. Bug: 1133704 Change-Id: Ic21b19dca228ee595816558f584519dd00dece94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445015 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813695}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7028f1d3895f..e51078b0b92b 2020-10-05 patrick.brosset@microsoft.com Make the screncast view tooltip more in line with the overlay tooltip If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134087 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34f679fd6ebd2c7f956c8cc432a564353979555f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813694}
-
Mariia Shvedchenko authored
Adding finch flag to understand whether we use page language while choosing matching process or not. Made GetMatchPatterns return vector instead of reference on vector. Change-Id: If2a73fd6b86680793df431452193737c5d756859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440035Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Mariia Shvedchenko <mariiash@google.com> Cr-Commit-Position: refs/heads/master@{#813693}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: If5db7645ff89b7071b2e7360c1f43496ba331d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445478Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813692}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4f213b39. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I512acf048d272b6fe166dd0b64222aa639be2829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448532Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813691}
-
David Roger authored
Bug: 1130945 Change-Id: I2c4ff4b016b8ac936630686ebd8ef03f238c6e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445779Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#813690}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I860273fecc0bc080000b84e618c4eeb2ae777272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445414Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813689}
-
Matthias Körber authored
Just slipped through :(. Change-Id: Ic355e8612bd9f53f4c82e05f71ef7ffaf1c5bf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449450Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#813688}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Iddb1964b9b3d404eb96eb02fde42204d314e9cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445777Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813687}
-