GitLab

Consent for Google service is no longer unified. This CL is removing the
client of the UnifiedConsentService as it is now obsolete.

Bug: 929372

TBR=asvitkine

Change-Id: I4cacda2c65e97e13dd79304a337468897a1a0414
Reviewed-on: https://chromium-review.googlesource.com/c/1460918
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630460}

The test times out on multiple bots.

BUG=923226
TBR=kenrb@chromium.org

Change-Id: Ief2710141129c4a2e5fddfa358f7a874a5075f63
Reviewed-on: https://chromium-review.googlesource.com/c/1461299Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630459}

Modernizes state and makes it easier to perform queries without
modifying state (Interlock*() methods can only inspect the current
value by replacing it..).

Uses the default std::memory_order_seq_cst. We could potentially be
slightly less strict but there probably isn't a reason to given this
isn't the most expensive operation in PostTask() or DoWork() already.

Clarifies things for https://crrev.com/c/1455266/9/base/message_loop/message_pump_win.cc#470

It's fairly weird that the whole algorithm depends on ScopedNestableTaskAllower
invoking ScheduleWork() when it's not even a concept known to MessagePump... but
this has long been the case...

R=fdoray@chromium.org

Bug: 885371
Change-Id: Id98fb6e72793cff0485ed916906a313a96f95332
Reviewed-on: https://chromium-review.googlesource.com/c/1460598
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630458}

There were a couple of problems here:
. EmbedRoot was Showing() the WindowTreeHost. Instead the visibility should
  be initially set from WindowTreeClient when it gets information about the
  root.
. The server needs to send IsVisible() for non-top-levels roots. This way,
  the correct visibility is set in the client. Without this, windows in a
  hidden container think they are visible. I'm mildly worried this should
  apply to top-levels too, and it's trickier to get right. I'm postponing
  that for now.

BUG=929454
TEST=covered by tests

Change-Id: Icf287c00b866dcaf62f7eb34377f9e950967eb94
Reviewed-on: https://chromium-review.googlesource.com/c/1460489
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630457}

Manual edit:
- change to reset onMergeItems_ inside FileTabledecorate because that
replaces the class constructor.
- remove closure markup @struct and @extends because they aren't needed
with ES6 class (they're implicit).

CL 3 of 4.

Bug: 778674
Change-Id: Iddbc2278b700f55588b85567aa9fbbe25a595b3f
Reviewed-on: https://chromium-review.googlesource.com/c/1460200
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630456}

Specifically adds support for standard actions.


Bug: 920659
Change-Id: I69e93a695092028f3583695c56b70bc35f71f144
Reviewed-on: https://chromium-review.googlesource.com/c/1460067Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#630455}

Also mark the corresponding metric as deprecated. See crbug.com/929518
for plans to improve metrics here.

I thouroughly manually tested this change by setting
|kConnectionLatencyTimeoutSeconds| to 0. This allowed me to verify that
even right after attempting to set connection latency, the Bluetooth
API can handle an immediate subsequent attempt to create a GATT
connection. This also allowed me to catch a potential new bug in
OnSetConnectionLatencySuccess() (see comments there for explanation).

Bug: 905724
Change-Id: I26a1ac3111a99212cd73f67507dcc8a19e62c566
Reviewed-on: https://chromium-review.googlesource.com/c/1457729Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630454}

Connect Java and native sides of JNI bridge for all functions on
WebsiteEvents.

Also cleanup some unused imports.

Bug: 923581
Change-Id: I57a5258d3734f55acb52c247ef5fd83c9196f0be
Reviewed-on: https://chromium-review.googlesource.com/c/1459583
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630453}

InstallActivity entry needs to be placed in base module's manifest
as we do not refresh application context after successful AR module
installation.

Bug fix for incorrect callback being called on successful AR module
installation.

Bug: 926225
Change-Id: I45c448d89d3b5aa15b81c38ef9ffc60d5a0a6308
Reviewed-on: https://chromium-review.googlesource.com/c/1459797
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630452}

https://chromium.googlesource.com/catapult.git/+log/22b1689dde6c..d77957d206cc


git log 22b1689dde6c..d77957d206cc --date=short --no-merges --format='%ad %ae %s'
2019-02-08 kbr@chromium.org Crash GPU process if renderer hangs.


Created with:
  gclient setdep -r src/third_party/catapult@d77957d206cc

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:911772
TBR=sullivan@chromium.org

Change-Id: Ia8a407a6e0a147fc41231db4898fdc2edc46cb87
Reviewed-on: https://chromium-review.googlesource.com/c/1461145Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630451}

Because CastSessionIdMap never gets destroyed, it does not make sense to
use WeakPtrs. We are replacing them with base::Unretained(this), and
adding comments why this is safe.

Bug: None
Test: cast_shell_unittests
Change-Id: I5970f7204cf3ac10f4403811dfb52e1f5d93ce62
Reviewed-on: https://chromium-review.googlesource.com/c/1437623Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Auto-Submit: Aidan Wolter <awolter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630450}

There's a contradictory comment about the copy constructor being
implicit, where, in reality, this was explicit. Since we
don't require Items to be copied, this CL makes Item non-copyable
instead, and provides move constructs.

Bug: None
Test: Internal only change, no visible changes expected.
Change-Id: I051a972181a3210d55745052c87bb58b8db7ef04
Reviewed-on: https://chromium-review.googlesource.com/c/1460124
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630449}

r1428879 changed AuthenticatorImpl to not immediately resolve the request
promise after an error occurs but wait for the UI to be dismissed first. As a
side-effect, the FidoRequestHandler for the request handler for the request
lives on while the UI is shown. I.e., external authenticators continue to
accept inputs (and users can still complete the request successfully); and the
Windows WebAuthn UI continues to be shown.

This changes AuthenticatorImpl to cancel all pending authenticators immediately
after an error has occurred. Also implements cancelling of U2F HID
authenticators.

Bug: 897757
Change-Id: Ibd4800a3dcc5ac49b92bec0bfe13e6ca506122ba
Reviewed-on: https://chromium-review.googlesource.com/c/1460480Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630448}

Bug: 924771
Change-Id: Ic864c914614f269ff01df4e22ba0d5f5a1d02be6
Reviewed-on: https://chromium-review.googlesource.com/c/1461186Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630447}

gcp_unittests makes a call across DLL boundaries to register fake
implementations for testing. This is not visible to link-time
optimization, so the classes involved need to be marked
lto_visibility_public to prevent the optimizer from generating
invalid code. See https://clang.llvm.org/docs/LTOVisibility.html

BUG=928396

Change-Id: Ie02e72503b3da8f9c35074bb7c2291d860baba42
Reviewed-on: https://chromium-review.googlesource.com/c/1455095Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Auto-Submit: Bob Haarman <inglorion@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630446}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/311f25ab..37a08a2a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4501b5a68bad9d4a1ae92462ba5931ac5be1c0ea
Reviewed-on: https://chromium-review.googlesource.com/c/1460983Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630445}

- Adds any preconfigured shares that do not match an explicitly known mode
to the dropdown.
- If new policies are added to later milestones that are unknown in older
versions of Chrome, the preconfigured shares will fallback to being added
in the dropdown. This ensures that we can gracefully handle adding new
enterprise policies in the future.

Bug: chromium:929322
Change-Id: I693ad6d102e0cfe3129ee349b86df84851038eb2
Reviewed-on: https://chromium-review.googlesource.com/c/1456945Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630444}

Change-Id: I9fcd596e475063646d93ef894ab8105c8461fe0a
Bug: 867008
Reviewed-on: https://chromium-review.googlesource.com/c/1448322Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630443}

Previously notification views were hardcoded with placeholders. Now they
are actually tied to Assistant notifications.

Still TODO:
- Handle button click events.
- Animate entry/exit.
- Add type to notifications so we can differentiate between
  in-Assistant and system notifications.

Bug: b:1453547
Change-Id: I3ccf3067f388b3e87eb4a0159c7ed404ee54ae5c
Reviewed-on: https://chromium-review.googlesource.com/c/1459586
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630442}

The OriginalTimingAllowOrigin attribute was added in
https://codereview.chromium.org/271083002 to ensure TAO headers are
preserved on cached resources (304 responses). This CL removes it
because it seems that it is no longer needed. It also moves the
corresponding test to WPT.

Bug: 929453
Change-Id: I41e0c84b04a94acc27c22e375f55398d9fc411e5
Reviewed-on: https://chromium-review.googlesource.com/c/1459333
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630441}

Cancel the FileDescriptorWatcher watch on the ClipboardX11's display
connection before closing the connection, during teardown.

Bug: 930007
Change-Id: I020962f522a3eb8017992d5dc430d8ce31a87049
Reviewed-on: https://chromium-review.googlesource.com/c/1460600
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630440}

The notion of active devices, as surfaced by Sync.DeviceCount and
exposed internally via DeviceInfoTracker, can very easily run into
duplicates if users disable and reenable sync on the same device,
because the cache GUID gets reset and a new DeviceInfo entity is
created.

This is particularly relevant in a world where sync-the-transport
gets enabled when the user signs in, since there will be a new
DeviceInfo instance every time.

In order to improve such notion, we leverage the sync timestamps
to instead count devices that are known to overlap in time.

Bug: 910390

Change-Id: I2866d98d53813b64a821de764d632748b15b72dd
Reviewed-on: https://chromium-review.googlesource.com/c/1436366Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630439}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78f6491898f6..de578cdd6b58


Created with:
  gclient setdep -r src-internal@de578cdd6b58

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0ce31f79b026ca6da919ccdbe611717a58880276
Reviewed-on: https://chromium-review.googlesource.com/c/1461144Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630438}

This reverts commit 48f72caa.

Reason for revert: Introduced tests fail on Android CFI bot. See crbug.com/930262.

Original change's description:
> android: Experiment setup for the reached code profiler.
> 
> This CL prepares the reached code profiler for the finch experiment. It adds:
> - base::Feature "ReachedCodeProfiler", which state is cached in
> - Android shared preference "reached_code_profiler_enabled", that determines
> whether to set
> - command line switch "enable-reached-code-profiler", that eventually enables
> the profiler
> 
> We cannot simply use a base::Feature for the reached code profiler because
> we have to know the feature state very early in the startup, before the
> FeatureList is initialized.
> 
> To work around this limitation we cache the feature state in Android shared
> preferences that are available in Java before native is initialized.
> 
> Since only the browser process has a right to read the shared preferences we
> pass the value of the cached feature state as a command line flag to all
> processes.
> 
> Bug: 916263
> Change-Id: I730b98c5484ca595bdfda46592572f5853784aa8
> Reviewed-on: https://chromium-review.googlesource.com/c/1393328
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630298}

TBR=pasko@chromium.org,gab@chromium.org,yfriedman@chromium.org,boliu@chromium.org,agrieve@chromium.org,alexilin@chromium.org

Change-Id: I2e9b1f35b4bb4cfce38b820d41140a0014bd6437
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 916263, 930262
Reviewed-on: https://chromium-review.googlesource.com/c/1460431Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630437}

Bug: None
Change-Id: I1cae4a6fbf4bd94fc0ec704ea998c1ab9d727834
Reviewed-on: https://chromium-review.googlesource.com/c/1460604Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630436}

This reverts commit c0cf050d.

Reason for revert: crbug.com/930250

Original change's description:
> Add remoting FTL API key
> 
> Add API key for remoting to use during the signaling process. Note that
> this key is only used by Chrome Remote Desktop and will not be used in
> the Chrome browser.
> 
> Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973
> 
> Bug: 927962
> Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f
> Reviewed-on: https://chromium-review.googlesource.com/c/1450409
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Auto-Submit: Yuwei Huang <yuweih@chromium.org>
> Commit-Queue: Roger Tawa <rogerta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630352}

TBR=rogerta@chromium.org,joedow@chromium.org,yuweih@chromium.org

Change-Id: I466452e9f2680b478ac5c3cf4b9600cba6d7cb8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 927962
Reviewed-on: https://chromium-review.googlesource.com/c/1461092Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630435}

Last patchset for change Ia7465d5e1cde0d4cd3c3d9ef9363f7679fded8bb that
was rejected by transient gerrit error.

Bug: 920396
Change-Id: I550414fe65aa34d843ad372caf54a0778de84939
Reviewed-on: https://chromium-review.googlesource.com/c/1456290
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Auto-Submit: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#630434}

This patch fixes the presubmit error:

third_party/blink/web_tests/NeverFixTests:2202 Duplicate or ambiguous entry lines third_party/blink/web_tests/NeverFixTests:2022 and third_party/blink/web_tests/NeverFixTests:2202. external/wpt/payment-request/payment-request-multiple-show-manual.https.html
third_party/blink/web_tests/NeverFixTests:2203 Duplicate or ambiguous entry lines third_party/blink/web_tests/NeverFixTests:2023 and third_party/blink/web_tests/NeverFixTests:2203. external/wpt/payment-request/payment-request-show-method-manual.https.html
third_party/blink/web_tests/NeverFixTests:2204 Duplicate or ambiguous entry lines third_party/blink/web_tests/NeverFixTests:2020 and third_party/blink/web_tests/NeverFixTests:2204. external/wpt/payment-request/payment-request-abort-method-manual.https.html

Change-Id: I5458bb3b3b3c23e5f9c2b2a186c61799feae24c9
NoTry: True
Tbr: rouslan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1461150Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630433}

A solid color layer that has its visibility set to true, but has no
color set (default color), will prevent the renderer, due to some
optimization, to not composit any other layer that is below it
resulting in a transparent looking layer tree.

Ideally the user would never see this transparent glitch because we
immediately set the visibility of the layer to false. But before the
layer visibility is updated there is a short flash of transparent
window on the screen.

This patch sets SK_ColorTRANSPARENT as the default color on the
stale content layer to avoid this issue.

Bug: 927915
Change-Id: If199cebda2b513822a79c7088368a6fb425d3ab6
Component: Delegated frame host, overview mode, stale content
Reviewed-on: https://chromium-review.googlesource.com/c/1450440Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630432}

This is in preparation for starting to implement PIN support. It doesn't
affect any non-test code and doesn't do anything to implement PIN
support yet, but this is a reasonably separable change to keep things
small.

(This was supposed to land in
https://chromium-review.googlesource.com/c/chromium/src/+/1450638 but I
messed up a rebase and merged some future changes into it.)

Change-Id: I987143035d13c21669b3fae6f382508433d450e4
Reviewed-on: https://chromium-review.googlesource.com/c/1460455
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#630431}

Update the controlling media playback documentation
with the latest changes.

BUG=893296

Change-Id: Ib60e19ed66ebf630eb4e81c660fe1df77d284206
Reviewed-on: https://chromium-review.googlesource.com/c/1461097
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630430}

This is a simpler (and in many ways more correct) alternative to
https://chromium-review.googlesource.com/c/chromium/src/+/1453802
(See comments on that issue for why.)

Bug: 877227
Change-Id: Ic59e4e8ed138b6399b0d782467a58a4e1962b714
Reviewed-on: https://chromium-review.googlesource.com/c/1457721
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630429}

- Uses HighlightButton (A button that fades opacity on highlight) instead
  of MDCFlatbutton.
- Uses Chrome blue tint for the title color instead of hardcoded RGB.

Bug: 910994
Change-Id: I076b72777595392add12606d29acd77147452539
Reviewed-on: https://chromium-review.googlesource.com/c/1453537
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630428}

- Adds UpdateSharePath to SmbService to call on
  SmbProviderClient::UpdateSharePath.
- Adds callback for error response handling for UpdateSharePath.

Bug: 922273
Test: compiles
Change-Id: Ic5521230e0b3973586471d9c5ece7c3bff1470d7
Reviewed-on: https://chromium-review.googlesource.com/c/1445236
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Auto-Submit: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630427}

This fixes various places where we need to override DVLOGs by replacing
the customized solution with using logging_override_if_enabled.h.

Now we can use standard DVLOGs in these files without affecting
ChromeCast code. Different DVLOG levels are used to reflect the
importance of those logs.

Bug: internal 73490388
Test: Manually tested by setting |enable_logging_override|.
Change-Id: I1329fa97f904e8560703a4c9621e301d019a240a
Reviewed-on: https://chromium-review.googlesource.com/c/1458702Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630426}

Currently, we only update window properties when we receive a window state change event (not from a notification).

One such window property focus fallback to widget, controls whether the accessibility system in Chrome infers focus when there's a non client view involved. This was added in
https://chromium-review.googlesource.com/c/chromium/src/+/1117720/

Unfortunately, this completely breaks focus in most apps when you first open them. i.e. ChromeVox and the chrome.automation api get a focus node of |null| because the fallback  window property was set some point before to false. That computation gets based upon whether the task id for the given accessibility event appeared before.
Unfortunately, there's no guarantee we will receive data for that task id before or after we call update window properties. This leads us into a state where we have the fallback focus window property set to false but we get accessibility data for that task id (just not a window state changed).

This, ultimately, breaks focus computation.

Bug: 929522
Change-Id: I2387a255b45770024581e339778c316cc04900ac
Reviewed-on: https://chromium-review.googlesource.com/c/1460305Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630425}

Legacy clients expect non-empty "non_unique_name" by mangling the
bookmark titles (e.g. append a blank space to empty titles) before
committing them.

This CL is adding the corresponding mangling of bookmarks titles before
committing bookmarks from modern client for backward compatibility.

Bug: 930124
Change-Id: I4ddd8c5b7ff6867ebca9dab908aa28230f6d4649
Reviewed-on: https://chromium-review.googlesource.com/c/1461124
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630424}

The files for test is added in
https://chromium-review.googlesource.com/c/chromium/src/+/1414192

Change-Id: If69e0b150c701532217ccbf8f86c4ec4894d2a9d
Reviewed-on: https://chromium-review.googlesource.com/c/1460582
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630423}

Currently, when a Chrome app is uninstalled, the respective
ChromeAppItem is not removed from ChromeAppListModelUpdater.
If the app is reinstalled in the same session, it is recognized
as existing and no new item is added to the app list.

This CL fixes this problem.

Bug: 884921
Test: manual, steps in bug.
Change-Id: I20bed583b1b484544cdf29f8fc0be2b08ef5280b
Reviewed-on: https://chromium-review.googlesource.com/c/1461189
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630422}

This test asserts that 'button' and 'link' do not
receive a language attribute; only the contents
of these elements receive a language attribute.

Change-Id: I8a9a1d1da3256f2e963fe327a04a49872f9a9547
Bug: 923068
Reviewed-on: https://chromium-review.googlesource.com/c/1458936Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630421}