- 13 Sep, 2017 40 commits
-
-
Matt Menke authored
RenderFrameHostImplBrowserTest.AbortedRendererInitiatedNavigationDoNotCancelPendingXHR is now failing, possibly due to https://chromium-review.googlesource.com/663140 TBR: jam@chromium.org NOTRY: true Bug: 576261,762945 Change-Id: Ib9a8893e105444be13653438c6bd364511dcfad7 Reviewed-on: https://chromium-review.googlesource.com/665070Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501659}
-
Helen Li authored
SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL removes src/net/sdch. histograms will be deprecated in a separate CL. net/ TBR=rdsmith@chromium.org ios/chrome/browser TBR=sdefresne@chromium.org Bug: 762686 Change-Id: Iea2e894c99303912b5f09b5708f9f32dea6bd325 Reviewed-on: https://chromium-review.googlesource.com/664979Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501658}
-
Brian Osman authored
Bug: 763605 Change-Id: I3e4c7fb40fe2e9dccdf0ba7549199466c785c605 Reviewed-on: https://chromium-review.googlesource.com/664983Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#501657}
-
Carlos IL authored
Websites with Security errors due to SHA1 signed certificates in the chain now show up with the broken (red triangle) indicator in the DevTools Security panel, instead of the neutral (red circle) indicator. R=estark@chromium.org Bug: 705671 Change-Id: I400936a3221ddeea65897a83f4ad04e6683e2d22 Reviewed-on: https://chromium-review.googlesource.com/664343Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos Joan Rafael Ibarra Lopez <carlosil@google.com> Cr-Commit-Position: refs/heads/master@{#501656}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/596aa47eec50..c562de2ba25b $ git log 596aa47ee..c562de2ba --date=short --no-merges --format='%ad %ae %s' 2017-09-13 loloangela Fix errors related to invalid-name pt. 11 Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I135d77739b4f88756a56fb86447fc048f01fd7c9 Reviewed-on: https://chromium-review.googlesource.com/664820 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501655}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbfd15c4..5bd1496e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iada9cfd9e871e7747ed10aa56e8e6f26439f4694 Reviewed-on: https://chromium-review.googlesource.com/664842Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501654}
-
Simon authored
For perf try jobs, you must specify --output-format=html in order to produce an HTML results file that can be displayed on the build page. This CL adds the flag if no --output-format is specified, or if none of the existing formats is html. Bug: chromium:762570 Change-Id: I5e39937faa64fa7d6bfb2a643e22eac426ff17b1 Reviewed-on: https://chromium-review.googlesource.com/661056Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501653}
-
Matt Menke authored
These likely broke in https://chromium-review.googlesource.com/662957 TBR: nhiroki@chromium.org NOTRY: true Bug: 748415 Change-Id: Ied4e2131b72e8dc004a7ac695d35a86e2acf8a1b Reviewed-on: https://chromium-review.googlesource.com/664845Reviewed-by:
-
Helen Li authored
top_25_009.wprgo is of the legacy format. This causes WprGo server to error out when trying to unzip the archive. See attached bug for more detail. I converted to the new .wprgo format using tools/perf/convert_legacy_wpr_archive. Bug: 763466 Change-Id: I32b37852147b6cf70c0ded34906b08988d2fd455 Reviewed-on: https://chromium-review.googlesource.com/665061Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501651}
-
Ria Jiang authored
After https://chromium-review.googlesource.com/c/chromium/src/+/617378, ClientWindowId is globally unique, so we can change FrameSinkId to have the value of the corresponding ClientWindowId. This also means that clients now know about their FrameSinkId. Changed ClientWindowId to be of type FrameSinkId to essentially merge these two ids in mus-ws. Updated uses of FrameSinkId in WindowManagerState and unittests. Fixed some more places in WindowTree that needed ClientWindowId conversions. Bug: 712302 Test: covered by tests Change-Id: I3a77487b7e10af5ba1850f2585b81f43768f2184 Reviewed-on: https://chromium-review.googlesource.com/639954 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#501650}
-
Matt Menke authored
They now seem to be timing out, issue likely caused by https://chromium-review.googlesource.com/657183 Bug: 763252 Change-Id: I6bee917df1995f4a4d176339485ad9e64577f977 TBR=rdsmith@chromium.org NOTRY=true Change-Id: I6bee917df1995f4a4d176339485ad9e64577f977 Reviewed-on: https://chromium-review.googlesource.com/665069Reviewed-by:
-
Tarun Bansal authored
This is a pure refactor CL and does not introduce any functionality change. Moving some of the code that retrieves memory information to t_p/Webkit/common makes it possible to access that code from chrome/browser. In the next CL, chrome/browser/chrome_content_browser_client.cc would call GetApproximatedDeviceMemory() to attach the required client hints to the navigation requests. Bug: 764513 Change-Id: I96e5d812b8f46e83601d02c6c48f1a37919f8041 Reviewed-on: https://chromium-review.googlesource.com/663768Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#501648}
-
Marti Wong authored
- Disable Select button of context bar when there is nothing to select. - Disable New Folder button of context bar when current root node is nil (removed remotely). - Added egtest to verify that when current root node is empty, the empty background appears and select button is disabled. Demo: https://drive.google.com/open?id=0B1O0Z7eoZMuGR2lZcGlvSUg4VjQ Bug: 695749 Change-Id: Iba6bf2e2d4e4260cc8d712d7e25e6417f8dc0455 Reviewed-on: https://chromium-review.googlesource.com/663501 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#501647}
-
Charlie Andrews authored
Bug: 705042 Change-Id: Iec0fe8718b3a0510bb73d2e20efa4c732b539940 Reviewed-on: https://chromium-review.googlesource.com/665098Reviewed-by:
-
Andrew Grieve authored
Applicable only when building release. Disable via --no-deobfuscate Bug: 620323, 758670 Change-Id: Ib1289e6eae6bb326a1879c791e673cdeba331eab Reviewed-on: https://chromium-review.googlesource.com/656720Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#501645}
-
Brett Wilson authored
Failing to explicitly initialize stack dumping before adding a malloc hook that uses it can cause problems. In particular, on Linux calling backtrace() can load a library which calls malloc, meaning the hook will be recursive. Bug: 764522 Change-Id: If602902aa4238903541ca52f765927369dbf6e71 Reviewed-on: https://chromium-review.googlesource.com/664301Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501644}
-
Simeon Anfinrud authored
This can be used to make sure that tasks are being flushed through a given task runner at a desired rate, a signal that can be used to determine if tasks are blocking a thread. BUG=Internal b/23908801 BUG=Internal b/36699101 TEST=cast_base_unittests Change-Id: I22dc48134ac46b2bd00bccee8105a7580d1072c9 Reviewed-on: https://chromium-review.googlesource.com/664086 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501643}
-
Rob Buis authored
Support unset as a CSS wide keyword [1] and add some unit tests for it. [1] https://www.w3.org/TR/css3-values/#common-keywords Bug: 660273 Change-Id: Ic739055b83988017e11ff3968c1a0aad48073613 Reviewed-on: https://chromium-review.googlesource.com/663820 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#501642}
-
sczs authored
This CL implements the Sad Tab functionality for the new architecture. -Adds a delegate setter to SadTab helper since the helper needs to outlive the Webstate. Since the delegate could previously only be set on init. This meant that the delegate had to persist until Webstate destruction, which is not ideal since we don't want the delegate to be a coordinator close to root. For this reason the helper is created as soon as a Webstate is Added and its delegate is added when the Tab is being displayed. Screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgeHZhbFBYQTl6Qnc Bug: Change-Id: I42c3c6710233b2148cc3bb696e0017db9c3c205f Reviewed-on: https://chromium-review.googlesource.com/656518Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#501641}
-
Ira Burak authored
Manually add MAJOR_BRANCH_DATE for M63. For the later versions, this file will be generated automatically. MAJOR_BRANCH_DATE file contains a date of the last major branch. This date will be used as a base date to compare expiry dates of histograms with. Bug: 753485 Change-Id: I2c336df168376c3ac909c877b5b938dad96a4347 Reviewed-on: https://chromium-review.googlesource.com/661068Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ira Burak <iburak@google.com> Cr-Commit-Position: refs/heads/master@{#501640}
-
Peter Kotwicz authored
BUG=None Change-Id: Ibae21432198d287ea3fac8656335232765f5dee8 Reviewed-on: https://chromium-review.googlesource.com/663243Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501639}
-
Jean-François Geyelin authored
Bug: 764692 Change-Id: I3e2493f770e8218aa9a5eb0351dfc0db0612832d Reviewed-on: https://chromium-review.googlesource.com/664809 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501638}
-
Koji Ishii authored
Following bot results are included. 1281 1282 1283 1284 1285 1286 1287 1291 1293 1294 1299 1300 1302 1303 1304 1305 85 lines were removed by consecutive passes since 1248. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I479d8f2513097eea14cd12eb8e4188b14b1c8bde Reviewed-on: https://chromium-review.googlesource.com/665197 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501637}
-
Ria Jiang authored
In the viz-hit-test case, when we cannot find the target window in EventTargeter, we were using NOTREACHED before this CL. But there are cases where the target window has simply been deleted by the time this event is processed, e.g. clicking the settings button inside system tray's network page, mouse move events after that but before the system tray goes away would fail. In these cases, it makes sense to just drop the event like we did in non-viz hit-test. Kept the TODO to investigate if it can be a security fault when no target window is found. Also fixes a memory exception in HTQ when using the transform directly. Bug: 752380 Change-Id: Ifa099c88a98d623b8be363fe3a77b7bc8eea4a54 Reviewed-on: https://chromium-review.googlesource.com/651564 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#501636}
-
Peter Beverloo authored
This fixes a crash that's observed on certain Android M devices. BUG=761060 Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8 Reviewed-on: https://chromium-review.googlesource.com/663363Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501635}
-
Xida Chen authored
The flakiness dashboard shows that these tests consistently pass: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-clip-rule.html%2Cvirtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-path-context-clip.html Bug: 717389, 717019 Change-Id: I3467abf55e55054fa38800ffd6e42e3c72a6b4b5 Reviewed-on: https://chromium-review.googlesource.com/664280Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501634}
-
Sandra Sun authored
This patch upstreams scroll_boundary_behavior.html to a web-platfrom-test. It is currently a manual test. It asks users to perform some scroll/drag behaviors and tap the "Done" button, and then checks the result. Bug: 762054 Change-Id: I9be937341d5d95137c715b8111b557f09baf8a80 Reviewed-on: https://chromium-review.googlesource.com/653810Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#501633}
-
Alexander Timin authored
Group all information passed to PostDelayedTask (callback, posted from and delay) into a struct to plumb it together to a place inside scheduler where a sequence number is generated and PendingTask is created. This will allow for easier plumbing for additional task metadata that we might want to add in the future. R=alexclarke@chromium.org CC=skyostil@chromium.org Bug: Change-Id: Iac00cd6c8ce5ac468116ee8bce17894da2d9bc79 Reviewed-on: https://chromium-review.googlesource.com/664703 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501632}
-
Xu Xing authored
The usage of CreateResourceFromTextureMailbox is listed here: https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit BUG=757291 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I73327a885e5b4dc171c79b420b3913e9e648b6e4 Reviewed-on: https://chromium-review.googlesource.com/664309 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#501631}
-
sczs authored
This is CL 1 of 2 for removing BrowsingDataRemovalControllerDelegate. Bug: 648940 Change-Id: I18d43e008388138d303ad165a313110d2c3b940c Reviewed-on: https://chromium-review.googlesource.com/654377 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Olga Sharonova authored
Connection to mojo audio system interface is bound to a thread. If we limit AudioSystem clients to use AudioSystem on a specific thread, it would mean we are introducing extra thread hops. So, instead of having a global AudioSystem instance bound to a specific thread, we are introducing one AudioSystem instance per client, and they are free to use that instance on any (one) thread they want. ---------One AudioSystem per client: 1) Extentions: *** ChromeVirtualKeyboardDelegate *** WebRtcAudioPrivate function (one AudioSystem instance for each function instance) 2) BrowserMainLoop: Owns AudioSystem instance and passes its pointer to *** SpeechRecognitionManager *** MediaStreamManager (AudioSystem instance is passed around a scary "manager" cluster: in AudioInputDeviceManager and MediaDevicesmanager members of MediaStreamManager and also in MediaDevicesDispatcherHost) *** AudioOutputAuthorizationHandler ----------AudioSystem::GetInstance factory method is introduced. It creates AudioSystemImpl instance and passes global AudioManager instance to it. Later we can make a finch-based decision to create AudioSysteToMojoAdapter there instead; or just switch to Mojo entirely. Bug: 740943 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I26a98376fb9edc33aba7c039e392849a460132e4 Reviewed-on: https://chromium-review.googlesource.com/655437 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501629}
-
Mohamad Ahmadi authored
Bug:764473 before: https://drive.google.com/open?id=0B-GXJsF3pXyjUGVnaTFfTVBtamc after: https://drive.google.com/open?id=0B-GXJsF3pXyjRzVBenpfYy1OZjg Change-Id: I1df52d623da2b197f4385863fae4c16ddd16a240 Reviewed-on: https://chromium-review.googlesource.com/663839 Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#501628}
-
galinap authored
Before sending a fetch request for suggestions for the current context to the native side, we want to check if the current URL is valid. If there is no active tab (which is the case when all tabs are dismissed), we clear the suggestions. If the URL is not a HTTP or a HTTP URL, we clear the suggestions. We also want to make sure that we don't initiate a fetch when the carousel already has suggestions for the current context. To do this, we compare if the new URL and the old URL are the same excluding the fragments. In all these cases we don't send a request to the native side. Otherwise, if the URL is a new network URL, we send a request to the backend. Bug: 745660 Change-Id: Iab7680e8e704f3de6fb4ed88be9e26c0fda3deca Reviewed-on: https://chromium-review.googlesource.com/646326 Commit-Queue: Galia Peycheva <galinap@google.com> Reviewed-by:
Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#501627}
-
Ondrej Skopek authored
Substitutes a string-based check in |startListeningMessageAnimation_| for a proper check of the current state in the speech module. Adjusts tests (and adds new ones) accordingly. Removes last TODO from voice.js. Bug: 583291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica08d32233eb69ae5b1930aeb00f34e879eadddf Reviewed-on: https://chromium-review.googlesource.com/663731 Commit-Queue: Ondrej Škopek <oskopek@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#501626}
-
Aaron Leventhal authored
After this should be better for Braille output, easier to predict for speech, and more accurately represents the format. For example 2 links on separate lines of HTML source will have a whitespace node between them -- this is rendered on the screen but until this CL did not show up in the a11y tree. It also corrects the word boundary algorithm so that the start of a word does not occur in a whitespace-only node. ChromeVox's move-by-word algorithm was adjusted to be able to find the next node when the current one did not have a word stop. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f7aa1624a2b5f7efb3d957656ec0b11fcc2a9af Reviewed-on: https://chromium-review.googlesource.com/657561Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#501625}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/adf17dc52ff4..489bef054ee9 $ git log adf17dc52..489bef054 --date=short --no-merges --format='%ad %ae %s' 2017-09-13 rmistry Use Chrome-GPU pool for CT GPU runs Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie23b066da2f73cbb9b39be7003182aa0b73d2289 Reviewed-on: https://chromium-review.googlesource.com/664917Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501624}
-
Mohamad Ahmadi authored
Bug:763499 after: https://drive.google.com/file/d/0B-GXJsF3pXyjRm4zbHVsaTFfSGs/view?usp=sharing before: https://drive.google.com/file/d/0B-GXJsF3pXyjWUx5MG81QWFKNnM/view?usp=sharing Change-Id: Iba3625cf83a626b38c4cf338650d0c98f06f674d Reviewed-on: https://chromium-review.googlesource.com/664217Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4560fda0. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1675 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor bajones@chromium.org: external/wpt/gamepad drott@chromium.org: external/wpt/css-fonts hta@chromium.org: external/wpt/webrtc TBR=qyearsley@chromium.org No-Export: true Change-Id: I84eab53cd30d672d25fe2af3d5e9747b51445d70 Reviewed-on: https://chromium-review.googlesource.com/664100 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501622}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fd1dd40d..bbfd15c4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If6e6e89b8eda7f2bedd77dd43b35168b43cfcd14 Reviewed-on: https://chromium-review.googlesource.com/664838Reviewed-by:
-
Yaron Friedman authored
This isn't the best solution but it means that we should get less random native stacks by not causing JNI abort. Basically, the OutputStream.toString call is known to allocate a java buffer of long enough size to fit the full exception stack trace which is bad if we're close to OOM threshhold. Since we didn't check for errors, we can end up using a local java stale reference that isn't actually valid. To avoid this, just drop the error, and allocate a small amount of native heap which based on crashes seems fine. Evidence of this happening in practice is its some amount of the: 1648 attempt to use stale local reference mentioned in the bug. And concrete example: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27da39a3ee_5e6b4b0d_3255bfef_95601890_afd80709%27%20OMIT%20RECORD%20IF%20SUM(special_protos.android_info.logcat_errors%20LIKE%20%27%25JNI%20ERROR%25%27)%20%3D%200&sql_dialect=dremelsql&ignore_case=false&enable_rewrite=false&omit_field_name=&omit_field_value=&omit_field_opt=&unnest=&stbtiq=&reportid=25304dba4c9bd9f9&index=2#7 The hope is that by not clobbering the original bug (in this case OOM from restoring tabstate in persistent store) these can be easier to triage. That's the hope anyway :/ BUG=726426 Change-Id: I3b40f432a2cb32c8b7a0777cdc1c5f1f7c9f100f Reviewed-on: https://chromium-review.googlesource.com/658067Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501620}
-
