GitLab

Add memory dumps for ServiceTransferCache. Note that this is expected to
come up as a regression in memory reported by the GPU process since this
data was not being reported until now.

R=ericrk@chromium.org

Bug: 859419
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I03de3eef4ef688b62b4714897c1f301f98d63e74
Reviewed-on: https://chromium-review.googlesource.com/1125524Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573496}

This CL:
 - introduces Segment to remove ad-hoc AllocateSegment / FreeSegment
   calls,
 - removes the const qualifier from Data to remove mutable from
   members,
 - inlines some functions, and
 - includes miscellaneous algorithmic simplification.

This CL doesn't change the behavior, and is not expected to improve or
regress performance.

Bug: None
Change-Id: If1700dd4ae430edbfbd8985836cd73505d441eb4
Reviewed-on: https://chromium-review.googlesource.com/1127573
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573495}

When using the Clear Browsing Dialog, this can call a DeleteAll in
SessionStorage backend code. There were DCHECKs around being bound to
a renderer, but this doesn't need to be the case when using the Clear
Browsing Data Dialog.

This CL removes those DCHECKs for DeleteAll.

R=mek@chromium.org

Bug: 859876
Change-Id: Iee4e3027ad1a1c396f1b7f746aec0e844a8f64b1
Reviewed-on: https://chromium-review.googlesource.com/1125023Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573494}

This CL adds a method in MediaViewerUtils to selectively enable or
disable the MediaLauncherActivity, enabling if the device is an Android
Go device and if a new HandleMediaIntents feature flag is enabled. This
new flag is enabled by default.

This CL also calls this new method when Chrome is started via the
ProcessInitializationHandler.

Bug: 856693
Change-Id: I80f03481e399ac163a3dd10720771d6404b8d56d
Reviewed-on: https://chromium-review.googlesource.com/1121577
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573493}

https://chromium-review.googlesource.com/c/chromium/src/+/1127028
changed content/public/app/BUILD.gn to always package the font service
manifest at the //content level.

We no longer need to package it at the //chrome level.

This fixes the "all" build:
autoninja -C out/Default   # (no target)

Bug: none
Change-Id: I6a22e06f95baf0905b1bab3c4352ed5fa8a5a5ca
Reviewed-on: https://chromium-review.googlesource.com/1130009Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573492}

On Linux X11, the GLSurface may have different compatibility key. We
have to have to create different GLContext and GrContext based on the
compatibility key. Becasue GLContext::MakeCurrent(GLSurface*) will not
work if they are not compatiable. On other platforms, the compatibility
key is always 0.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If36e218963f59c9dd7001c6fe7a7b133fd435434
Bug: 838899
Reviewed-on: https://chromium-review.googlesource.com/1125084
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573491}

This CL removes calls to base::AdaptCallbackForRepeating when the
returned base::RepeatingCallback is immediately converted
to a base::OnceCallback.
It also fixes a bug in //tools/clang/base_bind_rewriters which
caused commas to be wrongfully removed if base::AdaptCallbackForRepeating
is not the first parameter.

Change-Id: Ic90bfcef4496fa0a22a083e2c8506066cffd5b95
Reviewed-on: https://chromium-review.googlesource.com/1123819
Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573490}

Right now flow consists of:
* Demo preferences screen where user can select language related options
* Chrome OS Eula that has to be accepted
* Demo setup screen that shows progress and result of demo setup
More screens will be added later.

BUG=827376
TEST=Run tests in wizard_controller_browsertest.cc

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifa4c86201a0ef7b0a6c41b5805ba0c3fde1d791a
Reviewed-on: https://chromium-review.googlesource.com/1108356
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573489}

Follow up on r1124735.

TBR=blakeo@chromium.org

Bug: 845780
Change-Id: If2e40e0884fe46f5cf874f5eb5d1aeb4e479c722
Reviewed-on: https://chromium-review.googlesource.com/1130199Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573488}

This GAIA method is unused. Removing the infrastructure for handling the
result of calling it.

Bug: 844982
Change-Id: I85598a2535346046e2f34a0f0126eca8a7acc70a
Reviewed-on: https://chromium-review.googlesource.com/1111115Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573487}

[1] added a couple of asserts, assuming the outer/inner radii are
always following border invariants.

But the same code path is also triggered for outline painting, which
overrides some border properties to force rectangular outlines.

Also, GraphicsContext is not a good place to make outer/inner geometry
assumptions.

Remove the asserts and replace with explicit width/height checks.

[1] https://chromium.googlesource.com/chromium/src/+/e2eef42958b177eaf8cbbdae667c481d0789421c

Bug: 861529

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7deb45c42f2fef8dec2caf4cc90c0b52ee1b5f51
Reviewed-on: https://chromium-review.googlesource.com/1129328Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573486}

The mojom call is send only when resource loading hints feature is
enabled and the connection is slow.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib57d656406db6f63200ffbf5dbbe83c356d464ca
Bug: 854666
Reviewed-on: https://chromium-review.googlesource.com/1112925
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573485}

Mac doesn't have touch UI, and the test doesn't really make too much
sense on cast, but the code under test is built there and the test
is small and fast, so might as well run it. Maybe one day the test
should move to chromium_gtests_for_devices_with_graphical_output instead.

Bug: 843511
Change-Id: I1792ee0d57a9f039dba71bb6b28d33e272ab5236
Reviewed-on: https://chromium-review.googlesource.com/1129580Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573484}

This can reduce build steps in incremental build.

Bug: 810298
Change-Id: I8ef6c3aa908f5d6e2e8c57edf8d29ed80a0d1993
Reviewed-on: https://chromium-review.googlesource.com/1126892Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573483}

Also shifts the user menu right in this case so that the dropdown arrow
remains visible.

Bug: 861791
Change-Id: I65b0be969c1f15936ce3b86df5bae4eb7c200ed6
Reviewed-on: https://chromium-review.googlesource.com/1129847Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573482}

This adds a couple of tests which were missing previously for
features which are defined in code, but not available for use in
feature policy, being used to construct policies.

Change-Id: Ib3c860d3a0613606b5672c682559fec608696d12
Reviewed-on: https://chromium-review.googlesource.com/1126327Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573481}

This reverts commit f69edefd.

Reason for revert: Bug is fixed by adding VIEWS_EXPORT to MenuSeparator.

https://chromium-review.googlesource.com/c/chromium/src/+/1129999

Original change's description:
> Revert "cros: Add a double separator above context menu notifications"
> 
> This reverts commit 1c822163.
> 
> Reason for revert: 
> 
> Linker failures:
> obj/ash/app_menu/app_menu/notification_menu_view.o:notification_menu_view.cc:function ash::NotificationMenuView::NotificationMenuView(ash::NotificationItemView::Delegate*, message_center::SlideOutController::Delegate*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&): error: undefined reference to 'vtable for views::MenuSeparator'
> ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
> 
> Bug: 861885
> 
> Original change's description:
> > cros: Add a double separator above context menu notifications
> > 
> > Add and remove a double separator with NOTIFICATION_CONTAINER.
> > 
> > Bug: 843761
> > Change-Id: I45fb095079aaaf108a9a18958ab4e431072e588d
> > Reviewed-on: https://chromium-review.googlesource.com/1121243
> > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#573418}
> 
> TBR=jamescook@chromium.org,msw@chromium.org,newcomer@chromium.org
> 
> Change-Id: I10ce18a75e80116fa8d7a530d18e979a2dfbb395
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 843761
> Reviewed-on: https://chromium-review.googlesource.com/1129661
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573429}

TBR=jamescook@chromium.org,msw@chromium.org,newcomer@chromium.org

Change-Id: I70f5742583a5531d43ea5ff5b6c2815e691506da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 861885, 843761
Reviewed-on: https://chromium-review.googlesource.com/1130140Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573480}

Include memory dump from GrContext used for OOP raster in the GPU
process in traces.

R=bsalomon@chromium.org, ericrk@chromium.org, sadrul@chromium.org
TBR=bsalomon@google.com

Bug: 859419
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie010e1c567626343d5698b02c45776d215640da0
Reviewed-on: https://chromium-review.googlesource.com/1123894
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573479}

We must expose radiogroup/group names as a description, instead of as a
title, so that VoiceOver speaks them.

Bug: 861552
Change-Id: I743edfcfef8f5362984c69097cff8720e4228c07
Reviewed-on: https://chromium-review.googlesource.com/1129331
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573478}

MenuSeparator is being reused in Ash, but to do this VIEWS_EXPORT
needs to be added to views::MenuSeparator. Else we have linker failures:

std::__1::allocator<char> > const&): error: undefined reference to
'vtable for views::MenuSeparator'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable
symbol may be undefined because the class is missing its key function

Bug: 861885
Change-Id: I787fe6bf1d62518d03e52007b792481251ae4174
Reviewed-on: https://chromium-review.googlesource.com/1129999Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573477}

Bug: 849857
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8b9db90d117d0877c70e1b30b6af1e56cea46535
Reviewed-on: https://chromium-review.googlesource.com/1124925
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573476}

Bug: b:79879196
Change-Id: Ia118af06bf2efba9ae850795109a555434a76f84
Reviewed-on: https://chromium-review.googlesource.com/1130108Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573475}

Internal change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/649731

Change-Id: Ia98d8714494e05837274a7d69863647107ba2f87
Reviewed-on: https://chromium-review.googlesource.com/1129394Reviewed-by: Ran Ji <ranj@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573474}

computed_style.h is used in 1,300+ compilation units, and this CL
reduces its pre-processed size by 1.09MB.

* Avoid including image_resource_content.h
 image_resource_content.h is large due to dependency to mojom files.
 Stop inlining ShapeValue::IsImageValid().

* Avoid including style_svg_resource.h
  style_svg_resource.h and svg_resource.h are large due to
  dependency to mojom files.
 - Stop inlining many functions using StyleSVGResource and
   SVGResource.
 - Move ReferenceClipPathOperation and ShapeClipPathOperation
   to their own files.
 - Fix make_css_property_subclasses.py for generated
   core/css/properties/longhands/marker_*.h, which depend on
   StyleSVGResource.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I907a7772283b282a410fb47f457c447d5417f650
Reviewed-on: https://chromium-review.googlesource.com/1128794
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573473}

Mac doesn't have touch UI, and the test doesn't really make too much
sense on cast, but the code under test is built there and the test
is small and fast, so might as well run it. Maybe one day the test
should move to chromium_gtests_for_devices_with_graphical_output instead.

Bug: 843511
Change-Id: I792e8ed5bb419346b23a3e7432a7681e797b244d
Reviewed-on: https://chromium-review.googlesource.com/1129719Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573472}

Change made in response to spec clarification by UX.

Bug: b:78138093
Change-Id: Ie4b642d593f51051ea3f116f73954283e8475345
Reviewed-on: https://chromium-review.googlesource.com/1129553
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573471}

Minor css style changes to make its style closer to other interstitials.

Bug: 848023
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie575267fd6b424dd302fb3caf6db23669a778e92
Reviewed-on: https://chromium-review.googlesource.com/1129635Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573470}

This change fixes runtime errors introduced by the recent Autofill Home
change.

Bug: 861732
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia445d198ea4f4945b213df3e0f4d76509032c895
Reviewed-on: https://chromium-review.googlesource.com/1122616Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573469}

If the magnification gesture is enabled, the AccessibilityManager will
listen for triple-tap events and turn on (or off) the
PartialMagnificationController.

Bug: internal b/110532350
Bug: internal b/110481596
Test: manual
Change-Id: I3e1ed53fddb1c525c0cc3b238e243f59b737323d
Reviewed-on: https://chromium-review.googlesource.com/1125038
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573468}

This is a copy of https://crrev.com/c/1067424 but with tests fixed.

Bug: 844932
Change-Id: I77239bf76a673b33d56b8b7fe584a78ec319bc24
Reviewed-on: https://chromium-review.googlesource.com/1114253
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573467}

https://chromium.googlesource.com/catapult.git/+log/f6618d3f745e..21acb2a82232


git log f6618d3f745e..21acb2a82232 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 mheikal@google.com Throw exception instead of dying in get_device_sdk_version


Created with:
  gclient setdep -r src/third_party/catapult@21acb2a82232

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2c995ae2a28dd2ca5b25582fe9d8d3ad0435ea8b
Reviewed-on: https://chromium-review.googlesource.com/1129881Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573466}

This CL adds a VariationsHeaderURLLoaderThrottle on renderer to fix
the VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromSubresourceRequest.

Bug: 841309
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I6120ca42d7aeee9fe721a5af7c93c4047416225b
Reviewed-on: https://chromium-review.googlesource.com/1103451Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573465}

Bug: 854256
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I83ff040664e008108e8265a6b21069e270dac981
Reviewed-on: https://chromium-review.googlesource.com/1128209Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573464}

Delete the explicit DownloadSaveInfo move constructor in favor of
using the default move constructor. This simplifies the code and
makes it less likely that a future additional member will be
overlooked.

Also initializing members in the declaration. This Simplifies
documentation and allows the default constructor to be used.

Bug: none
Change-Id: I6a5ccb895d074f13e7a5aaae6cabbec4d1e7809a
Reviewed-on: https://chromium-review.googlesource.com/1129214Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573463}

This is a mitigation of a crash with an unknown cause, which
seems to be causing peer_handler_ to be NULL at an unexpected time.

It returns a rejected promise instead of crashing.

Bug: chromium:855161
Change-Id: Icbb4f42780ae0969ad4d0eff2ef1e9f66a129c11
Reviewed-on: https://chromium-review.googlesource.com/1128972
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573462}

Labels are not assigned to targets anymore, so the definition is now meaningless.
Instead, target affinity is defined.
This should allow us to finally close tracking bug.

Bug: 760614
Change-Id: Id705837bd502ae0e6333b9fc8cab250bc590ff11
Reviewed-on: https://chromium-review.googlesource.com/1119388
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573461}

This reverts commit 30c71bac.

Reason for revert: This CL needs to be cherry picked to m68 branch, but some testing function is changed in other CLs and breaks the build. So I'll revert this for now, check in a CL with production code only, and later land another for test.

Original change's description:
> Download: Fix an issue that download percentage can move backwards.
>
> On certain Android devices, when disconnecting from WIFI, the network
> code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
> auto download resumption. And we erase the data downloaded by parallel
> requests, so the download percentage will go backwards.
>
> Instead, we should keep the slice info when resume with an error.
>
> Bug: 837128
> Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e
> Reviewed-on: https://chromium-review.googlesource.com/1112754
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571286}

TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837128
Change-Id: Id514b0f01b950d9940933fd17cb10d962ed69d85
Reviewed-on: https://chromium-review.googlesource.com/1129660
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573460}

This reverts commit 147c8df5.

Reason for revert: Test failure, see crbug.com/861893

Original change's description:
> [Mac] Replace Editing Word with Selected Suggestion from Touch Bar
> 
> WebContents::Replace() replaces the current text selection with a given
> string. Currently, SuggestedTextTouchBarController replaces the
> current user selection when a suggestion is chosen from the touch bar.
> 
> SuggestedTextTouchBarController now calculates a range that
> encompasses the word in which the cursor resides. If the cursor is not
> in or at the end of a word, the range representing the editing word
> starts at the cursor position and has length 0.
> 
> When a suggestion is chosen from the touch bar, the selection within
> the textfield is modified to encompass the word currently being
> edited (which may be only a cursor position) and then
> WebContents::Replace() is called to replace the selection.
> 
> A unit test was written to test that
> editingWordFromText:cursorPosition: properly calculates the range
> encompassing the current editing word for various combinations of word
> and non-word characters.
> 
> Bug: 717553
> Change-Id: I4fe1fbaf2e19f8b33177e07789dca3a30bb7d88e
> Reviewed-on: https://chromium-review.googlesource.com/1123226
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Commit-Queue: Tessa Nijssen <tnijssen@google.com>
> Cr-Commit-Position: refs/heads/master@{#573362}

TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com

Change-Id: I8e79b608aab37f7fda5e09f6fbd3d16c0d19a384
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717553
Reviewed-on: https://chromium-review.googlesource.com/1130120Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573459}

The WebFormElementObserverImpl made an incorrect but also totally unnecessary
cast of a Node to an HTMLElement. This edge case was discovered by the fuzzer
where a form was inside an <svg> element, whose style attribute was changed,
but which could not be casted to HTMLElement.

Bug: 861571
Change-Id: I62c8238e25ef39e662dc154a1f2bd772667ec52f
Reviewed-on: https://chromium-review.googlesource.com/1128973Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573458}

Per the spec[1][2], when 'auto' is specified for 'rx' or 'ry' the used
value of said property will be the used value of the other property
('rx' for 'ry' and vice versa.)

[1] https://svgwg.org/svg2-draft/geometry.html#RX
[2] https://svgwg.org/svg2-draft/geometry.html#RY

Bug: 861585
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec0a9179527a5b0e99cc6a0ec671e5b6d92f828b
Reviewed-on: https://chromium-review.googlesource.com/1128885Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#573457}