GitLab

ContentViewCore holds a window pointer that is used during
destruction of native AwContents to remove observers. However the
current CleanupReference based finalization scheme does not enforce
an ordering on the destruction of native WindowAndroid and AwContents
instances. Satisfaction of the constraint that AwContents is destroyed
before WindowAndroid is therefore dependent on the CleanupReference
implementation, and possibly the implementation of the JVM as well.

Making the AwContents DestroyRunnable strongly reference the
associated WindowAndroidWrapper enforces the correct ordering.

BUG=595336

Review URL: https://codereview.chromium.org/1809643002

Cr-Commit-Position: refs/heads/master@{#381675}

Remove the following channels:
 - BackForward
 - Editing
 - Events
 - Frames
 - FTP
 - History
 - IconDatabase
 - Loading
 - PlatformLeaks
 - PopupBlocking
 - Progress
 - SpellingAndGrammar
 - LiveConnect
 - Threading
 - Compositing
 - Gamepad
 - ScriptedAnimationController

They are unused.

Review URL: https://codereview.chromium.org/1811883002

Cr-Commit-Position: refs/heads/master@{#381674}

Use w3c testharness in
LayoutTests/editing/selection/
 extend-by-character-001.html
 extend-by-character-002.html
 extend-by-character-003.html
 extend-by-character-004.html
 extend-by-character-005.html
 extend-by-word-001.html

BUG=

Review URL: https://codereview.chromium.org/1798413003

Cr-Commit-Position: refs/heads/master@{#381673}

BUG=274045

Review URL: https://codereview.chromium.org/1789593002

Cr-Commit-Position: refs/heads/master@{#381672}

When there is an IME extension listening on input.ime.onKeyEvent, the key event will be passed to the extension before the OS handling it, and  ProcessKeyEventDone() will be called after the extension calls input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be excused in different orders. The current implementation has bugs as the variables in system such as |composition_changed_| and |result_text_| will be changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone() in InputMethodAuraLinux to recover the passed environment.

BUG=517773
TEST=None

Review URL: https://codereview.chromium.org/1801363005

Cr-Commit-Position: refs/heads/master@{#381671}

The compilation was broken due to crrev.com/381594

BUG=none
TBR=paulirish, pfeldman

Review URL: https://codereview.chromium.org/1814743002

Cr-Commit-Position: refs/heads/master@{#381670}

textarea-paste-newline.html used dumpAsText() without js-test.js.
This CL has no behaivor changes.
This is a preparation of crbug.com/380471.

BUG=380471

Review URL: https://codereview.chromium.org/1807123002

Cr-Commit-Position: refs/heads/master@{#381669}

Rewrite white-space property for contenteditable=plaintext-only elements as:
    normal   -> pre-wrap
    nowrap   -> pre
    pre-line -> pre-wrap
because whitespace collapsing doesn't make sense in plain-text editing.
The new behavior matches to Microsoft Edge for TEXTAREA.

BUG=595491

Review URL: https://codereview.chromium.org/1813663002

Cr-Commit-Position: refs/heads/master@{#381668}

Cr-Commit-Position: refs/heads/master@{#381667}

There's no pointers to what GN is or how to set it up from this document
despite there being references to using it. This change adds the
GN Quick Start Guide to the Advanced Features section.

Review URL: https://codereview.chromium.org/1806213002

Cr-Commit-Position: refs/heads/master@{#381666}

BUG=none
R=horo

Review URL: https://codereview.chromium.org/1810453002

Cr-Commit-Position: refs/heads/master@{#381665}

BUG=589698

Review URL: https://codereview.chromium.org/1800823002

Cr-Commit-Position: refs/heads/master@{#381664}

It was a dumpAsText() test without js-test.js.
This CL has no behavior changes.

Review URL: https://codereview.chromium.org/1813583002

Cr-Commit-Position: refs/heads/master@{#381663}

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340

Review URL: https://codereview.chromium.org/1766273002

Cr-Commit-Position: refs/heads/master@{#381662}

It is useless with new Animation system.

BUG=575041

Review URL: https://codereview.chromium.org/1810853002

Cr-Commit-Position: refs/heads/master@{#381661}

BUG=

Review URL: https://codereview.chromium.org/1810713002

Cr-Commit-Position: refs/heads/master@{#381660}

R=isherman@chromium.org
BUG=none
TEST=`git grep md-downloads`

Review URL: https://codereview.chromium.org/1805273002

Cr-Commit-Position: refs/heads/master@{#381659}

Also use the platform-specific color in CommonThemePaintMenuItemBackground

This should fix a regression introduced by ff6ab32f

BUG=570698

Review URL: https://codereview.chromium.org/1797053002

Cr-Commit-Position: refs/heads/master@{#381658}

Previous isTreatedAsStackingContext is confusing because besides
positioned elements we also treats some other elements as "pseudo
stacking contexts" (see ObjectPainter::paintPseudoStackingContext()
==> renamed to ObjectPainter::paintAllPhasesAtomically()).

The actual difference between elements "isTreatedAsStackingContext" and
other pseudo stacking contexts is that the former are treated as
"z-index:0" so are stacked in the containing stacking context.

Then isTreatedAsOrStackingContext() is to check if the element should
be stacked, so rename it to isStacked().

Added a chapter in Source/core/paint/README.md to explain how we understand
and use the concepts.

Also avoid "pseudo stacking context". Rename
ObjectPainter::paintPseudoStackingContext() to
ObjectPainter::paintAllPhasesAtomically().

Review URL: https://codereview.chromium.org/1798263002

Cr-Commit-Position: refs/heads/master@{#381657}

Grab the current time in various formats so we can compare how long it's
been since the last ack.

Also use QueryUnbiasedInterruptTime to determine whether the computer
has been suspended recently.

BUG=588342

Review URL: https://codereview.chromium.org/1804303002

Cr-Commit-Position: refs/heads/master@{#381656}

BUG=496258

Review URL: https://codereview.chromium.org/1809863002

Cr-Commit-Position: refs/heads/master@{#381655}

BUG=none

Review URL: https://codereview.chromium.org/1808943002

Cr-Commit-Position: refs/heads/master@{#381654}

Cr-Commit-Position: refs/heads/master@{#381653}

This is needed to allow building with the N preview SDK.

BUG=595525,595522

Review URL: https://codereview.chromium.org/1808073002

Cr-Commit-Position: refs/heads/master@{#381652}

content/common/gpu/client/gl_helper.{h|cc} depends on media.

It looks like it's only used by content/browser/compositor
anyway, so I moved it there.

BUG=586384

Review URL: https://codereview.chromium.org/1802383002

Cr-Commit-Position: refs/heads/master@{#381651}

https://chromium.googlesource.com/skia.git/+log/bf680c30a280..cc864c336d19

$ git log bf680c30a..cc864c336 --date=short --no-merges --format='%ad %ae %s'
2016-03-16 mtklein Add back SkAutoTDelete::detach() for Android temporarily.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1809643007

Cr-Commit-Position: refs/heads/master@{#381650}

Also, put rasterizer threads on top of main thread events.

Review URL: https://codereview.chromium.org/1798253003

Cr-Commit-Position: refs/heads/master@{#381649}

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206

Review URL: https://codereview.chromium.org/1806703002

Cr-Commit-Position: refs/heads/master@{#381648}

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1814573002

Cr-Commit-Position: refs/heads/master@{#381647}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c4384a34d3b6..1d2c8cd5bebc

$ git log c4384a34d..1d2c8cd5b --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1808953002

Cr-Commit-Position: refs/heads/master@{#381646}

Move the following grid-column/grid-row related longhands from
LegacyCSSPropertyParser into CSSPropertyParser:
grid-column-start, grid-column-end,
grid-row-start, grid-row-end

BUG=499780

Review URL: https://codereview.chromium.org/1798863005

Cr-Commit-Position: refs/heads/master@{#381645}

Revert of Disabling v8.infinite_scroll for mac and linux. (patchset #1 id:1 of https://codereview.chromium.org/1812613002/ )

Reason for revert:
Re-enabling as crash bug has been fixed.

Original issue's description:
> Disabling v8.infinite_scroll for mac and linux.
>
> TBR=sullivan
> BUG=595404
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
>
> Committed: https://crrev.com/fc14335324676f130243e608d8231aa578e0902d
> Cr-Commit-Position: refs/heads/master@{#381584}

TBR=robertocn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595404

Review URL: https://codereview.chromium.org/1808743004

Cr-Commit-Position: refs/heads/master@{#381644}

The AudioDecoder service is created by MojiMediaClient directly,
without intermediate factory.

BUG=542910

Review URL: https://codereview.chromium.org/1810763002

Cr-Commit-Position: refs/heads/master@{#381643}

Before this change, UpdatePerUserShortcutsInLocation() looked for
shortcuts pointing to |install dir|(.*)chrome\.exe and updated them
to point to the chrome.exe of the current installation. Unfortunately,
for a user-level dev/beta/stable installation, |install dir| is
something like "C:\Users\...\Google\Chrome", which means that
"C:\Users\...\Google\Chrome SxS\chrome.exe" is matched.

With this CL, a dev/beta/stable installer will no longer try to update
shortcuts pointing to a Canary installation.

BUG=595374

Review URL: https://codereview.chromium.org/1803383002

Cr-Commit-Position: refs/heads/master@{#381642}

BUG=593567
R=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1813603002

Cr-Commit-Position: refs/heads/master@{#381641}

When building Chrome with VS 2015 Update 2 RC there is a compiler error:

1>  texture_definition.cc
1>base/memory/ref_counted.h(414): error C2027: use of undefined type 'gpu::gles2::GLStreamTextureImage'
1>  gpu/command_buffer/service/texture_manager.h(31): note: see declaration of 'gpu::gles2::GLStreamTextureImage'
1>  base/memory/ref_counted.h(413): note: while compiling class template member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T *)'

This is caused by a compiler bug, together with a type trait used in
std::vector:
https://twitter.com/StephanTLavavej/status/710191543840219136

A VS bug has been filed at:
https://connect.microsoft.com/VisualStudio/feedback/details/2475971

Bug 595189 has a more minimal repro.

BUG=440500,595189
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1806743002

Cr-Commit-Position: refs/heads/master@{#381640}

The GLHelperHolder in RenderWidgetHostViewAndroid wants to use a
command-buffer-aware context, which means it has to create a
WebGraphicsContext3DImpl. However we can hide that behind the
ContextProviderCommandBuffer API, to help us deprecate and
delete the WebGraphicsContext3D class.

We make a few cleanups to the class overall while we're touching it.

R=sievers@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1805343005

Cr-Commit-Position: refs/heads/master@{#381639}

This change is a subset of https://codereview.chromium.org/1698183005/

A Task is a unit of work in the task scheduler. It has a closure,
a sequenced time, TaskTraits and other metadata inherited from
base::PendingTask.

A Sequence holds Tasks that must run in order. It is ref-counted
and has thread-safe Push, Pop and Peek operations. Priority queues,
worker threads and task runners will have references on Sequences.

BUG=553459

Review URL: https://codereview.chromium.org/1705253002

Cr-Commit-Position: refs/heads/master@{#381638}

Review URL: https://codereview.chromium.org/1813613002

Cr-Commit-Position: refs/heads/master@{#381637}

Reduced official build size from 7.9MB to 6.4MB. Can reenable WebRTC by changing the BUILD.gn file.

BUG=595038

Review URL: https://codereview.chromium.org/1806963002

Cr-Commit-Position: refs/heads/master@{#381636}