- 17 Apr, 2019 40 commits
-
-
Darwin Huang authored
- Creates a ClipboardItem. - Uses ClipboardItem for navigator.clipboard.{read,write}() - Updates navigator.clipboard tests and adds ClipboardItem tests. - Final CL for shipping new Async Clipboard API w/image support! :D Bug: 150835 Change-Id: Ic7059fbbb87c60487af8ad0d8a9e5ab92978f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553383Reviewed-by:Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651837}
-
Christian Fremerey authored
Bug: 783442 Change-Id: Ifcceaf981b5841872280149b882f5d3949ca9dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553174Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651836}
-
Etienne Bergeron authored
The class DisableFontSmoothing is modifying a system wide setting that affect rendering. Unfortunately, that setting is also affecting other unittests. The call to SystemParametersInfo is modifying a system-wide setting: see: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-systemparametersinfoa It seems to have first appeared in https://codereview.chromium.org/100255 to cater for the test -- RenderViewTest.PrintLayoutTest. Chrome tests should not modify the global state of the system. Unittests should be able to handle different configurations. Every tests are passing correctly. If some tests are failing or disabled because of this class, we should fix it by detecting if fonts smoothing is activated or not. Bug: 953293, 759870 Change-Id: Ib1899f00ba18ae530da2a078933ff8b0a0983f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569969Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651835}
-
Kelvin Jiang authored
Host permissions for Manifest V3 can only be specified in the new manifest key |host_permissions|. Hosts in |permissions| or |optional_permissions| will trigger an install warning. Bug: 62898 Change-Id: I5f12dfadfcdcad522cc231478ff2cb405ebd2648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560730Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#651834}
-
Rohit Rao authored
Creates ChromeActionsAppInterface to serve as the eDO interface for actions-related helpers, following the pattern established for EG2 helpers. Uses the C++ wrappers to handle conversions from std::string to pure ObjC objects suitable for transfer over IPC. BUG=922813 Change-Id: Ic9e8f31af179f3a3cedcf29e92320ef0e12db1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569750 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#651833}
-
Robert Sesek authored
Using mach_thread_self() returns a reference that must be deallocated with a separate system call. Using the cached port stored by pthreads means not having to issue two system calls to get the thread ticks. Change-Id: Ic3a1e8cbe74a88f070a1c6843b03778132a53b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572438Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#651832}
-
Regan Hsu authored
This CL copies the settings-main and settings-basic polymer components used by the currently combined OS and Browser settings page to the future exclusive OS settings page. This CL also renames settings-* to os-settings-* in os settings. Bug: 950007 Change-Id: I7a0412964de498683bf329683411812503024f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566621Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651831}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/854d22feaf4b..084712c40e18 git log 854d22feaf4b..084712c40e18 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 ilkos@google.com Merge "Fix start_ts associations" 2019-04-17 cferris@google.com Merge "Modify initialize function for changed parameter." Created with: gclient setdep -r src/third_party/perfetto@084712c40e18 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia03904098cbadb1350c5024b07bd7620b4c90dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651830}
-
Tommy C. Li authored
Right now, when the user double-clicks a word within an elided URL, we trigger unelision on the second mousedown. During unelision, the text shifts. If the mouse moves at all during the second mouseup, the selection may change unexpectedly. This is ordinarily not a problem, but since the text has shifted underneath the user, even tiny mouse movements can cause large selection changes. This CL fixes that by applying a minimum threshold to any drag movements (8px). Any drag movements smaller than that are ignored. This threshold is active until mouseup. Bug: 951447 Change-Id: I584b827e408e2d03e20d76bb0bd3b038e193e80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570571 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#651829}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7ea5259bb00..db8bc8a9d46c Created with: gclient setdep -r src-internal@db8bc8a9d46c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I8ec60a6ed8def71661f76398e7ace0590f012d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572181Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651828}
-
Alexei Filippov authored
Change-Id: I41534e7523fe04c07051da087c9c5b19b332de15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572269Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#651827}
-
Anastasia Helfinstein authored
This is a reland of 91a61a31 Original change's description: > [Switch Access] Refactor focus for clarity around back button > > Bug: None > Change-Id: I3318ae4d5f37d67e7fe5abb894f9edacddc785d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549944 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647532} Bug: None Change-Id: I5fbb04a2c11c7e77afc98891dc60f795bb9f2c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553812Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#651826}
-
Steve Kobes authored
The original UMA and UKM include subframes since crrev.com/645061. Reporting the main frame jank separately will assist our analysis. UKM collection review doc: go/lsukmrevmf Bug: 581518 Change-Id: I5f9119492033a31d6896e35cd08ae848378907d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553653 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#651825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e72279d25f75..1e2cb1573bd2 git log e72279d25f75..1e2cb1573bd2 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 maruel@chromium.org [roll-dep] Ignore chromium-autoroll rolls Created with: gclient setdep -r src/third_party/depot_tools@1e2cb1573bd2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4dc48ec04dc56b694a0a2ec9d65f107c2cb82af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572186Reviewed-by:
-
Becky Zhou authored
Fix a crash introduced from http://crrev/c/1556779 Bug: 942771 Change-Id: I86e05da12c15447a9ad5f551b5e39683778e3f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570920Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651823}
-
Caroline Rising authored
Mirroring state would be sticky when the bubble anchor changed but not when the bubble would be recreated. Bug: 910739 Change-Id: Ia9a9609b2959fe8133437da5966fdc7f41c32a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570539Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#651822}
-
Adrienne Walker authored
Bug: 949773 Change-Id: I390333a7b9f5c67c4200fd28cc5d08b2719a7905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570131Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#651821}
-
Nate Chapin authored
RenderFrameImpl::CommitSyncNavigation() runs a navigation synchronous only if (1) the navigation will load as empty, and (2) it is the first navigation in the frame. TestWebFrameClient::BeginNavigation now follows the same rules. Bug: 855189 Change-Id: Ic5858ab1d8617a359d44f5e8cbc034de5bc4bf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548050 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Austin Eng authored
Now that Dawn is tested on the chromium.dawn waterfall, it is no longer needed to have use_dawn=true on the gpu fyi bots. Bug: 948902 Change-Id: I6abd029b63e5d845879baaf3eb1cca76ee7eae8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572262Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#651819}
-
Aleks Totic authored
Update expectations for http/tests/devtools/elements/styles-3/styles-add-blank-property.js http/tests/devtools/elements/styles-4/styles-update-from-js.js TBR: atotic@chromium.org Bug: 938884,946716 Change-Id: Id57c4e781770a706fac559e3152c4277ea09d286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572272Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#651818}
-
Dmitry Gozman authored
Provisional document loader is going away (see step 8.d from the doc linked to the bug), so we explicitly pass DocumentState and ui::PageTransition to WillSendRequestInternal. This required splitting GetTransitionType as well, since it uses WebDocumentLoader internally. Bug: 855189 Change-Id: I03e9f342d258e56c2eff97128fa8461f27f2fb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522334Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651817}
-
Tim Song authored
The proper color should be dark red according to the specs. BUG=953242 Change-Id: I509587210eff6422ab48a29b189785b67c103f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570543Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#651816}
-
Katie D authored
This fixes a UX issue where menus that have no other content and otherwise wouldn't be shown are shown when a screen reader is enabled. For example, in the Files app in Chrome OS, there are some areas that have no context menu, and just showing this one is counter intuitive. Bug: 953063 Change-Id: Ib6516d1aa33c207b5dc66e2ecd4032faf8b50363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568653Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#651815}
-
Will Cassella authored
The omnibox disables autocompletion if the user has backspaced - detected by checking the current text size against the previous text size. An exception to this is trailing selected text, which is not considered when comparing the size. Previously only the selection_end field was used to determine the size of the selection, which is incorrect in the case of an inverted selection (where the selection start is greater than the end). This fixes that. Bug: 951375 Change-Id: Ie245db06570e3b6df8d41a7645d60429973eecf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570751Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#651814}
-
Ben Pastene authored
This turns down the following bots: https://ci.chromium.org/p/chromium/builders/ci/Android%20Find%20Annotated%20Test It's been red and unmaintained for a while. https://ci.chromium.org/p/chromium/builders/ci/Android%20Remoting%20Tests Same thing. https://ci.chromium.org/p/chromium/builders/ci/Android%20VR%20Tests Its tests moved to the main android waterfall. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Builder%20%28dbg%29 Served to only trigger the prev three testers. Bug: 952610 Change-Id: Iafaeb7d430f9d12d8a5440b60c98cb96174139f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570658Reviewed-by:
-
Malay Keshav authored
This patch removes the clipping portion from the rounded corner shader. This is not needed and as the layer with the rounded corner is already masked to bounds and clipped. This clipping also caused bugs due to it not performing any blending for partial pixels. Bug: 952100 Change-Id: Ib006e1cc52144db33ed209edda42b9371963f45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570687Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#651812}
-
Steven Bennetts authored
A small handful of NetworkStateHandler changes that will be required to support mojo. These have been extracted out to keep the follow-up CL introducing the mojo API to a reasonable size. Bug: 862420 Change-Id: I9a7b2da5bf4a3bfc2aae5797dca6d536fd760e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570759 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#651811}
-
Steven Bennetts authored
This CL: * Adds an AshDBusHelper class to Ash to create and/or track dbus::Bus * Passes the dbus::Bus instance from Chrome to Ash via ShellInitParams in classic / SingleProcessMash mode. * Removes //chromeos/dbus as a dependency in //ash, adds the minimum required dbus related dependencies, and adds or updates comments for dependencies that need to be removed. Bug: 951017 Change-Id: Ic1196da6688c49d612842352808dad99c19cd62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561834 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651810}
-
Katie D authored
The article is being written for M75. Bug: 953095 Change-Id: Icc3c6fd5892662993f83ebe21976d5d15c7ba6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568318Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6f5e84894e74..011d3a125e15 git log 6f5e84894e74..011d3a125e15 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 srte@webrtc.org Revert "Cleanup in NetworkEmulationManagerImpl." 2019-04-17 danilchap@webrtc.org Use DefaultTaskQueueFactory instead of Global in test RealTimeController 2019-04-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3904a433..14c052d7 (651612:651715) 2019-04-17 dklee@google.com Revert "Ensure that we always set values for min and max audio bitrate." 2019-04-17 artit@google.com Revert "Only process cross traffic simulation if added." 2019-04-17 srte@webrtc.org Removes TimeMicros interface from ThreadProcessingFakeClock. 2019-04-17 dklee@google.com Ensure that we always set values for min and max audio bitrate. 2019-04-17 srte@webrtc.org Make MessageQueue processing an optional feature of FakeClock 2019-04-17 mirtad@webrtc.org Prepare to move SPS VUI rewriting out of H.264 packetizer. 2019-04-17 srte@webrtc.org Cleanup in NetworkEmulationManagerImpl. 2019-04-17 hbos@webrtc.org Implement RTCOutboundRtpStreamStats.retransmitted[Bytes/Packets]Sent. 2019-04-17 nisse@webrtc.org Expose send parameters for RemoteEstimatorProxy for field trial. 2019-04-17 perkj@webrtc.org Add field trial to AimdRateController to only increase while not in ALR 2019-04-17 eladalon@webrtc.org Rename "UpdateLayerConfig" to "NextFrameConfig" 2019-04-17 eladalon@webrtc.org OnLossNotification() receives references 2019-04-17 srte@webrtc.org Only process cross traffic simulation if added. 2019-04-17 nisse@webrtc.org Drop usage of legacy VCMPacketRequestCallback 2019-04-17 nisse@webrtc.org Don't call VideoReceiver::SetNackSettings Created with: gclient setdep -r src/third_party/webrtc@011d3a125e15 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic0db264363b96dc4865964c7125bab2f9fef5010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572185Reviewed-by:
-
Elly Fong-Jones authored
This flag doesn't do anything. Bug: 953690 Change-Id: I71c038a2299613523f09b9d04eb0d87e8b1561b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572242 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651807}
-
John Rummell authored
If the device supports it, playback of videos encrypted using pattern encryption with AES 128 bit keys in Cipher Block Chaining mode (CBC) will be allowed. Tested CBCS playback by using the Widevine integration console. Tested CBCS encryption scheme query by running the W3C drm-check-encryption-scheme.https.html test with flag EncryptedMediaEncryptionSchemeQuery enabled. BUG=813845 TEST=see above Change-Id: I3babfc2c4afe114ce2b3d18a5556f5a27f15a93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546500 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Christian Biesinger authored
Matches the source change in https://crrev.com/c/1437282 R=brucedawson@chromium.org Change-Id: Id641b1445479b48cd1eb4224f93a60932e02800e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572241 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#651805}
-
Hiroshige Hayashizaki authored
After this CL, all references to address space that can occur during off-the-main-thread worker script fetch use FetchClientSettingsObject::GetAddressSpace(), and thus use outsideSettings' address space correctly. There are still direct calls to SecurityContext::AddressSpace(), but they are used for insideSettings fetch. Bug: 945215, 878274 Change-Id: Ie006e3c06966b24d38847ffc84e30291a7973c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570632 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#651804}
-
Charlie Harrison authored
This histogram is still useful for debugging, and for evaluating whether we need to implement re-indexing. TBR=jkarlin@chromium.org Bug: None Change-Id: Ib75a7c2984046d1c049154548bfd82c803a1360d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572239Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#651803}
-
Mohamed Heikal authored
This reverts commit d84a0fe3. Reason for revert: performance regression crbug.com/950549 Original change's description: > Reland "Do not create PrefetchGCMAppHander in reduced mode" > > > Reason for reland: Original cl always created prefetch service when full > browser starts to make sure to create gcm handler. Unfortunately, this was on > the critical path, thus a performance regression. There is also a crash that > seems to be caused by the original cl where the gcm driver is created twice. > > In this new version of the cl, the PrefetchServiceFactory uses > FullBrowserTransitionManager to register a callback when full browser is > loaded, however, the callback is not registered if prefetch service is never > created, thus solving the performance issue (also, clearer I belive). > > > Original change's description: > > > Do not create PrefetchGCMAppHander in reduced mode > > > > > > If in reduced mode, we cannot create PrefetchGCMAppHandler. Instead we pass the > > > prefetch service a closure to create the gcm app handler on demand. > > > > > > This cl also changes the signature of the getter for PrefetchGCMHandler in > > > PrefetchService to require a profile to be passed in. This ensures that: > > > 1) the getter can only be called in full browser mode (there is no profile in > > > reduced mode). > > > 2) if PrefetchGCMHandler hadn't been created yet, then it can be > > > created on demand using the aforementioned profile. > > > > > > Bug: 934337 > > > Change-Id: I7e813f425e0ba8687f9b519b4300fa7eec014929 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495737 > > > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Reviewed-by: Xi Han <hanxi@chromium.org> > > > Reviewed-by: Jian Li <jianli@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#640470} > > > Bug: 934337, 944952, 943271 > Change-Id: Id4cf79cfc09998d946d2ec0685294aa553f02fa4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538779 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647321} TBR=carlosk@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934337, 950549 Change-Id: Ib5088fce99ec425d26e3cd756145db6f5b289567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564534Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#651802}
-
Jacob Dufault authored
Bug: 943491 Change-Id: I24fb4c0bb8ed7aacdde17509e89b145035f38f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568188 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#651801}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3aad3e9228b3..21712068feee git log 3aad3e9228b3..21712068feee --date=short --no-merges --format='%ad %ae %s' 2019-04-17 zoddicus@users.noreply.github.com Validate that SPIR-V binary is encoded as little endian for WebGPU (#2523) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@21712068feee The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iac7fe715afd97ac24fb90935faf24231bdbad37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572184Reviewed-by:
-
Sinan Sahin authored
Also, replace disabled_text_color with default_text_color_tertiary Bug: 951231 Change-Id: I95b148c6372bb4f20d0c32d7317058130be0eb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570185 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#651799}
-
Tina Wang authored
Previously the notification on Windows doesn't have an image on the left. Add Chrome logo to be the image. Previous: https://screenshot.googleplex.com/czHKUPwf9Bu Now(image will change base on channel): https://screenshot.googleplex.com/p3oeicKOEf5 Bug: 952428 Change-Id: Ibc972b977806d8f8c2e4b44fa852f12dd40a0827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565448 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#651798}
-
