GitLab

BUG=399803

Review URL: https://codereview.chromium.org/458093002

git-svn-id: svn://svn.chromium.org/blink/trunk@179911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change WebAnimation to WebCompositorAnimation
Change WebAnimationCurve to WebCompositorAnimationCurve
Change WebAnimationDelegate to WebCompositorAnimationDelegate

This is patch 3 of 3. It builds on http://crrev.com/413983002

BUG=396358

Review URL: https://codereview.chromium.org/412123002

git-svn-id: svn://svn.chromium.org/blink/trunk@179910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=399803

Review URL: https://codereview.chromium.org/461543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the Layout tests for shadow so that they dont use child
elements of <shadow>. In this patch, childs which are added through
JS is being removed.

BUG=334957

Review URL: https://codereview.chromium.org/450533007

git-svn-id: svn://svn.chromium.org/blink/trunk@179908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=396400
NOTRY=true

Review URL: https://codereview.chromium.org/458053004

git-svn-id: svn://svn.chromium.org/blink/trunk@179907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

What is happening is:
1. User opens popup
2. PopupListBox::layout measure's row width
  2-1. text width is calculated as ltr
  2-2. this width for ltr is registered to the WidthCache
3. PopupListBox::paintRow is called
  3-1. WidthCache has a interval mechanism so the cached ltr width is not used
  3-2. text width is calculated as rtl
  3-3. Text is  drawn as rtl
4. User hovers over items
5. PopupListBox::paintRow is called each time the selection changes
  5-1. WidthCache's cached ltr width is used
  5-2. Text is  drawn as rtl (rtl width is shorter than the rtl width so there is extra space on the right side)

There are two problems
- PopupListBox::layout is measuring row width using ltr always
- WidthCache is returning ltr width for rtl text

This just fixes PopupListBox::layout.
BUG=398929

Review URL: https://codereview.chromium.org/451983004

git-svn-id: svn://svn.chromium.org/blink/trunk@179906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CallbackData created by InjectedScriptManager should be deleted when
an associated worker thread terminates. The most straightforward way
to do that is to make the InjectedScriptManager hold a list of
OwnPtr<CallbackData> that the InjectedScriptManager created.
Since the the InjectedScriptManager is destructed in ~WorkerScriptController(), it's guaranteed that all associated CallbackData is destructed
in
~WorkerScriptController() as well.

This change will fix a couple of inspector-protocol/debugger tests in oilpan builds.

BUG=398472

Review URL: https://codereview.chromium.org/452043002

git-svn-id: svn://svn.chromium.org/blink/trunk@179905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added an assertion to the patch in https://codereview.chromium.org/444223004/

In StyleSheetContents::checkLoaded after parentStyleSheet check, "this pointer" is guaranteed to be equal to rootStyleSheet.
So we can only use this pointer instead of rootStyleSheet.

Review URL: https://codereview.chromium.org/456673002

git-svn-id: svn://svn.chromium.org/blink/trunk@179904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change...
- adds 'onupdatefound' event and version attribtues (eg. '.installing') into
ServiceWorkerRegistration interface.
- adds WebServiceWorkerRegistrationProxy interface to talk to the registration
object from embedder.

[NOTE] ServiceWorkerRegistration is still disabled by the macro since Chromium
side is still actively being implemented:
https://codereview.chromium.org/427523002/

[Spec] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj


BUG=396400
TEST=compile (layout tests will be added after enabling the registration interface)

Review URL: https://codereview.chromium.org/424693004

git-svn-id: svn://svn.chromium.org/blink/trunk@179903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/457263002

git-svn-id: svn://svn.chromium.org/blink/trunk@179902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=179897 was committed
with a broken test :(

BUG=399967
NOTRY=true
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/459723002

git-svn-id: svn://svn.chromium.org/blink/trunk@179900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Assert that updator functions of HashMap, HashSet, and Vector should not be used during weak processing.

We already have assertions in Heap::allocate and Heap::reallocate. However the
member functions of HashMap, HashSet, and Vector don't always call
Heap::allocate or Heap::reallocate, and it's very hard to detect
allocation-in-weak-processing.

BUG=400652

Review URL: https://codereview.chromium.org/456633002

git-svn-id: svn://svn.chromium.org/blink/trunk@179899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As a step to use toFoo, this cl introduces DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it.
Additionally this cl clean up static_cast<TextCloneCSSValue*> with toTextCloneCSSValue().

BUG=309516

Review URL: https://codereview.chromium.org/453203003

git-svn-id: svn://svn.chromium.org/blink/trunk@179898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The button is configured to snooze the item for 1 hour. The item is deprioritized
in the UI by changing the opacity. Subsequent patches could separate snoozed
items out into a separate collapsible stream.

This patch adds the concept of annotations on a group of failures, 
persisting them in local storage. Subsequent patches should persist
the annotations in a frontend.

NOTRY=true
BUG=399967

Review URL: https://codereview.chromium.org/448503003

git-svn-id: svn://svn.chromium.org/blink/trunk@179897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The slow, normal, and fast keywords, and the seconds unit, are not used by
the presentational style for the marquee element.

R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/457633002

git-svn-id: svn://svn.chromium.org/blink/trunk@179896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes RenderFlowThread::adjustedPositionRelativeToOffsetParent
which was added in [1] to support regions. This code is no longer
called and is dead.

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=150894

BUG=

Review URL: https://codereview.chromium.org/459603002

git-svn-id: svn://svn.chromium.org/blink/trunk@179895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- |m_createdDocument| renamed to |m_parsedResponse|
- Refactor |didReceiveResponse|:
-- Decoder init factored out into |createDecoder|
- Refactor |responseXML|:
-- Response document init factored out into |initResponseDocument|

Refactoring in preperation to async parsing change.
This patch is split from https://codereview.chromium.org/454313002/

TEST=fast/xmlhttprequest, http/tests/xmlhttprequest
BUG=402261

Review URL: https://codereview.chromium.org/455193002

git-svn-id: svn://svn.chromium.org/blink/trunk@179894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=

Review URL: https://codereview.chromium.org/454103003

git-svn-id: svn://svn.chromium.org/blink/trunk@179893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium stopped overridding createSolidColorLayer() from
WebCompositorSupport and inheriting from WebSolidColorLayer at
https://src.chromium.org/viewvc/chrome?revision=288125&view=revision, and
Blink removed the function at
https://src.chromium.org/viewvc/blink?revision=179785&view=revision.

BUG=None
TEST=None
R=tkent@chromium.org

Review URL: https://codereview.chromium.org/460453003

git-svn-id: svn://svn.chromium.org/blink/trunk@179892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

use new onDrawPicture variant, as the previous is now deprecated and is no longer called by the base-class.

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/455213002

git-svn-id: svn://svn.chromium.org/blink/trunk@179891 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary blink:: prefixes
- Make blank lines consistent

BUG=

Review URL: https://codereview.chromium.org/455883003

git-svn-id: svn://svn.chromium.org/blink/trunk@179889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This innocuous-looking call was changed in
https://codereview.chromium.org/255563004 to produce huge data URLs for
canvas elements.  This caused a performance regression in Android
WebView which needs to report URLs of the last tapped element to the
embedding app.  Switch absoluteImageURL() back to its previous behavior
of ignoring canvas elements, and introduce a new method
absoluteImageURLIncludingCanvasDataURL() that's only used in
WebViewImpl::saveImageAt and copyImageAt.

NOTRY=true
BUG=395859

Review URL: https://codereview.chromium.org/457013002

git-svn-id: svn://svn.chromium.org/blink/trunk@179888 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'border-image' has 'border-image-source', 'border-image-slice',
'border-image-width', 'border-image-outset' and 'border-image-repeat'.
http://www.w3.org/TR/css3-background/
m_imageSlice is for 'border-image-slice' and m_borderSlice is for
'border-image-width'.
It causes confusion between m_borderSlice and m_imageSlice.
This patch changes m_borderSlice to m_borderWidth along with
property name.

BUG=
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/456753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add some performance testing for paint invalidations (https://codereview.chromium.org/450813002/)

Reason for revert:
Timing out on perf bots. One example:
http://chromegw/i/chromium.perf/builders/Linux%20Perf%20%281%29/builds/2268/steps/blink_perf/logs/stdio

Original issue's description:
> Add some performance testing for paint invalidations
> 
> After moving paint invalidations after compositing updates, we
> lost most of the performance coverage we had as most performance
> tests trigger layout without generating a frame.
> 
> The new cases are DRT specific as we use
> Internals.forceCompositingUpdate. This is required as rAF
> will cap the tests to the sync frequency.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179881

TBR=dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org,xianxianzhu@chromium.org,jchaffraix@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/459663002

git-svn-id: svn://svn.chromium.org/blink/trunk@179886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

skia is changing the signature for onDrawPicture, so this CL adds the new one, and removes OVERRIDE from the old.

BUG=

Review URL: https://codereview.chromium.org/454993002

git-svn-id: svn://svn.chromium.org/blink/trunk@179885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The try except block in _rename_results_folder() is throwing an UnboundLocalError.
Because the return statement in except block is inside if statement.
If the condition is false the function doesnot return which throws an error so the return statement must be outside the if statement.

Review URL: https://codereview.chromium.org/454853002

git-svn-id: svn://svn.chromium.org/blink/trunk@179884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All this class did was prevent callers from null pointer checking the
object, but all hasCompositedLayerMapping() does is null check it so it's
not clear what value this is adding, lets remove it.

Review URL: https://codereview.chromium.org/457473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After moving paint invalidations after compositing updates, we
lost most of the performance coverage we had as most performance
tests trigger layout without generating a frame.

The new cases are DRT specific as we use
Internals.forceCompositingUpdate. This is required as rAF
will cap the tests to the sync frequency.

Review URL: https://codereview.chromium.org/450813002

git-svn-id: svn://svn.chromium.org/blink/trunk@179881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The EME specification now describes the format of the license
request provided to the application via the message attribute of
the message event as being JSON. This change allows the browser
tests to work once the new message format is implemented.

BUG=358271
TEST=EME layout tests pass with and without the JSON change

Review URL: https://codereview.chromium.org/429033003

git-svn-id: svn://svn.chromium.org/blink/trunk@179880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also report INFINITY if number of samples is 1. This is another way to interpret the confidence interval of 1 data point.

NOTRY=True
BUG=401806
TEST=tools/perf/run_benchmark smoothness.fast_path.key_silk_cases;  # Open tools/perf/results.html and ensure no NaNs.

Review URL: https://codereview.chromium.org/457873002

git-svn-id: svn://svn.chromium.org/blink/trunk@179878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This logs errors when the underlying commands fail, and tries
to recover a bit more cleanly.

TBR=eseidel@chromium.org, ojan@chromium.org, wangxianzhu@chromium.org
BUG=397678

Review URL: https://codereview.chromium.org/417123006

git-svn-id: svn://svn.chromium.org/blink/trunk@179877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The interface for getExcludedIntervals was designed when shape-inside
was still a thing, and it was possible for a line in a shape to have
multiple segments. shape-outside can only have one segment per line, so
this refactors the code to simplify and reflect that reality.

Review URL: https://codereview.chromium.org/454123002

git-svn-id: svn://svn.chromium.org/blink/trunk@179876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code was attempting to take the fast scrolling path for RenderViews that
were not composited. Unfortunately, there's no way for the compositor to scroll
RenderViews that are not composited. Instead, we should bail out and run the
slow scrolling path.

This CL also removes some dead code from this function and updates the comments
to more accurately reflect reality.

R=jamesr@chromium.org
BUG=401878

Review URL: https://codereview.chromium.org/457773002

git-svn-id: svn://svn.chromium.org/blink/trunk@179875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No one should be reading the hasVisibleDescendant state while its dirty. This
CL adds an ASSERT to prevent that from happening and fixes the callers that are
reading dirty state today.

R=skobes@chromium.org

Review URL: https://codereview.chromium.org/455963002

git-svn-id: svn://svn.chromium.org/blink/trunk@179874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

And fix compilation breakage from r179850.

TBR=haraken,oilpan-reviews
BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/451153002

git-svn-id: svn://svn.chromium.org/blink/trunk@179873 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=399178
NOTRY=true

Review URL: https://codereview.chromium.org/453713004

git-svn-id: svn://svn.chromium.org/blink/trunk@179872 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This object is the proxy for the ServiceWorker cache; it's created
entirely through the CacheStorage interface.

R=falken@chromium.org,jkarlin@chromium.org
BUG=399178

Review URL: https://codereview.chromium.org/434543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179857

BUG=394004
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/452923007

git-svn-id: svn://svn.chromium.org/blink/trunk@179870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Send QUIT_LOG to LogToServer thread immediately on exception
to avoid blocking.

We still need to press ctrl-c twice to quit the whole rebaseline-o-matic
script. This is intended because we want the first ctrl-c to break the
current rebaseline, and the second to break the outer loop. This also
ensures that the loop continues on any temporary exception raised during
a rebaseline.

Review URL: https://codereview.chromium.org/454933003

git-svn-id: svn://svn.chromium.org/blink/trunk@179869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bust the MemoryCache to ensure script requests reach the browser-side and get added to and retrieved from the ServiceWorker's script cache.

BUG=387589

Review URL: https://codereview.chromium.org/419693002

git-svn-id: svn://svn.chromium.org/blink/trunk@179868 bbb929c8-8fbe-4397-9dbb-9b2b20218538