- 30 May, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a6d63441aee..87b2fa4bb58f Created with: gclient setdep -r src-internal@87b2fa4bb58f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Iaa78541ec7303a5f649fdd628e707b0d0d8a5beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636516Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664712}
-
Sergio Villar Senin authored
This is a followup of http://crrev.com/c/1588650. In this CL MemoryInfoTest is moved out of time function overrides. TestMockTimeTaskRunner is used instead. Overriding the time functions is no longer required as the mock clock provided by the test task runner has all the required features, basically moving time forward at will. Bug: 919383 Change-Id: I13ac8b2436d0b07da1374dee189372619ecbfbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590103 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664711}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1bf1cfe3. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I46548c2ddb0a203f0e79e01339215d77b8232bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636624Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664710}
-
Alex Clarke authored
A large but mostly trivial patch in preparation for removing base::MessageLoop. We introduce SingleThreadTaskExecutor a simple FIFO scheduler, which is intended for non-test code that needs a simple single threaded task environment. Tests should use ScopedTaskEnvironment or TestBrowserThreadBundle instead. This patch also moves MessageLoop::Type to MessagePump::Type and moves the factory method to MessagePump::Create. TBR=gab@chromium.org Change-Id: I9850c4657bb90b62490f4313c420cae025101371 BUG: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632216Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#664709}
-
Etienne Pierre-doray authored
This CL fixes a few issues with SequenceLocalStorage: - Supports holding T with disabled copy/move constructor by adding emplace(). - Prevents auto default construction with GetValuePointer. - Query if SequenceLocalStorageSlot currently holds a value with operator bool(). - Update doc to use NoDestructor. This makes it possible to replace in many cases: SequenceLocalStorageSlot<unique_ptr<T>> with SequenceLocalStorageSlot<T> and auto ptr = sls.Get(); if (!ptr) { ptr = make_unique<T>(); sls.Set(ptr); } return *ptr; with return sls.GetOrCreateValue(); TBR=fdoray@chromium.org Change-Id: I0473fbb4eded35177aa32fabb5377b0cad648c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634876 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#664708}
-
Mohamed Amir Yosef authored
Bug: 967424 Change-Id: Ic7ed7f1934357fba85ce0e187298b6508a5e8b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614179 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664707}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sammc@chromium.org Change-Id: I4b3b1b6e59ca65ecdce281818234353955e5ff78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636352Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664706}
-
Juan Antonio Navarro Perez authored
Underlying issue in crbug.com/962918 has been fixed, let's try re-enabling them now. NOTRY=true TBR=crouleau@chromium.org Bug: 966630 Bug: 966619 Bug: 966631 Change-Id: Ic59ce1d63d6c4b796420fec23002dafa853b35cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636195Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#664705}
-
Juan Antonio Navarro Perez authored
Stories fail while trying to DumpMemory. NOTRY=true TBR=crouleau@chromium.org Bug: 964960 Change-Id: I1b806e8fdc71d32e9caf11d124aebf88073e339b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635616Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. DO NOT SUBMMIT BUG=891670 This CL was uploaded by git cl split. R=primiano@chromium.org Change-Id: Ib36c5a18d81596be37e707dae0a6d0879edb28c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635815 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#664703}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 887407 Change-Id: I4d98da09939b86c31a04d8b82823f6a0f9b8f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631286Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664702}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I455b2f1cb18ed0fb3543d6517cc0deaeea0559b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664701}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. DO NOT SUBMMIT BUG=891670 This CL was uploaded by git cl split. R=rmcelrath@chromium.org Change-Id: Iccef22a70c2f7465a6a3da5bb717c18922d8065a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635517 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#664700}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 887407 Change-Id: Ib35383c1272e2ab649ec2b0d76e2b1c9f5f28d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632221Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0270f5ed3fb2..8a6d63441aee Created with: gclient setdep -r src-internal@8a6d63441aee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I661aaa20e32cd8bbc9904f69a15a41032dd6e860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636501Reviewed-by:
-
Sergio Villar Senin authored
This is a followup of http://crrev.com/c/1590101. In this CL WebViewTest is moved out of time function overrides. TestMockTimeTaskRunner is used instead. The migration is far from trivial. Some other classes had to be migrated first, InteractiveDetector (with test) and DocumentLoader among others. In order to simplify a bit the migration, a new attribute was added to WebNavigationParams carrying the clock to be used by DocumentLoader. That clock is precisely the one being used by TestMockTimeTaskRunner. That modifications in DocumentLoader had some side effects in order non directly related tests, in particular CSSAnimationTests. There is a pretty tiny rounding error in TimeTicks <-> double conversions that force us to replace an exact comparison (EXPECT_DOUBLE_EQ) by an approximation (EXPECT_NEAR) with a very tiny margin error. Bug: 919383 Change-Id: Ie1bf2402a9cf55f312ba4cf5f129097e25ed4ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588650 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664697}
-
Wei-Yin Chen (陳威尹) authored
Measure performance of Grid-to-Tab transition animation in the following use cases: - Back to current tab showing NTP/web page - To another live tab showing NTP/web page - To another frozen tab showing web page Bug: 964406 Change-Id: Ib730ae1bb19f3660f5050e9c04dd588e67425001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636339 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664696}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/172e5d373fad..b2021956d81c git log 172e5d373fad..b2021956d81c --date=short --no-merges --format='%ad %ae %s' 2019-05-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src f051812343eb..e7866de4b1dc (4 commits) Created with: gclient setdep -r src/third_party/angle@b2021956d81c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I5bb019c4d93e05f1eedd04631b0ba27822ee0a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636622Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Downsample by 2 to reduce memory usage and drawing cost. The scaling factor can be configured by Finch. Bug: 964406 Change-Id: Ie6aa046bdebaa771b90431d28c9c4be320ffb826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637031 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Mythri A authored
The DCHECK in IssuePendingOperations is not correct. We still need to issue pending operations when the backend has failed so we can call required callbacks (for ex: for FetchEntry requests). This DCHECK was added in an older version of code when we didn't receive any requests before initializing the backend. Also adds a test to test this path. Change-Id: I5eec4886445eb65b0b083cc0805713449d07fc11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634703Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#664693}
-
Noel Gordon authored
defined(DEBUG) => !defined(NDEBUG) Bug: 936429 Change-Id: I6b8b9402c32af0defd043bf20debf4ce417abe82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636995Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#664692}
-
Mitsuru Oshima authored
* Currently only used by ClientControlledState for ARC++, to simply send the move request to Android w/o reparenting. * DefaultState/TabletModeState will be addressed in a separate Cl,along with the change to wm::SetBoundsInScreen. * Removed TestClientControllStateDelegate and replaced with callback. This also requires android side change. (ag/7533307) Bug: 875047, b/78306357 Test: covered by unit tests. Change-Id: I5b3cd7a74ead0eb90bb9204ca8a6812aec2c3ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602744 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#664691}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/069773abcb3e..0270f5ed3fb2 Created with: gclient setdep -r src-internal@0270f5ed3fb2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ie748280a911ab873027e7e3d9bb99aa17ab992f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636778Reviewed-by:
-
Maggie Cai authored
Currently, if we have a website that redirects from a link that is in the scope of a installed PWA, to a link that is not in the scope of a PWA, the intent picker icon will show, and clicking it will show no bubble. This is a issue where we don't reset the intent picker icon view when we try to update the visual and found the app list we queried is empty. This CL fixes this issue and add a test for it. BUG=967296 Change-Id: I58184b70d739ba5b4b5ff9e3d4826327a485bde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631153Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#664689}
-
Joel Hockey authored
Fetches VmInfo from concierge in order to get seneschal server handle, then creates default dir for sharing and shares it along with other persisted shares. Bug: 957477 Change-Id: I797d14c3590adc44cfdcefb0af25b37d64254f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631009 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#664688}
-
Dmitry Vorobiev authored
WebContentsAndroid has a getTelephonyNetworkCountryIso() call in its constructor. As far as WebContents is usually created on the UI thread, there is a synchronous call which goes through the binder there. In this CL TelephonyManager subscribes to the TelephonyManager updates and stores obtained values. Former WCA construction time was about 8ms for the first time and about 4.5ms for the following times. In this CL WCA construction time is about 13ms for the first time and about 0.09ms for the following times. Bug: None Change-Id: I9933a1c16931b12ae8489c7e9a5e319ca655dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617499 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664687}
-
Hirokazu Honda authored
Bug: 949898 Test: Play videos with YouTube app Change-Id: I737bfd232cefc3a4db379bdbc9f1eb1dc62c7c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621804Reviewed-by:
-
Ken Rockot authored
This updates all manifests of services built into Content and Chrome so that they directly specify (or at least parameterize) their execution mode. TBR=avi@chromium.org Bug: 895615 Change-Id: I8dfc53f74ebe71e6903e383e69b61ac8cfc90005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615713Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664685}
-
Simon Que authored
Includes the Week 1 CI builders, which were migrated in: https://chromium-review.googlesource.com/c/chromium/src/+/1634109 R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 950413 Change-Id: If842e60432c20e30aa15e49df7bbf90f8dc9b326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637018 Commit-Queue: Simon Que <sque@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664684}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d25d871d3b1..2f0f5fb37d74 git log 2d25d871d3b1..2f0f5fb37d74 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ded5f903261a..172e5d373fad (11 commits) Created with: gclient setdep -r src/third_party/skia@2f0f5fb37d74 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: Id8fb17e3c702f451cecf4e077f5140b6e211f611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636779Reviewed-by:
-
Alexey Baskakov authored
The problem: ExtensionRegistryObserver events happen too early and don't include any post registration code. Bug: 915043 Change-Id: I3ff3b2a4e567be828d0dc5597a30081a757067c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631259 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Also changed != and == to !== and ===, because these are the recommended operators to avoid implicit type conversion. There is no intended change in behaviour, so it should be covered with current set of tests. Test: Manually loaded the grid view and selected items in a few different ways Bug: 778674 Change-Id: I3314262ca85eb3dcabdf616c638486e582fd8f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636665 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#664681}
-
Hayato Ito authored
Regarding DCHECK_CURRENTLY_ON(BrowserThread::UI) defined in the removed code, FrameTreeNode::GloballyFindByID, called from WebContents::FromFrameTreeNodeId, has the same DCHECK so there should be no behavior change. Change-Id: I4c827b3a3dbbb3b4be6f66ee920a28b1ce792f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634133Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#664680}
-
abhi.rathore authored
Select popup is still visible during mouse wheel scroll outside select popup dialog, which is not a correct behaviour in android. Hence we hide the select popup during page scroll in android. Bug: 967563 Change-Id: I0bab0fb5beca7046bbf802b7935f785bf352f9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631811Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Cr-Commit-Position: refs/heads/master@{#664679}
-
Maksim Sisov authored
Previously, the WaylandConnection was a proxy between the clients of the WaylandBufferManager and the manager itself. This was a redundant functionality, and it was decided to avoid proxying. The following changes have been made in this cl: Renamed: * WaylandBufferManager => WaylandBufferManagerHost * WaylandConnectionProxy => WaylandBufferManagerGpu * WaylandConnectionConnector => WaylandBufferManagerConnector Code changes: The WaylandConnection no longer forwards calls to the WaylandBufferManager. Instead, the WaylandBufferManagerHost and the WaylandBufferManagerGpu have an associated mojo connection, and are able to speak to each other without a proxy in between. This is more logical and makes the WaylandConnection class be less overloaded with different functionality. The tests have also been rewritten, and helper methods have been added. Bug: 947411 Change-Id: I9ffd162f8459705ae22f55a9f1b1e7caa1567986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617359Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#664678}
-
Chih-Yu Huang authored
For video decoding, Chrome renderer stack needs texture-backed VideoFrame. But VideoDecoder requests and uses DMA-buf VideoFrames from the VideoFramePool. We need to generate the texture of the DMA-buf before passing to the renderer. VideoFrameConverter is design to convert DMA-buf VideoFrame to texture-backed VideoFrame. BUG=941330 TEST=Pass video_decode_accelerator_tests with relation chain CLs Change-Id: Ia3bcf49202697794a318df0136e4838b71ae3885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535514 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#664677}
-
Alexandre Courbot authored
This reverts commit 91b0391f. Reason for revert: Bug: chromium:968392 Test: Checked that video_VideoSeek.vp8.switchres passed on Kevin. Original change's description: > media/gpu/v4l2svda: fix stateless API specification violation > > The stateless API states that resolution of frames should be set on the > OUTPUT queue, and the coded resolution read back from the CAPTURE queue. > However we were setting the resolution on the CAPTURE queue and > expecting the ioctl to update it to the coded resolution. > > This works with our current kernel drivers, but is not correct with > respect to the stateless codec API specification. The kernel drivers > have been updated to support the correct behavior, so carry that change > into Chromium as well. > > Bug: 948534 > Test: Checked that VDA unittest passes on Kevin and Minnie with kernel > driver fixes. > > Change-Id: I8f589f81ae1a7d8223235739f0748e58ac25e342 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553124 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659876} TBR=tfiga@chromium.org,hiroh@chromium.org,acourbot@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 948534 Change-Id: I710af049273963ec34786633b0afb67736df2249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636992 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
Originally command_buffer_helper is at //media/gpu target. At the next CL, //media/gpu/linux will use command_buffer_helper. But //media/gpu already depends on //media/gpu/linux. To avoid circular dependency, we separate command_buffer_helper to a isolated build target. BUG=941330 TEST=Build chrome for chromeos and linux target Change-Id: Ia456b36b1a7229aa58ccaba4248c29d17ca698ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564364 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Sertay Sener authored
According to Push API spec[1], while subscribing to a push service, applicationServerKey field in push should also accept a base64url encoded string. [1]https://w3c.github.io/push-api/#idl-def-pushsubscriptionoptionsinit Bug: 802280 Change-Id: I8b02e4e5259b6359aece4c42eb66e1ce00b2bab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597492Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sertay Sener <sesener@microsoft.com> Cr-Commit-Position: refs/heads/master@{#664674}
-
Maciej Pawlowski authored
The destructor of UniqueProtoDatabase posts deletion of the underlying LevelDB to a task runner via DeleteSoon. In order to not leak it, we need to run the message loop at the end of the test. Bug: 968053 Change-Id: I1ab5289fc7c63713fcce958a3191297f3b8b8cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634875Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Cr-Commit-Position: refs/heads/master@{#664673}
-
