- 01 Oct, 2020 40 commits
-
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Id133ab0b0744c07405d0ed69eb9774b27b5c09f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442540 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812827}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601289755-benchmark-87.0.4277.0-r1 to 87-4265.0-1601289755-benchmark-87.0.4278.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia705a8f0f5e4466ebe4a74a7671ce39ef4955b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812826}
-
zhaoyangli authored
These run on Xcode 12.2 and should use 14.2 simulator runtime. Bug: 1132967 Change-Id: I344e4bd651da37792cf156e95cd55efafa68d816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440201Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812825}
-
Jesse Schettler authored
Since there's no benefit to passing uuid and device_name by value in LorgnetteManagerClientImpl, pass them by const reference. Bug: None Change-Id: I7594cc938d2c1180eeb172b8c71ac0ee967f1d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442501 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812824}
-
Xi Han authored
In this CL, Feeds articles are opened as a Tab instead of CCT from the StartSurface. When back button is pressed from the Tab, it will return to the original Feed articles on the StartSurface. Also support to open the Feeds articles in incognito tab. Demo: https://drive.google.com/file/d/1r3H3_S8EZms33vspI_IarE4NH3Eh9aI3/view?usp=sharing Bug: 1108451 Change-Id: I651b2378970f0ed53d2b663cdd97fd2872057ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424639 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812823}
-
Bailey Berro authored
Allows clients to implement the BatteryHealthObserver interface and register themselves as an observer in order to receive periodic updates about the battery health. Bug: 1128204 Change-Id: Ib4ffc60ec5fd30bda37c255bd17b669eaa4b9f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438474 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812822}
-
adamta authored
The IPH bubble for the Discover feed should only be shown if the NTP has been created with the Discover feed. This can be determined by checking if the named guide for the Discover feed menu button has been created. Bug: 1132757 Change-Id: I0bbf35fba8fb49fcb080ce581f3bf953d56ce0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434910 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812821}
-
Brandon Wylie authored
CustomTabCompositorContentInitializer relies on ChromeActivity to initialize compositor content. This method is part of ChromeActivity's interface, so removing the dependency is difficult. Moving the #initializeCompositorContent behind an interface and injecting that into CustomTabCompositorContentInitializer to decouple the two. This change is meant to be an example on how to handle this case. Bug: 1123209 Change-Id: I8ba93cd80074c8935bd07428327f74ca2973eb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429870Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812820}
-
Jacobo Aragunde Pérez authored
The kAlert accessible event was explicitly produced in several places, causing duplication. There are two places where the event must be produced for all the alert bubbles to work properly: * BubbleDialogDelegateView::AddedToWidget for the session crashed bubble * BubbleDialogDelegate::OnBubbleWidgetVisibilityChanged for the rest of them This is still causing duplication for the save password bubble, we leave it reported with a TODO in its test. Bug: 1082217 Change-Id: I29af53794823ff115767077a8824fdc6795dbe4e AX-relnotes: prevent redundant alert events. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394695 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812819}
-
Owen Min authored
The following policies can never be supported from cloud. The tag only works as a hint to the server team but not changing any browser behavior. UserDataDir CloudPolicyOverridesPlatformPolicy MachineLevelUserCloudPolicyEnrollmentToken CloudManagementEnrollmentToken CloudManagementEnrollmentMandatory CCTToSDialogEnabled Change-Id: Ibb661edc76b587ebd8f40090312ed0f06df079e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441742Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812818}
-
Leonard Grey authored
Command string constants often have ampersands embedded in them for display in Windows menus. These need to be stripped out for display in commander. Bug: 1014639 Change-Id: I37e87013fd0eb4a18eb796b8870768c9794c1aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440308Reviewed-by:
-
Nate Chapin authored
Change-Id: Ie26ffe4038baa99cca2942440df3cbddfea29069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436681 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#812816}
-
Caleb Raitto authored
We're only adding use counters for these methods. Bug: 973801 Change-Id: Id87584bb501f7ccd7cb98c0c3ce2d7500763bb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438755 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
-
Prashant Nevase authored
The dark mode settings were tightly coupled to blink settings. As per usage those don't change until chrome is relaunched or webview's lifetime. This patch cleans up dark mode settings and new behavior is - blink settings is used for enabling/disabling dark mode while dark mode settings are used to configure dark mode filter. Decoupling settings will help create DarkModeFilter without blink settings. This is needed for raster side dark mode for images. Bug: 1082339 Change-Id: I763ea3f0f05e43b4ea30926817f3aca06bf5f84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390588 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Gil Dekel authored
As of today, all ChromeOS releases utilize kernels that robustly support universal planes. This makes the need to accommodate for non-supporting code paths obsolete. This CL removes this code. Bug: 1129546 Change-Id: I2df722646cb85b3b4cdf04354941824e72aa15e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413407 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#812813}
-
Yulun Wu authored
There are a variety of hard coded ink drops that need to be unified (see related bug). This CL replaces them with themed colors based on search box background color. Related Bug: 1051167 Bug: 1133246 Change-Id: Id2ce3c94461405516d6ad3f83cc271c7c51d06ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442354Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812812}
-
Michael Checo authored
- Implement i18n for strings. - Localize CPU card title - Localize Battery Status card title - Localize Memory card title - Localize Diagnostics app title Bug:1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Icf9dbb0b0a19c4d3d216548460c21a89fd178ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433126Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This is a reland of d0bda2ee. This is the same as the initial CL except logging of the password length. Original change's description: > Add metrics to InsecureCredentialsManager > > This CL adds metrics about passwords weakness check. > > Bug: 1119752 > Change-Id: I20ff20dde480c84ebd5d252ce7684cecc4fc4c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434336 > Commit-Queue: Irina Fedorova <irfedorova@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812625} TBR=rkaplow Bug: 1119752, 1134152 Change-Id: Iecfabdcfa32b687b53e00a9e147b6695e4610327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442734Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#812810}
-
kylechar authored
The --force-gpu-rasterization flag hasn't existed for a while but it's still used by GPU tests that want to ensure GPU rasterization. Switch the tests to use --enable-gpu-rasterization instead. I think this is only an issue on Linux, since other platforms have GPU rasterization enable by default, but some of the screenshot_sync and pixel_skia_gold_tests will change how they run with this. Bug: 1133368 Change-Id: I973d5ad6343d1e9d951a4854a98956fa09098387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437705Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812809}
-
Andrei-Laurențiu Olteanu authored
This is a reland of 503df9e6 Add nogncheck to chrome_browser_interface_binders.cc. Original change's description: > [Telemetry SWX] Add lid events > > Create and make available mojo interface for chrome://. > > Add implementation in chrome://. > > Add implementation in chrome-untrusted://. > > Add implementation for cros_healthd fake onLidOpened event emitter. > > Add browser test for lid event listener. > > Bug: b:167523716 > Change-Id: I4281778d451264f57154913330d8cd5ba83cb4f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389981 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Oleh Lamzin <lamzin@google.com> > Reviewed-by: Mahmoud Gawad <mgawad@google.com> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> > Cr-Commit-Position: refs/heads/master@{#812623} Bug: b:167523716 Change-Id: Ied8ce33faafef480a76c8a6d6d74eb4ff299d6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440670Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#812808}
-
Rohit Agarwal authored
This CL modifies: a) The incognito button string in the account picker dialog. b) The title of the incognito interstitial. c) The content of the incognito interstitial. d) Formatting the sub-content of the incognito interstitial to bold wherever needed. Screenshot: crbug.com/1133288/#c5 Bug: 1133288 Change-Id: I5dd5513bea0afced5bde8f3281f72145116c96fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437396 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812807}
-
Luke Zielinski authored
These are needed by wptrunner on chromium CI. For run_web_tests.py these files will be replaced by internal versions from LayoutTests/resources via wpt.config.json Change-Id: I7b500360cdaa7a67581f85f429030bf26c4768af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441480 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#812806}
-
Matthew Mourgos authored
Bug: 1080827, 1122723 Change-Id: I6332168a821b1be34f91ecfa9903712867517ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441513Reviewed-by:
-
Evan Stade authored
Switch aggregate_vector_icons to the new version, without removing aggregate_vector_icons2. This will allow downstream clients to switch back to aggregate_vector_icons before aggregate_vector_icons2 is removed. Bug: 1132894 Change-Id: I42e6c04c0cde42e7c84810403333ebd3def577a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441327Reviewed-by:
-
Kevin Ellis authored
CSS animations are to return computed values for the keyframe properties rather than values directly from the keyframes rule. In particular, variable references are to be resolved. The spec calls for resolving at the time the animation is generated but acknowledges that the extraction can be done lazily as an optimization. https://drafts.csswg.org/css-animations-2/#keyframes New tests failures are the result of not using the correct canonical form during property serialization. Bug: 1070627 Change-Id: If6ad836147c15feaf4d0374f8798e75fc390878b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194279 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#812803}
-
minch authored
Remove kSystemMenuIconColor and kSystemMenuIconColorToggled. Feature pod button use kButtonIconColor and kButtonIconColorPrimary in the spec. Make FeaturePodIconButton as ImageButton only. Since it already has |toggled_| to control the toggle state. Update the icon color on |toggled_| is enough for it. Bug: 1133063 Change-Id: I46e498e967e0065cfd4ce6451adf60275e1864bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439432Reviewed-by:
-
Shakti Sahu authored
This CL adds java tests for video tutorial IPH card. Bug: 1134117 Change-Id: I3096c1c31729fb90a896ce237e0f3c25e6e2a8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442380Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812801}
-
Tim Volodine authored
Initial componentization of chrome/renderer/safe_browsing code. In this patch: - move some initial files and tests to components/ safe_browsing/content/renderer/phishing_classifier (in particular features* and test_utils code). - add new build config file, - update all relevant build files and includes. BUG=1115700 Change-Id: I75e6ca754ad00135d8e6d9e466565885377b92f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437384 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#812800}
-
chinsenj authored
Remove LOG(ERROR) is ash/wm/gestures/wm_gesture_handler.cc Change-Id: I53135342ea8e060c802a7ee34cf2af96bb436d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442301Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812799}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/281fb1ed7ba9..75b9ab6751f3 2020-10-01 hta@webrtc.org Move have_pending_rtp_data_channel_ to sdp_offer_answer 2020-10-01 hta@webrtc.org Move more functions from PeerConnection to SdpOfferAnswer 2020-10-01 peah@webrtc.org Reland "Activating AVX2 support by default" 2020-10-01 danilchap@webrtc.org Support layer skipping in L3T1 scalability structure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd446860ed5dac6c9d214fc06e95da82c254fbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443032Reviewed-by:
-
cfredric authored
Bug: 973801 Change-Id: I95164a1bfc21f2af9e3377228ffe5ec4b2fbd2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438470 Commit-Queue: Chris Fredrickson <cfredric@google.com> Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812797}
-
Piotr Bialecki authored
Add origin trial feature name for WebXR Depth Sensing API, as per instructions found in: https://chromium.googlesource.com/chromium/src/+/master/docs/origin_trials_integration.md This prepares the feature for an OT. The OT will not be enabled until we get the necessary sign-offs from web platform owners and security + privacy reviewers (see launch bug below). Bug: 1131625 Change-Id: Ib139254efc5bab3bfe6578e6c929e2a26ee7aca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441490Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#812796}
-
Etienne Bergeron authored
This CL is making the TtsPlatformImpl instance a leaky instance since the singleton is alive for the whole duration of the process. The use of WeakPtr is no longer required. Bug: 1133813 Change-Id: Ice2ff18c88c9168c6471ceaa7613c7b2f344ce99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441201 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812795}
-
Dominik Inführ authored
https://crrev.com/c/2429270 added kBackgroundAllocationFailure to GarbageCollectionReason. Update the enum here as well and add other missing values as well. Bug: v8:10315 Change-Id: I572ae13bcb276457afec4625f992230ddf9a7577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440836Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812794}
-
Joanmarie Diggs authored
This is a follow-up to http://crrev.com/c/2426490 which prevents an infinite loop in AXPosition::AsValidDOMPosition by ensuring we have a changed AXPosition after calling CreatePreviousPosition in generated content. That fix failed to check that the previous position created was not null prior to seeing if it had indeed changed. Bugs: 1131019, 1133124 AX-Relnotes: Prevents a page crash when accessibility is enabled. Change-Id: Iaa8a7d79c5750809e6a3d39f7077f6593f95488d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440630 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Pavol Drotar authored
The launchWebApkSiteSettings test inside the ManageTrustedWebActivityDataActivityTest file turned out to be flaky. We believe it was due to the check of whether an activity is running which failed on a slower device. The fix uses CriteriaHelper to wait with a timeout until the activity starts running. Bug: 1131836 Change-Id: Id660518f7e1b52626c7e9daabfdd45b73bbf9d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442830 Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Reviewed-by:
-
Etienne Bergeron authored
This CL is making the TtsPlatformImpl instance a leaky instance since the singleton is alive for the whole duration of the process. The use of WeakPtr is no longer required. Bug: 1133813 Change-Id: Iceeb676cd23a1867132255b51c4fb3439e049985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441674 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Harry Cutts authored
This will be used to show or hide a separate set of settings for pointing sticks. For now, the visibility logic is modified to show mouse settings if either a mouse or pointing stick is connected, to preserve existing behaviour. To test, you can use a Python script [0] to create a fake pointing stick with uinput. [0]: https://gist.github.com/HarryCutts/e17783d9475e45abcc4b73b9e7aabb7a Bug: 1114828 Test: check `hasPointingStick` value with and without a pointing stick Change-Id: I917c8ead69a126280752a9a1a4b4bea609c7e33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427888 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/11b196b0c0c6..124ea2073720 2020-10-01 engeg@google.com gclient: override special DEPS file for P0 2020-10-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-01 ahassani@chromium.org paygen: Add default source_version 2020-10-01 bpastene@chromium.org cros_chrome_sdk: Fetch SDK components in parallel on two threads. 2020-09-30 pprabhu@chromium.org cbuildbot: Bump skylab tool version 2020-09-30 lamontjones@chromium.org cros_branch: allow multiple checkouts of the manifest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ie11ace58584c4604324d96184cd37c0631869308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441741Reviewed-by:
-
Esmael El-Moslimany authored
Hide promo and modules until both are loaded. Fix issue with promo that is not shown until resize. The promo is hidden using "display: none" when the "hidden" attribute is set. This needs to be updated before emitting the loaded event. The handler needs the bounding rect of the element to be set to determine if it overlaps with the most-visited tiles. This is only a concern for when modules are disabled. Change-Id: Idf6c692f3e18af38bcc3e2d7224466c2239608e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441942 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812788}
-
