- 10 Aug, 2020 40 commits
-
-
Alice Wang authored
This CL adds |Signing in...| string for the sign-in in progress screen title of the web sign-in bottom sheet. Screenshot: https://crbug.com/1102784#c3 Bug: 1102784 Change-Id: I9c3e33da3986bcb7156ef67e27dbe088342cbce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309700 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796429}
-
Xinghui Lu authored
Bug: 1114761 Change-Id: Id46125f5a1d28c4af39be7bbd75d08172c1a1490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345715Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796428}
-
Lei Zhang authored
When calling chrome.fileSystem.chooseEntry() to save edited PDFs, there is an option for the file types to accept. For each file type, the description is optional. The API documentation [1] says "if not present, a description will be automatically generated", but the generated description ended up being an empty string in this case. Fix this by manually setting the file type description. [1] https://developer.chrome.com/apps/fileSystem Bug: 1114127 Change-Id: If3440fcd13a152bb55e8f80193b4960103776cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343782Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796427}
-
Jesse McKenna authored
This change makes IdleWakeups count the cumulative number of processes created and destroyed with the target executable name during the monitoring period, and display these counts in its final summary. This enables the measurement of process turnover resulting from operations of interest, which would otherwise not be reflected in total process count (as a destroyed process and created process that both occur in between polls would cancel each other out and go undetected). Note that it is still possible to miss a process if its lifetime is so short that it is created and destroyed entirely between samples. Counting is done by comparing the previous snapshot's set of process IDs with the target executable name against the new snapshot's. The accuracy of the counts added by this change was verified by comparing against those collected by an ETW trace (System Activity > Processes) over the same period. In this comparison, IdleWakeups identified all created and destroyed Chrome processes apart from a utility process with a lifetime of only 0.08 seconds between samples. Change-Id: I93d674377906f6bd543da2c7b65792bb811fd91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342251 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#796426}
-
Peter Wen authored
Lint no longer requires manifest_package to be specified, so remove this arg from lint.py as well as the gn templates. Bug: 1108791 Change-Id: I4b48dc1ce3eb40ef8b4e703ca4ece475f2d28c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339929 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796425}
-
Bo Liu authored
Need to ensure AwBrowserProcess.start isn't called multiple times for a single process. Also add an annotation to disable batching and use it for app cache tests, since app cache can only be set once and the setting is global. Bug: 989569 Change-Id: I360230ac612a004bda94dded1d9dd6cb2e3f14cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335673Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796424}
-
Peter Kotwicz authored
BUG=None Change-Id: I03c770a9f06ebdb310cf1ace86cfc3b76b897e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345487Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cac176496829..039f681a841a 2020-08-10 johnstiles@google.com Label constants with k prefix (not g) and use constexpr. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I1b4d5a967110ed0f4f15a4acb4aa257d9611c2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796422}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib78ac377c2210a475b6fdd39900ca046679e64e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346867Reviewed-by:
-
Liviu Tinta authored
Add methods to check each pointer event has corresponding compat mouse event regardless of the interleaving order in which pointer events and mouse events are generated. Change-Id: Id6667e14c72338b2d18cc1ca5730ba5b4c25a63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342288 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796420}
-
Guido Urdaneta authored
These tests were using fake audio, but the issue is fixed and now they can use real audio. Bug: 1047655 Change-Id: Iedcc48f1fc19f8d5e4afd5ec04a90c991dae3e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346348 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796419}
-
Peter Wen authored
Rather than use one universal baseline.xml for lint, allow each target that wants to use lint baselines to specify its own via the gn variable lint_baseline. This also allows better co-location of baseline.xml and the code that it refers to. Also fixes the existing lint issues for cast apk. Bug: 1108791 Change-Id: I982cd35636ce9e08817be6cf8b6cccd18455d8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327834 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
sauski authored
To prevent the HaTS Next survey from attempting to open windows in the non-primary OTR profile it runs in, a WebContentsDelegate is introduced to handle attempts to create new WebContents. These are re-opened in the browser which initiated the HaTS survey instead. Bug: 1110888 Change-Id: I96942014fbeb9e78f036d87187902a9dd1dcc66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324129 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#796417}
-
Jeffrey Young authored
Ambient settings page section to selected preferred unit. https://screenshot.googleplex.com/nUzVCEC9eH7.png Preferred unit displayed in ambient mode. https://screenshot.googleplex.com/NE93vpZzarx.png BUG=b:154046129 Change-Id: I79e0bd111c486283bc0a0793527d394f86a870e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339218Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#796416}
-
Yutaka Hirano authored
We have used deprecation reports for Atomics.wake to test ReportingObserver for workers, but now Atomics.waks is being removed so this test will not work. We have some WPTs using ReportingObservers in workers, in wpt/html/cross-origin-embedder-policy, so we won't lose test coverage by removing this test. Bug: v8:7883 Change-Id: I63728234f0c008d826cb8c889461a0ec8b17ce53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336131 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#796415}
-
Ella Ge authored
Tests: CrComponentsCrPolicyNetworkBehaviorMojoTest.All CrComponentsNetworkConfigTest.All CrComponentsPolicyNetworkIndicatorMojoTest.All failing on linux-chromeos-dbg bot because file not found. The path should be cr_components/ instead of settings/ TBR=jhawkins@chromium.org Bug: 1114675 Change-Id: I1867ef3da6e8cc15e5c24a3da65df4991557de44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346845Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796414}
-
Sahel Sharify authored
This cl adds platform browser tests for payment handler uninstallation. Bug: 1068734 Change-Id: Ibc7fa4e28afec32ee21a2378c3899b4c61d2daa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341013Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796413}
-
Stephen McGruer authored
This augments the Chromium log formatter to handle process_output messages, allowing it to capture logs for a test from ChromeDriver. The logs are accumulated for each test, then inserted into the output JSON as an artifact if the test has a CRASH status. The post-run script in wpt_common.py then converts the crash log lines to a file on disk. Also, the handling of the CRASH status in the Chromium log formatter is fixed; it was incorrectly mapping CRASH to FAIL. Finally, --enable-chrome-logs is passed as a webdriver-arg in run_wpt_tests.py, so that full browser logs are available. Bug: 1057197 Change-Id: I7b533398f8b008ea493c1d183f429b1b13d4a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327613 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#796412}
-
Maksim Sisov authored
We need to avoid using non-Ozone/X11 code when OzonePlatform feature is enabled for Linux once use_x11 && use_ozone are set together. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ia1b9234cffdd6e40e50f39a6e35900c9f42e221e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315685Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796411}
-
Richard Knoll authored
This adds Start/StorAdvertising to the NearbyConnections interface and hooks it up to the NearbyConnectionsManager on the browser side and to the NearbyConnections class on the utility process that delegates to the third_party library. Bug: 1076008 Change-Id: I2cf883432c625d3c34060536fcbfa13f190c98c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339470Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796410}
-
Ioana Pandele authored
The native pointer was set to 0 before calling a method on it. Bug: 1102025 Change-Id: I55bb0d60c02c70620738784f07d1c7764f63598e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346430Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#796409}
-
Sebastien Lalancette authored
- Added final Copy Link URL icon, - Fixed the string for Copy Link URL action, - Fixed the string used for Open in New Window action title (it should not have a capital 'i'), - Fixed new menu's Open in Incognito string. This CL adds the first icon (copy_link_url) for the new actions. If the proposed pattern is acceptable then the remaining icons will follow a similar pattern. - Icon resource under ui/menu/, - No "menu" prefix to the icon name, - PNGs with different scales used instead of PDF, - Template icon, to allow menus to set the color. Bug: 1093302 Change-Id: Ie22d50d78a4d38c56f9c04cfc2c9cbb66d83ef0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343320 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796408}
-
Antonio Sartori authored
This CL implements the part "Does source expression A subsume source expression B?" of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#subsume-source-expressions in the services/network Content Security Policy module. This is part of a series of CL implementing the whole subsumption algorithm according to that spec. Bug: 1094909 Change-Id: I6e60608aa7734b2415cfec9d4b68a1d8dbf54b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315889 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796407}
-
Ella Ge authored
TBR=rogerta@chromium.org No-try: true Bug: 1113367 Change-Id: I2405c15ad68d30b3cbd92ac831a95758e1766123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346907Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/623cf68b45ca..b27f3f1980fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC eirage@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: eirage@google.com,andypaicu@google.com Change-Id: I906336f70bdf0a574104769edca16240cfad2797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346525Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796405}
-
Frédéric Wang authored
The HTML specifications [1] indicates that the "%s" token is preserved when parsing the URL and this is important to properly perform syntax validation. Currently, Chrome removes the token, which means that something like "ht%stp://example.org" is treated as a valid URL and bypasses the security check. This is however treated as invalid for the browser process validation and so leads to a crash (bad IPC message). The WPT tests are updated to provide the correct expectations. Those for which the %s token is inside the protocol are treated as relative URLs and are valid. Others where the %s token is inside the hostname or port should raise syntax errors. [1] https://html.spec.whatwg.org/multipage/system-state.html#normalize-protocol-handler-parameters Bug: 1112377 Change-Id: I962bcfdd593223568fc72475efeb299adaa72236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335434Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#796404}
-
Kevin Ellis authored
https://github.com/w3c/csswg-drafts/issues/5400 There is the issue that led to the spec change for play state: https://github.com/w3c/csswg-drafts/issues/2066 The issue addresses undesirable toggling of the play state due to inactive timelines, but does not seem to adequately address having an unresolved (null) timeline. Bug: 1113382 Change-Id: I33032ee1e9de10d3dce4958fce599bd98391328f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339676Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#796403}
-
Stepan Khapugin authored
Adds scribble support to the omnibox (not location bar). Bug: 1098342 Change-Id: If9c1ead2506a77767d4a16a811e26f79ddfe9b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340914 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#796402}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4cba6578f09..01e0ccdc9b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iea9300514fc25d7e302ec4ae9ba302ebbaaaf135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346549Reviewed-by:
-
Ben Kelly authored
This CL updates the testing config to match the new trial launch target of 3 maximum simultaneous fetches. Bug: 1035448 Change-Id: Ibaf8e219709f00b39361ccfa30adc6b4d7b51517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343316Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#796400}
-
Danil Chapovalov authored
it is ignored by webrtc Bug: webrtc:6471 Change-Id: Idaae7b4520bab691e948e4671890bd3dbeeadd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346384Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#796399}
-
Xianzhu Wang authored
They were in draw_properties_unittest.cc. They should belong to picture_layer_impl_unittest.cc because PictureLayerImpl makes LCD-text decision. Change-Id: I9fad0ccc2b708419383f134c90b66eef04327b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344817Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796398}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/577cc158d1e2..01e0ccdc9b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I822646620d8f1fa10a9ae1d5f0ec21286b673cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346547Reviewed-by:
-
Alice Wang authored
This CL replaces waitForIdleSync() with more specific wait to improve the AccountPickerBottomSheetTest stability on MM. Bug: 1093050 Change-Id: I52741b71b0ef399eb84f08348cdba383618ebff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345307Reviewed-by:
-
Ella Ge authored
This CL adds the TWA quality enforcement for http error 5xx and for page unavailable offline. The offline one is mostly same as 404 one, but failed when navigation finish with errorCode -106 (internet disconnected) Also, changes to use different error string that use for the toast and the message send to TWA client app. For the toast we use the localized string since it's showing in the UI. For the message to TWA client app, since it's used in a crash message, we do not localize it. Bug: 1109609 Change-Id: Ic314eeb6fdfacf6e066a6e8dbb5e72334f021e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336996 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d44592935782..32d36b08379e 2020-08-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifd3c3d341b075c3358b27095895b4eff638cd805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346704Reviewed-by:
-
Gauthier Ambard authored
This is a reland of ee4eb865 The original CL was reverted because some tests were broken when the flag was enabled. CL fixing the tests: https://crrev.com/c/2330052 Original change's description: > [iOS] Add fieldtrial config for IOSRequestDesktopByDefault > > Bug: None > Change-Id: Iea882e82e5573edaf917d8f3d976d876e2120de9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317789 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792621} Bug: None Change-Id: I0ce43d62cf33bc52321b2584a548308fce4227db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329325 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#796393}
-
Andy Paicu authored
Bug: 1114675 Change-Id: I10ff8b750702a7644e13c450f493106093ff993f TBR: jhawkins@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346346 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796392}
-
Charlie Hu authored
This CL removes dead function |blink::PolicyValue::Combine|. Change-Id: I7f2e95129efc58c73d845a3662ee8e52c78a253d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342643 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Rakesh Soma authored
2) Consider all characters as being valid for cloud directory serial mapping. Bug: 1114454 Change-Id: I9cef10c11b07f21295a6fda4ca46fdd723f04153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344814 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#796390}
-
