- 19 May, 2020 40 commits
-
-
mark a. foltz authored
This reverts commit 34fae769. Reason for revert: Seems to have broken tab mirroring. Original change's description: > [Media Router] Consolidate origin checks for using Cast streaming apps. > > Previously, the origin check was only done for sink availability and not > at route creation. It also did some brittle string parsing of the > media source ID. > > The updated check covers all streaming app IDs, adds the meet.google.com > origin, and checks origins for both availability and route creation. > > Follow up changes will add additional checks to prevent opaque origins > from also launching streaming apps (see bug for details). > > Bug: 1047834,1081503 > Change-Id: I081822796524ec2c72af29c544382cb4c9d9542d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095928 > Commit-Queue: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769512} TBR=mfoltz@chromium.org,takumif@chromium.org,jophba@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047834, 1081503, 1084643 Change-Id: I328fe04b0d0541a86649e84f06a44a30e128051b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207748 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#770231}
-
danielng authored
Updating strings to be the ones that have gone through review. Bug: 1016193 Screenshots: https://drive.google.com/drive/folders/11-3tM0nDWJr0ttYWjt6_irsuSEDkSOJ9?usp=sharing Change-Id: I4202b4fbbabadb82f00f929c3c6a835da9a61761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208315 Auto-Submit: Daniel Ng <danielng@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#770230}
-
George Burgess IV authored
Per discussion on cxx@chromium.org, these nits sound like a good deal to land. Bug: 1016926 Change-Id: Iec646df3a6644b6fa4cb76a734d4f620cb92e78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207377 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770229}
-
Alex Gough authored
Prelude to removal of WithSandboxType API. See linked bug for rationale. Does not change behavior. Tests: browser_tests ChromeMojoProxyResolverFactoryBrowserTest.* Bug: 1065087 Change-Id: I0ad3e1cf9f5da9efc41d9d63a839f8dd15a9d443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202680 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#770228}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I6e85ace81c366b01763a2c816a7525d5cb50cc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994912Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#770227}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55b3dc0c14c8..1b63b4ac6933 2020-05-19 robertphillips@google.com Revert "SkSL function inlining" 2020-05-19 bsalomon@google.com Avoid MIP mapping in strict_constraint_no_red_allowed 2020-05-19 brianosman@google.com Remove legacy matrix concat code 2020-05-19 ethannicholas@google.com SkSL function inlining If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Id432c16499cc95a250d888ccbc0636e332363fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770226}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b54466be408..8d6b021a2a13 2020-05-19 yunchao.he@intel.com Fix a bug for texture subresource If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I21229fa1ad61bff3d090dac7f8067b2c56b98e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209274Reviewed-by:
-
David Lechner authored
This replaces DeprecatedWriteRemoteCharacteristic with WriteRemoteCharacteristic in device/fido. The replacement method has a parameter to specify writing with or without response, so this also allows us to remove the use of the separate WriteWithoutResponse method. Change-Id: I567d50c779c9f31ba44e557f2db9fc929273140a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191233 Commit-Queue: David Lechner <david@pybricks.com> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#770224}
-
Antonio Gomes authored
... in favor of its frame token-based RenderFrameHostManager::GetOpenerFrameToken(). There is still only valid callee of RenderFrameHostManager::GetOpenerRoutingID() which currently prevents its complete removal: RenderFrameProxyHost::InitRenderFrameProxy(). BUG=1051144 R=avi@chromium.org, dtapuska@chromium.org Change-Id: I6c02b09542298d6069c00fcf01672c4aa526251b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207972 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#770223}
-
danakj authored
The test wants to updatePosition() after its not visible but it was doing it before waiting for the visibility change to occur. Then it wants to verify that it's not received but it was being received flakily and racing with the next visibility change. So we use roundTripToBrowserThen() to wait for the updatePosition() to take effect if it would do so incorrectly. R=nasko@chromium.org Bug: 866140, 1069111, 1083452, 1083585 Change-Id: I0a51f0919b579456154b408e1455cd41d5416c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204646Reviewed-by:
-
Kyle Horimoto authored
This CL adds support for dynamically-generated settings URLs (e.g., networking URLs which include the network's GUID as a URL parameter). It also adds a few test doubles which are used in SearchHandlerTest. Fixed: 1080892 Change-Id: I05254ab559a98c7a19edd3ceb44bff3a5f329faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208530Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#770221}
-
David Lechner authored
This replaces the use of DeprecatedWriteRemoteCharacteristic with WriteRemoteCharacteristic. It is assumed that all devices use write without response since the new WriteRemoteCharacteristic method no longer looks at the GATT characteristic properties. Change-Id: Ib7b7180b5671dde2771c1bf6a084efcb02558a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197153 Commit-Queue: David Lechner <david@pybricks.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#770220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90ec1ccfec93..e0d8925a3c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sebsg@google.com,clamy@google.com Change-Id: I831b6b8bdeed827b87e7940a2104a613c52036ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208962Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770219}
-
Rodney Ding authored
- Add ThirdPartyOriginTrials flag to runtime enabled features. - This feature will be used to gate access to validating script-injected token with its external script origin. - Test added to cover injecting tokens from insecure/secure context into insecure/context document. Bug: 1073926 Change-Id: I96e0e805de7ed76806c0c358aee93915fe9115af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201405Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#770218}
-
Mike Wittman authored
https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/acf93761dc00..dfd3f3d84cfc $ git log acf93761d..dfd3f3d84 --date=short --no-merges --format='%ad %ae %s' 2020-05-15 wittman [Sampling profiler] Add include dir to public config Created with: roll-dep src/third_party/libunwindstack Bug: 1083530 Change-Id: I825c095891a353a3ad2159a0ac23ee2c294f96e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208607 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#770217}
-
Ian Kilpatrick authored
Tests only - a previously untested combination of properties which was accidently "fixed" by turning on the FlexNG codepath. Bug: 1081872 Change-Id: I3279a75fd5b8a610919b289d7d1a28d2982d38aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208359 Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770216}
-
Rohit Agarwal authored
Through IntentURI we can create a CCT via PaymentHandlerActivity which opens the CCT halfway in front of the regular tab. This allows a malicious CCT to represent itself as the content of the background tab. This CL adds an extra check to ensure we fire PaymentHandlerActivity only if the intent was sent from Chrome and not via external navigation. This CL also adds a browser test. Bug: 1083972 Change-Id: I136774e23a641fd5feef9e47aaa87ba2d2f94b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205933Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#770215}
-
Oleh Lamzin authored
Clarify that local time zone is used for DevicePowerPeakShiftDayConfig policy. Bug: b:154476021 BYPASS_POLICY_COMPATIBILITY_CHECK=clarify timezone behavior Change-Id: I1a149feb4c44cf348d202fbf9ea489f04d3b4546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206799Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#770214}
-
John Lee authored
Bug: 1000989 Change-Id: Id62a256095d33a4eb3cb60582fed8783ba86c350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204967Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770213}
-
John Lee authored
This removes a mixin and updates the color to be more inline with other places in WebUI by sharing an already existing CSS variable. The difference in color seems very minor. https://imgur.com/a/0Pn2qVG Bug: 973674 Change-Id: Id38c3584807937356f1ce406ed6c12ba0882a047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204852Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770212}
-
Anne Lim authored
Removed the flag since it has been completely rolled out. Bug: 1078584 Change-Id: I0e056574aa0d949d8b3879c855dc8a876ccf342c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191161Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Dylan Cutler authored
This refactor will allow us to instrument other APIs as well without defining new private methods. Bug: 973801 Change-Id: Id0a2200dfbd3df37bf31a34d1d9d08dbc67be571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207492 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#770210}
-
Fabrice de Gans-Riberi authored
* Add a Cast Streaming Receiver app served from a content directory in CastRunner. * Rename "isolated Contexts" to "child Contexts" in CastRunner. Child Contexts are used for both isolated Contexts and Cast Streaming Contexts. * Register the Cast Streaming MessagePort in ApiBindingsClient. Bug: 1042501 Change-Id: Ic70ac7cd5362aecabcb0254fd906f0d2907cc01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176426 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770209}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/f45e60c61cc1..7e802793566c 2020-05-14 dschuff@chromium.org Update revision for PNaCl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: If9c5361daa83d7841101df2a4f1e75c7e5f0a0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209120Reviewed-by:
-
Bo Liu authored
The method was added in P, not N. Bug: 1084615 Change-Id: Ia0772c68b8190f3b0bc775e60c4aabefb59afa48 Tbr: torne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208366Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770207}
-
Lily Chen authored
This CL refactors ReportingDeliveryAgent to take NetworkIsolationKeys of reports and endpoints into account. It sorts the reports so that only reports with the same NIK and origin are batched in the same upload. Reports for the same (NIK, origin) but different groups can still be in the same upload if they share an endpoint URL. Also reports that get assigned to the same endpoint URL can be batched together, even if they are assigned to ReportingEndpoints configured for different origins. All the NIK fields are still empty except in tests. Bug: 993805 Change-Id: I953f0b1ff38fbe2625c539e6e00306621f1025d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138566 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
-
Dan Harrington authored
Bug: 1044139 Change-Id: If61fb3d4513350d0b95551fee6dcb0317310e7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175548Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#770205}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b5f3df1f97e..cdfc69c7f0f8 2020-05-19 lexa.knyazev@gmail.com Add ClearTestES3.TextureArrayRGB8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I5b351f7e09441636cf2948d55518669707d81e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209117Reviewed-by:
-
Regan Hsu authored
screenshot: https://screenshot.googleplex.com/rckz8zvey2T Fixed: 1083027 Change-Id: I9d9bb2dd6bf1dadefbd40a8205eabc968f6df439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203407Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/719446c0dbbd..501473c8d1a3 2020-05-19 tvanderlippe@chromium.org Add verify_lib_check to ts_library 2020-05-19 mathias@chromium.org Add basic stylelint config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I686706b93e3bb3d0b2fdf50b1b13b1f463d55f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209119Reviewed-by:
-
David Benjamin authored
The Enable* functions are only called by the Add*Internal functions. We can fold them together and both save a copy and slightly simplify the sts_state.domain.clear(), etc., logic. Bug: none Change-Id: I368fd96640d0c89cbde5ba9ad5e861859d9c277b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208074 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#770201}
-
Andy Paicu authored
... check modals instead. Since modals have been the default for a while, all these test were disabled and needed reworking. Bug: 935900 Change-Id: I47e706dc288e24369a2b6e1f1af5af24deb7bfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171490 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#770200}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43c108b7e9a7..71e9acb97c77 2020-05-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8ffd7240..d8b1c2f5 (768712:770095) 2020-05-19 courtneyfe@chromium.org Remove android_manifest_for_lint from BUILD.gn files 2020-05-19 terelius@webrtc.org Reduce alert spam in rtc_event_log_visualizer 2020-05-19 handellm@webrtc.org VideoAdapter: remove lock recursions. 2020-05-19 handellm@webrtc.org Reland "RtpVideoStreamReceiver::RtcpFeedbackBuffer: remove lock recursions." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic3ffac0500d507ced52c5eb093b18d0d3e9fbbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209128Reviewed-by:
-
yilkal authored
This is a reland of bb4748c6 Original change's description: > Update Add Accounts page for supervised user accounts. > > This cl updates the messaging in add accounts > settings page for supervised users for edu coexistence. > Supervised users are able to add only EDU school account as > a secondary account. > > The screenshot can be found here: > https://drive.google.com/file/d/1u4ATw_tuJfmXUeoU3tr0agJp6y1vgAl5/view?usp=sharing, > > Bug: 1082336 > Change-Id: Ic7026b4ce60a87b3e85329e282ec1c59f3d54a67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204274 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769480} Bug: 1082336 Change-Id: Ifaf6c89f288bdefd7e3bfe8f4391f7e7af3329f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204924 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#770198}
-
Yulun Wu authored
Bug: 1072051 Change-Id: I880c68122554f9cb705939f00e5d3ed99b470720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203262Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770197}
-
Charlene Yan authored
TabStripController::GetGroupCollapsedState is confusing for a boolean. Change this to IsGroupCollapsed. Bug: 1018230 Change-Id: I19cd667f7cd7c7769588b4b18fb6c143f54e0dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208362Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770196}
-
Eric Seckler authored
Adds Power.CpuTimeSecondsPerProcessType UMA for Android. We sample the current process's CPU time from /proc/<pid>/stat after every 100th main thread task and record samples into the histogram for every second of CPU time consumed. This only works on Android, because the Android sandbox allows access to /proc from within isolated processes. This UMA metric will aid power consumption/efficiency estimations for Chrome on Android (see bug). Bug: 1081760 Change-Id: Ia9fe3f96700379308e1f4b0a8da18e14a7d4ef89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196464Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#770195}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 49 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-11-15. TBR=chromium-metrics-reviews@google.com Change-Id: I3d67fb25e93988a9449bfd355ee5856db8c74771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208751Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#770194}
-
Jan Wilken Dörrie authored
This change adds more Windows only std::wstring overloads to string_utils.h. These additional overloads are useful for the ongoing migration of base::string16. Furthermore, it generalizes a few APIs by taking StringPiece instead of const ref to string, and base::span instead of const ref to vector. Bug: 911896 Change-Id: If7d87044e63a4ace2d1a92b24c5b5f16efb5d413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207219Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#770193}
-
Ben Kelly authored
This CL plumbs three protocol related fields through the fetch API Response internal representation: 1) The |alpn_negotiated_protocol| which is set for TLS negotiated protocols like H2. 2) The |connection_info| enumeration which includes information on older protocols like H1. 3) The |was_fetched_via_spdy| boolean which is set for H2. The first two values, |alpn_negotiated_protocol| and |connection_info|, are collectively used to populate the `PerformanceResourceTiming.nextHopProtocol` value. They are also both used to populate the correct protocol information in the devtools network panel. The |was_fetched_via_spdy| boolean is used to populate the deprecated `navigator.chrome.loadTimes().wasFetchedViaSpdy` property. Without this plumbing the resulting exposed values will generally be wrong if the page loaded via a service worker with a FetchEvent handler. For example, `PerformanceResourceTiming.nextHopeProtocol` is always the empty string for resources loaded via a service worker that does a pass-through or cached load. This CL also plumbs these values through the cache_storage layer. While that may seem unintuitive at first, since the data is coming from disk, it matches the behavior when loading from http cache. Generally the values represent the protocol used to originally load the response and are persisted in the cache. I believe this also matches the cache_storage spec where Response objects are effectively held in an array without any serialization or deserialization where data would be lost: https://w3c.github.io/ServiceWorker/#cache-objects Although the spec is not currently clear if the protocol information lives on the response object, its not clear where else it could be stored. This should become clearer once the Resource Timing spec is integrated with the fetch spec in: https://github.com/w3c/resource-timing/issues/39 This CL includes an automated WPT test for the `PerformanceResourceTiming.nextHopProtocol` value since we can verify that its populated with "http/1.1" instead of the empty string. Unfortunately it was not possible to writes for the other attributes since we do not currently have the ability to test against an http2 server. Both `wasFetchedViaSpdy` and the devtools output effectively need an http2 server to observe differences. These parts of the CL were manually tested. Bug: 1069813 Change-Id: I84819ef5a53e9246f9e383e56b6d7e5901a7a243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143860Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#770192}
-
