GitLab

/verbose linking of chrome.dll creates over one GB of output. This
causes ExecLinkWrapper to consume over two GB of memory which leads to
an OOM failure in the 32-bit depot_tools python, and the loss of all
of the valuable output. This change modifies ExecLinkWrapper to
process the output one line at a time, thus avoiding the OOM.

I've tested that this handles the 1.1 GB of output which the previous
version of this function failed on and I've visually confirmed that the
output looks the same - no extraneous blank lines, for instance, when
displaying warnings, errors, or 1.9 million lines of verbose output.

I also verified that the script stays idle when waiting for output -
blocking on .readline().

This fixes the previous attempt which omitted the vital link.wait() call
which meant that error codes were not propagated.

R=scottmg@chromium.org
BUG=672182,672841

Review-Url: https://codereview.chromium.org/2568563002
Cr-Commit-Position: refs/heads/master@{#437696}

This CL adds logic for resetting all User Controls to its default
value upon closing the device file descriptor; otherwise, as the
bug proves, they persist across camera uses, e.g. the zoom level
is unchanged.

This would be relatively simple except for the fact that controls
come in two types: user controls and camera controls, and
that some controls need another one to be set or cleared
beforehand (e.g. white_balance_auto must be set to off
before white_balance can be set, etc).

See [1] for Spec
[1]  https://www.linuxtv.org/downloads/legacy/video4linux/API/V4L2_API/spec-single/v4l2.html#control

BUG=662616

Review-Url: https://codereview.chromium.org/2479413002
Cr-Commit-Position: refs/heads/master@{#437695}

* Fix/add header guards in header files in //net except for in //net/third_party
  and in header files that are meant to be included only with some special macro
  defined (these are typically *_list.h):
  + #ifndef FILE_NAME in line 5,
  + #define FILE_NAME in line 6,
  + #endif  // FILE_NAME in the last line.
* Add newline to the end of files that do not already end in a newline.
* Remove empty line from the end of files that end in an empty line
  (that is, remove newline characters down to exactly one newline).
* Add empty line between Copyright notice and header guard in
  net/proxy/dhcpcsvc_init_win.h

Review-Url: https://codereview.chromium.org/2562113002
Cr-Commit-Position: refs/heads/master@{#437694}

BUG=

Review-Url: https://codereview.chromium.org/2558993004
Cr-Commit-Position: refs/heads/master@{#437693}

BUG=640506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2566493005
Cr-Commit-Position: refs/heads/master@{#437692}

https://skia.googlesource.com/skia.git/+log/e29ce641d378..0e8fc8b9e6a1

$ git log e29ce641d..0e8fc8b9e --date=short --no-merges --format='%ad %ae %s'
2016-12-09 bsalomon Relandx2 "Remove antialiasing control from GrPaint."
2016-12-09 mtklein remove Building with Skia Tutorial
2016-12-09 brianosman Plumb dst color space in many places, rather than "mode"
2016-12-09 bsalomon Revert "Reland "Remove antialiasing control from GrPaint.""
2016-12-09 bsalomon Reland "Remove antialiasing control from GrPaint."
2016-12-05 brianosman Remove SkImage::makeTextureImage
2016-12-09 robertphillips Different approach to fixing gpu blurs on platforms that "useDrawInsteadOfClear"

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2569463002
Cr-Commit-Position: refs/heads/master@{#437691}

Previously the fake server used to update all of the progress markers
to the highest single version of an entity being returned in a
GetUpdates response. This caused odd behaviors when clients asked for
different sets of model types. This in turn resulted in tests failing
when they never agreed on some progress marker's version that wasn't
actually being actively updated.

This change separates all model types version/progress markers in the
fake server code. This should help clients that are being enabled
mid-test to get match progress markers when priority and non-priority
types are requested across separate GetUpdates messages.

Also removed some special case logic around filtering deleted items. It
is unclear what purpose that logic was serving.

BUG=672596

Review-Url: https://codereview.chromium.org/2564663003
Cr-Commit-Position: refs/heads/master@{#437690}

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567733002
Cr-Commit-Position: refs/heads/master@{#437689}

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983

Review-Url: https://codereview.chromium.org/2558223002
Cr-Commit-Position: refs/heads/master@{#437688}

enable_mac_keystone was a global flag in the build directory that's only used
by 4 total checks in 2 BUILD files. I'm trying to clean up the global build
flags.

Changes the checks to just check for mac Chrome branded builds. The previous
code additionally checked for "official" builds, but "official" is actually an
optimization level that I don't think is relevant to whether there are
installer scripts included in the bundle.

BUG=671706

Review-Url: https://codereview.chromium.org/2558973003
Cr-Commit-Position: refs/heads/master@{#437687}

The TRACE_EVENT_CATEGORY_GROUP_ENABLED sets enabled to true even when
filtering mode was turned on. This should be set only for recording and
etw modes.

BUG=669611, 670013

Review-Url: https://codereview.chromium.org/2547193002
Cr-Commit-Position: refs/heads/master@{#437686}

Change message to show that clicking on a trash can actually
deletes items instead of just removes them, even though the
operation is "remove" by the DownloadHistory backend.

BUG=666292

Review-Url: https://codereview.chromium.org/2564053003
Cr-Commit-Position: refs/heads/master@{#437685}

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2563883005
Cr-Commit-Position: refs/heads/master@{#437684}

Secondary: This change causes constraint space to not be const

Also, minor bug fixes by Ian to make tests pass.

BUG=635619

Review-Url: https://codereview.chromium.org/2562703003
Cr-Commit-Position: refs/heads/master@{#437683}

This CL adds Rappor metrics to collect data for the cross-origin
autoplay experiment. It records the ETLD+1 of top-level frame and
iframes when a video is allowed to/blocked to autoplay and also
when the user has manually started a blocked video.

BUG=672526

Review-Url: https://codereview.chromium.org/2524443002
Cr-Commit-Position: refs/heads/master@{#437682}

BUG=none

Review-Url: https://codereview.chromium.org/2563553002
Cr-Commit-Position: refs/heads/master@{#437681}

As the first step in making BookmarkIndex usable on non-bookmark items, add
a TitledUrlNode interface to represent objects like bookmarks that expose a
title and URL. BookmarkIndex now expects its items to be TitledUrlNodes and
BookmarkNode implements the TitledUrlNode interface.

BUG=630769

Review-Url: https://codereview.chromium.org/2537223008
Cr-Commit-Position: refs/heads/master@{#437680}

Add native_lib_version_rule = "//build/util:chrome_version_json" to
chrome_public_apk to fix the build failure caused by "No such file or
directory: 'gen/CHROME_VERSION.json'" when building
monochrome_public_apk in a fresh output directory.

Review-Url: https://codereview.chromium.org/2565853002
Cr-Commit-Position: refs/heads/master@{#437679}

I'm adding histogram for different events during ClearServerData flow. They'll
help monitor how often enabpling passphrase encryption encounters issues.

R=zea@chromium.org,jwd@chromium.org
BUG=490836

Review-Url: https://codereview.chromium.org/2557733004
Cr-Commit-Position: refs/heads/master@{#437678}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/df2363501bd7..707aaac64b3c

$ git log df2363501..707aaac64 --date=short --no-merges --format='%ad %ae %s'
2016-12-09 eakuefner [Telemetry] Add temporary logging to desktop_browser_finder

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2566723002
Cr-Commit-Position: refs/heads/master@{#437677}

This bot config is having stability problems - disable all tests until
the issue is resolved.

BUG=672502
NOTRY=true
NOPRESUBMIT=true
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2562133002
Cr-Commit-Position: refs/heads/master@{#437676}

BUG=666796

Review-Url: https://codereview.chromium.org/2565843002
Cr-Commit-Position: refs/heads/master@{#437675}

When copying around TraceWrapperMember, e.g., when it is dded to a backing
store, we want the write barrier because the initial trigger could've observed a
different state.

(This is how it was supposed to be when initially designed.)

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2567463003
Cr-Commit-Position: refs/heads/master@{#437674}

Per dpranke, it seems Gerrit strips out <a id=foo> anchors.

BUG=

Review-Url: https://codereview.chromium.org/2567583002
Cr-Commit-Position: refs/heads/master@{#437673}

BUG=646176

Review-Url: https://codereview.chromium.org/2562033003
Cr-Commit-Position: refs/heads/master@{#437672}

As part of this, also moved computation of PaintLayer::ancestorScrollingLayer,
because that is required for sticky position constraint updates.

BUG=646188
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2561693002
Cr-Commit-Position: refs/heads/master@{#437671}

Prior to completing the FRE on Android, we should disallow
UI options that allow creating new tabs in Chrome.

This disables "Web Search" from the action mode menu and
also the various "Open in X" menu options.

BUG=671149

Review-Url: https://codereview.chromium.org/2559573002
Cr-Commit-Position: refs/heads/master@{#437670}

The code will now open files in the browser process before passing the
handles across IPC to the utility process. The utility process in turn
invokes courgette/bsdiff, which memory maps the files and operates on
them as before.

There is a behavioral difference when using the courgette or
courgette_mini tools: the output file will now be created/overwritten
at the start of the operation, and in the case of a failure, will be
deleted. Previously, the output file was created late in the operation
operation and several failure modes would leave it unmodified.

BUG=660325

Review-Url: https://codereview.chromium.org/2534873005
Cr-Commit-Position: refs/heads/master@{#437669}

Display error message when user try to open a locked supervised user profile when force-sign-in is enabled.

BUG=642059

Review-Url: https://codereview.chromium.org/2552473002
Cr-Commit-Position: refs/heads/master@{#437668}

The MS VP9 MFT swallows driver exceptions and later hangs because it gets
into a weird state. Instead the vectored exception handler can upload a
crash dump so we can get more actionable feedback.

BUG=636158
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2559633002
Cr-Commit-Position: refs/heads/master@{#437667}

Add a ColorBehavior argument to
- blink::Image::imageForCurrentFrame
- blink::Image::draw
- blink::Image::applyShader

Plumb these arguments through to all sub-classes. For sub-classes where
there is a trivial implementation, add it (e.g, blink::BitmapImage).
For all other sub-classes and callsites that need behavior changes, add
TODOs referencing the appropriate bugs.

This patch should have no behavior change -- it just formally
propagates arguments that were previously implied or pulled out of
global variables.

BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2559013002
Cr-Commit-Position: refs/heads/master@{#437666}

This cl is to enable HW H264 encoding on Android by default, with a flag.
This feature is firstly introduced in crbug/615108 (cl
https://codereview.chromium.org/2358683002), disabled by default with
a combined flag for both VP8 and H264. Now we separate the flag into
two and still keep VP8 HW encoder disabled by default.

BUG=664652

Review-Url: https://codereview.chromium.org/2549283002
Cr-Commit-Position: refs/heads/master@{#437665}

The new audit.js and audio-testing.js have a duplicate library of Audit task
runner. Separate legacy utilities out of audio-testing.js and create a new
audit-util.js so we can use those utilities in both settings.

To add the inclusion of 'audit-util.js' before all the instances of
'audio-testing.js', I ran this bash script:

```bash
for f in `find . -name '*.html'`
do
  echo $f
  perl -p -i -e 's@(\s*)<script(.*)src="(.*)audio-testing.js"></script>@
$1<script src="$3audit-util.js"></script>\n
$1<script src="$3audio-testing.js"></script>@g' $f
done
```

After adding the new JS file, some expected files needed care on console
warning messages. To update the expected text files:

FILES="audioparam-automation-clamping
audioparam-nominal-range
audioparam-setValueCurve-duration
audioparam-setValueCurve-exceptions
biquadfilternode-basic
oscillator-basic
pannernode-basic"

```bash
for f in $FILES
do
  echo "~/chromium/src/out/Default/layout-test-results/webaudio/
$f-actual.txt ~/chromium/src/third_party/WebKit/LayoutTests/webaudio/
$f-expected.txt"
  cp ~/chromium/src/out/Default/layout-test-results/webaudio/
$f-actual.txt ~/chromium/src/third_party/WebKit/LayoutTests/webaudio
$f-expected.txt
done
```

Note that I had to change `onstatechange.html` file manually, because it was
using the style of `<script ... />`. Except for this file, all the changes
is done by two scripts above.

BUG=672926

Review-Url: https://codereview.chromium.org/2567713002
Cr-Commit-Position: refs/heads/master@{#437664}

BUG=660942
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2561653002
Cr-Commit-Position: refs/heads/master@{#437663}

This CL ensures the origin header is properly set when using
browser-side navigation.

BUG=648588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2496293003
Cr-Commit-Position: refs/heads/master@{#437662}

It's not relevant at all.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2566493004
Cr-Commit-Position: refs/heads/master@{#437661}

The allows using RenderFrameHost::GetLastCommittedOrigin() correctly
when the RenderFrameHost is different from a frame's current RFH, such
as when it's pending or pending deletion.

BUG=590035, 663740
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2546533007
Cr-Commit-Position: refs/heads/master@{#437660}

This will put the onus on individual observers to extract the security
information they require, after a change has occurred.  The intent is to
allow chrome/browser-residing observers to monitor security level
changes, independent of style.

BUG=641508

Review-Url: https://codereview.chromium.org/2562503002
Cr-Commit-Position: refs/heads/master@{#437659}

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2563863002
Cr-Commit-Position: refs/heads/master@{#437658}

Currently the TracedValues were being created even when the tracing category was
disabled. This CL moves the creation of the TracedValues into a function, which
is called only when the TRACE macro arguments are evaluated, which, in turn,
only happens when the tracing category is enabled.

Measuring on a linux workstation using the linux perf tools, the instrumentation
overhead with the tracing category disabled is now below 2% of the cost of the
ResourceFetcher::requestResource function, as opposed to the 12% measured
before.

Review-Url: https://codereview.chromium.org/2537143005
Cr-Commit-Position: refs/heads/master@{#437657}