GitLab

I regressed this in r149891.

BUG=140689

Review URL: https://chromiumcodereview.appspot.com/10853018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150092 0039d316-1c4b-4281-b951-d872f2087c98

Not used anywhere yet.

BUG=138550

Review URL: https://chromiumcodereview.appspot.com/10836105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140248
TEST=Install pkidpnnapnfgjhfhkpmjpbckkbaodldb from the web store, wait for it to finish downloading voice data, then turn speech feedback on/off with Ctrl+Alt+Z and you should hear the high-quality voice.
TBR=derat
Review URL: https://chromiumcodereview.appspot.com/10850018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150089 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150088 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150087 0039d316-1c4b-4281-b951-d872f2087c98

Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*

Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.

Review URL: https://chromiumcodereview.appspot.com/10704026

BUG=140687
TBR=benjhayden@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150086 0039d316-1c4b-4281-b951-d872f2087c98

Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabWindowSnapshot respectively.
Use GrabWindowSnapshot (the old internal version) in tests.


BUG=139694


Review URL: https://chromiumcodereview.appspot.com/10830158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10824164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150084 0039d316-1c4b-4281-b951-d872f2087c98

It fails flakily.

BUG=chromium:140765
TBR=satish@chromium.org, hans@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150083 0039d316-1c4b-4281-b951-d872f2087c98

Make the LICENSE file more explicit about the fact that the headers used by Chromium use a BSD license.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10843032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150082 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150081 0039d316-1c4b-4281-b951-d872f2087c98

- gold - r149858 - Fix license metadata for gold
- acid3 - r150075 - Fix license metadata for acid3

BUG=138921
TBR=cmp,thestig

Review URL: https://chromiumcodereview.appspot.com/10855005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150080 0039d316-1c4b-4281-b951-d872f2087c98

Creating OWNERS file for extensions team so that this does not need to be covered by chrome/OWNERS.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150079 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nirnimesh@chromium.org
BUG=140760

Review URL: https://chromiumcodereview.appspot.com/10825197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139611
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/10843041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150074 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150073 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=92933
Not used anywhere yet, so no observable effect.

BUG=138550


Review URL: https://chromiumcodereview.appspot.com/10853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150071 0039d316-1c4b-4281-b951-d872f2087c98

This depends on: http://codereview.chromium.org/10662003/

Based on the HTML to Platform Accessibility APIs Implementation Guide
(http://www.w3.org/TR/html-aapi/), add some new tests to assert the
correct behavior for computing the text alternative for a
checkbox, button, and text field, then fix the implementation to
match the test.

BUG=124314
TBR=dtseng

Review URL: https://chromiumcodereview.appspot.com/10823073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150069 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150068 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org
BUG=104998
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10836108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150065 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150064 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150063 0039d316-1c4b-4281-b951-d872f2087c98

Support for draggable regions hasn't landed yet, so we hard-code 20px of
draggable space at the top of the window.

BUG=130182
R=rsesek@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10824004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135197

Review URL: https://chromiumcodereview.appspot.com/10834168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150061 0039d316-1c4b-4281-b951-d872f2087c98

They aren't compiled more, so it's safe to remove them. There references were
updated in previous patches.

BUG=125846
TBR=ben@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10831173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150060 0039d316-1c4b-4281-b951-d872f2087c98

Found with:

$ cppcheck --enable=all -j4 --force base 2> base-errors

R=jar@chromium.org
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10827112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150059 0039d316-1c4b-4281-b951-d872f2087c98

Switched to returning std::string instead of base::StringPiece in GetScaleFactorsAsString() as base::StringPiece does not take ownership of data passed to it in the constructor.

TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10854003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150057 0039d316-1c4b-4281-b951-d872f2087c98

This change looks weird - sorry about that. On Mac, setNeedsDisplay-driven drawRect calls appear to be implemented with a software timer that is slightly slower than vsync. So in order to render aligned with Vsync we have to either use CVDisplayLink or call CGLFlushDrawable immediately when new frames arrive at the browser RWHVMac. CVDisplayLink adds a frame of latency, so we don't want to use that for rendering. So, we call CGLFlushDrawable immediately.

Calling CGLFlushDrawable is fine except when the window becomes non-visible, during which undocumented behavior kicks in: CGLFlushDrawable returns immediately, no longer throttled to vsync. So, we have the unfortunate task of manually throttling CGLFlushDrawable so that chrome doesn't spin while the window is hidden.

The implementation of manual throttling is to use CVDisplayLink to compute vsync frame counts, and compare that to the flush (swap) counts. If the swap count gets more than frames ahead of vsync, we sleep for 1 frame interval to simulate blocking on vsync.

NOTE: this code path is only for the non-threaded accelerated compositing path. It will not be triggered for the threaded compositing path because we won't render frames at faster than vsync unless there's a bug in the compositor thread scheduling logic.

BUG=139416

Review URL: https://chromiumcodereview.appspot.com/10828104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150055 0039d316-1c4b-4281-b951-d872f2087c98

However, Chrome generates images which are a combination of the toolbar icon from the default theme + a tint.
Added the ability for themes to store hidpi assets in the data pack such that the few hidpi assets which are generated are preserved when a user closes Chrome and reopens it.

Repro steps/steps for testing:
1) Run chrome with --force-device-scale-factor=2
2) Change the theme.
3) Close Chrome and relaunch with --force-device-scale-factor=2
4) Ensure that the toolbar buttons are still hidpi

Test=Manual, see instructions above
Bug=136888



Review URL: https://chromiumcodereview.appspot.com/10783015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150053 0039d316-1c4b-4281-b951-d872f2087c98

This was left over from the transition to the IRT library: it is to
make the audio thread work when libppruntime is linked into the user
nexe (which is no longer supported) rather than into the IRT.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=1691
TEST=run_ppapi_ppb_audio_browser_test (only run on Mac, not Windows or Linux)

Review URL: https://chromiumcodereview.appspot.com/10824171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150052 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150051 0039d316-1c4b-4281-b951-d872f2087c98

This cl introduces a regression test for bug 138745, in which the
ftp_protocol_handler did not correctly return errors on requests with invalid
ports.

This bug was fixed in
http://codereview.chromium.org/10834053/

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Review URL: https://chromiumcodereview.appspot.com/10844004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150050 0039d316-1c4b-4281-b951-d872f2087c98

While registering the attached device path as file system, set the media
device name as file system name.

BUG=none
TEST=none
TBR=gbillock@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150046 0039d316-1c4b-4281-b951-d872f2087c98

Change 143421 - Revert 142809 to re-enable Chrome to Mobile by default on trunk (after M21 branch).

Change 142809 - Revert 135840 to disable Chrome to Mobile by default on trunk (for M21 branch).

Change 135840 - Revert 135442 to re-enable Chrome to Mobile by default on trunk.
We passed the M20 branch point with Chrome to Mobile disabled, as intended.

Change 135442 - Disable Chrome To Mobile by default; enable via chrome://flags.
This feature should be disabled-by-default on M19; for immediate merge.

Don't revert http://crrev.com/130312 to keep the AboutFlags_disable-chrome-to-mobile UMA bin.
Note: Mac's ViewIDTests don't yet support VIEW_ID_CHROME_TO_MOBILE_BUTTON.

BUG=102709, 120905
TEST=Chrome To Mobile is disabled on trunk (for the M22 branch point).
TBR=msw@chromium.org,sky@chromium.org,nyquist@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://wkb.urg/93186
TBR=tony

Review URL: https://chromiumcodereview.appspot.com/10852021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150037 0039d316-1c4b-4281-b951-d872f2087c98