- 04 Sep, 2018 40 commits
-
-
Robert Sesek authored
The change in be983c8b was incomplete because calls into SetUpBundleOverrides() would re-override the CHILD_PROCESS_EXE path. This moves the SetUpBundleOverrides() into ChromeMain rather than in various delegate methods, so that it is not called in tests. This requires allowing the crashpad_handler to be started from the Framework that is not bundled in a .app, so the rpath is adjusted in the component build. Finally this enables network service browser_tests, which were previously disabled on Mac, to verify the fix. Bug: 877992 Test: browser_tests --gtest_filter=*NetworkContextConfigurationBrowserTest* Change-Id: If88a8dd13b9b7b0500d08a180658597ae6f5997d Reviewed-on: https://chromium-review.googlesource.com/1198306 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#588516}
-
Koji Ishii authored
Following bot results are included. 9355 9363 9370 9375 9381 9385 9386 9387 9388 9389 9391 9392 9393 9394 9395 9396 9399 9401 9403 9404 9405 9407 9409 9411 9412 9413 7 lines were removed and 7 lines were deflaked by consecutive results since 9395. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ieadc8d401c48f18791b8634d28f1476ee9ea8376 Reviewed-on: https://chromium-review.googlesource.com/1198653 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#588515}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e29cf318258..913ff54db050 git log 3e29cf318258..913ff54db050 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 xinghua.cao@intel.com ES31: support compute shader uniform buffer on D3D backend Created with: gclient setdep -r src/third_party/angle@913ff54db050 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Iad9b3048bc019144f0fcd3c746ee338326423081 Reviewed-on: https://chromium-review.googlesource.com/1204057Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588514}
-
Annie Sullivan authored
This CL records the event timestamps for mouse click and enter keypress in the desktop omnibox, and passes them through to CommonNavigationParams, which are used to generate InputTo* page load metrics. Doc covering this work in more detail: https://docs.google.com/document/d/1sAaPCsvxF19l1fgGcxW-SouxVwwcQ4rsz4md4jjq2Gs/edit Bug: 750639 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I92a48fa69413f8163756b3b7289335b898b9849e Reviewed-on: https://chromium-review.googlesource.com/1178624 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#588513}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9c4a18f0f63..a79a538f1026 git log e9c4a18f0f63..a79a538f1026 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 primiano@google.com Fix stale reference to trace_processor_wasm Created with: gclient setdep -r src/third_party/perfetto@a79a538f1026 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie26ee768a28f7b70e42c0975e17173dd36ce3156 Reviewed-on: https://chromium-review.googlesource.com/1204054Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588512}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cff3fd834ca8..a45e1a71f548 git log cff3fd834ca8..a45e1a71f548 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 ethannicholas@google.com fixed ASAN error while compiling .fp files Created with: gclient setdep -r src/third_party/skia@a45e1a71f548 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I4a95de7cf1f4f3323b0f8861200212b7fc8214f6 Reviewed-on: https://chromium-review.googlesource.com/1204055Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588511}
-
Christos Froussios authored
Once all the passwords have been copied to the encrypted database, the native backend will be cleared. This cleanup is performed in the background and does not block the password manager. From the next run onward, the serving password store will always be the now encrypted login database. Resetting the migration feature will have no effect. Bug: 571003 Change-Id: I1f98c35f0dcc666224f1b8e925fb50ce8880d9c5 Reviewed-on: https://chromium-review.googlesource.com/1179157Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#588510}
-
Samuel Huang authored
This reverts commit fb97b393. Reason for revert: https://crbug.com/880245 This seems to cause VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow to fail on linux-chromeos-dbg (and similar Keyboard tests): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7640 Original change's description: > Add imeservice into the feature list. > > Expose kImeServiceConnectable to IME private clients, which is used > for checking whether it should load IME Mojo Service bundles. > > Bug: 837156 > Change-Id: Id2889577616823cef99e3a3cfea16b5e33a9147c > Reviewed-on: https://chromium-review.googlesource.com/1203515 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Leo Zhang <googleo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588453} TBR=wuyingbing@chromium.org,shend@chromium.org,googleo@chromium.org Change-Id: I686a7a2eee36cfffacee956bbc063d3c835dab54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837156 Reviewed-on: https://chromium-review.googlesource.com/1203880Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588509}
-
Byoungkown authored
Enable jumbo build in components/rappor/. Use jumbo build after adding "use_jumbo_build=true" args in GN. Bug: None Change-Id: I369479aa5f1215e5e0f2fc23e1546209c41e4aad Reviewed-on: https://chromium-review.googlesource.com/1203670Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#588508}
-
Greg Thompson authored
It served its purpose and is now safe to remove. BUG=827173 R=pastarmovj@chromium.org,isherman@chromium.org Change-Id: I297865c08486ace46c5a42df698cf169ab5d7f9a Reviewed-on: https://chromium-review.googlesource.com/1203372Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588507}
-
Alexandr Ilin authored
This CL adds a new MappingProtectionSetCorrectly test to the PlatformSharedMemoryRegion. This test examines that page protection bits are set correctly on a mapped region and that the process doesn't have rights to change the protection level. Bug: 795291 Change-Id: I029de3b31c74f7c14d92d5da7fb4a2a35ec7659a Reviewed-on: https://chromium-review.googlesource.com/1199811Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588506}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9680338c..b65cd7cc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40142aa510af4b4659f6e836265fd4b3cc13cc88 Reviewed-on: https://chromium-review.googlesource.com/1203872Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588505}
-
Fredrik Söderquist authored
Shrinks page.h by ~1.1M. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie71224313e0a1c26319854707b14e62e65dc46a3 Reviewed-on: https://chromium-review.googlesource.com/1203911Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#588504}
-
Rayan Kanso authored
Bug: 766077 Change-Id: Ie5cf7a94036dfa74787465ef210510b2b5993ed9 Reviewed-on: https://chromium-review.googlesource.com/1202209Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#588503}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e5af96606b9..4092cd6db459 git log 4e5af96606b9..4092cd6db459 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 jonasolsson@webrtc.org Consolidate loggability checks and replace streams. 2018-09-04 mbonadei@webrtc.org Add nogncheck for headers of codecs not used in Chromium. 2018-09-04 ilnik@webrtc.org Reland "Remove obsolete field trial from the tests" 2018-09-04 ilnik@webrtc.org Revert "Remove obsolete field trial from the tests" 2018-09-04 sakal@webrtc.org Enable ULPFEC for kVideoCodecGeneric if GenericPictureId is enabled. 2018-09-04 magjed@webrtc.org Reland "Fix a bug in barcode_decoder.py" 2018-09-04 nisse@webrtc.org Delete class EventTimerWrapper. 2018-09-03 brandtr@webrtc.org Remove MediaOptimization::Reset. Created with: gclient setdep -r src/third_party/webrtc@4092cd6db459 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:824831 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idabeba5988358f506170e35d914296813b5ba935 Reviewed-on: https://chromium-review.googlesource.com/1204052Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588502}
-
Henrik Grunell authored
Bug: 880109 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4577cfc1a62232d7eb8574d874f648e5e07d5b9e Reviewed-on: https://chromium-review.googlesource.com/1203370Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#588501}
-
Eric Karl authored
Before, one call to SetDeferCommits(false) would clobber any number of SetDeferCommits(true) calls that happened before. This change refactors SetDeferCommits(bool) into DeferCommits() that returns a ScopedDeferCommits object. We stop deferring commits when the ScopedDeferCommits object is destroyed. This required a minor refactor to WebViewImpl, ChromeClientImpl and SimCompositor. Previously these classes would defer / un-defer commits independently, relying on global state. Now ChromeClientImpl and SimCompositor interact with WebViewImpl who maintains the state of commit deferral. Bug: 835353, 879656 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50fd8f54ff908b703643f670cabea986426cc935 Reviewed-on: https://chromium-review.googlesource.com/1195704 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588500}
-
Leonid Kaplan authored
SerialWorker instances could leak when the original task runner is shutting down and no longer accepting tasks. This is because of the implementation of ~PostTaskAndReplyRelay, which attempts to destroy its own instance by DeleteSoon, which is also not accepted by the task runner. This behavior produces warnings in ASAN builds, for example when an instance of DnsConfigServicePosix::HostsReader is destroyed in services_unittests.NetworkContextTest. BUG=879152 Change-Id: I48df8e3171975ff6f11fe0676e456f8e8b756ec9 Reviewed-on: https://chromium-review.googlesource.com/1193344Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588499}
-
Christos Froussios authored
Previously, the bubble would merge the pending credentials into the password list too. However, the pending credentials are not guaranteed to have a valid primary key, which results in duplicates and ineffective rows, particularily when a password is generated. Bug: 878729 Change-Id: I68da172ce02a21a5127132d291c68ddfbf017999 Reviewed-on: https://chromium-review.googlesource.com/1202283Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88dc49aaadb0..069d8c1aa313 git log 88dc49aaadb0..069d8c1aa313 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 anthonyalridge@google.com Moves the labels on the dot plot to the y axis. Created with: gclient setdep -r src/third_party/catapult@069d8c1aa313 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I15cbab4816083dd65a374f1d9d1644817edb37dc Reviewed-on: https://chromium-review.googlesource.com/1204053Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588497}
-
Orsi Batiz authored
Created a primitive version of function AllowTrustedTypePolicy "require-trusted-types" changed into "trusted-types" and takes a list of policy names createPolicy updated to throw when policy name is not allowed Tests added for policy creation attempt when policy name is on the whitelist and when it isn't Tests added fot policy creation attempt with no whitelist given Poked at existing tests to change "require-trusted-types" into "trusted-types" Removed boolean require_safe_types_ from csp_directive_list Bug: 739170 Change-Id: Ida0188cf38f8edba8b966b2f708b7a7919d08b29 Reviewed-on: https://chromium-review.googlesource.com/1186325Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Cr-Commit-Position: refs/heads/master@{#588496}
-
Hiroki Nakagawa authored
This CL adds SharedWorkerScriptFetcher that initiates a top-level worker script loading for shared workers from the browser process. Once the fetcher receives a response head, that unbounds the URL loader and its client, and passes them to the renderer process with the StartWorker message. In the renderer process, WorkerClassicScriptLoader in Blink makes a resource request as usual, and ResourceDispatcher in Content serves it using the passed URLLoader etc. In addition, this CL makes Shared Workers run with AppCache on NetworkService, AppCache's fallback case is not implemented yet though. Subsequent CLs will implement the case. See the design doc for more details: https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing Bug: 715632 Change-Id: I7aafd2224dec42a89a274a9b1820ae9775535aca Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1154743 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#588495}
-
Vadym Doroshenko authored
This CL contains implementation of Save() function, that processes saving/updating when the user clicks Save/Update button. This implementation is copy and adaptation of PasswordFormManager::Save function. Bug: 831123 Change-Id: I2eea0ffe09d3877d7ab1672044bee0d7c2fcb327 Reviewed-on: https://chromium-review.googlesource.com/1169061 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588494}
-
Kush Sinha authored
- Revert auth.mojom. - Change arc_auth_service.h and arc_auth_service.cc to make code compile. - Remove tests for above deleted changes from arc_auth_service_browsertest.cc. Bug: 880038, 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I692bb172322350beb1846ad8fe563ba5a296077f Reviewed-on: https://chromium-review.googlesource.com/1199187 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588493}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b97eba7fb2c0..d38c84de1ba5 git log b97eba7fb2c0..d38c84de1ba5 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 dgarrett@google.com workspaces: Refactor branch config, and Repo creation. Created with: gclient setdep -r src/third_party/chromite@d38c84de1ba5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4a7a44f3d8e63143eec3fcf95fb420b322aa4b5c Reviewed-on: https://chromium-review.googlesource.com/1204051Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588492}
-
Hugo Holgersson authored
This fixes a flakiness that has been haunting this test for a while. It used to flake ~ 4/100 times: $ python third_party/WebKit/Tools/Scripts/run-webkit-tests --repeat-each=100 -t Release LayoutTests/fast/spatial-navigation/snav-stay-in-overflow-div.html Now, even 1000 runs pass. snav-testharness.js does not use requestAnimationFrame(). The old helper, spatial-navigation-utils.js, did. Different rAF-timings probably caused the flakiness. Bug: 803086, 871416 Change-Id: Idbf0bfb544236ba1a77986c7d62200b2e17d6884 Reviewed-on: https://chromium-review.googlesource.com/1185188 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#588491}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c3f40a42ff8..e9c4a18f0f63 git log 8c3f40a42ff8..e9c4a18f0f63 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 fmayer@google.com Add map for items that contain their key. Created with: gclient setdep -r src/third_party/perfetto@e9c4a18f0f63 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I567e44bfd32756e5c5f551c627a0ede5e2ff4ba2 Reviewed-on: https://chromium-review.googlesource.com/1204050Reviewed-by:
-
Mathias Bynens authored
This is an ECMAScript feature, implemented in V8. Proposal repository: https://github.com/tc39/proposal-global Intent to ship: https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ Bug: v8:5537 Change-Id: I7d3d7c1aa4a5b3dba33eb37f49ad1da2fb5c6d63 Reviewed-on: https://chromium-review.googlesource.com/1203971 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ie84ad57f247bf91366f03c30e63ae4ae115848d9 Reviewed-on: https://chromium-review.googlesource.com/1203890Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#588488}
-
Yoichi Osato authored
We use |GetSelectionState() ==/!= SelectionState::kNone| expression at many call sites to check a LayoutObject is selected. However SelectionState has 6 values and they represents more info than a LayoutObject is just selected. To clarify the meaning, this patch introduces LayoutObject.IsSelected() instead of GetSelectionState(). For ReplacedPainter, we paint selection highlight except LayoutSVGRoot. We checked this as |GetSelectionState() != kContain| in selection_state.h replaced_painter.cc::IsSelected but it was also unreadable. This patch changes the code using |CanBeSelectionLeaf()| which returns false for LayoutSVGRoot but behavior doesn't change. This is also a preparation for move SelectionState member to Node. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib0b65627bb0f5d5976013c3c5ff77a87f1e9e561 Reviewed-on: https://chromium-review.googlesource.com/1195257Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#588487}
-
Maja Kabus authored
Static GetString() functions removed from TrustedHTML, TrustedScript and TrustedURL. Their implementations has been moved into global GetStringFromTrusted{HTML | Script | ScriptURL | URL} functions in the util file. Calls to GetString() adjusted in the files that use it. Bug: 739170 Change-Id: I1f73b2d63164fc8df4ad9c16dd6806a109a2db0b Reviewed-on: https://chromium-review.googlesource.com/1203831Reviewed-by: -
Chromium WPT Sync authored
Using wpt-import in Chromium 5ce3f48c. With Chromium commits locally applied on WPT: 5428f3ff "[WebSocket] Fix cookies/006.html?wss wpt" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24052 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ieb0efa5709857df7e47322dadba3fdc59b503f63 Reviewed-on: https://chromium-review.googlesource.com/1203871 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588485}
-
Fredrik Söderquist authored
Shrink page.h from ~9.16M to ~7.01M. Change-Id: If7516a607c481637ec12872edd33641df8e5ad95 Reviewed-on: https://chromium-review.googlesource.com/1203835Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Noel Gordon authored
Bug: 880127 Change-Id: Ia501894e384937da8e1aa2c9520372b6067f9d34 Reviewed-on: https://chromium-review.googlesource.com/1203755Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588483}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f98c9d6e3f80..8c3f40a42ff8 git log f98c9d6e3f80..8c3f40a42ff8 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 primiano@google.com Standalone build: add support for Link Time Optimization Created with: gclient setdep -r src/third_party/perfetto@8c3f40a42ff8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie2a377e7f64ebc02790032e2733d23261182a3e2 Reviewed-on: https://chromium-review.googlesource.com/1203451Reviewed-by:
-
Rune Lillesveen authored
Comments and processing intstructions are never marked dirty. LazyReattachIfAttached() should not mark ancestry child-dirty when detaching such nodes. Bug: 868810 Change-Id: I22dfcb3fe7e6a691b7b5cd56156cd61ca1765097 Reviewed-on: https://chromium-review.googlesource.com/1203832Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#588481}
-
Rob Buis authored
Some typo and suggested corrections. Bug: 803774 Change-Id: Ia695bb55f52b9c5777c6ace22db5fcf093c948f7 Reviewed-on: https://chromium-review.googlesource.com/1203371Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#588480}
-
Matt Falkenhagen authored
This makes the test more extensible. Preparation for adding tests for the Clients API and resultingClientId. Specifically, the requestInfos from the workers and the expectations will have a resultingClientId in addition to the URL. Bug: 876223, 778497 Change-Id: Id7c25a77f43f33d40b64ea77c2cf51a0745f57c6 Reviewed-on: https://chromium-review.googlesource.com/1203711 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
These tests are all about 'mask-image' (the unprefixed property.) TBR=schenney@chromium.org Bug: 432153, 880183 Change-Id: I399ea4dd6a3dd48ee464a12279caa2a4fdd9f3a2 Reviewed-on: https://chromium-review.googlesource.com/1203891Reviewed-by:
-
Noel Gordon authored
windowId => appId, clarify some comments, rename odd variables, format a few helper routines. Bug: 880127 Change-Id: Ieff0384975930be4384d2dc932187b817cc1527d Reviewed-on: https://chromium-review.googlesource.com/1203516 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588477}
-
