GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275761 0039d316-1c4b-4281-b951-d872f2087c98

Since he is no longer on the project. Sniff. :'(

BUG=none
R=jln@chromium.org

Review URL: https://codereview.chromium.org/317243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275756 0039d316-1c4b-4281-b951-d872f2087c98

Scripts like that usually do not require a --option if this is a
mandatory singleton argument. Also, forgetting to pass the extension
sounds like something that the script could simply handle.

BUG=None

Review URL: https://codereview.chromium.org/286423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321868
R=msw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/300623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275754 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the coordination of initial metrics gathering tasks out of
MetricsService and into ChromeMetricsServiceClient. As part of this move, it
also does the following:
- Moves registration of metrics providers from MetricsService to
  ChromeMetricsServiceClient
- Moves registration of prefs for individual metrics providers from
  MetricsService to ChromeMetricsServiceClient
- Eliminates MetricsService being a TrackingSynchronizerObserver in favor of
  ChromeMetricsServiceClient being a TrackingSynchronizerObserver

BUG=374218,375776,376288
TBR=thakis

Review URL: https://codereview.chromium.org/293393010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275753 0039d316-1c4b-4281-b951-d872f2087c98

I'm switching to a new project.

Review URL: https://codereview.chromium.org/313963009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275752 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275746 0039d316-1c4b-4281-b951-d872f2087c98

The hint is now per page instead of per layer.

BUG=367202
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/316053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275744 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves GoogleURLTracker and associated friends to the Google component.
It additionally moves strings that GoogleURLTrackerInfoBarDelegate into
components_strings.grd (via google_strings.grdp).

Dependencies of this code on google_util are temporarily punched through the
embedder, as google_util will require more time to componentize. Once
google_util is componentized, the indirection through the embedder will be
removed.

BUG=373209,373222
TBR=thakis, cbentzel

Review URL: https://codereview.chromium.org/316203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275743 0039d316-1c4b-4281-b951-d872f2087c98

Added empty PrivetV3HTTPClient and implementation.
Reordered LocalDiscoveryUIHandler member to match dependency.

BUG=372843
TBR=noamsml

Review URL: https://codereview.chromium.org/318283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275742 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r260354, which accidentally got reverted in r260354.

BUG=381978

Review URL: https://codereview.chromium.org/325543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275741 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (https://codereview.chromium.org/321703002/)

Reason for revert:
Didn't fix.

Original issue's description:
> Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (https://codereview.chromium.org/324523002/)
> 
> Reason for revert:
> Breaks Linux ASAN http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2865
> 
> Original issue's description:
> > Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.
> > 
> > BUG=239879
> > NOTRY=true
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275716
> 
> TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=239879
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275739

TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239879

Review URL: https://codereview.chromium.org/318293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275740 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (https://codereview.chromium.org/324523002/)

Reason for revert:
Breaks Linux ASAN http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2865

Original issue's description:
> Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.
> 
> BUG=239879
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275716

TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239879

Review URL: https://codereview.chromium.org/321703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275739 0039d316-1c4b-4281-b951-d872f2087c98

Add ability to wait for an element specified by a JS function.

The ActionRunner API's WaitForElement will not support lookup
by xpath, unlike WaitAction(). Page sets that uses this
feature now have their own _CreateXpathFunction instead,
that uses element_function variant of WaitForElement.

BUG=361809

Review URL: https://codereview.chromium.org/321563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275738 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275737 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175719:175754&mode=html

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/318273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275736 0039d316-1c4b-4281-b951-d872f2087c98

Using seq is more complicated, but allows other applications
access to the MIDI hardware.

I still have some more verification to do and probably some bugs to fix but I think this is a good start.

Note that Chrome OS might need a new kernel module built.

BUG=344410

Review URL: https://codereview.chromium.org/264973012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275732 0039d316-1c4b-4281-b951-d872f2087c98

The effect layers were transformed to the wrong position, as the anchor
point has been replaced with transformed origin in
https://codereview.chromium.org/295193002.

BUG=382087

Review URL: https://codereview.chromium.org/319183011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275731 0039d316-1c4b-4281-b951-d872f2087c98

~ViewManagerSynchronizer destroys the view_manager_. Destroying the
view_manager_ may add transactions to pending_transactions_. So, we
have to make sure view_manager_ is destroyed first.

BUG=365012
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/320713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275730 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275729 0039d316-1c4b-4281-b951-d872f2087c98

The roll is breaking two ChromiumOS browser_tests:
VirtualKeyboardBrowserTest.HideKeyboardKeyTest
VirtualKeyboardBrowserTest.KeysetTransitionTest

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/320213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275728 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275722 0039d316-1c4b-4281-b951-d872f2087c98

Follow on r269281 - plumb the JS API from testRunner.SetColorProfile
through to the render_widget where the color profile is stored.

Updating the webview() about any color profile change is done in the
render_view_impl: implementation of that is a TODO(noel).

BUG=369787

Review URL: https://codereview.chromium.org/316913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275720 0039d316-1c4b-4281-b951-d872f2087c98

Prior to http://crrev.com/268831 we never considered the actual
coded size when constructing buffers for FFmpeg.  We do now, but
were not aligning the extents properly.

Sadly we had no test coverage for odd sized videos :(  I've fixed
the extents and added a test using one of the bug clips (which
will be landed separately).

BUG=379127
TEST=new pipeline test
NOTRY=true

Review URL: https://codereview.chromium.org/318133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275719 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the Chrome D-Bus bindings and modifies the device/bluetooth
GATT Chrome OS code to use the new bindings defined in crbug.com/378182 for
descriptor value reads and writes.

BUG=378182
TEST=device_unittests; manual tests using custom bluetoothd

Review URL: https://codereview.chromium.org/309623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275718 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372843
TBR=noamsml

Review URL: https://codereview.chromium.org/320683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275717 0039d316-1c4b-4281-b951-d872f2087c98

Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.

BUG=239879
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646

Review URL: https://codereview.chromium.org/324523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275716 0039d316-1c4b-4281-b951-d872f2087c98

There are two input type enums:
* one in the autocomplete code
* one in the metrics code that's used for UMA logging;
  this one is meant to remain stable

As part of fixing the linked bug, I created
https://codereview.chromium.org/314773002/
whch needed an input type enum, one which would remain stable.
It didn't necessarily have to be the metrics enum.

After discussion with the UMA folks (who deal with how to handle
stable enum problems all the time), we reached the conclusion
that we should have one stable enum and use it everywhere.  That's
the cleanest answer.

This single enum has to live in the metrics directory because metrics
is a component.

This change combines the two existing enums into one, putting the
new enum in a new file in the metrics directory.  The reason for
a new file is so we can include it without include the whole
OmniboxEventProto or any other metrics code.

The main files to review are autocomplete_input.h and *.proto.
All other changes are a mechanical result of the changes in
those three files.

The internal proto change has been submitted.

TBR=stevenjb
for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
that removes an unnecessary include

BUG=284781
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696

Review URL: https://codereview.chromium.org/319523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275713 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert.
Something breaks "Linux ASan LSan Tests", TaskManagerNewPrintPreview.

> Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.
> 
> BUG=239879
> 
> Review URL: https://codereview.chromium.org/324523002

TBR=alekseys@chromium.org

Review URL: https://codereview.chromium.org/319373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275711 0039d316-1c4b-4281-b951-d872f2087c98

You cannot have two.

BUG=None
TBR=dtu@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/322703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275710 0039d316-1c4b-4281-b951-d872f2087c98

Noticed this while reading code.

BUG=

Review URL: https://codereview.chromium.org/325593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381858
R=oshima@chromium.org
TEST=compile succeeds

Review URL: https://codereview.chromium.org/322553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284781
TBR=mpearson
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/321673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275707 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Omnibox: Combine Two Input Type Enums into One (https://codereview.chromium.org/319523005/)

Reason for revert:
Broke the build on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac

Original issue's description:
> Omnibox: Combine Two Input Type Enums into One
> 
> There are two input type enums:
> * one in the autocomplete code
> * one in the metrics code that's used for UMA logging;
>   this one is meant to remain stable
> 
> As part of fixing the linked bug, I created
> https://codereview.chromium.org/314773002/
> whch needed an input type enum, one which would remain stable.
> It didn't necessarily have to be the metrics enum.
> 
> After discussion with the UMA folks (who deal with how to handle
> stable enum problems all the time), we reached the conclusion
> that we should have one stable enum and use it everywhere.  That's
> the cleanest answer.
> 
> This single enum has to live in the metrics directory because metrics
> is a component.
> 
> This change combines the two existing enums into one, putting the
> new enum in a new file in the metrics directory.  The reason for
> a new file is so we can include it without include the whole
> OmniboxEventProto or any other metrics code.
> 
> The main files to review are autocomplete_input.h and *.proto.
> All other changes are a mechanical result of the changes in
> those three files.
> 
> The internal proto change has been submitted.
> 
> TBR=stevenjb
> for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
> that removes an unnecessary include
> 
> BUG=284781
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696

TBR=pkasting@chromium.org,isherman@chromium.org,mpearson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=284781

Review URL: https://codereview.chromium.org/320713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275705 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175750:175751&mode=html

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/325613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275704 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275703 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175719:175750&mode=html

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/322673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275702 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275701 0039d316-1c4b-4281-b951-d872f2087c98

All platforms use autofill profiles, which use libaddressinput.

TBR=estade@chromium.org
BUG=327046

Review URL: https://codereview.chromium.org/319373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275700 0039d316-1c4b-4281-b951-d872f2087c98