- 06 Dec, 2019 40 commits
-
-
Erik Chen authored
The builder both builds and run tests, so it potentially needs more time. Bug: 1029936 Change-Id: I1e11437a81c1725287432ef5f919c5415f1be544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954541Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#722596}
-
Martin Kreichgauer authored
Screenreaders currently announce the chrome://... resource reference when focusing these icons. The dialog embedding this component already has labels that provide the semantic context. Bug: 974046 Change-Id: If0850187ab2bce95b8bc8756f3ab7693df7a27d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938256 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#722595}
-
Natalie Chouinard authored
Move Notification settings and tests to subpackage, and rename according to go/clank-preferences-refactor naming conventions. Bug: 876376, 1030446 Change-Id: I050d854907d46a45e35e24ce3eadf14c8ecc9915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953607 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722594}
-
Josh Nohle authored
In this CL, we do not consider a host verified until it has a public key and beacon seeds, data required for communication between the mult-device host and client. This CL should only be relevant after v1 DeviceSync is deprecated, when a public key and beacon seeds are not available until v2 DeviceSync host device data has been decrypted. When only v1 DeviceSync is running or when v1 and v2 DeviceSync are running in parallel, we guarantee that the eligible host devices always have a decrypted public key and beacon seeds, as long as that data was properly sent by the CryptAuth backend. See http://go/cros-devicesync-v2-remote-device-id for more details. Bug: 951969, 1019206 Change-Id: I454c79ddfae3cbf5f3bde602384e13d62ea1ffd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935229 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#722593}
-
Maksim Sisov authored
WaylandWindow handles too many things and confuses developers that are not familiar with it. To make things better, extract surface methods into WaylandSurface. This change does not bring any functional changes except removed is_active() method that was only used by tests. Instead, tests just rely on the PlatformWindowDelegate::OnActivationChanged calls. Test: ozone_unittests Bug: 1028919 Change-Id: Ia58577f86d8e31ec93b113d887b34166fbe19cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954478 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722592}
-
Karan Bhatia authored
This reverts commit 852ad1d0. Reason for revert: Suspected to break compile on mac-archive-rel Original change's description: > [DevUI DFM] Move 17 chrome:// pages to DFM, via new dev_ui_browser_resources.pak. > > This CL moves 83.5 kB of "long tail" resources to the Developer WebUI > Dynamic Feature Module (DevUI DFM), for 17 chrome:// pages whose > resources were in browser_resources.pak. These pages and their > associated resource prefixes are: > > accessibility (IDR_ACCESSIBILITY_*) > components (IDR_COMPONENTS_*) > device-log (IDR_DEVICE_LOG_UI_*) > domain-reliability-internals (IDR_DOMAIN_RELIABILITY_INTERNALS_*) > download-internals (IDR_DOWNLOAD_INTERNALS_*) > interventions-internals (IDR_INTERVENTIONS_INTERNALS_*) > local-state (IDR_LOCAL_STATE_*) > media-engagement (IDR_MEDIA_ENGAGEMENT_*) > memory-internals (IDR_MEMORY_INTERNALS_*) > notifications-internals (IDR_NOTIFICATIONS_INTERNALS_*) > predictors (IDR_PREDICTORS_*) > sandbox (IDR_SANDBOX_INTERNALS_*) > site-engagement (IDR_SITE_ENGAGEMENT_*) > snippets-internals (IDR_SNIPPETS_INTERNALS_* | IDR_FEED_INTERNALS_*) > supervised-user-internals (IDR_SUPERVISED_USER_INTERNALS_*) > translate-internals (IDR_TRANSLATE_INTERNALS_*) > ukm (IDR_UKM_INTERNALS_*) > > Note that chrome://snippets-internals has 2 prefixes, corresponding to > {SnippetsInternalsUI, FeedInternalsUI}. > > Also, some DevUI pages in browser_resources.pak are not moved, because > they are new and can be handled later (need IsWebUiHostInDevUiDfm() > change), or are not used by Android. > > These resources are moved to new file dev_ui_browser_resources.pak, > which then feeds into dev_ui_resources.pak. 18 WebUI .cc files have > their resource include headers updated. > > Bug: 927131 > Change-Id: Ideaf57e2997b4621d7ffdfea8c126bf78688c322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954458 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722576} TBR=thakis@chromium.org,huangs@chromium.org,agrieve@chromium.org Change-Id: I93a24570c0be77d5fc1dad2342e83ea5d9bead25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956013Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#722591}
-
Kurt Horimoto authored
This config will be used to trigger the display of the banner UI for the save passwords infobar. This CL also introduces CreateAuxilliaryData to the OverlayUserData template so that OverlayUserData can be shared amongst OverlayRequest configs. The SavePasswordsOverlayRequestConfig adds an InfobarOverlayData to its OverlayRequest exposing the InfoBar pointer. This can also be used by other infobar OverlayRequest configs so that their InfoBars can be accessed as request->GetConfig<InfobarOverlayData>()->infobar(). In addition, this CL also adds IOSChromeSavePasswordInfoBarDelegate:: FromInfobarDelegate(), which allows downcasting to the appropriate type. Bug: 1030357 Change-Id: I3b89d8516b8b25d8e32576aff200fa10d92a61f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951130Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#722590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/981821ef9bd1..08b668ce35ac Created with: gclient setdep -r src-internal@08b668ce35ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I069cc3acb41d880f19fec977e13bece2143932d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722589}
-
Sadrul Habib Chowdhury authored
If a sequence does not have enough frames, then instead of discarding them completely, retain the throughput-data, and accumulate them with the throughput metrics of the subsequent sequences (of the same interaction-type) until there are enough frames to report the metric. Bug: 1031251 Change-Id: I4bbe1d0b024e04afd92677426a546699d9cc85d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952529Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#722588}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 80-3945.24-1574073604-benchmark-80.0.3964.0-r2 to 80-3945.42-1575283012-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id19c1aed8b648b688096ee333292498b47d44e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722587}
-
Maksim Sisov authored
To hide future different types of WaylandWindows (WaylandSurface, WaylandPopup and WaylandSubsurface), add a factory method, which will handle everything on its own. Also make unittests and OzonePlatformWayland use this factory. Bug: 1028919 Change-Id: I745f99024b6657be3686ee92b0baf4c93f08b9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954470 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Matthew Mourgos authored
Without this change the back button just instantly appears/disappears. Bug: 1031363 Change-Id: I731bfb62637215f18ea90c5c34b2b51d7be4c787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952423Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722585}
-
Kevin McNee authored
We now have all listeners created before performing the action that will lead to the expected message being sent. Bug: None Change-Id: I7b300136dedee619842d4753cd6d291fd8205b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954807Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#722584}
-
Brian Sheedy authored
Updates the golden images for the VR browser data URL emphasis test to account for a recent change to the security token icon from an "i" in a circle to a warning triangle. TBR=alcooper@chromium.org Change-Id: I05afeea881638cd971503cd692fc5e1db0ca793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955846Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722583}
-
Maksim Sisov authored
Just moving the translation helper method to utilities. Bug: 1028919 Change-Id: I6e60bcdf804e4aaff9cb39d437e4302af2ed3fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953710 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Tricia Crichton authored
Add sameSite to AddCookie command, but do not include in DevTools parameters if not set by user. Add sameSite to GetCookie commands. Bug: chromedriver:3264 Change-Id: Iefb02e131804bdf7235bdb98b5ebf38e7a886cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955793 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#722581}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe18a43d590a..6b52dc21e166 git log fe18a43d590a..6b52dc21e166 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 jyasskin@google.com Default to origin's default branch instead of always origin/master. Created with: gclient setdep -r src/third_party/depot_tools@6b52dc21e166 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1023031 Tbr: agable@chromium.org Change-Id: Id096878bf58f5cb701c4ceaaeec737eff415cee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955848Reviewed-by:
-
Brian Sheedy authored
Adds support for base::win::GetVersion() returning either 5 or 6 on Windows 10, which are valid return values but currently unhandled, which has been causing flaky test failures. Bug: 1007013 Change-Id: I40217ff610cb9071c2504352e8a99b234f3c1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954216 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#722579}
-
Antonio Gomes authored
As part of this CL: - WebRTCPeerConnectionHandler became RTCPeerConnectionHandlerPlatform - WebRTCPeerConnectionHandlerClient became RTCPeerConnectionHandlerClient - MockWebRTCPeerConnectionHandler became MockRTCPeerConnectionHandlerPlatform BUG=919392, 787254 Change-Id: Id5737142323fb611a177b3ca6d0a79c21bd91c39 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1b26bf3946791df4fcac71594f2acb34a040774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953383 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#722578}
-
Steven Bennetts authored
Prior to using mojo for network configuration, when creating a new configuration for a visible network, the GUID of the visible network would be provided so that it was preserved. Some UI depends on this (e.g. OOBE flow) and generally it is less confusing for logging, debugging, etc. This restores that behavior by providing an optional guid property in the mojo ConfigProperties and translating it to ONC. Bug: 1009406 Change-Id: Ia6fc22afa16b514a767dc97274bc216f28112ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951558Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Samuel Huang authored
This CL moves 83.5 kB of "long tail" resources to the Developer WebUI Dynamic Feature Module (DevUI DFM), for 17 chrome:// pages whose resources were in browser_resources.pak. These pages and their associated resource prefixes are: accessibility (IDR_ACCESSIBILITY_*) components (IDR_COMPONENTS_*) device-log (IDR_DEVICE_LOG_UI_*) domain-reliability-internals (IDR_DOMAIN_RELIABILITY_INTERNALS_*) download-internals (IDR_DOWNLOAD_INTERNALS_*) interventions-internals (IDR_INTERVENTIONS_INTERNALS_*) local-state (IDR_LOCAL_STATE_*) media-engagement (IDR_MEDIA_ENGAGEMENT_*) memory-internals (IDR_MEMORY_INTERNALS_*) notifications-internals (IDR_NOTIFICATIONS_INTERNALS_*) predictors (IDR_PREDICTORS_*) sandbox (IDR_SANDBOX_INTERNALS_*) site-engagement (IDR_SITE_ENGAGEMENT_*) snippets-internals (IDR_SNIPPETS_INTERNALS_* | IDR_FEED_INTERNALS_*) supervised-user-internals (IDR_SUPERVISED_USER_INTERNALS_*) translate-internals (IDR_TRANSLATE_INTERNALS_*) ukm (IDR_UKM_INTERNALS_*) Note that chrome://snippets-internals has 2 prefixes, corresponding to {SnippetsInternalsUI, FeedInternalsUI}. Also, some DevUI pages in browser_resources.pak are not moved, because they are new and can be handled later (need IsWebUiHostInDevUiDfm() change), or are not used by Android. These resources are moved to new file dev_ui_browser_resources.pak, which then feeds into dev_ui_resources.pak. 18 WebUI .cc files have their resource include headers updated. Bug: 927131 Change-Id: Ideaf57e2997b4621d7ffdfea8c126bf78688c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954458Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722576}
-
Peng Huang authored
Bug: 1020626 Change-Id: I70860caa686d221c3346eaaa018f9304c04a6f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955864 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#722575}
-
Lei Zhang authored
Bug: 659750 Change-Id: I78a775072dc1bde8c7db0bfaddd39ae6c55d432c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954542Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#722574}
-
Tommy Li authored
This is a reland of ebc60412 Original change's description: > [omnibox] Fix ZeroSuggestProvider duplicate classifications bug > > The below CL introduces a bug, where ZeroSuggestProvider can create > a match with duplicate text classifications. This triggers a DCHECK > as described in the linked bug. > > https://chromium-review.googlesource.com/c/chromium/src/+/1947765 > > This CL fixes it and adds a test. > > Bug: 1030741 > Change-Id: If59fbd320d720e2a7ff8d2f66d9ee92e11bb9a68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951557 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722497} Bug: 1030741 Change-Id: Ic169c05bfc953da56b161beb677e454ad0b2d437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955787Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#722573}
-
Maksim Sisov authored
This CL 1) extracts ShellObjectFactory into a separate file and keeps the same creation and initialization logic of wrappers of shell objects, 2) extends ShellPopupWrapper and ShellSurfaceWrapper interfaces by adding Initialize method so that it is more convenient to initialize XdgPopupWrapperImpl XdgSurfaceWrapperImpl and let them handle initialization based on the available xdg-shell version, 3) makes WaylandWindow use the extracted ShellObjectFactory, 4) makes InitializeStable and InitializeV6 methods of XDGWrapper objects be private members. The decision on which one to call is made in the main Initialize method now. 5) reconsiders the logging whether we need to keep pointers to some objects or not. Bug: 1028919 Change-Id: I87fd5fc0d0b35222f26c460c9174da6053dc320e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953708Reviewed-by:
-
Manas Verma authored
This reverts commit 69671ce5. Reason for revert: Tested in Canary, and the flow stops immediately after authentication. Will try to debug this, and possibly just go ahead with the long term solution right away. Original change's description: > [Autofill Auth] Adding capability to disable WebAuthn UI from Autofill > > Providing an option to disable WebAuthn UI from InternalAuthenticatorImpl. > > By disabling WebAuthn UI, modal dialogs will stop conflicting between the two > components and this will give Autofill full control over the user experience. > > Bug: 949269 > Change-Id: Ibf88cdb0f014c022371546df54d10e2c9eb7bc24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948916 > Commit-Queue: Manas Verma <manasverma@google.com> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722230} TBR=sebsg@chromium.org,jsaul@google.com,martinkr@google.com,manasverma@google.com Change-Id: Iab4507114f3e19e59acddd49ea89244ee7390048 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955910Reviewed-by:
Manas Verma <manasverma@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#722571}
-
Mila Green authored
Bug: 1027181 Change-Id: Ia370f73f7b6c88428b0a4665fd7bfef02d7dc05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929411 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#722570}
-
Jimmy Gong authored
- CupsPrintersList is deprecated in favor of CupsSavedPrinters and CupsNearbyPrinters. Bug: 1005905 Test: Browser tests Change-Id: I3ff1c0cc276e7f846c8b99232478a6cb38d28f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938068Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#722569}
-
Roman Sorokin authored
* Updated according to specs * Removed all manual paper-ripple calculations * Use flex layout for the pin pad TEST=checked for oobe, settings, security pin, multiprofile screen Bug: 1023394 Change-Id: I85978a0d98a2026283af23ae5fcedae68338a085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950520Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722568}
-
Oystein Eftevaag authored
BUG=1029465 TBR=crouleau@chromium.org NOTRY=true Change-Id: I123c11915e286e99c001fbf6802b889603c63037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954732Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#722567}
-
Etienne Bergeron authored
This CL is adding a pre-computed array of indices between text_ and layout_text_. The array contains pair of indices: <text_ offset, layout_text_ offset> Both sequence are ordered (e.g. text_ offsets and layout_offsets_). Previously, a scan 0(n) was made to find the offset (e.g. rank) of the codepoint within the text. There are an assumption that both codepoints had the same offset. Unfortunately, this is not working correctly with text eliding. The current implementation is 0(lg n). This CL is a step towards having a correct support for text eliding and removing the display_text_ phase by integrating it into the layout_text_. The goal is to allow a mismatch between the amount of codepoint in text_ and display_text_. Bug: 1025561 Change-Id: I76a2343b46589f5e9260da0cc60ff6af4ccd8e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945277 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#722566}
-
llin@chromium.org authored
Bug: b/144317438 Test: unit tests Change-Id: Ibd447281a78e05c75a6bd1a681dea12a00c2b8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954270Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722565}
-
Peter Thatcher authored
Preparing to implement WebCodecs (https://www.chromestatus.com/feature/5669293909868544). Also add an impl of VideoFrame and a skeleton class of VideoDecoder. Bug: 897297 Change-Id: I722ef891c10795e815ce0772b6f1be3afc563d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946940 Commit-Queue: Peter Thatcher <pthatcher@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#722564}
-
Kehuang Li authored
Input stream needs to release itself from AudioManager by calling ReleaseInputStream after closing, but CastAudioInputStream didn't, and thus will not be able to create new streams after open/close 16 times. Bug: internal: 144114606 Test: Compile. Change-Id: Ic2ee3e8e5110bee3597380620f06e48731786199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954450Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#722563}
-
inglorion authored
Sometimes, build or test failures occur in ThinLTO builds that do not occur in non-LTO builds. This change adds some hints on debugging such failures to the Clang sheriffing documentation. R=hans,rnk,thakis Change-Id: Id14456ca4fbae72daa57524dc7119ba520aca988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955067 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#722562}
-
Elly Fong-Jones authored
These metrics are (per hcarmona@, owner) unused and expired a few milestones ago. Remove the code that gathers them as a first step towards deleting BubbleUi. Bug: 496955 Change-Id: Icd1437093a081b50ee6f03f196259d9056c6204d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953393Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722561}
-
Maksim Sisov authored
It must be non-tooltip that closes children windows. Bug: 1028046 Change-Id: I9b5212873cb2c1a4179a28e915edd5fe84b29c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954483Reviewed-by:
-
Sebastien authored
Extracted Catalog and HighlightedGames specific logic into their own store instances. The Service class will be in charge of the overall flow, but the specific business logic and caching will reside in these stores. Typical code flow to help reviewers: Client-> GamesServiceImpl->GetHighlightedGame HighlightedGamesStore->SetPendingCallback GamesServiceImpl->UpdateStores CatalogStore->UpdateCatalogAsync GamesServiceImpl->OnCatalogReceived -- Kickoff all feature stores - (i.e. HighlightedGamesStore->ProcessAsync) - These will call their pending callbacks (UI is waiting). GamesServiceImpl->DoneUpdating Bug: 1018201 Change-Id: I6d0625f841fcfa8462d5555c58408405dc352ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944268 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#722559}
-
Matthew Mourgos authored
Bug: 1024636 Change-Id: I3c85ff89dfe152451e29c554a6646811e87b36a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951427Reviewed-by:
-
inglorion authored
This adds a script which can be used to transform linker command lines that use thin archives into invocations that use the object files referred to from those thin archives. This can be used to debug linker issues, particularly in ThinLTO builds. BUG=877722 R=hans,rnk Change-Id: Ibdebd1c92c85122f7705d68fa9ac46abfe6f3d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954537Reviewed-by:
-
