GitLab

If a download is interrupted on start, notification is not posted.
However, the download will show up in download home.
This CL fixes the issue by allowing interrupted downloads to post new notifications.

BUG=714798

Review-Url: https://codereview.chromium.org/2848723004
Cr-Commit-Position: refs/heads/master@{#468355}

Final experiment results here: https://bugs.chromium.org/p/chromium/issues/detail?id=682041#c18

BUG=682041

Review-Url: https://codereview.chromium.org/2850653002
Cr-Commit-Position: refs/heads/master@{#468354}

This reverts commit 14d9d00f.

Reverting in hopes of fixing 716594. See it for details.
I had to do this manually as codereview complained about file being
too big.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
R=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
TBR=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
BUG=716594

Review-Url: https://codereview.chromium.org/2849193002
Cr-Commit-Position: refs/heads/master@{#468353}

And remove the now unused test related classes.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2847283002
Cr-Commit-Position: refs/heads/master@{#468352}

Make sure save as PDF sets DPI to a nonzero value. Since we now check it
in Windows, if the job settings were previously invalid it will crash if
the printer does not reset them correctly.

BUG=None

Review-Url: https://codereview.chromium.org/2847003007
Cr-Commit-Position: refs/heads/master@{#468351}

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypes        | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665

Review-Url: https://codereview.chromium.org/2844463004
Cr-Commit-Position: refs/heads/master@{#468350}

Revert of WebVR: fix focus while presenting (patchset #1 id:1 of https://codereview.chromium.org/2847233002/ )

Reason for revert:
So there are a bunch of problems with this CL.

1. Now third-party iframes can just arbitrarily read head pose without needing focus as long as the main page has focus.

2. We've just broken the assumption that only one VrDisplay can be focused at a time. If the page has two iframes that want poses, and one presents, they're now both going to be fighting with each other to get the pose information.

Original issue's description:
> WebVR: fix focus while presenting
>
> If the WebVR document loses focus, check if the new focused element is an
> embedding local parent frame. If that's the case, continue presenting.  This
> fixes issues with Cardboard-style touch events that are reported as a click at
> viewport (0, 0) where the resulting focus loss stopped presentation.
>
> BUG=710863
>
> Review-Url: https://codereview.chromium.org/2847233002
> Cr-Commit-Position: refs/heads/master@{#468140}
> Committed: https://chromium.googlesource.com/chromium/src/+/984c8d18acf4b891d5bf39db6a898e2187340e0f

TBR=bajones@chromium.org,klausw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=710863

Review-Url: https://codereview.chromium.org/2851223002
Cr-Commit-Position: refs/heads/master@{#468349}

This is done by not adding the layer to the render surface layer list
(rsll) on the active tree. The layer will still be part of rsll on
the pending tree to ensure that it gets rastered.

BUG=517170
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2838033002
Cr-Commit-Position: refs/heads/master@{#468348}

Merge the three arrays that contain the valuator number, min and max
into one array that contains a struct. These three values are related.

BUG=716422

Review-Url: https://codereview.chromium.org/2848253002
Cr-Commit-Position: refs/heads/master@{#468347}

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=707638

Review-Url: https://codereview.chromium.org/2846303002
Cr-Commit-Position: refs/heads/master@{#468346}

BUG=591099
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2847493002
Cr-Commit-Position: refs/heads/master@{#468345}

https://pdfium.googlesource.com/pdfium.git/+log/72b715d51383..b8e00f247803

$ git log 72b715d51..b8e00f247 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 npm Fix CGifLZWDecoder::Decode comparison

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I2c0e306547e6a0093165ceb950744c67e01dea9b
Reviewed-on: https://chromium-review.googlesource.com/491328
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468344}

Part 1/2.

BUG=713847

Review-Url: https://codereview.chromium.org/2847313002
Cr-Commit-Position: refs/heads/master@{#468343}

Disable flaky NetworkQualityEstimator (NQE) test in Cronet. Also, rename
a few NQE tests.

BUG=710626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2850873002
Cr-Commit-Position: refs/heads/master@{#468342}

Reconcile the remaining Service Worker tests that concern the Fetch
standard. As noted below, some tests must be persisted in the Chromium
project due to unresolved timeout issues in the build environment (see
https://crbug.com/658997).

**fetch-event-async-respond-with**

The Chromium-specific version of this test is almost identical to the
version provided by the Web Platform Test suite, though it suffers from
timeout issues in the build environment.

Rename the Chromium-specific version to document its deprecated status
and improve the upstream version to defer frame removal and omit
unnecessary resource.

**fetch-event-network-error**

The upstream version of this test is almost identical to the
Chromium-specific version.

The Chromium-specific version of this test is almost identical to the
version available upstream. The upstream version is preferable because
it contains an additional assertion not found in the Chromium version.

Remove the Chromium-specific version of this test, and update the
upstream version to omit an unnecessary resource.

**fetch-event-respond-with-argument**

Re-locate Chromium-specific test to the Web Platform Test suite
directory so that it may be included in that project.

**fetch-event-respond-with-stops-propagation**

The Chromium-specific version of this test is almost identical to the
version provided by the Web Platform Test suite, though it suffers from
timeout issues in the build environment.

Rename the Chromium-specific version to reflect its deprecated status,
and improve the upstream version to defer frame removal and omit
unnecessary resource.

**fetch-event**

Remove sub-tests from the Chromium-specific version that are present in
the upstream version. Rename the test file to reflect the
implementation-specific nature of the test.

Extend the upstream version with a relaxed version of Chromium's
sub-test for request headers.

In both versions, formalize tear down logic to ensure consistent frame
removal and subsequent client de-registration.

BUG=688116, 658997
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2836233002
Cr-Commit-Position: refs/heads/master@{#468341}

There is a crash in DeviceDataManagerX11::UpdateDeviceList() that could
occur if there is no valuator information for the deviceid.

BUG=716422

Review-Url: https://codereview.chromium.org/2856563002
Cr-Commit-Position: refs/heads/master@{#468340}

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429

Review-Url: https://codereview.chromium.org/2849523005
Cr-Commit-Position: refs/heads/master@{#468339}

Revert of Implementing Binary glTF reader for the VR controller model (patchset #3 id:40001 of https://codereview.chromium.org/2852533004/ )

Reason for revert:
Test added in this patch fails on downstream bot (see http://crbug.com/717088)

BUG=717088

Original issue's description:
> Implementing Binary glTF reader for the VR controller model
>
> The binary glTF format enables us to deliver 3D models on a single file with minimal size.
>
> Binary glTF Specification in: https://github.com/KhronosGroup/glTF/tree/master/extensions/Khronos/KHR_binary_glTF
>
> BUG=644562
>
> Review-Url: https://codereview.chromium.org/2852533004
> Cr-Commit-Position: refs/heads/master@{#468198}
> Committed: https://chromium.googlesource.com/chromium/src/+/b416391e0ae62217afb7ea5ffeb04ab2640a96ed

TBR=mthiesse@chromium.org,bajones@chromium.org,acondor@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644562

Review-Url: https://codereview.chromium.org/2852103002
Cr-Commit-Position: refs/heads/master@{#468338}

And also add a trace event that matches the non-network service path.

BUG=598073,694688

Review-Url: https://codereview.chromium.org/2846393002
Cr-Commit-Position: refs/heads/master@{#468337}

https://skia.googlesource.com/skia.git/+log/53f77bd4fdd7..489530e06cb7

$ git log 53f77bd4f..489530e06 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 benjaminwagner Fix merge conflict.
2017-05-01 scroggo Remove unnecessary SkFILEStream::getMemoryBase
2017-05-01 msarett Only store width and height on SkPixelRef (part 2)
2017-04-28 benjaminwagner Omit shapes_mixed_10000_32x33 on GTX960 ANGLE Release
2017-04-28 benjaminwagner Omit HalfFloatAlphaTextureTest on CommandBuffer bot.
2017-04-30 benjaminwagner Add Swarming bot id and task id to recipe expectations.
2017-05-01 egdaniel Revert "Revert "Plumb the use of GrBackendRenderTarget throughout Skia""

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I4c26c247c484d17dd5b77af9db392553db895821
Reviewed-on: https://chromium-review.googlesource.com/491306Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468336}

With out-of-process iframes, it is not safe to assume that an
unresponsive event comes from the main frame's widget/process.

BUG=623228
TEST=See bug for repro steps.

Review-Url: https://codereview.chromium.org/2427423003
Cr-Commit-Position: refs/heads/master@{#468335}

Add a new pattern to detect and scrub serial numbers logged in
/var/log/messages

BUG=714802
TEST=components_unittests --gtest_filter=AnonymizerToolTest.AnonymizeCustomPatterns

Review-Url: https://codereview.chromium.org/2842263005
Cr-Commit-Position: refs/heads/master@{#468334}

BUG= 716597

Review-Url: https://codereview.chromium.org/2850963002
Cr-Commit-Position: refs/heads/master@{#468333}

We add the following log messages:
* Error message when one of tracingCategories & traceEventsToMeasure is specified
but not the other.
* Hint users to use tools/perf/run_benchmark to get tracing based metrics

BUG=701059

Review-Url: https://codereview.chromium.org/2856463003
Cr-Commit-Position: refs/heads/master@{#468332}

The browser code contains partial support for using multiple zygote
processes, which exists to support Flash component updates. However,
at present the browser process only creates a single zygote, on startup,
and uses that for everything. Clean up the code to make that more clear.

* Remove probably-unused lazy zygote creation code.
* Always use ZygoteHandle instead of ZygoteHandle*. ZygoteHandle is always
a pointer under the hood.
* Add CHECKs to validate the assumption there is only one zygote.

This came up while investigating a zygote check failure on Chrome OS.
I'm concerned that the lazy-launch code could be starting a zygote during
browser process shutdown. See crbug.com/692227

BUG=692227,569191
TEST=manually load web pages, extensions and nacl apps to trigger child
process creation, verify they load properly

Review-Url: https://codereview.chromium.org/2850903002
Cr-Commit-Position: refs/heads/master@{#468331}

Revert of Photo Picker Dialog: Use sandboxed utility process for decoding images. (patchset #11 id:240001 of https://codereview.chromium.org/2816733002/ )

Reason for revert:
generate_orderfiles.py fails due to AndroidManifest.xml change (see http://crbug.com/717071 )

BUG=717071

Original issue's description:
> Photo Picker Dialog: Use sandboxed utility process for decoding images.
>
> BUG=656015
>
> Review-Url: https://codereview.chromium.org/2816733002
> Cr-Commit-Position: refs/heads/master@{#468209}
> Committed: https://chromium.googlesource.com/chromium/src/+/83c9f3f4faeb35a3a2607446def65f1a8da7aa49

TBR=twellington@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,finnur@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=656015

Review-Url: https://codereview.chromium.org/2853793003
Cr-Commit-Position: refs/heads/master@{#468330}

SkPixelRef no longer stores an SkImageInfo

BUG=skia:6535
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2848063002
Cr-Commit-Position: refs/heads/master@{#468329}

The |hit_test_bounds_override_inner_| member of
aura::Window is no longer used, so remove it.
No functional changes.

BUG=344924
TEST=aura_unittests
TBR=varkha@chromium.org

Review-Url: https://codereview.chromium.org/2852653004
Cr-Commit-Position: refs/heads/master@{#468328}

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ActiveScriptWrappable.h
- ConditionalFeatures.h
- DOMDataStore.h
- DOMWrapperMap.h
- DOMWrapperWorld.h
- Microtask.h
- ScopedPersistent.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2848963002
Cr-Commit-Position: refs/heads/master@{#468327}

Part 2/2.

BUG=713847

Review-Url: https://codereview.chromium.org/2851103002
Cr-Commit-Position: refs/heads/master@{#468326}

This uses the new DelayedPersistentAllocation to avoid allocating the
full "counts" array when only one value is being stored.  That one
value is kept in the HistogramSamples metadata.  When a second value
is recorded, the counts-array is created and the single-sample is
moved; it is there-after unused.

This change only affects SampleVector.  A future change may add the
same support for PersistentSampleMap.

A quick test shows persistent memory use is reduced by 44% (from 924
KiB to 512 KiB) after a clean start and the loading of three pages:
  chrome://histograms
  https://www.google.com/
  chrome://histograms  (again)

BUG=705342

Review-Url: https://codereview.chromium.org/2811713003
Cr-Original-Commit-Position: refs/heads/master@{#466401}
Committed: https://chromium.googlesource.com/chromium/src/+/4162bafec82ea11c98d4dc2572337a039b79fdb9
Review-Url: https://codereview.chromium.org/2811713003
Cr-Commit-Position: refs/heads/master@{#468325}

They should not come close to one hour.

BUG=717028
TEST=test only change
R=jonross@chromium.org
TBR=jonross@chromium.org

Review-Url: https://codereview.chromium.org/2855623002
Cr-Commit-Position: refs/heads/master@{#468324}

In https://codereview.chromium.org/2810943005/, we added a presubmit script
to check if eventSender is still used in new layout tests. Here, We add a
doc to explain why we want to replace EventSender and give some examples
on how to use this new API in testing.

BUG=711340

Review-Url: https://codereview.chromium.org/2844803005
Cr-Commit-Position: refs/heads/master@{#468323}

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844393004
Cr-Commit-Position: refs/heads/master@{#468322}

BUG=715729

Review-Url: https://codereview.chromium.org/2844843002
Cr-Commit-Position: refs/heads/master@{#468321}

BUG=705865
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2851203002
Cr-Commit-Position: refs/heads/master@{#468320}

Decreased the number of missing header files by 4.

BUG=661774

Review-Url: https://codereview.chromium.org/2854603002
Cr-Commit-Position: refs/heads/master@{#468319}

https://pdfium.googlesource.com/pdfium.git/+log/ce8e51e6c444..72b715d51383

$ git log ce8e51e6c..72b715d51 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 npm Add PDF reference to CFX_Matrix comment

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I9b0e04c24e07ab8ba754d96b22859e1cb8297f3a
Reviewed-on: https://chromium-review.googlesource.com/491049
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468318}

iOS has a custom method for determining which omnibox suggestion types
are search/query types (as opposed to URL types). This change removes it
in favor of the cross-platform method used on other platforms. This has
useful effects on how we display navsuggest and calculator suggestions
and eliminates the need to maintain separate logic.

See the bug for a detailed description of the motivation for this change
and an analysis of its effects.

BUG=716047

Review-Url: https://codereview.chromium.org/2852553002
Cr-Commit-Position: refs/heads/master@{#468317}

BUG=715060

Review-Url: https://codereview.chromium.org/2850863002
Cr-Commit-Position: refs/heads/master@{#468316}