- 16 Oct, 2018 40 commits
-
-
Min Qin authored
These download will not show up on Download Home, and user will not be able to interact with them. Just remove them from history on startup BUG=851650 Change-Id: I1966510ec2ffb16df2d797433a629d8e1260f26c Reviewed-on: https://chromium-review.googlesource.com/c/1281422 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599858}
-
siyua authored
Code regarding the dialog pending view is useless now since we've changed the design. Previously dialog would change to a pending state with all checkboxes and buttons disabled after the user clicks the save button. And after 5 secs a close button would show. New design is to dismiss the dialog directly. Bug: 852904 Change-Id: Idb0ab56f80431a8c26a6bd178ef864bcc16887f0 Reviewed-on: https://chromium-review.googlesource.com/c/1282037Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#599857}
-
Xianzhu Wang authored
Remove out-dated docs about PaintInvalidationState and DisplayItemClient cache generation. Add new paint invalidation and raster invalidation. Update docs about paint properties. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I46df3f3e98353fc9a66fc950430df0d8e416d394 Reviewed-on: https://chromium-review.googlesource.com/c/1281921Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599856}
-
Greg Kerr authored
This reverts commit 642d0ad7. Reason for revert: The browser tests are failing again. I cannot reproduce locally but it seems most likely related to this CL. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5775 Original change's description: > Reland "macOS V2 Sandbox: Report correct sandbox profile for nacl-loader." > > This is a reland of 6d83f4b9 > > Original change's description: > > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader. > > > > The nacl loader process, used only on macOS, currently tries to load an > > invalid profile type under the V2 sandbox. This loads the correct type. > > > > Bug: 892554 > > Change-Id: I7b2733db426e3c91181b1f375d791d2918ac6763 > > Reviewed-on: https://chromium-review.googlesource.com/c/1268671 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Derek Schuff <dschuff@chromium.org> > > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#598380} > > TBR: rsesek@chromium.org,dschuff@chromium.org,tsepez@chromium.org > > Bug: 892554 > Change-Id: Ic9cd4da3a17f2a6d36b3ed7145762baf22d8c7f4 > Reviewed-on: https://chromium-review.googlesource.com/c/1279201 > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599391} TBR=dschuff@chromium.org,tsepez@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892554 Change-Id: I3770ed00eafff34550530f7820e76b4e43da252c Reviewed-on: https://chromium-review.googlesource.com/c/1281869Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599855}
-
Giovanni Ortuño Urquidi authored
Implements GetBluetoothState() by using the new BluetoothSystem mojo interface. Bug: 882346 Change-Id: I75f11b9de33c98e2913aeb08a1e5e085532e803d Reviewed-on: https://chromium-review.googlesource.com/c/1272957 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#599854}
-
Wenzhao Zang authored
Bug: 895031 Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174 Reviewed-on: https://chromium-review.googlesource.com/c/1281165Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599853}
-
Tetsui Ohkubo authored
This CL adds animation to NewMessageListView when notifications are removed. Video: http://shortn/_hXnIGaYesF UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest.RemovingNotificationAnimation BUG=769219 Change-Id: I06c909acb227f9bfa484083dca36a95d79ece7f5 Reviewed-on: https://chromium-review.googlesource.com/c/1280087 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#599852}
-
Ben Pastene authored
Bug: 876494 Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a Reviewed-on: https://chromium-review.googlesource.com/c/1281230Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#599851}
-
Aleks Totic authored
Labeling all the failures caused by #889721, "no fragment, no outline" as such. I've also triaged rest of outline failures. I'd like to rebaseline, these are minor inline layout pixel differences: paint/invalidation/outline/focus-layers.html paint/invalidation/outline/focus-ring-on-inline-continuation-move.html paint/invalidation/outline/inline-outline-repaint-2.html paint/invalidation/outline/outline-containing-image-in-non-standard-mode.html I've also investigated paint/invalidation/outline/inline-focus.html This seems to be a real case of too much invalidation. Bug: 889721 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iba888ea769e54433ca1272d475baefd078bf6a12 Reviewed-on: https://chromium-review.googlesource.com/c/1281915Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#599850}
-
Sunny Sachanandani authored
After migrating InProcessCommandBuffer to use GPU scheduler, most tasks are scheduled after their sync token dependencies are satisifed (see crrev.com/c/1157874). The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer for pepper, which specifies a sync token, and waits while handling the message. Change ReturnFrontBuffer to contain the sync token, and use it to specify the dependency to the scheduler. Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are specified as task metadata in all cases. Make other cleanups such as removing unnecessary sync token tests, and make sure the sync token code paths are not used where unsupported by using NOTREACHED. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 Bug: 778753 Reviewed-on: https://chromium-review.googlesource.com/c/1168155Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#599849}
-
Adam Rice authored
http/tests/fetch/chromium/release-handle-crash.html no longer crashes since https://chromium-review.googlesource.com/c/1278613 landed. Remove the flaky expectations. BUG=893015 Change-Id: I79738c8d44e001a3fad05fdbe11d687d895a3dae Reviewed-on: https://chromium-review.googlesource.com/c/1280074Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#599848}
-
Joel Einbinder authored
This will allow for new methods that operate on AXNodeIds, like Accessibility.click and Accessibility.focus. It also allows multiple calls to getFullAXTree to be compared. Bug: 887173 Change-Id: Iaaf103bced9c5dbc9dd04306c2562044f50dfd2c Reviewed-on: https://chromium-review.googlesource.com/c/1237526 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599847}
-
Andrew Xu authored
(1) Modified code so that tablet mode updating will enable/disable display orientation in setting page. (2) Code refactoring: move all of methods related with display information in SystemInfoApi::SystemInfoEventRouter to DisplayInfoProvider and its subclasses. In the previous code, tablet mode's change will not affect display orientation when setting page has already shown. As result, when opening setting page then changing laptop to tablet mode, user is still able to modify display orientation. After investigation, the bug reason is that in ChromeOS change in tablet mode will not trigger OnDisplayChanged event. Bug: 889625 Change-Id: Ic526ec54e6c01cd14a0d4a7e883774b9fafed268 Reviewed-on: https://chromium-review.googlesource.com/c/1264544 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#599846}
-
Trent Apted authored
Related apps under ui/file_manager all use background_base.js, which instantiates a VolumeManagerFactory. VolumeManagerFactory, BackgroundBase, their tests, and things they depend on should all move to //ui/file_manager/base/*. Capturing deps by Closure-compiling makes things easier to move. Start with volume_manager_unittest.js. Break its dependency on the files app `unittest_util.js` (which shouldn't move) by splitting out some test utility functions to ui/file_manager/base/js/mock_chrome.js. Bug: 879035, 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieab83e90607da78cf06352ecce73c0f8d62a2838 Reviewed-on: https://chromium-review.googlesource.com/c/1278622 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599845}
-
Xiaohan Wang authored
Add TRACE_EVENTs for all methods that call into the CDM so that we can monitor CDM's performance more closely. Bug: 879970 Test: Manually tested and checked traces. Change-Id: I61c063ad656b852463195b2cea93f91aee8d91ba Reviewed-on: https://chromium-review.googlesource.com/c/1281042Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599844}
-
Albert J. Wong authored
This message does not exist anymore and there does not seem to be an equivalent replacement. Codepaths with referencing ResizeOrRepaint seem to be dead. Deleting. Bug: 545684 Change-Id: Icbec543f3eadbdd440d2dd58c8fb4e33f6d69770 Reviewed-on: https://chromium-review.googlesource.com/c/1241134 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599843}
-
Koji Ishii authored
Following bot results are included. 10554 10556 10564 10575 10580 10588 10595 10601 10603 10605 10607 10608 10616 10618 10622 10625 10628 10637 10644 10651 10654 10657 10667 10674 10680 12 lines were removed and 7 lines were deflaked by consecutive results since 106188888888. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic4b22c7ca4477780993bc371558828f4c8ab8c64 Reviewed-on: https://chromium-review.googlesource.com/c/1278448 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This metric is the same as the normal install size, but applies a different dex multiplier. Change-Id: I82e20c1086eea30ea91474b1c5096061fb38d1fd Reviewed-on: https://chromium-review.googlesource.com/c/1281054 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599841}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bbd532d164f0..a1ac3fe80647 git log bbd532d164f0..a1ac3fe80647 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 jiawei.shao@intel.com ES31: Support textureGather[Offset] on int/uint formats on D3D11 Created with: gclient setdep -r src/third_party/angle@a1ac3fe80647 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I78829226c924ce9ea7cd7d82b450c39bc33801e1 Reviewed-on: https://chromium-review.googlesource.com/c/1282344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599840}
-
Albert J. Wong authored
After this change, RenderWidgetHost *never* forwards an IPC message on to another object. This removes one whole method of implicit virtual dispatch making the code more traceable. ... yay! Bug: 419087 Change-Id: Ia81e46814b3bcc3f6bd57ed992d2c0621c5d4ab5 Reviewed-on: https://chromium-review.googlesource.com/c/1282022Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#599839}
-
Zhuoyu Qian authored
BUG=561800 Change-Id: Ia074881a22e83873ff26249ea056ad9c6365fe14 Reviewed-on: https://chromium-review.googlesource.com/c/1248141Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#599838}
-
Ryan authored
This is already enabled by default in source, but this updates the JSON to match the Finch config. Bug: 881930 Change-Id: I26f637447141730e24f0a2e2c4d84b05f2cba2fa Reviewed-on: https://chromium-review.googlesource.com/c/1278621Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599837}
-
Tarun Bansal authored
Currently, when an anchor element is clicked, we record if it contains image or not based on only the properties of the clicked element. This CL changes the logic to also look at other anchor elements in the page that point to the same HREF. If any of the other anchor element in the page point to the same href as the clicked href, and contains image, then we record that the clicked anchor element also contains image. Bug: 871521 Change-Id: Ia21133e023596128e62621551931ad054fda98e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278468Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599836}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7c39bf7b87f8..1929d6e1d44e git log 7c39bf7b87f8..1929d6e1d44e --date=short --no-merges --format='%ad %ae %s' 2018-10-15 thestig@chromium.org Split pdfium_embeddertests sources. 2018-10-15 thestig@chromium.org Move fx_skia_device_unittest.cpp to pdfium_embeddertests. 2018-10-15 thestig@chromium.org Split pdfium_unittests sources. 2018-10-15 thestig@chromium.org Split public/ headers into their own source_set. 2018-10-15 thestig@chromium.org Restrict fxcrt's visibility to third_party. 2018-10-15 tsepez@chromium.org Clone dict before iteration in CJS_Document::get_info 2018-10-15 xlou@chromium.org Use CropBox instead of ArtBox or TrimBox 2018-10-15 tsepez@chromium.org Convert %s -> %ls for wide string error format. 2018-10-15 thestig@chromium.org Make core/ pass gn check. 2018-10-15 thestig@chromium.org Use more UnownedPtr in CPDF_FormControl. 2018-10-15 thestig@chromium.org Move CPDF_ModuleMgr methods into cpdf_modulemgr.cpp. 2018-10-15 thestig@chromium.org Make ":pdfium" pass gn check. 2018-10-15 tsepez@chromium.org Stop shadowing codec memory size with CCodec_ProgressiveDecoder::m_SrcSize 2018-10-15 thestig@chromium.org Make fxjs/ pass gn check. 2018-10-15 thestig@chromium.org Make fpdfsdk/ pass gn check. 2018-10-15 thestig@chromium.org Make xfa/ pass gn check. Created with: gclient setdep -r src/third_party/pdfium@1929d6e1d44e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895152,chromium:409670,chromium:895009 TBR=dsinclair@chromium.org Change-Id: I95c8a745294172817f98cc2e21f0110bd5b978cf Reviewed-on: https://chromium-review.googlesource.com/c/1282322Reviewed-by:
-
Hector Carmona authored
Bug: 889222 Change-Id: I666bb92178d2e5236143656f9b96180df8fd133c Reviewed-on: https://chromium-review.googlesource.com/c/1266202 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#599834}
-
Ted Meyer authored
Simply return an empty buffer and log an error. Bug: 894941 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I02a70afb3f326c1a9a8b845f7bc8d1aa84cb5dad Reviewed-on: https://chromium-review.googlesource.com/c/1281692 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
The children/leaves (LayoutSVGShape et al) will handle this. Cf. LayoutBox::HitTestChildren. Move the code to SVGLayoutSupport::HitTestChildren, and share that between the two users. Change-Id: Ibad76d35d90b2738cc3b840e0762147ef5098b4d Reviewed-on: https://chromium-review.googlesource.com/c/1278401Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c064d0b121db..be7450b6c635 git log c064d0b121db..be7450b6c635 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 brianosman@google.com Revert "Preserve pixel config in makeColorSpace of GPU backed images" 2018-10-15 brianosman@google.com Revert "Fix bug with makeColorSpace of GPU images with non-renderable configs" 2018-10-15 ethannicholas@google.com Revert "converted AARectEffect to new FP system" 2018-10-15 brianosman@google.com Add documentation to SkRGBA4f 2018-10-15 brianosman@google.com Fix bug with makeColorSpace of GPU images with non-renderable configs 2018-10-15 reed@google.com remove unused isABitmap code 2018-10-15 brianosman@google.com Revert "Revert "Use SkImage to manage mip map cache purging, not Bitmap/PixelRef"" 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms bdafec6a06cd..33ca7b4f7334 (1 commits) 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 bsalomon@google.com Make GrTextureOp disable filtering/aa in more cases. 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms d27291c0eba6..bdafec6a06cd (1 commits) 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 71e256cae02a..767b41b1a841 (1 commits) 2018-10-15 mtklein@google.com another NVPR-only op 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms d26444f2999e..d27291c0eba6 (1 commits) 2018-10-15 ethannicholas@google.com fixed Metal release build 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 79b914075cc5..bbd532d164f0 (1 commits) 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 herb@google.com Change 0 extraSize allocation behavior for SkArenaAlloc 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b655b88172fa..d26444f2999e (1 commits) 2018-10-15 brianosman@google.com Preserve pixel config in makeColorSpace of GPU backed images 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 9369e44523c7..b655b88172fa (1 commits) Created with: gclient setdep -r src/third_party/skia@be7450b6c635 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Id0e8723f9035a363c68aaa431f3920ab12095da2 Reviewed-on: https://chromium-review.googlesource.com/c/1281866Reviewed-by:
-
Christian Biesinger authored
This is required before (re)landing a Flexbox change (bug 596743 / https://chromium-review.googlesource.com/c/chromium/src/+/1269235) This fixes the previously found issues in the wallpaper manager and the OOBE UI. This changes more than necessary, but this is easier and should not be harmful. Bug: 890100, 891988, 892757 Change-Id: I745a22fadabd182d06d6b4c67b428d495c48bae4 Reviewed-on: https://chromium-review.googlesource.com/c/1281726Reviewed-by:
-
John Z Wu authored
imports should come after the header guards. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2644a6978cdaf2019e2ad78f990c6c2e0d455f1a Reviewed-on: https://chromium-review.googlesource.com/c/1282387 Commit-Queue: John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#599829}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I70c6f29a95265d3554dd938c00a69a54d1dd5729 Reviewed-on: https://chromium-review.googlesource.com/c/1272420Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599828}
-
Patrick Monette authored
This is meant to make the code easier to read by making ownership more obvious and standardize a little bit the different functions that implement the various dialog types. Also will facilitate a possible transition to the IFileDialog interface This CL should not change the behavior of the dialogs. Bug: 73098,884075 Change-Id: I0d2f5cc02e1d08ab3f54385fb166bc34ae1f5b53 Reviewed-on: https://chromium-review.googlesource.com/c/1249911Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#599827}
-
Weidong Guo authored
Background: After switching to another account, the item list for folder gets destructed, but |items_grid_view_| still has stale pointer to the object. When opening a folder, AppsGridView::SetItemList() will try to remove observer from the stale object, thus causing the crash. Changes: Notify observers when the folder item will be deleted. Bug: 891430 Change-Id: Id2957b594022321feaf6ee3cf402af318ddf169a Reviewed-on: https://chromium-review.googlesource.com/c/1282033Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#599826}
-
Noel Gordon authored
CL:1237801 removed this start-up message, but it was being used in the ui/views/select_file_dialog_extension_browsertest.cc tests. These file extension dialog browser tests didn't complain about the message being removed because the they're DISABLED on Chrome OS ¯\(ツ)/¯ We should get those test running again, which will be the subject of a of a new testing bug. For now, recover the 'ready' start-up message. Bug: 453634, 887792 Change-Id: I69b5118f9ebab6d7ee2ac2285ac714b223a437a4 Reviewed-on: https://chromium-review.googlesource.com/c/1282482Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599825}
-
Hirokazu Honda authored
This reverts commit eb0d6e13. Reason for revert: This CL causes a crash on AMD device, b/117398307 Original change's description: > Use ARGB8888 for a dummy buffer for protected content playbkack on ARC++ > > We have specified R8 format for a dummy buffer for protected content playback > on ARC++. > R8 format is not supported on exynos device. It leads crash on the devices. > ARGB8888 should be used instead, which is widely supported on all Chrome OS > device. > > BUG=chromium:787660, chromium:887658 > TEST=No crash on peach_pit and Protected content playback on veyron_minnie and eve > > Change-Id: Ia550277ad30a0e0fd814106a1610b59a1a86bb03 > Reviewed-on: https://chromium-review.googlesource.com/1242564 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593842} TBR=posciak@chromium.org,gurchetansingh@chromium.org,hiroh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:787660, chromium:887658 Change-Id: I7cc4e8607b0dd267f73a2f32879abae74f9fa24e Reviewed-on: https://chromium-review.googlesource.com/c/1282505Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599824}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f727917ac25..7d7bbc3b530f git log 2f727917ac25..7d7bbc3b530f --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl upload: delete no longer supported flags. Created with: gclient setdep -r src/third_party/depot_tools@7d7bbc3b530f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: If4f421e036ff5a4a81d8b95ecbaab9df5e016a16 Reviewed-on: https://chromium-review.googlesource.com/c/1281842Reviewed-by:
-
Tetsui Ohkubo authored
This CL implements TopCornerBorder hack for NewMessageListView. For the detail of the hack, please refer https://crrev.com/c/1161710 . NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: I24ad795fe118c21ef40be6b4ecc2f8e4a5f85101 Reviewed-on: https://chromium-review.googlesource.com/c/1278068 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Andrew Grieve authored
The non-full reports capture about the same info and load much faster. We can always switch them back, but thought it's worth trying them for a while to see if there are any drawbacks. Also adds a note about opening the viewer directly for uploading files. Results of this commit are already pushed to https://storage.googleapis.com/chrome-supersize/index.html Bug: 880671 Change-Id: I79f1b2298658cde0564c5976f47382e930f7196a Reviewed-on: https://chromium-review.googlesource.com/c/1281174 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Jun Mukai authored
This is the final phase of tab-dragging with touch on Mash. This makes several changes to use the result of the previous phases and achieve tab-dragging with touch on Mash. BUG=867074 TEST=manually Change-Id: I53239efbdf567754d3e9322b334d0a4e6751fa52 Reviewed-on: https://chromium-review.googlesource.com/c/1247034 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Currently to use GetState we have to create a RunLoop, call GetState with a callback that saves the result in a class variable, run the loop and then access the class variable to get the result. This CL attemps to simplify this by wrapping GetState into a function that waits for the call to respond and returns the result directly. Bug: 870192 Change-Id: I9d8d2dfb654443f99d56fe6e676efe9bfb8d0717 Reviewed-on: https://chromium-review.googlesource.com/c/1278464 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599819}
-
