GitLab

These Tab Capture API tests should be enabled per the referenced
bug.

Bug: 177163
Change-Id: I8ca71238532e245ae08216f4a7aa948eb1e916da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165706Reviewed-by: Archana Simha <archanasimha@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762530}

net: url_request_unittest: add expected_ prefix to response_status and cert_status fields in OCSPVerifyTestData

Makes it more obvious which fields are the test inputs and which are the
test expectations.

Change-Id: I5f4fb14b006954f910ff8cf65c9a4137b4b11565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165654
Commit-Queue: Matt Mueller <mattm@chromium.org>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762529}

Modified Notification View to take out hardcoded colors.  Moved
them to NativeTheme::ColorId and used the GetSystemColor call at the
different references to it.

Replaced NotificationButtonMD with MDTextButton.

Changed accent_color to base::Optional<SkColor>, updated associated
calls to account for that

Bug: 1056948
Change-Id: I28345c6b7f64301d1706531dc7df817348414d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141215
Commit-Queue: Matthew Porter <matt.porter@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762528}

The traffic in L CQ is relatively large after it is turned on.
Remove this test suite for now to reduce test load.

No-Try: true
Bug: 1032336, 1060245
Change-Id: I2598b2a46ab411108a49f4170e2a1b7d5f3468e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165459Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#762527}

Bug: 1071220
Change-Id: I6ff87fa96986647a8290707c148e643d4d45d55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151845
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762526}

No processes should be launched with an invalid combination of flags for
sandboxing. This eliminates SandboxType::kInvalid and adds a CHECK at
the point where the command line is parsed when child processes start.

Unit tests exist for this code and continue to pass. Tests that
verified that bad command lines were recognized are now removed as
Chrome will safely CHECK in these cases.

The following changes in default or behavior:-

* cloud print service (--type=service) now reports kNoSandbox
* NaCl loader process on non-Mac now reports kUtility
   - The NaCl loader defines its own sandbox but its command line
     is processed in some tests and needs a valid value.
* Fuchsia: sandbox types are now enumerated and the type must be
   specified when the low level sandbox policy is constructed.
* Linux: type added for Zygote to have before it grows up to get a
   real sandbox

Bug: 1065087
Change-Id: Ibe277153fa58771d12bae7e3c2f9c6b92b9370a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120049Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762525}

This reverts commit 23979013, which
reverted an earlier implementation of this CL in commit
a18fd063 due to
https://crbug.com/1065341.

The main functional difference between this and the original version is
where the JavaScript code calls the pref-storing functions. They were
previously called inside useTheme() and useFontFamily() instead of the
UI callbacks. Changes to the synced prefs result in a series of
observers being notified, which ultimately led to the useTheme() and
useFontFamily() methods being called again, potentially leading to an
infinite loop and the behavior seen in the bug.

The updateThemeSelection() method from the original CL was excluded in
this reimplementation because it was unintentionally never called in the
original CL. Omitting it helps reduce the scope of the CL and highlight
the important changes.

Bug: 1016615, 1065341
Change-Id: Ifd0e71027afd196267419ed81f7bdc0d78978a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152901Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#762524}

Android builders on perf waterfall started failing since this commit. Reverting this change to mitigate.

https://ci.chromium.org/p/chrome/g/chrome.perf/console?limit=200

Revert "Remove/replace unnecessary logging.h includes in .cc files (ipc)"

This reverts commit ba6e417c.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Remove/replace unnecessary logging.h includes in .cc files (ipc)
> 
> CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
> to the much smaller headers check.h, check_op.h, and notreached.h,
> respectively.
> 
> This CL updates .cc files to use those headers instead when
> possible, with the purpose of saving compile time.
> 
> (Split out from https://crrev.com/c/2164525 which also has
> notes on how the change was generated.)
> 
> Bug: 1031540
> Change-Id: I9b41171cc43f427005f9a9d78e5cd61341ebeb40
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164512
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Auto-Submit: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762412}

TBR=hans@chromium.org,tsepez@chromium.org

Change-Id: I21ebe546731e74bec8178d6bca889c1aeb4239c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1031540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165458Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#762523}

Each layout algorithm had a small portion of duplicated code to set up
the fragment builder for block fragmentation. Move this into a
SetupFragmentBuilderForFragmentation() utility function. Also move the
code that sets the first-for-node bit and the sequence number into this
function. This used to be done as part of FinishFragmentation(), but
that function is skipped in cases where the fragmentainer size is
unknown (column balancing pass). For now this doesn't cause any known
problems, but I'm working on a CL that will require it to be correct.

The old SetupFragmentation() was renamed to
SetupSpaceBuilderForFragmentation(), to avoid confusion.

No behavior changes expected for now.

Change-Id: I17aa3c491bb4f3b03aa83d2f5db766df22964cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164516Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762522}

The revocation_status field is only used when |response_status| == PROVIDED.
(Both in the current test data and as defined in the OCSPVerifyResult header:
https://source.chromium.org/chromium/chromium/src/+/master:net/cert/ocsp_verify_result.h;drc=32f60f7cc761469dc08b3757686a4e395566e4f7;l=72)

Change-Id: Ifa3b6905c2e932db23abf50def13fc0843c6ba56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165652
Auto-Submit: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762521}

Bug: 1069258
Change-Id: Iab2547dce1bbfd48d0892d630720d4b99e1bd868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163064
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762520}

This CL moves all drawables used by the Site Settings UI out of
//chrome. Any images used only in site_settings are moved to
//components/browser_ui/site_settings/java/res, and others that are used
other places in //chrome are moved to
//components/browser_ui/styles/java/res.

This is part of an effort to componentize the Site Settings UI so it can
be reused by WebLayer.

Bug: 1058595
Change-Id: I4fd4efaaefbea9791932adcbafec233ab71f46fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160114Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762519}

This CL makes sure the header text is programmatically aligned with the
small icons on the left.

It also makes sure the collapse button is aligned with the remove
suggestion button.

Bug: 1052522
Change-Id: I4ee9e107bc92e32951a85714c90c3bc9dcfbc968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165722
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762518}

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: I91305fe44026e637eaf7f2c543a9ad159e86e60a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164812
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762517}

This CL flips dependency MetadataRecorder <-> ProfileBuilder to
define MetadataRecorder types directly in the class.
This allows us to simplify MetadataProvider into a concrete class.

Bug: 1056283
Change-Id: I25501a6af2cd8690802c6ed14dbb0e8efbedad9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164986Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762516}

- Except VAPID key creation to M85 only which should be deprecated soon

Bug: 1072599, 1072598, 1072592
Change-Id: I6c345a4e7e914741ec6e5b3876a43cd82c2bdbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162987Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762515}

These tests start to produce non-deterministic outputs because of an
upstream change.

TBR=chlily

Bug: 1074441
Change-Id: Id96cbb071b990ba2d39212efa2b65fa65965ca97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165717Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762514}

The AppApiTest.ReloadAfterAppCrash was disabled for flakiness many
years ago. It is no longer flaky.

Bug: 118502
Change-Id: I395ec6821ecb2fe46c82066ba5d5498eaa628ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145936Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762513}

A few people have hit this and the error message is really confusing
(tells you that you forgot to add .java files as resources, rather than
telling you that you've listed something that isn't a resource).

Bug: 1026378
Change-Id: I8da70f83ed621837f740506d8fed6f24fddb97d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165245
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762512}

Change-Id: I40b531571f97b8f606c7a1089be40e4f21b6bed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165854
Commit-Queue: Matt Mueller <mattm@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762511}

Expand comment to explain what happens with conflicting PolicyDecisions.

Bug: None
Change-Id: Id5c39ea0824cf1bf279644851addae3cc12e119a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164688
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762510}

The comment for FindAppWithUrlInScope() and
FindInstalledAppWithUrlInScope() was out of date. We now search for the
app with the most specific scope for the provided URL rather than the
first matching one.

This behaviour was changed by:
https://chromium-review.googlesource.com/c/chromium/src/+/1909055

Change-Id: Ia99108f9aaf194890ea89cf7661e62883b3109ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160828
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762509}

Catches exceptions raised by SkiaGoldSession.RunComparison in
LocalDeviceInstrumentationTest and fails the test when caught. This
should prevent future occurrences of exceptions caused by missing
runtime args such as --git-revision causing the test runner to blow up
and not run most tests, instead just failing the tests that are
actually trying to use Skia Gold.

Bug: 1074058
Change-Id: I32d050f787352d73b16fdb36a01c29bfcc096f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165650
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762508}

These are helpers for PendingAssociated{Receiver,Remote}, so they
should be defined in the corresponding header.

Bug: 1074391
Change-Id: If79abeecd90a5f3df5f5698181dccf2295aadabe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165707
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762507}

- Add the delegate interface into AwMetricsServiceClient for the tasks
that depends on aw/browser.
- Implemented the interface in AwMetricsServiceClientDelegate.

Bug: 1072770
Change-Id: I49e94141d51c27802b151d86bd75ef612ac3c78c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159582Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762506}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I0c25b95980d4faebed1ddfe6763f11f28da44bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165439Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762505}

For conveniently changing a single header without using get_stream and
then update_raw_headers.

  set_header "https://example.com/main.js" "cache-control" "max-age=10"

Example: 
Change-Id: Iab0c5c0c0d307cbd2f0cd1139877aca9c56216d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164367Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762504}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d1dafb8d..9935cf7b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I781b106f961b4fc120675befc8cb36ec5e16d7eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164768Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762503}

Matching filled fields with profiles is expensive and grows
quadratically in the number of profiles and form fields.
With this CL, type matching and voting is omitted if
#fields * (#profiles + #credit-cards) >= 5000.

BUG=1060011

Change-Id: I40b71d07c115334e1cc4a9f90f6d15671f135b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160936Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#762502}

This CL converts WebStatePolicyDecider::ShouldAllowResponse
from returning a decision to instead taking a callback that
it calls with a decision. This CL also changes the decision
type from a bool to a PolicyDecision, making it consistent
with ShouldAllowRequest.

These changes are needed for implementing Safe Browsing on
iOS. We need to make ShouldAllowResponse asynchronous since
we need to be able to wait to receive a Safe Browsing
decision before deciding whether to allow a navigation
response. We need to change the decision type to a
PolicyDecision in order to indicate that we want to cancel
a navigation and also show an error page.

Change-Id: I0353132f49768b98900df5122dd9fd59f68d7c98
Bug: 1073546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153575
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762501}

This method changes whether a button is enabled. It can/should be used
instead of overriding IsDialogButtonEnabled().

Bug: 1011446
Change-Id: I733eb90639c74013aae9f764606a9c746eaddb56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165851
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762500}

These videos show those bounds in red, with and without the present CL:
WITHOUT: https://photos.app.goo.gl/VxLUSbqtM7o8W9Xt6
WITH: https://photos.app.goo.gl/ZS1Y3ixMToYRZUm58

Notice that in the "WITHOUT" video, the bounds change after a fraction
of a second. That really is accurate (and is fixed in the present CL)!

Test: manual
Change-Id: I4443b295d1efecce373defca9169867e0157b792
Fixed: 1073667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165576Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762499}

This reverts commit ee96764b.

Reason for revert: Suspected cause of
network_service_out_of_process_content_browsertests
failures across several bots.

Original change's description:
> Reland browser test to exercise DoH against external servers
> 
> The core part of the change was previously reviewed in:
> https://chromium-review.googlesource.com/c/chromium/src/+/1961006
> 
> However, the change was reverted due to failures in
> network_service_out_of_process_components_browsertests
> on Android (crbug/1038953). This change fixes those failures,
> and also includes a minor merge for //net/dns/dns_util.cc.
> 
> The trybots don't run the failing Android tests, so I verified
> manually on an Android emulator by running:
> components_browsertests --disable-features=NetworkServiceInProcess
> 
> This reverts commit 9338addd.
> 
> Bug: 1032710
> Change-Id: I27f783c9f4bdd74e2bc3446bffd5ecff0a08f98f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079652
> Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762206}

TBR=jam@chromium.org,ericorth@chromium.org,kaustubhag@chromium.org

Change-Id: Icbc51e276d0cfcd14a5291c44a5132d73e97a4b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032710, 1074453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165860Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762498}

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: I338d455d733df2b561fbae9b3edb90d303170377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164751
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762497}

The internals page now gets some data for Feedv2,
though not everything works yet.

As part of this, I decided to make collecting
and passing debug data for internals more explicit
instead of relying on setting and reading prefs in
various places.

Reland:
This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2142732
The only change is to fix the type annotation in feed_internals.js

Tbr: dcheng@chromium.org,rockot@google.com,iwells@chromium.org,dpapad@chromium.org


Bug: 1044139
Change-Id: Idba678e83295e0f09d5a7e2bab96ebb03d457442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164692Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762496}

Corresponding spec draft PR:
https://github.com/immersive-web/anchors/pull/40

Additionally, correctly handle cases where the app could try and access
properties of already-deleted anchor.

Change-Id: I309bd168a7d5715fec79e927512bdb721d1fd31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159928Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762495}

Test is flaky on Marshmallow Tablet Tester

TBR=boliu@chromium.org

Bug: 1074438
Change-Id: Id1458cd6fd88b5d322e03fdf8dec1ad9f06add0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165858Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762494}

(Added No-Try to release resources for L CQ)

No-Try: true
Bug: 1032336
Change-Id: I800429e0c1ea29f7a12ad0a2f9707ea1ac162e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165709
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762493}

Change-Id: I6ece6128f0e6da015cb983eb3c3e17bd1b316337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163149
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762492}

WebInputEvent::Type and WebTouchPoint::State are adjusted in this change.

This allows us to alias this enumeration to a mojo defined type that
will come in another CL.

No functional changes in this CL, largely completed via sed.

Change-Id: I57ad12e89aeba5a0d7e780abe0c627a0e1bc3876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160859
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762491}