GitLab

Review URL: https://codereview.chromium.org/445443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287500 0039d316-1c4b-4281-b951-d872f2087c98

When the nested message loop running a synchronous drag event on windows
is cancelled due to an external event, it does not currently set the
item visible again.

Now it does.

BUG=393519
TEST=Open a signed-in profile on two computers. On one computer,
uninstall an app from the app launcher. Then, Quickly switch to the
other computer and start dragging around a different app. When the sync
event to uninstall the app comes in, the drag should cancel, with the
item being dragged reappearing.

Review URL: https://codereview.chromium.org/435303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287499 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/439883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
NOTRY=True

Review URL: https://codereview.chromium.org/434343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315439
TEST=run the js tests.

Review URL: https://codereview.chromium.org/439753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/437353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399852
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/444513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287494 0039d316-1c4b-4281-b951-d872f2087c98

When an app has multiple file handlers for the same file type, it is
shown twice in the "Open With" menu. This CL ensures that only one
file handler is taken from each app.

TEST=Install an app with file handlers (e.g. Text).
Open the Files app and select a handled file (e.g. .txt).
The "Open" menu on the bottom right (next to the trash can) should have a drop-down button.
Click the drop-down, it should list Text.
Select the file again and right-click it.
Click "Open With".
A list of apps should pop up that includes Text.

BUG=350193

Review URL: https://codereview.chromium.org/415403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287493 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the App List overlay opens and closes without animating. This
looks strange the dialog itself animates as it opens. Add an animation
delay so the overlay animates slowly open to match the sub-dialogs.

BUG=395494

Review URL: https://codereview.chromium.org/429823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287492 0039d316-1c4b-4281-b951-d872f2087c98

Previously the gallery refers the current selected item to save images. But the
selection can be out of sync when a user traverses images before saving changes.

BUG=400016
TEST=manually

Review URL: https://codereview.chromium.org/435183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/425333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287490 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dmazzoni@chromium.org
BUG=393489

Review URL: https://codereview.chromium.org/444513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287489 0039d316-1c4b-4281-b951-d872f2087c98

pattern rather than a prefix.

BUG=370952
R=yoz@chromium.org
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/437883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287488 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388515

Review URL: https://codereview.chromium.org/439243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287487 0039d316-1c4b-4281-b951-d872f2087c98

Kill AddSuccess and GTestTestResults (the latter is already unused, but
was left out from deletion during
https://codereview.chromium.org/430383003/)

BUG=383639

Review URL: https://codereview.chromium.org/439553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287486 0039d316-1c4b-4281-b951-d872f2087c98

And Move api_resource_manager_unittest.cc to extensions_unittests to pass the unittest.(by using ExtensionsTest)

BUG=397164, 354046
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/431023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287485 0039d316-1c4b-4281-b951-d872f2087c98

The in-process DeltaUpdateOps don't require content/ and can be eventually used on iOS, whereas the out-of-process version needs to stay in chrome/.

Part 1d in design doc here: https://docs.google.com/document/d/1F76yNZCnPnGzgNXhI-sCFKlXulwx_s_OKTGbJS5NhbA/edit?usp=sharing

BUG=371463

Review URL: https://codereview.chromium.org/420503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287484 0039d316-1c4b-4281-b951-d872f2087c98

We want to be able to ask for the current benchmark's name when generating results. This threads the benchmark through so that it will be available to results objects.

Review URL: https://codereview.chromium.org/386943007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=306341
NOTRY=True

Review URL: https://codereview.chromium.org/417163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/442493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287481 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes three arguments from the RequireAdditionalModules method
since only the ScriptContext is needed to get those values.

BUG=todo

Review URL: https://codereview.chromium.org/442553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287480 0039d316-1c4b-4281-b951-d872f2087c98

I checked that gcc also expands NULL to just 0 here, so
this no longer seems like a clang bug.

BUG=162818

Review URL: https://codereview.chromium.org/437373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287479 0039d316-1c4b-4281-b951-d872f2087c98

Remove weak pointers from CastSocket by explicitly tracking and resetting callbacks created inside the class.

Ensure all sockets are closed and callbacks reset in all relevant code paths: Close(), CloseWithError(), and the dtor.

Review URL: https://codereview.chromium.org/417403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394085

Review URL: https://codereview.chromium.org/397793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287476 0039d316-1c4b-4281-b951-d872f2087c98

You can't Quit() the MessageLoop of a base::Thread. This CL makes
BackgroundServiceLoader use DelegateSimpleThread and run a MessageLoop
instead of using base::Thread, so that applications can safely Quit()
their current MessageLoop as usual to signify that they are done.

This shouldn't be necessary for the desktop shell once services are moved
out (network, NVS), but we'll likely continue to use this loader on android.

Note: the quit_on_shutdown() method is being removed in https://codereview.chromium.org/394903005/

BUG=

Review URL: https://codereview.chromium.org/437493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287475 0039d316-1c4b-4281-b951-d872f2087c98

This function in Aura is intended to be used for layer damage (not
window damage), so make the Mac version do the same.

BUG=none

Review URL: https://codereview.chromium.org/427393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287474 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287473 0039d316-1c4b-4281-b951-d872f2087c98

The FileDownloader refactor caused callbacks to be more tightly bound to
PnaclCoordinator than they were previously. Before the refactor, callbacks that
were invoked as the pexe was downloaded (or the cached translated nexe was
received) were generated through the CompletionCallbackFactory interface, which
would cause them to be cancelled when PnaclCoordinator was destroyed.

This change checks that the plugin instance is still alive before calling any
of the callbacks in the PPP_PexeStreamHandler interface.

I tried conducting some local testing, but didn't manage to hit quite the same
codepath as the one reported in the bug.

BUG=400171

Review URL: https://codereview.chromium.org/433633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287472 0039d316-1c4b-4281-b951-d872f2087c98

* lazy_background_task_queue_unittest.cc uses keyed_service/content directly
so make dependency explicit.
* I missed the GN build file when adding extensions_test.h/cc

BUG=none
TEST=compiles

Review URL: https://codereview.chromium.org/432433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287471 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/441753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287470 0039d316-1c4b-4281-b951-d872f2087c98

This refactor deletes AppWindow::Delegate, to simplify the arrangement
of classes relating to AppWindow. AppsClient has been moved from apps to
apps/ui, and ChromeAppsClient has been moved from chrome/browser/apps to
chrome/browser/ui/apps, for DEPS reasons.

This is a follow-up to r286514, which saw the rest of
AppWindow::Delegate's methods moved into another class.

BUG=391137
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/436503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287469 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Migrate TestCommon to Chromium c++ style and remove un-used header. (https://codereview.chromium.org/436133002/)

Reason for revert:
This patch removed some touch event logging in TestPlugin.cpp which broke the following layout tests

plugins/touch-events-details.html
plugins/touch-events-synthesized.html
plugins/transformed-events.html

Reverting.

Original issue's description:
> Migrate TestCommon to Chromium c++ style and remove un-used header.
> 
> Changes:
> 1) Run clang-format through source and header files.
> 2) Rename data member variables to use unix_hacker_ style.
> 3) Rename methods to use CamelCase style.
> 4) Rename file name to test_common.
> 5) Removed un-used test_common header.
> 
> BUG=331299
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287382

TBR=jochen@chromium.org,abhishek.a21@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=331299

Review URL: https://codereview.chromium.org/439973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287468 0039d316-1c4b-4281-b951-d872f2087c98

The paste PopupMenu was getting clipped by the status bar when the insertion
handle was brought close to the status bar. Update the position of the PopupMenu
 using the height of the status bar.

BUG=397915

Review URL: https://codereview.chromium.org/421173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287467 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns at:
Error: Field requires API level 19 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_IMMERSIVE_STICKY [InlinedApi]

So we need to add @SuppressLint to suppress this lint error.

BUG=327768

Review URL: https://codereview.chromium.org/420393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287466 0039d316-1c4b-4281-b951-d872f2087c98

This should make it run in the ChromiumOS config on the Main Waterfall.

BUG=399315
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/437693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/432053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287464 0039d316-1c4b-4281-b951-d872f2087c98

 ToolkitDelegateViews will be moved to components/renderer_contenxt_menu in a separate CL so that athena can use it.

BUG=397320

Review URL: https://codereview.chromium.org/417063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399362
NOTRY=true

Review URL: https://codereview.chromium.org/434403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287462 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/437313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375497

Review URL: https://codereview.chromium.org/440703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287460 0039d316-1c4b-4281-b951-d872f2087c98