GitLab

BUG=234710
TBR=scherkus@chromium.org,qinmin@chromium.org

Review URL: https://codereview.chromium.org/16082004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202888 0039d316-1c4b-4281-b951-d872f2087c98

We should not allow attachment after an initial navigation.

Currently, we don't allow attachment after an instance ID is allocated. 

These two checks are not equivalent. We chould have requested an instance ID from
the browser process and then immediately attach a new winow to the <webview> on the next
line prior to getting an instance ID. This will cause attach to get called again.

BUG=244641
Test=manually, this is a race that is extremely hard to test reliably. I will avoid adding
an automated test to avoid introducing more flake.

Review URL: https://chromiumcodereview.appspot.com/16057004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202886 0039d316-1c4b-4281-b951-d872f2087c98

Try to expand the revision range to include a change to .DEPS.git if the script detects a change to DEPS

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16023021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202880 0039d316-1c4b-4281-b951-d872f2087c98

> Use totmaps if available on chromeos
>
> We currently use statm on linux. This provides less than great results.
> We take total resident memory and subtract "shared pages" from it instead of
> using a count of pages that only this process has mapped.
>
> On chromeos we've added totmaps which sums up the fields from the process'
> smaps.
>
> BUG=125150
> TEST=Examine memory reports from about:memory and task manager, and compare
>      them to the sums of the results in the smaps.
>
> R=thestig@chromium.org, willchan@chromium.org
>
> Review URL: https://codereview.chromium.org/15779007

TBR=davemoore@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202640

Review URL: https://codereview.chromium.org/16116003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202878 0039d316-1c4b-4281-b951-d872f2087c98

Simply restart WPR using the same port it was on before. The browser will still
be set up to point to that port.

I think we originally restarted the browser because we used to not explicitly
pass the ports to use to WPR. Now that those are stored in browser_backend,
they can stay stable across WPR restarts.

BUG=None
TEST=tools/perf/run_measurement --browser=android-content-shell page_cycler tools/perf/page_sets/top_25.json --page-filter="youtube|plus" --pageset-repeat=1 -v
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/15917016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202877 0039d316-1c4b-4281-b951-d872f2087c98

Symbols may now be in lib/ instead of lib.target/. I'm not sure whether this is
always the case or not.

BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16094010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202876 0039d316-1c4b-4281-b951-d872f2087c98

Previously, download rate was estimated as bytes_received/(current_time - download_start_time)

Although simple, this would react slowly to dynamic changes in download time, or user initiated pauses.

With this change, a ring buffer of the past 10 seconds of download time is used instead, and estimates are derived from that. It handles dynamic changes to bandwidth well. Pauses are handled reasonably well, as estimates are accurate after ten seconds - a better solution would be to clear the data rates when the user resumes from a pause. The main downside with this approach is it takes about 100 bytes of memory per active download, as well as adds some complexity.

BUG=16390
TEST=content_unittests

Review URL: https://chromiumcodereview.appspot.com/14697023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202874 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202873 0039d316-1c4b-4281-b951-d872f2087c98

Caused WebViewInteractiveTest.PopupPositioningMoved to fail on Mac dbg 10.6 and 10.7:
WebViewInteractiveTest.PopupPositioningMoved: 
[1326:263:0529/075351:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
/Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
import pkg_resources
/Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
import pkg_resources
HTTP server started on 127.0.0.1:49950...
sending server_data: {"host": "127.0.0.1", "port": 49950} (36 bytes)
[1325:263:0529/075353:219402889538:INFO:CONSOLE(431)] "chrome.webRequest is not available: You do not have permission to access this API. Ensure that the required permission or manifest property is included in your manifest.json.", source: binding (431)
[1325:263:0529/075353:220201666944:INFO:CONSOLE(431)] "chrome.webRequest is not available: You do not have permission to access this API. Ensure that the required permission or manifest property is included in your manifest.json.", source: binding (431)
[1326:263:0529/075354:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
[1326:263:0529/075355:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
[1326:263:0529/075355:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
[1325:263:0529/075356:222219659574:INFO:CONSOLE(18)] "webview.loadstop", source: chrome-extension://nnkmmcedebpphammhapimbckejdabddg/main.js (18)
[1325:263:0529/075356:222325071892:INFO:CONSOLE(33)] "onInput, value: C, step = 1", source: http://localhost:49950/files/extensions/platform_apps/web_view/popup_positioning_moved/guest.html (33)
[1325:263:0529/075356:222831052658:INFO:web_view_interactive_browsertest.cc(227)] DIFF: x = 42, y = 86
../../chrome/browser/extensions/web_view_interactive_browsertest.cc:237: Failure
Expected: (std::abs(diff.x() - left_spacing)) <= (threshold_px), actual: 18 vs 10
[1325:263:0529/075356:222837065116:INFO:CONSOLE(33)] "onInput, value: Chromium, step = 2", source: http://localhost:49950/files/extensions/platform_apps/web_view/popup_positioning_moved/guest.html (33)

> Blink roll 151349:151373
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151373&mode=html
> TBR=
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/16194003

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/15904014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244337

Review URL: https://chromiumcodereview.appspot.com/15915009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202871 0039d316-1c4b-4281-b951-d872f2087c98

Previously time calculations based on "now"-time taken when renderer processed resource notification messages.

Renderer time is calculated by interpolation based on taken values. Because of long JS evaluation or heavy rendering, "renderer" time range might be skewed.

To fix situation, "renderer" time should be taken when IPC messages are processed by renderer IO thread.

This patch adds message filter that supplies aforementioned messages with timestamps.


BUG=223836

Review URL: https://chromiumcodereview.appspot.com/14646006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202870 0039d316-1c4b-4281-b951-d872f2087c98

- delete prepopulated search engines from user prefs
- delete the default search engine from user prefs
- reset unmanaged and non-extension URLs to prepopulated list. 

New unit tests:
- TemplateURLPrepopulateDataTest.ClearProvidersFromPrefs
- TemplateURLServiceTest.ResetNonExtensionURLs
- TemplateURLServiceTest.ResetURLsWithManagedDefault

BUG=235037,244291

Review URL: https://chromiumcodereview.appspot.com/15572002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202869 0039d316-1c4b-4281-b951-d872f2087c98

If MediaCodec fails, we need to report the error to WMPA.

BUG=233420
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/15822006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202868 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202867 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151373&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16194003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166709,244800
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16194006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202862 0039d316-1c4b-4281-b951-d872f2087c98

Reset startup page along with home page.


BUG=235037

Review URL: https://chromiumcodereview.appspot.com/16106002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202861 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202860 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes the dump series is not complete, or contains files with 0 bytes.

Rather than bailing out entirely, just skip those files.

This can happen for instance when using Telemetry-driven tests:
- each "page" on a "page set" is a different test, and will
contain its own set of "heap dumps"
- however, the "page set" itself is long running, so whilst
telemetry fetches heap dumps, chrome is still running and
generating dumps that aren't interesting.
- before starting the next page, telemetry removes all
those spurious dumps
- the final set of dump files contains "holes", but that's fine.

BUG=

Review URL: https://chromiumcodereview.appspot.com/15861007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202859 0039d316-1c4b-4281-b951-d872f2087c98

To migrate SyncFS from WAPI to DriveAPI, this change adds utility functions to
convert from/to WAPI ResourceID to/from DriveAPI FileID as below, and replaces
WAPI ResourceIDs stored in DriveMetadataDB with DriveAPI FileIDs using
DB migration mechanism (DB schema version: 1 -> 2).

(WAPI) "file:xxxx" <=> "xxxx" (DriveAPI)
(WAPI) "folder:yyyy" <=> "yyyy" (DriveAPI)

When using WAPI (i.e. IsDriveAPIEnabled() returns false), DriveMetadataDB
passes ResourceIDs re-converted from FileIDs to DriveMetadataStore so that the
SyncFS can use migrated DB contents on WAPI.


BUG=234557
TEST=unit_tests --gtest_filter=\*DriveMetadataDBMigrationUtilTest\*

Review URL: https://chromiumcodereview.appspot.com/15808002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202858 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/16101010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202857 0039d316-1c4b-4281-b951-d872f2087c98

When using jarjar to rename Java packages to avoid name conflicts, the
generated JNI code no longer works as it refers to the old name. Support
using the jarjar remapping list during JNI generation to generate code
that refers to the post-remapping names, since the JNI headers are not
intended to be read by humans anyway.

BUG=

Review URL: https://chromiumcodereview.appspot.com/15715006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202856 0039d316-1c4b-4281-b951-d872f2087c98

R=digit@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15705005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202855 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202854 0039d316-1c4b-4281-b951-d872f2087c98

r1636 Android backend: fix references to source top dir.

BUG=
TBR=sbc@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16168007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202853 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements the Shell::Close() method for Content Shell on Android.

BUG=138226

Review URL: https://chromiumcodereview.appspot.com/14977010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202852 0039d316-1c4b-4281-b951-d872f2087c98

At the same time this
- removes a lot of unnecessary code testing_automation_provider* and pyauto,
- removes the dependency of testing_automation_provider* on ProxyConfigServiceImpl.

BUG=234982
TEST=New browser_tests. Ran pyauto test testCachedCredentialsAddUser locally.

Review URL: https://chromiumcodereview.appspot.com/16045005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202849 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land after first version (r202580) was reverted. The problem was
that extra invalidations occurred due to a call to SetNeedsCommit(). The
solution is to avoid calling SetNeedsCommit(), and accept that this debug info
will be stale on the impl-thread until something else commits.

BUG=240946

Review URL: https://chromiumcodereview.appspot.com/16023024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202848 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a way of generically making any textfield or combobox disabled if necessary.

R=estade@chromium.org
BUG=180147

Review URL: https://chromiumcodereview.appspot.com/15979002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202847 0039d316-1c4b-4281-b951-d872f2087c98

Also remove unnecessary code in local_file_util.cc.

BUG=241701

Review URL: https://chromiumcodereview.appspot.com/15686005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244102
TBR=bruening
NOTRY=true

Review URL: https://codereview.chromium.org/16072011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202845 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
BUG=163314
NOTRY=true

Review URL: https://codereview.chromium.org/15924008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241113
TEST=browser_tests --gtest_filter="*FileManager*"

Review URL: https://chromiumcodereview.appspot.com/15919006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202843 0039d316-1c4b-4281-b951-d872f2087c98

To be able to use input method just after log-in, we should notify the end of
ime initialization to input method engine, otherwise onActivate event will be
missed.

The right way to fix this issue is migrating packaged app and working with lazy 
background page, but it requires much effort both for chrome and extension side
so and hard to merge to M28. So please let me add this temporary hack.

BUG=242864
TEST=Manually checked on link

Review URL: https://chromiumcodereview.appspot.com/15912004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202842 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163314
R=glider@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15870005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237277

Review URL: https://chromiumcodereview.appspot.com/15810003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242989

Review URL: https://chromiumcodereview.appspot.com/15747009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202839 0039d316-1c4b-4281-b951-d872f2087c98

Adds a flag for --enable-app-launcher-shim to chrome://flags. Enable to 
ensure an OSX app bundle for the App Launcher exists under the 
Applications folder. If the flag is not present any previously created 
app bundle for the App Launcher will be deleted on startup. 

BUG=138633
TEST=Tested enabling and disabling the flag in chrome://flags.

Review URL: https://chromiumcodereview.appspot.com/15675008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202838 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves the file type select drop-down list towards right by putting it inside of the button bar.

TEST=Open an image in a browser window. Hit CTRL+S.
BUG=242195

Review URL: https://chromiumcodereview.appspot.com/15674006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202837 0039d316-1c4b-4281-b951-d872f2087c98

1) Deprecated the UMA key "Translate.ServerReportedUnsupportedLanguage" (the internal histograms.xml should be modified later).

2) Added the UMA key "Translate.UnavailableLanguage" which is sent when the language is reported by the server but not available for the user locale.
[We decided to implement a new UMA instead of 2) in another CL]

3) Added the UMA key "Translate.UnsupportedLanguageAtInitiation" which is sent when the language was unsupported during initialization.

BUG=242142
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/15311006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202836 0039d316-1c4b-4281-b951-d872f2087c98