- 16 Jul, 2020 6 commits
-
-
Christopher Cameron authored
Specify a 0.005-1,000 nit luminance by default. This is a temporary measure in two ways: - We should plumb this through video and the compositor, and thereby get the correct values. - The default tonemapping affects the SDR range, which is undesirable. We should roll our own tonemapping that doesn't have this property. This will make HDR look less washed out on barely-HDR-capable monitors, such as the built-in Macbook Pro screens. Bug: 1101041 Change-Id: I4db344d35f5259dbeb4191e4901e9798882a06d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300979Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifc93d758802005dd99de07e254d2f81f159cd735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300819Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788802}
-
Yue Zhang authored
http://crrev.com/c/2119188 exposes two bugs in the setup introduced in http://crrev.com/c/2143671, which jointly lead to a corner case where the dialog animation is not setup correctly. This CL fixes this issue by 1) restoring dialog view size and position after animation 2) restoring the animation view alpha in the correct position. This CL also revives a disabled test that could have caught this issue by removing the flaky parts and add some bug-specific checkings. Bug: 1075677, 1099563 Change-Id: Ie722d77f806dd556f69cb2df6b758500739cdc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278923Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788801}
-
Orin Jaworski authored
Now that the submatch mechanism is eliminated, this CL removes several related functions and collapses logic at call sites. The flag omnibox-tab-switch-suggestions-dedicated-row is also removed because the omnibox-tab-switch-suggestions and omnibox-suggestion-button-row flags are sufficient, and there are no dedicated tab switch suggestions. Bug: 1102619 Change-Id: Iaa0b86601b1968a182af74b5478ec8bc312d8bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300627Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788800}
-
Siye Liu authored
Some IMEs may start and complete composition within same edit session. Therefore, we should still fire composition events at the moment where we commit the text to blink. This change also contains several refactors: 1. Refactor code in |CommitTextAndEndCompositionIfAny|. 2. Moves logic to set |new_text_inserted_| from |TSFTextStore::SetText| to |TSFTextStore::InsertTextAtSelection| since IMEs may directly invoke the latter method. We need to correctly set the |new_text_inserted_| flag in order to push text states to blink. 3. |TSFTextStore::InsertTextAtSelection| may be called several times in single edit session. Therefore, we need to aggregate all replacement ranges into single |replace_text_range_|. 4. In |TSFTextStore::RequestLock|, we should also reset all caches such as |new_text_inserted_| even when the function early returns. 5. In |TSFTextStore::RequestLock|, use the replace text end pos instead of the cached |composition_start_| as the |new_composition_start|. Bug: 1099125 Change-Id: Ibfa2ff284a183939596d9ea2a5e7105e8139b099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274245Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788799}
-
Martin Kreichgauer authored
WebAuthn GetAssertion requests originating from the cryptotoken extension, which implements Chrome's U2F API, currently may result in a CTAP2 request if the selected authenticator supports CTAP2. This hasn't really caused issues in the past: Lenient authenticators accept an appId as the makeCredential request's rp_id parameter and let us challenge the U2F credential that way. Or if the authenticator indicates over CTAP2 that the credential doesn't exist, GetAssertionTask would then automatically retry over the U2F interface based on the presence of the appId extension. Responses for both cases are equivalent. But sending CTAP2 GetAssertion requests in order to respond to a request to the U2F API is unexpected and inefficient. It may also cause issues with future authenticators that decide to treat user verification as non-optional for all requests arriving on the CTAP2 interface. Instead, change GetAssertionTask to never try its CTAP2 path for these requests. Bug: 1099782 Change-Id: Ice54122bf3b9f63814d594074a39b9b46279ded4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298541 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#788798}
-
- 15 Jul, 2020 34 commits
-
-
Andrew Grieve authored
Mostly left instances in feed since that will probably go away one day anyways. TBR=agrieve Bug: 1041930 Change-Id: I8191fe4f9b90f5eee2c46bfe2e5923fddf40bf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298040Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788797}
-
yilkal authored
This cl renames kEnableSecondaryAccountsForChildExperiment feature flag to kEnableSecondaryAccountsForChild. This is because the flag is now being used for a feature. Bug: 1101622 Change-Id: I981cd16fc0a9fa0ce993221f77c4eab7f7838f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300635 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#788796}
-
Peter Wen authored
Rather than using direct deps for javac compilation, use it only for turbine header compilation. The javac compilation process requires many potential transitive deps that will take a more comprehensive approach, perhaps similar to bazel's reduced java classpath. Turbine using direct deps would only affect annotation processors. In particular, possibly Dagger. Building chrome_java with only turbine's direct deps seems to have worked, but only removing more of the dirs in the allowlist can determine if this works for the entire codebase. Bug: 1092528 Change-Id: Ifc745d269ce8850a6c675458fcff25c46ca39937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299531 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This CL turns AutofillAgent::submitted_forms_ from a std::set<FormData> with custom comparator into a set of renderer IDs. The sole purpose of this set is to avoid duplicate submission events per form. Unique renderer IDs suffice for this. And since the comparator used before this CL was generally not sound (false positives), this at least theoretically solves some missing form-submission bugs. Bug: 896689, 1007974 Change-Id: I8fab1ee692c26c26b2cc061b0045b9757820b553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297527Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#788794}
-
Sushma Venkatesh Reddy authored
iHD v20.1.1 is unable to support Y800 format on gen 12 devices yet - https://github.com/intel/media-driver/issues/941. As we only care about NV12 and I420 images currently, this workaround should be acceptable. Bug: b:159896972 Test: On TGL tast run <IP_ADDR> graphics.VAAPIUnittest.jpeg_decoder Signed-off-by:
Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com> Change-Id: Ic26f57f547b0a127c40cbe2a007068e57243feae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294345Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788793}
-
Allen Webb authored
The system logs command to retrieve a list of system files is broken by a seccomp violation and is leading to crashes. Since it has been broken for a while and there haven't been complaints about the missing data, this change removes the broken command. Bug: 1021425 Change-Id: Ia8c5ab094bd1e97bb2996d31c458a00657c8b9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298707 Auto-Submit: Allen Webb <allenwebb@google.com> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#788792}
-
Peter Kasting authored
Whether operator/() does integer or floating-point division is not necessarily obvious to the reader (and will hopefully be changing in the future). Where it's at least as simple to get the same result without using it, do so. In many cases the code was effectively snapping to a multiple of some time, which can be done in a shorter form using operator%(). Bug: 1104532 Change-Id: Id6614bfa91636bcf14568bb05212354b5a68c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296859 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#788791}
-
Nina Satragno authored
This is a reland of 98450e6f The original change uncovered a bug by changing the timing of requests. If <cr-lottie> was detached while the animation request was in-flight, the worker would be terminated but the onreadystatus change callback would still fire and try to send a message to the terminated worker. Fix this by aborting the request when detaching. The reland also fixes a similar racy issue when changing the animation URL. If the URL changes before the first one had a chance to load, then whichever request comes last would be the one shown. This fixes that issue by cancelling the first request before starting the new one. Added tests for both issues. Bug: 1104105 Original change's description: > [webauthn] Port fingerprint enrollment assets to lottie > > Replace the fingerprint enrollment APNGs on the webauthn fingerprint > enrollment page by lottie versions. This shaves ~200kb and adds a > transparent background to the fingerprint animation that partially fixes > issue 1041877. > > Also, add "hidden" and "singleLoop" attributes to lottie to match the > APNG img tag behaviour; and update the wrapper to allow dynamically > loading another animation into the same element. > > Finally, this updates the settings UI worker CSP to allow the lottie > worker. > > Fixed: 1082312 > Change-Id: I0c92663ec6e1bfd76c03f995b6e96d210f26173f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116557 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786933} Change-Id: I6686e11295d7c0154659ae5c97cdf1cb773344f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290847Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#788790}
-
Renjie Tang authored
Change-Id: Ifee5f2ad4c323e3ca2d3e3ad289e7888e93c81d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300630 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788789}
-
Kyle Milka authored
Wrap the contents of the share tab (QrCode + Download button) in a scroll view so everything can be seen on smaller devices. Bug: 1105809 Change-Id: Iba3b85c5a6ef31beb24bb080a7b12942298a79cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300232Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#788788}
-
Dana Fried authored
Before the separator was rendered as a border, which had all sorts of odd interactions with the focus ring (including being rendered at the wrong time, causing it to not refresh immediately after the focus ring disappears - see associated bug). Now it is rendered as part of the background, which means it is behind all other elements. This provides the same effect with less code and is robust to focus ring changes. Bug: 1049546 Change-Id: I472067bd28569fac8ef00a6d6b6335d5935b6e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294342Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788787}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I86d163536815e90517099286f247fafe9dcea1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300722Reviewed-by:
-
Kristi Park authored
Multiple flakes in linux-chromeos-chrome (e.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7058) TBR=reillyg@chromium.org Bug: 1069695 Change-Id: Ib783ef93bbb2d005aa6f49446343f6786bd89a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300663 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788785}
-
Keishi Hattori authored
Add STACK_ALLOCATED to LayoutObject referencing structs in anticipation of oilpanization of LayoutObjects. Bug: 1030176 Change-Id: I81bc2a6db7b6ce891885ed106311299dd6c26b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298884Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788784}
-
Eliot Courtney authored
Previous code may pass nullptr if cached_promise_texture_ already exists. This CL also explicitly checks GrContextIsGL rather than !GrContextIsMetal. Bug: 1105698 Test: Youtube works in lacros chrome Change-Id: I19c468d8d007f0156e85996fd5b43cd13e9e6e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299680 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788783}
-
Liquan (Max) Gu authored
In order to reuse most of PaymentRequestImpl for WebLayer, to move the business logic from PaymentRequestImpl to ComponentPaymentRequestImpl, we need to put a clear cut between the UI logic and the business logic within PaymentRequestImpl. So this CL is to create PaymentUIsManager to take over the the UI logic of PRImpl. Change: * Move mUI into PaymentUIsManager and renaming as mPaymentRequestUI * Move the PaymentUisShowStateReconciler into PaymentUIsManager Bug: 1102522 Change-Id: I128a58c8a86c6325e408ad249571c45f127d44ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299187 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#788782}
-
Lijin Shen authored
Add a suffix to the key of intent data to distinguish intent from another chrome channel. Otherwise, intent from another chrome channel leads to an unnecessary metrics logging. Bug: 1090103 Change-Id: Iead382e1c052759da2c491c4d87bf61d142698f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299523 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#788781}
-
XiangYang authored
The page show white color in navigation initial. For dark mode, this excepted a dark color. If developer don't set WebView background color, just show a black background in dark mode. Bug: 1098235 Change-Id: I9b221d0a899d228c71f6ce3b9a46c9dda45c4536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256921 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#788780}
-
rbpotter authored
Add the annotations button and bar to the new toolbar. Hook up the button so that entering/exiting annotation mode works. Bug: 1105732 Change-Id: I87f1067b474c552295c66c0946ce98a813083b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298999Reviewed-by:
-
Eric Mill authored
of publicly trusted certificates. Change-Id: Ia22a664eea5a33bf23149d5f04ec3d48bc029d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300536Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Eric Mill <ericmill@google.com> Cr-Commit-Position: refs/heads/master@{#788778}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594814211-0517d79b9f4059a1b68c79d5638e00f140bf56b4.profdata to chrome-mac-master-1594835994-5147b08f1c93c88abb9731970c5f21d575c9bbcd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic01e6c36c60221a550751726becd2e64878cc3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300298 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
behdad authored
This change adds some unittests for adjust_upper_limit script used by rendering representative pertf tests. Bug: chromium:1052361 Change-Id: I5850b5ca888d6dca7318277ca8bd6eb4bdf40a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283660Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788776}
-
Rushan Suleymanov authored
When reupload is initiated after loading from the disk right away, it may lead to upload bookmarks which were removed from the other device. This would restore removed bookmarks. In practise it may be caused by some devices which a rarely used. Initiating reupload after receiving latest updates from the server helps to prevent such behaviour. Bug: 1061411 Change-Id: Ibc5646b19bf133de496140fa152b544bc06ebcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299721 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788775}
-
Lan Wei authored
Avoid testRunner.eventSender in paint/invalidation/table/ table-overflow-auto-in-overflow-auto-scrolled.html Bug: 1047176 Change-Id: I853c88de12cbf36f854a57f0d0f6216d9c1412d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297099Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788774}
-
Katie D authored
This keeps Switch Access from getting stuck in a state where the user cannot use SA at all after the user tries to go into a quick settings subpage from the status tray settings. However, users still can't access quick settings subpages after this change: that will be addressed later. AX-Relnotes: N/A Bug: 1105196 Change-Id: I251ffb4f8937076ee7e5e079300636972aaa4beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300621 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#788773}
-
David Tseng authored
This change unconditionally recovers ChromeVox's pointer focus except when touch exploring. This choice was made after various pieces of feedback: - from the CFM team (regarding lost focus) - from Chrome OS accessibility testers Additional changes: - rename BackgroundMouseHandler -> PointerHandler (which more accurately captures its new function) - caught some places where we were sending direct pass through touches (when an anchor point wasn't being explicitly set). Always convey these paths to ChromeVox as click gestures. ChromeVox will decide how to handle them - revise tests accordingly - allow PointerHandler to be owned by GestureCommandHandler, the only place it is used explicitly - adds coverage for re-reading of nodes in touch exploration - removes the single tap at anchor point logic behavior. Prior to this change, TouchExplorationController sends a tap press/release if a user quickly double taps. This is fairly confusing to explain and goes somewhat against the purpose of having a double tap and hold pass through R=akihiroota@chromium.org, dmazzoni@chromium.org Bug: 1102990 AX-Relnotes: makes double tap feedback not be so strict when touch exploring off of items in ChromeVox Change-Id: I1ebb54b0f31c08d01f46d5bf49d1862c30aca337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296364 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#788772}
-
Kristi Park authored
This reverts commit 43370549. Reason for revert: Suspect for failing "Win7 Tests (dbg)(1)" browser_tests https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/83627 Original change's description: > Roll DevTools Frontend from 2a4147183191 to d8d96d5f0af2 (5 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2a4147183191..d8d96d5f0af2 > > 2020-07-15 jacktfranklin@chromium.org Ship new ElementsBreadcrumbs to production > 2020-07-15 wolfi@chromium.org Use FrameManager for frames section in application panel > 2020-07-15 tvanderlippe@chromium.org Move copy_lighthouse_locale_files to third_party/lighthouse > 2020-07-15 tvanderlippe@chromium.org Move copy_wasm_deps to sdk/wasm_source_map/BUILD.gn > 2020-07-15 tvanderlippe@chromium.org Move embedder-scripts to front_end/BUILD.gn > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1093247,chromium:1101262 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I493eb47f07ded2676ab3f949bf3df79096dad6e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300286 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#788702} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If35df14e3465658e849a11cb7ffc513893619aa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1093247, chromium:1101262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300821Reviewed-by:
-
Shelley Vohr authored
Refs https://chromium-review.googlesource.com/c/chromium/src/+/2231678. When the label was updated to use underscores, the associated jQuery call in accessibility.js was not likewise updated, so it would error with: "Uncaught TypeError: Cannot read property 'value' of null" Change-Id: Iac01a1246a0bb1e0bb8a7c02a5965cfba5f66323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296883Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#788770}
-
Justin Cohen authored
Bug: 1106030 Change-Id: I7a422c99de9f3de5b613e38625260c93927adb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299533 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788769}
-
Leonid Baraz authored
Bug: b:161266545 Change-Id: I57f47b6c8acff90de983ca4c553b6f4fdacfba0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296636 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#788768}
-
Miguel Casas authored
VASupportedProfiles is an internal class of vaapi_wrapper.cc in charge of enumerating the encoding/decoding video/image profiles supported in Chrome. It basically holds a |supported_profiles_| member, filled upon construction from GetSupportedProfileInfosForCodecModeInternal(). This CL: - Refactors GetSupportedProfileInfosForCodecModeInternal(), renaming it to FillSupportedProfileInfos()) to do all the enumerations needed, and reorders a bit the contents of the for-for-for loops, so that IsEntrypointSupported_Locked() is unnecessary and removed entirely. - Changes the signature of IsProfileSupported() to maybe-return a ptr to the ProfileInfo entry (and not a bool), which simplifies callsites. - Removes GetSupportedProfileInfosForCodecMode(), simplifying some of the callsites as well (except GetSupported...ForTesting() which is made a friend). - Sprinkles static_assert()s to verify sizes of constexpr data structs. This CL also removes the references to VAProfileVP9Profile1 and 3, because those are not present in my experience in the wild, neither in libva impls nor in videos, and are not properly validated nor tested. Bug: 1040291, 1105103 Change-Id: I6717cac3e57f5e304eae04272842efacf7e1f762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292780Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#788767}
-
chrome://nearby-internalsJuliet Levesque authored
Add a tab that will eventually display Nearby-related HTTP messages. See the following screenshot for display: https://screenshot.googleplex.com/mL7965ihWuh. Bug: 1093634 Change-Id: I7d0cb3a15f6f114a888ff86ab0545f645ae5b9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269700Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#788766}
-
Xiaohan Wang authored
The session expiration should only change after Update(), Load() or Remove(). This CL updates Update() and Remove() to update session expiration if needed. Load() remains unimplemented. Note that we don't need to update expiration on Close(), which is handled at a higher layer in MediaKeySession::OnSessionClosed(). Bug: 999747 Change-Id: Ie0f32cde8fcae46581cf135753a3de4b7e2ca7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298344Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788765}
-
Stephanie Kim authored
It looks like win-official and win32-official occasionally take 4+ hours to complete. Even though win32-official hasn't seen any5 hour timeouts, some runs cut it pretty close so I'm increasing timeout for that too. Bug: 1106006, 1072012 Change-Id: I361ea8a3ee921a6af86fee34163f497529222ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300628Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#788764}
-
