- 12 Apr, 2019 40 commits
-
-
Jacob Dufault authored
Change-Id: Ic56f86eee47d27077c07cf781dcae80f983020aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562516 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#650479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb85b8b3f306..81fd86c1ca03 git log bb85b8b3f306..81fd86c1ca03 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 herb@google.com Revert "Convert the CPU path case to use prepareForDrawing" 2019-04-12 michaelludwig@google.com Remove debug quadType() checks 2019-04-12 michaelludwig@google.com Support domain clamping and transform matrices in YUVToRGB effects 2019-04-12 herb@google.com Convert the CPU path case to use prepareForDrawing 2019-04-12 benjaminwagner@google.com Factor common SSH logic into a new flavor. Created with: gclient setdep -r src/third_party/skia@81fd86c1ca03 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935563,chromium:935503,chromium:8959 TBR=egdaniel@chromium.org Change-Id: I2ae6457e8e3ad9fdb6bb42957b323e0dc727b334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650478}
-
David Bokan authored
Reland Note: Original CL actually fixed the test on Mac which caused it to mis-match the failing expectation. The test remained broken on other platforms because it didn't account for scroll animations. This CL fixes the test and updates the expectation to passing, original CL in PS#1. The IsOffscreen computation was comparing the FrameView's GetScrollableArea()->VisibleContentRect, which is be the content rect in the _root scroller_, with the object's VisibleRectInDocument, which is in document coordinates. This breaks when a non-default root scroller is active. I've rewritten this method to be cleaner. I've kept the separate mapping up to the local frame first using VisualRectInDocument rather than mapping directly from local to root frame since VisualRectInDocument has some specific logic in subclasses that uses a different local rect depending on the LayoutObject type; I couldn't find an equivalent way of getting an equivalent rect but in local coordinates and several tests depend on this (e.g. how line boxes are collected in a LayoutInline). TBR=eae@chromium.org Bug: 949406 Change-Id: Iec0f5a27bd242c537db231cfb44b39d535fc579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565724 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650477}
-
Yutaka Hirano authored
As a preliminary step to have a platform provided underlying sink, this CL defines UnderlyingSinkBase. UnderlyingSinkBase is much simpler than UnderlyingSource because we don't need extra logic that was needed for lifetime issues. Bug: None Change-Id: Ibcb5ccd364627df553cdd2be1c9dc1c1fa45a685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564278 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#650476}
-
Martin Kreichgauer authored
The WebAuthn UI is responsible for telling the request handlers when to dispatch requests to the Touch ID authenticator. When it does, it currently shows a Touch ID sheet, waits 1250 ms, and then notifies the handler. Instead, hide the UI and dispatch immediately. TBR=oshima@chromium.org Change-Id: Idc0e140814a2ab42b260f46203b98769b82db1a5 Bug: 943329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565555 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#650475}
-
Yusuf Ozuysal authored
This temporarily removes the restrictions on tab_ui target being only included in apk builds and make it part of the base at all times. This CL will be baked in Canary, cherry-picked to 74 and will be reverted. This is done to disable the DFM for 74. BUG=951198 investigating install rates. This will be reverted for the next milestone. Change-Id: I746a31ed7bc431d22d56de5edb32e7c67a021c8b Binary-Size: Increase is due to adding a DFM to the base while we are Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564760Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#650474}
-
Khushal authored
Ensure that the names used for surfaces created in SurfaceControl include the package name. This is needed to ensure the layer is included in tracking of android internal metrics. R=piman@chromium.org Bug: 952078 Change-Id: I469aa5b9ac61020ad3d2589b02777e22e011c6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565189 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#650473}
-
Daniel Bratell authored
Ozone platforms should not depend on ui/display/manager since that is a high level build target that ultimately can depend on ozone again, creating a dependency cycle. This is a followup to previous "fix one instance" that fixes all the instances, which I hope will be enough to break the cycle blocking https://chromium-review.googlesource.com/c/chromium/src/+/1538507 For path changes in ash: TBR=jamescook@chromium.org Change-Id: Ice1d8b21e9bc1709c07bd37943857b07c6093798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553424 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#650472}
-
Tim Song authored
The problem was that the controller was not registering itself as an observer. BUG=682890 Change-Id: Ic37a692c2879069734d25eaf38f7f5448bcb212f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565372Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#650471}
-
Eric Aleshire authored
This is in line with other helper functions which had GREYAssert converted to NSError as part of the EG2 conversion. Bug: 922813 Change-Id: Ib4e44af9a45555733e2773ef40b55df2cf79b97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566456Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#650470}
-
Sergey Ulanov authored
After crrev.com/649520 VulkanSurface was failing with a DCHECK when initializing on platforms that don't report currentExtent values for VulkanSurface. Updated VulkanSurface::CreateSwapChain() to handle this case properly. Also added some extra checks when casting uint32_t value received from Vulkan to int. Change-Id: I33a1d1ff3dc40b12ed9f7951ec5068f791fc45a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565249Reviewed-by:
-
Caleb Raitto authored
To disambiguate missing a RequestFinishedInfoListener vs. missing the general UrlRequest executor, add a new error type. Bug: 879208 Change-Id: I71b15ebf520fbb53b91a03721ea7291f4b50a435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559705 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#650468}
-
Dominic Battre authored
This CL allows Chrome Sync to store multiple entries for blacklisting domains from password saving again. This is necessary to make sure that the Login Database and Chrome Sync's database are fully in sync. The long term goal is that there can be only one blacklist entry per origin / realm. This requires to things: 1) Cleaning up old entries (not part of this CL) 2) Stopping the bleeding - i.e. preventing that the user can store more than one blacklist entry per origin / realms. Part 2) is achieved in this CL by properly normalizing entries in FormSaverImpl::PermanentlyBlacklist(). The unique key of each entry consists the following columns with the described normalization: - origin_url -> replaced by origin (not containing the path anymore) - username_element -> cleared - username_value -> cleared - password_element -> cleared - signon_realm -> used verbatim Bug: 952336 Change-Id: I47f6e9877dc53275641229aa71d4d8549a68af0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566290Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#650467}
-
Moe Ahmadi authored
Bug: 905816 Change-Id: Ic8820ee4467647c1a4270583a3648abceaef3032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566054 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#650466}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bd29f6f75209..db58954c8cb3 git log bd29f6f75209..db58954c8cb3 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 dpranke@chromium.org Use the same git-cache bucket for authenticated and unauthenticated repos. Created with: gclient setdep -r src/third_party/depot_tools@db58954c8cb3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:935084 TBR=agable@chromium.org Change-Id: I3f938ab6e8d069b141840451422300838ea632e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566279Reviewed-by:
-
Xiyuan Xia authored
UIPerformanceTest::SetUpOnMainThread() needs to be called to start tracing. Otherwise, it hangs on exit when trying to stop trace. Bug: 942599 Change-Id: I13045ea5244bc20db8387c11972b2274e4d90f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566364Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650464}
-
Tommy Steimel authored
This CL adds a MprisNotifier to connect to the Media Session service and update the MprisService with the metadata of the active media session. Bug: 951584 Change-Id: Idf8f5db3197783e27495e6f70779c3157bfb8e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562628 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Bug: 842296 Change-Id: I43f6a5ebe7de228483072aab92b796f34ab81ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566158 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Brian White authored
Putting the export=false on the <enumeration> tag ends up just being ignored. Local-metric aggregation works fine but the key-metric ends up being also aggregated and stored in the output tables. Change-Id: I3a061f14af847bb55bbd49d5fe0c8a918a4017cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566390Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#650461}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/svg. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibe056e0972447afcb54db2209f3977ec42ec094c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564073 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#650460}
-
Dominik Röttsches authored
For unique local font matching, on Windows 10, we do not need to scan fonts and build a lookup structure but instead we can perform lookups directly against IDWriteFontSet using GetMatchingFonts() API. This API is only available where IDWriteFactory3 is available, which means on Windows 10. Add a method to DWriteFontProxy to perform a single font lookup using this API. Also add a method to dermine which mode should be used on the current machine: single lookups or retrieving the shared-memory lookup table that we built for Windows 7 and 8. See the design document [1] for more details. [1] https://docs.google.com/document/d/1yCZwVIF39S8WOgCUraT5OuUUaLSqWrxoG3mqdtnHnhs/edit#heading=h.s74lqnekmr53 Bug: 951978 Change-Id: I833139238a47ba9e72f643656a75c2e78c069343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565310 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#650459}
-
Ryan Hansberry authored
These logs will allow developers in the future to understand if an unexpected situation (crbug.com/943761) was hit when examining feedback reports. Bug: 943761 Change-Id: Ice7054acb8dd13c3f405195f8919b08c8312c007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566416 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#650458}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b727c7b27557..5b353de6daa9 git log b727c7b27557..5b353de6daa9 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 rmhasan@google.com [Telemetry] Allow test paths to be used as test names Created with: gclient setdep -r src/third_party/catapult@5b353de6daa9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=crouleau@chromium.org Change-Id: I0154e3f2b8c922c7c3e11c3d01871a7ae84e0b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566450Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/249b32178539..330fbee5d870 git log 249b32178539..330fbee5d870 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 jonaso@webrtc.org Make ExtraICEPing send slightly fewer extras Created with: gclient setdep -r src/third_party/webrtc@330fbee5d870 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I63035de4776e64a840f8a69d5a7b7dab9d79e27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566274Reviewed-by:
-
Charlene Yan authored
Change-Id: I13e40a605cd1c891a533e4d2a4d9a62c3ccbe3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566020 Auto-Submit: Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#650455}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81880ac0f676..e7d286efc876 git log 81880ac0f676..e7d286efc876 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 treehugger-gerrit@google.com Merge "Talk about sampling in docs." Created with: gclient setdep -r src/third_party/perfetto@e7d286efc876 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4e6b9d2e6b7a6ec546998dd18e19c2c843720567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566277Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit a00b988e. Reason for revert: speculative revert as a possible cause of android build failures (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916352597455843616/+/steps/compile/0/stdout) Original change's description: > Android: Link against apk_under_test resources for test apks > > Test apks are allowed to reference resources that live in the apk_under_test. > We've previous supported such references via R.java constants, but this > CL also adds the ability for resources in the test apk to directly > reference resources in the apk_under_test (e.g. via xml @references). > > The need for this has come with the latest version of the support > library. > > To accomplish this: > 1. Adds a "-I UnderTest.ap_" flag when compiling test apks resources > 2. Sets the test apk's arsc package name to match the apk_under_test's > package name. > 3. Uses --emit-ids / --stable-ids to avoid collisions between the > test apk and the apk_under_test. > 4. Updates incremental install manifest logic to do the same trick. > > Some other small tweaks to related resource code: > * Removes incremental AndroidManifest.xml as an explicit build output > * Moves most uses of "aapt dump" to "aapt2 dump" > * Removes --check-resources-pkg-id in favor of always enabling it > * Removes --optimize-resources in favor of having it implicitly set by > --optimized-resources-path > > Bug: 896775 > Change-Id: I6ea2d1ec8d1109bede4e0701eb4c7aeaa2a67503 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556395 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650427} TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org Change-Id: Ie70c31177c5b5e33d830a9d4fc57f10613fc5d30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566365Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#650453}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/485dd5e5..8042513e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42086b21a2f8e620cd3d08e4bceb74e1e18c3d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565728Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650452}
-
Toni Barzic authored
Bug: None Change-Id: Id6caf41b9f355a2100b4660cd6c53e3440c56610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565111 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#650451}
-
Matt Mueller authored
The WebSocketChannel and URLRequest will be destroyed if the connection is aborted, so the |out_headers| and |callback| in these methods would not be safe to access. Also use weakptr on URLRequestHttpJob::NotifyBeforeStartTransactionCallback. This avoids an issue where the callback is run while the URLRequest is cancelled but not yet destroyed, similar to https://crrev.com/be9d8e81e8c3ac82d25597e653d929dfff2d8ec1 Bug: 947407 Change-Id: I7d4e16859fa9f9c17ce4264eb78a9c4224a686b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559493 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#650450}
-
Lily Chen authored
If the sampling rate is 0.0 or 1.0, there is no need to generate a random number to see whether we should sample or not. In most cases, this eliminates a file read to /dev/urandom which may be slow. Bug: None Change-Id: I6ed8302574d45ddd1437610c8c5b03de187f8c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566112Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1de3cd440cf8..bd29f6f75209 git log 1de3cd440cf8..bd29f6f75209 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 nodir@google.com Roll bb to 080c945efd74d45e9edac5d5b6cc598bbe106593 Created with: gclient setdep -r src/third_party/depot_tools@bd29f6f75209 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I768cdac6aad31967aa5fa079af5a1b409ff23e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566140Reviewed-by:
-
Vlad Tsyrklevich authored
Test the higher-level AnalyzeCrashAllocator() function and have it check deallocation stack traces as well. Bug: 951410 Change-Id: I2755c1e08de386290cd2ddc710269f7f60553e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566115 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#650447}
-
Robert Liao authored
This is a run of clang-tidy with the existing .clang-tidy config on //ui/views including modernize-use-default-member-init and readability-redundant-member-init. BUG=940732 TBR=sky@chromium.org Change-Id: I9f14648a041bbdb799b94642126483441cdf39c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542062Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#650446}
-
Ethan Jimenez authored
1. Introducing support for `TextUnit_Word` and `TextUnit_Line` in `AXPlatformNodeTextRangeProviderWin::MoveEndpointByUnit`. Similar to `MoveEndpointByCharacter`, this change introduces methods `MoveEndpointByWord` and `MoveEndpointByLine`. Since these last three methods basically followed the same code path, a new method `MoveEndpointByUnitHelper` generalizes how to move an endpoint given which `AXPositionInstance` method is relevant to a particular unit, i.e. `CreateNextCharacterPosition` and `CreatePreviousCharacterPosition` for the character unit. With such generalization, methods to move by character, word and line have been refactored to use `MoveEndpointByUnitHelper`. 2. Refactoring a big chunk of `AXPlatformNodeTextRangeProviderTest` in order to reduce code repetition and improve readability. 3. Adding unit tests for `MoveEndpointByWord` and `MoveEndpointByLine`. Bug: 928948 Change-Id: I3d323ff483407bb50a8d678ef0fe6677591f71e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563434Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#650445}
-
Mehran Mahmoudi authored
This calls TouchlessUiController::addModelToQueue and TouchlessUicontroller::removeModelFromQueue when a dialog is shown and dismissed, respectively. It also renames AppHooks::createTouchlessMenuCoordinator() Bug: 944512 Change-Id: I1f8b6ea6c2f411e04b2c24d4022399b05930527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564558Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#650444}
-
Alexandre Frechette authored
Also adds doc and test around s2langquadtree's unique face constraint. Bug: 850947 Change-Id: Ie8a48040bddeb011b59a8e3be230f1fdfa0d3406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553586 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1f7039a6c177..82eb22e297f5 git log 1f7039a6c177..82eb22e297f5 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 capn@google.com Propagate descriptor decorations to access-chain and load results Created with: gclient setdep -r src/third_party/swiftshader@82eb22e297f5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iae52dd8695bb25cb98b7792a73ed2ec1d92afdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564644Reviewed-by:
-
Collin Baker authored
ViewObserver::OnViewVisibilityChanged is currently only called when the observed view's visible() state changes. This is different than View::VisibilityChanged, which is called whenever SetVisible() is called on the observed view or any of its ancestors, or whenever the parent widget's visibility changes. This makes OnViewVisibilityChanged's behavior and interface match VisibilityChanged. In doing so, this fixes an InkDrop bug where InkDrop state incorrectly remained after a view was no longer drawn. This bug resulted from switching to the ViewObserver interface. Bug: 943979, 949067 Change-Id: I35cb4db5625060e2564f6c295dd047ca57c7a8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553708 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#650441}
-
Christian Dullweber authored
Some deletions are very slow or don't finish at all. To identify which tasks of a deletion are causing this, record a histogram after 180s with the task ids from BrowsingDataRemoverImpl. Bug: 927474 Change-Id: I9499f5ae4a36c400b8524bd0d9e1f6b44bc34122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559950Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#650440}
-
