GitLab

think this was happening because we were injecting from the the
browser at load_start, but the document might not be established
in the renderer by the time this message is received.

Since we are now not even showing the toolstrip until
load_complete, it is no big deal to delay the CSS injection
until then.

Review URL: http://codereview.chromium.org/100182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14914 0039d316-1c4b-4281-b951-d872f2087c98

when tab->GetActiveEntry() is NULL.

Review URL: http://codereview.chromium.org/100172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14913 0039d316-1c4b-4281-b951-d872f2087c98

Parts of the code are from ermilov.maxim@gmail.com. Thanks!

BUG=8405
Review URL: http://codereview.chromium.org/100106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14912 0039d316-1c4b-4281-b951-d872f2087c98

Make "Reopen closed tab" be "Reopen closed window" when a window is the top item on the closed tabs stack.

Original patch by Miranda Callahan (see http://codereview.chromium.org/100054 ), r=me.

BUG=11183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14910 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100144


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14909 0039d316-1c4b-4281-b951-d872f2087c98

Also rebaseline another SVG test since eseidel says our result looks ok.

Review URL: http://codereview.chromium.org/100187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14907 0039d316-1c4b-4281-b951-d872f2087c98

This only works with post-1.0 Chrome, as it refers to the new Window names.

R=kuchhal

Review URL: http://codereview.chromium.org/101008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14906 0039d316-1c4b-4281-b951-d872f2087c98

TBR=evan

Review URL: http://codereview.chromium.org/100185


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14904 0039d316-1c4b-4281-b951-d872f2087c98

- Introduce ExtensionHost, which is the guy that talks to the RenderViewHost.
- ExtensionView holds an ExtensionHost, and also renders its contents in an
  HWND.
- Added code to load a page optionally specified in the manifest as a
  background process whenever it exists.
Review URL: http://codereview.chromium.org/92043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14902 0039d316-1c4b-4281-b951-d872f2087c98

Reenabling all of them.
Hopefully it'll help with flakiness.

Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux.

BUG=6584,2136
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/101013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14899 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=make sure all tests (unit-tests, ui-tests...) still work.
Review URL: http://codereview.chromium.org/100032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14897 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14896 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100170


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14894 0039d316-1c4b-4281-b951-d872f2087c98

We weren't sizing the GtkFixed widget because the animation delegate callbacks weren't being called. Now we artificially call AnimationProgressed() once we know what size the GtkFixed should be.

TEST=switching back to a tab that has an infobar open should properly display that infobar.

Review URL: http://codereview.chromium.org/99110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14893 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14892 0039d316-1c4b-4281-b951-d872f2087c98

on large <canvas> elements.  We disable the __debugbreak
only when skia tells us it is prepared to correctly 
handle a failed (NULL) malloc().  It does this
by calling sk_malloc_flags() without SK_MALLOC_THROW.

Note that, since the switch to tcmalloc, the new_handler
was not getting called at all (since tcmalloc doesn't 
support it yet), so this crash is currently unreproducible
in trunk.  In order to test this change, I reverted the 
tcmalloc change in my client.  This is not the case in the 
stable branch, since it doesn't use tcmalloc, so this change 
is still needed there.  (It will also be needed in trunk 
again once mbelshe's re-implementation of the new_handler
is in).

BUG=http://www.crbug.com/2044
Review URL: http://codereview.chromium.org/100163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14891 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14890 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14889 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100177


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14888 0039d316-1c4b-4281-b951-d872f2087c98

Second attempt at cleaning up handling of --disable-popup-blocking.  I didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab.  This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab.

I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected).
Review URL: http://codereview.chromium.org/99203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14886 0039d316-1c4b-4281-b951-d872f2087c98

* clean up toolbar/infobar/findbar borders
* move findbar to BrowserWindowGtk's vbox (so it stacks on top of infobar, as on windows)
* properly show findbar when switching between tabs
Review URL: http://codereview.chromium.org/99166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14885 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99204


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14884 0039d316-1c4b-4281-b951-d872f2087c98

Move linux version of X509Certificate::IsEV in x509certificate_nss.cc


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14883 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14882 0039d316-1c4b-4281-b951-d872f2087c98

Disable view-source if the page source is not viewable as text.
For example, a page of content type application/x-shockwave-flash
is not viewable.

http://crbug.com/9562

Review URL: http://codereview.chromium.org/66061


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14880 0039d316-1c4b-4281-b951-d872f2087c98

Implement dropping of tabs into an existing tab strip from another window. Implement dragging and dropping of tabs within a window.
Review URL: http://codereview.chromium.org/102010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14879 0039d316-1c4b-4281-b951-d872f2087c98

Allow words to be wrapped in message box.

We use DT_WORDBREK|DT_EDITCONTROL as the argument of DrawText().
With this option, DrawText() try to wrap texts at word-breaks first,
then wraps at non-word-breaks if one line is still too long.

This change only affects for Labels in MessageBox.
If we can always use this policy, please let me know
and I'll fix the code.

http://crbug.com/2441

Review URL: http://codereview.chromium.org/100013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14878 0039d316-1c4b-4281-b951-d872f2087c98

more extensions bookmarks changes:* add schema verification* add unit tests for schema* add a few new methods (getTree, getChildren)* add events
Review URL: http://codereview.chromium.org/102009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14877 0039d316-1c4b-4281-b951-d872f2087c98

Switch to a raw kAEOpenDocuments AppleEvent handler for opening dropped files to avoid crashes when Cocoa feeds us files specified on the command line.

Review URL: http://codereview.chromium.org/100142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14876 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14875 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14874 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.

Back to using system colors. Adds highlight icons.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14826
Review URL: http://codereview.chromium.org/99102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14873 0039d316-1c4b-4281-b951-d872f2087c98

Part 1 of sample sprucing. Also, change chromium_extension.py to generate a random ID if the manifest doesn't have one.

* Create a test/data/extensions/samples directory and add
  Reader and Gmail samples to it.

* Minor fixes to buildbot sample to fit better visually.

* Minor fixes to bookmarks sample to use new button styles.

* Workaround for bug in bookmark sample where extension APIs do
  not load the first time.

* Move Resizer extension into samples/.

* Fix TabsAPI sample to not use old deprecated manifest
  properties anymore.

Part 2 will move the remaining samples into samples/ (don't want
to do that at the same time because git-cl doesn't know how to
tell Rietveld about moves and it would be confusing to review).

Review URL: http://codereview.chromium.org/99172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14872 0039d316-1c4b-4281-b951-d872f2087c98

activeDocumentLoader's url, not the document's current URL.

BUG=10924
Review URL: http://codereview.chromium.org/92090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14871 0039d316-1c4b-4281-b951-d872f2087c98

with one tab, drag the tab, and while dragging click and release the
right mouse button we get all confused. This is because we get two
OnMousePressed events in a row, which results in cancelling out the
current drag which doesn't work well when only one tab with one window
is left.

BUG=10800
TEST=see bug

Review URL: http://codereview.chromium.org/100169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11146
Review URL: http://codereview.chromium.org/99194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14869 0039d316-1c4b-4281-b951-d872f2087c98

. Removes MoveToFront on Widget.
. CHanges AsWindow to GetWindow.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/99133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14868 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14865 0039d316-1c4b-4281-b951-d872f2087c98